@xmldom/xmldom 0.9.0-beta.7 → 0.9.0-beta.8

package/CHANGELOG.md

@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.0-beta.8](https://github.com/xmldom/xmldom/compare/0.9.0-beta.7...0.9.0-beta.8)
+
+### Fixed
+
+- fix: Throw DOMException when calling removeChild with invalid parameter [`#494`](https://github.com/xmldom/xmldom/pull/494) / [`#135`](https://github.com/xmldom/xmldom/issues/135)
+
+BREAKING CHANGE: Previously it was possible (but not documented) to call `Node.removeChild` with any node in the tree,
+and with certain exceptions, it would work. This is no longer the case: calling `Node.removeChild` with an argument that is not a direct child of the node that it is called from, will throw a NotFoundError DOMException, as it is described by the specs.
+
+Thank you, [@noseworthy](https://github.com/noseworthy), [@davidmc24](https://github.com/davidmc24), for your contributions
+
+
 ## [0.9.0-beta.7](https://github.com/xmldom/xmldom/compare/0.9.0-beta.6...0.9.0-beta.7)
 
 ### Feature

package/lib/dom.js

@@ -952,22 +952,26 @@ function _onUpdateChild(doc, el, newChild) {
  * @private
  */
 function _removeChild(parentNode, child) {
-	var previous = child.previousSibling;
-	var next = child.nextSibling;
-	if (previous) {
-		previous.nextSibling = next;
+	if (parentNode !== child.parentNode) {
+		throw new DOMException(NOT_FOUND_ERR, "child's parent is not parent");
+	}
+	//var index = parentNode.childNodes.
+	var oldPreviousSibling = child.previousSibling;
+	var oldNextSibling = child.nextSibling;
+	if (oldPreviousSibling) {
+		oldPreviousSibling.nextSibling = oldNextSibling;
 	} else {
-		parentNode.firstChild = next;
+		parentNode.firstChild = oldNextSibling;
 	}
-	if (next) {
-		next.previousSibling = previous;
+	if (oldNextSibling) {
+		oldNextSibling.previousSibling = oldPreviousSibling;
 	} else {
-		parentNode.lastChild = previous;
+		parentNode.lastChild = oldPreviousSibling;
 	}
+	_onUpdateChild(parentNode.ownerDocument, parentNode);
 	child.parentNode = null;
 	child.previousSibling = null;
 	child.nextSibling = null;
-	_onUpdateChild(parentNode.ownerDocument, parentNode);
 	return child;
 }
 
@@ -1345,10 +1349,11 @@ Document.prototype = {
 		return newChild;
 	},
 	removeChild: function (oldChild) {
-		if (this.documentElement == oldChild) {
+		var removed = _removeChild(this, oldChild);
+		if (removed === this.documentElement) {
 			this.documentElement = null;
 		}
-		return _removeChild(this, oldChild);
+		return removed;
 	},
 	replaceChild: function (newChild, oldChild) {
 		//raises

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xmldom/xmldom",
-  "version": "0.9.0-beta.7",
+  "version": "0.9.0-beta.8",
   "description": "A pure JavaScript W3C standard-based (XML DOM Level 2 Core) DOMParser and XMLSerializer module.",
   "keywords": [
     "w3c",
@@ -46,7 +46,7 @@
   "devDependencies": {
     "@stryker-mutator/core": "5.6.1",
     "auto-changelog": "2.4.0",
-    "eslint": "8.40.0",
+    "eslint": "8.42.0",
     "eslint-config-prettier": "8.8.0",
     "eslint-plugin-anti-trojan-source": "1.1.1",
     "eslint-plugin-es5": "1.5.0",