@xmldom/xmldom 0.9.0-beta.2 → 0.9.0-beta.4

package/CHANGELOG.md

@@ -4,14 +4,64 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.9.0-beta.2](https://github.com/xmldom/xmldom/compare/0.9.0-beta.1...0.9.0-beta.2)
+## [0.9.0-beta.4](https://github.com/xmldom/xmldom/compare/0.9.0-beta.3...0.9.0-beta.4)
+
+### Fixed
+
+- Security: Prevent inserting DOM nodes when they are not well-formed [`CVE-2022-39353`](https://github.com/xmldom/xmldom/security/advisories/GHSA-crh6-fp67-6883)
+  In case such a DOM would be created, the part that is not well-formed will be transformed into text nodes, in which xml specific characters like `<` and `>` are encoded accordingly.
+  In the upcoming version 0.9.0 those text nodes will no longer be added and an error will be thrown instead.
+  This change can break your code, if you relied on this behavior, e.g. multiple root elements in the past. We consider it more important to align with the specs that we want to be aligned with, considering the potential security issues that might derive from people not being aware of the difference in behavior.
+  Related Spec: <https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity>
+
+### Chore
+
+- update multiple devDependencies
+- Add eslint-plugin-node for `lib` [`#448`](https://github.com/xmldom/xmldom/pull/448) / [`#190`](https://github.com/xmldom/xmldom/issues/190)
+- style: Apply prettier to all code [`#447`](https://github.com/xmldom/xmldom/pull/447) / [`#29`](https://github.com/xmldom/xmldom/issues/29) / [`#130`](https://github.com/xmldom/xmldom/issues/130)
+
+Thank you, [@XhmikosR](https://github.com/XhmikosR), [@awwright](https://github.com/awwright), [@frumioj](https://github.com/frumioj), [@cjbarth](https://github.com/cjbarth), [@markgollnick](https://github.com/markgollnick) for your contributions
 
+## [0.9.0-beta.3](https://github.com/xmldom/xmldom/compare/0.9.0-beta.2...0.9.0-beta.3)
+
+### Fixed
+
+- fix: Stop adding tags after incomplete closing tag [`#445`](https://github.com/xmldom/xmldom/pull/445) / [`#416`](https://github.com/xmldom/xmldom/pull/416)
+  BREAKING CHANGE: It no longer reports an error when parsing HTML containing incomplete closing tags, to align the behavior with the one in the browser.
+  BREAKING CHANGE: If your code relied on not well-formed XML to be parsed and include subsequent tags, this will no longer work.
+- fix: Avoid bidirectional characters in source code [`#440`](https://github.com/xmldom/xmldom/pull/440)
+
+### Other
+
+- ci: Add CodeQL scan [`#444`](https://github.com/xmldom/xmldom/pull/444)
+
+Thank you, [@ACN-kck](https://github.com/ACN-kck), [@mgerlach](https://github.com/mgerlach) for your contributions
+
+
+## [0.7.6](https://github.com/xmldom/xmldom/compare/0.7.5...0.7.6)
+
+### Fixed
+- Avoid iterating over prototype properties [`#441`](https://github.com/xmldom/xmldom/pull/441) / [`#437`](https://github.com/xmldom/xmldom/pull/437) / [`#436`](https://github.com/xmldom/xmldom/issues/436)
+
+Thank you, [@jftanner](https://github.com/jftanner), [@Supraja9726](https://github.com/Supraja9726) for your contributions
+
+
+## [0.8.3](https://github.com/xmldom/xmldom/compare/0.8.3...0.8.2)
+
+### Fixed
+- Avoid iterating over prototype properties [`#437`](https://github.com/xmldom/xmldom/pull/437) / [`#436`](https://github.com/xmldom/xmldom/issues/436)
+
+Thank you, [@Supraja9726](https://github.com/Supraja9726) for your contributions
+
+
+## [0.9.0-beta.2](https://github.com/xmldom/xmldom/compare/0.9.0-beta.1...0.9.0-beta.2)
 
 ### Fixed
 - Avoid iterating over prototype properties [`#437`](https://github.com/xmldom/xmldom/pull/437) / [`#436`](https://github.com/xmldom/xmldom/issues/436)
 
 Thank you, [@Supraja9726](https://github.com/Supraja9726) for your contributions
 
+
 ## [0.9.0-beta.1](https://github.com/xmldom/xmldom/compare/0.8.2...0.9.0-beta.1)
 
 ### Fixed
@@ -55,6 +105,7 @@ Thank you [@weiwu-zhang](https://github.com/weiwu-zhang) for your contributions
 
 - update multiple devDependencies
 
+
 ## [0.8.2](https://github.com/xmldom/xmldom/compare/0.8.1...0.8.2)
 
 ### Fixed

package/SECURITY.md

@@ -6,20 +6,20 @@ The most up-to-date version of this document can be found at <https://github.com
 
 This repository contains the code for the libraries `xmldom` and `@xmldom/xmldom` on npm.
 
-As long as we didn't publish v1, we aim to maintain the last two minor versions with security fixes. If it is possible we provide security fixes as path versions.
-If you think there is a good reason to also patch an earlier version let us know in a github issue or the release discussion once the fix has been provided. 
-The maintainers will consider it and if we agree and have/find the required resources, a patch for that version will be provided.
+As long as we didn't publish v1, we aim to maintain the last two minor versions with security fixes. If it is possible we provide security fixes as patch versions.
+If you think there is a good reason to also patch an earlier version, let us know in a GitHub issue or the release discussion once the fix has been provided. 
+The maintainers will consider it, and if we agree and have/find the required resources, a patch for that version will be provided.
 
 Please notice that [we are no longer able to publish the (unscoped) `xmldom` package](https://github.com/xmldom/xmldom/issues/271), 
 and that all existing versions of `xmldom` are affected by at least one security vulnerability and should be considered deprecated.
 You can still report issues regarding `xmldom` as described below.
 
-If you need help with migrating from `xmldom` to `@xmldom/xmldom`, file a github issue or PR in the affected repository and mention @karfau.
+If you need help with migrating from `xmldom` to `@xmldom/xmldom`, file a GitHub issue or PR in the affected repository and mention @karfau.
 
 ## Reporting vulnerabilities
 
 Please email reports about any security related issues you find to `security@xmldom.org`, which will forward it to the list of maintainers. 
-The maintainers will try to respond within 7 calendar days. (If nobody peplies after 7 days, please us send a reminder!)
+The maintainers will try to respond within 7 calendar days. (If nobody replies after 7 days, please us send a reminder!)
 As part of you communication please make sure to always hit "Reply all", so all maintainers are kept in the loop.
 
 In addition, please include the following information along with your report:
@@ -29,15 +29,15 @@ In addition, please include the following information along with your report:
 - An explanation who can exploit this vulnerability, and what they gain when doing so -- write an attack scenario. This will help us evaluate your report quickly, especially if the issue is complex.
 - Whether this vulnerability public or known to third parties. If it is, please provide details.
 
-If you believe that an existing (public) issue is security-related, please send an email to `security@xmldom.org`. 
+If you believe that an existing (public) issue is security-related, please email `security@xmldom.org`. 
 The email should include the issue URL and a short description of why it should be handled according to this security policy.
 
 Once an issue is reported, the maintainers use the following disclosure process:
 
 - When a report is received, we confirm the issue, determine its severity and the affected versions.
 - If we know of specific third-party services or software based on xmldom that require mitigation before publication, those projects will be notified.
-- A [github security advisory](https://docs.github.com/en/code-security/security-advisories/about-github-security-advisories) is [created](https://docs.github.com/en/code-security/security-advisories/creating-a-security-advisory) (but not published) which details the problem and steps for mitigation.
-- If the reporter provides a github account and agrees to it, we (add that github account as a collaborator on the advisuory)[https://docs.github.com/en/code-security/security-advisories/adding-a-collaborator-to-a-security-advisory].
+- A [GitHub security advisory](https://docs.github.com/en/code-security/security-advisories/about-github-security-advisories) is [created](https://docs.github.com/en/code-security/security-advisories/creating-a-security-advisory) (but not published) which details the problem and steps for mitigation.
+- If the reporter provides a GitHub account and agrees to it, we [add that GitHub account as a collaborator on the advisory](https://docs.github.com/en/code-security/security-advisories/adding-a-collaborator-to-a-security-advisory).
 - The vulnerability is fixed in a [private fork](https://docs.github.com/en/code-security/security-advisories/collaborating-in-a-temporary-private-fork-to-resolve-a-security-vulnerability) and potential workarounds are identified.
 - The maintainers audit the existing code to find any potential similar problems.
 - The release for the current minor version and the [security advisory are published](https://docs.github.com/en/code-security/security-advisories/publishing-a-security-advisory).

package/lib/.eslintrc.yml

@@ -1,2 +1,3 @@
 extends:
   - 'plugin:es5/no-es2015'
+  - 'plugin:node/recommended'

package/lib/conventions.js

@@ -1,4 +1,4 @@
-'use strict'
+'use strict';
 
 /**
  * "Shallow freezes" an object to render it immutable.
@@ -17,9 +17,9 @@
  */
 function freeze(object, oc) {
 	if (oc === undefined) {
-		oc = Object
+		oc = Object;
 	}
-	return oc && typeof oc.freeze === 'function' ? oc.freeze(object) : object
+	return oc && typeof oc.freeze === 'function' ? oc.freeze(object) : object;
 }
 
 /**
@@ -37,14 +37,14 @@ function freeze(object, oc) {
  */
 function assign(target, source) {
 	if (target === null || typeof target !== 'object') {
-		throw new TypeError('target is not an object')
+		throw new TypeError('target is not an object');
 	}
 	for (var key in source) {
 		if (Object.prototype.hasOwnProperty.call(source, key)) {
-			target[key] = source[key]
+			target[key] = source[key];
 		}
 	}
-	return target
+	return target;
 }
 
 /**
@@ -87,7 +87,7 @@ var HTML_BOOLEAN_ATTRIBUTES = freeze({
 	required: true,
 	reversed: true,
 	selected: true,
-})
+});
 
 /**
  * Check if `name` is matching one of the HTML boolean attribute names.
@@ -100,7 +100,7 @@ var HTML_BOOLEAN_ATTRIBUTES = freeze({
  * @see https://html.spec.whatwg.org/#attributes-3
  */
 function isHTMLBooleanAttribute(name) {
-	return HTML_BOOLEAN_ATTRIBUTES.hasOwnProperty(name.toLowerCase())
+	return HTML_BOOLEAN_ATTRIBUTES.hasOwnProperty(name.toLowerCase());
 }
 
 /**
@@ -131,7 +131,7 @@ var HTML_VOID_ELEMENTS = freeze({
 	source: true,
 	track: true,
 	wbr: true,
-})
+});
 
 /**
  * Check if `tagName` is matching one of the HTML void element names.
@@ -144,7 +144,7 @@ var HTML_VOID_ELEMENTS = freeze({
  * @see https://html.spec.whatwg.org/#void-elements
  */
 function isHTMLVoidElement(tagName) {
-	return HTML_VOID_ELEMENTS.hasOwnProperty(tagName.toLowerCase())
+	return HTML_VOID_ELEMENTS.hasOwnProperty(tagName.toLowerCase());
 }
 
 /**
@@ -161,7 +161,7 @@ var HTML_RAW_TEXT_ELEMENTS = freeze({
 	style: false,
 	textarea: true,
 	title: true,
-})
+});
 
 /**
  * Check if `tagName` is matching one of the HTML raw text element names.
@@ -227,7 +227,7 @@ var MIME_TYPE = freeze({
 	 * @see [`DOMParser.parseFromString` @ HTML Specification](https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-domparser-parsefromstring)
 	 */
 	isHTML: function (value) {
-		return value === MIME_TYPE.HTML
+		return value === MIME_TYPE.HTML;
 	},
 
 	/**
@@ -242,9 +242,7 @@ var MIME_TYPE = freeze({
 	 * @see https://dom.spec.whatwg.org/#dom-domimplementation-createhtmldocument
 	 */
 	hasDefaultHTMLNamespace: function (mimeType) {
-		return (
-			MIME_TYPE.isHTML(mimeType) || mimeType === MIME_TYPE.XML_XHTML_APPLICATION
-		)
+		return MIME_TYPE.isHTML(mimeType) || mimeType === MIME_TYPE.XML_XHTML_APPLICATION;
 	},
 
 	/**
@@ -283,7 +281,7 @@ var MIME_TYPE = freeze({
 	 * @see https://en.wikipedia.org/wiki/Scalable_Vector_Graphics Wikipedia
 	 */
 	XML_SVG_IMAGE: 'image/svg+xml',
-})
+});
 
 /**
  * Namespaces that are used in this code base.
@@ -306,7 +304,7 @@ var NAMESPACE = freeze({
 	 * @see NAMESPACE.HTML
 	 */
 	isHTML: function (uri) {
-		return uri === NAMESPACE.HTML
+		return uri === NAMESPACE.HTML;
 	},
 
 	/**
@@ -329,16 +327,16 @@ var NAMESPACE = freeze({
 	 * @see https://www.w3.org/2000/xmlns/
 	 */
 	XMLNS: 'http://www.w3.org/2000/xmlns/',
-})
+});
 
-exports.assign = assign
-exports.freeze = freeze
-exports.HTML_BOOLEAN_ATTRIBUTES = HTML_BOOLEAN_ATTRIBUTES
-exports.HTML_RAW_TEXT_ELEMENTS = HTML_RAW_TEXT_ELEMENTS
-exports.HTML_VOID_ELEMENTS = HTML_VOID_ELEMENTS
-exports.isHTMLBooleanAttribute = isHTMLBooleanAttribute
-exports.isHTMLRawTextElement = isHTMLRawTextElement
-exports.isHTMLEscapableRawTextElement = isHTMLEscapableRawTextElement
-exports.isHTMLVoidElement = isHTMLVoidElement
-exports.MIME_TYPE = MIME_TYPE
-exports.NAMESPACE = NAMESPACE
+exports.assign = assign;
+exports.freeze = freeze;
+exports.HTML_BOOLEAN_ATTRIBUTES = HTML_BOOLEAN_ATTRIBUTES;
+exports.HTML_RAW_TEXT_ELEMENTS = HTML_RAW_TEXT_ELEMENTS;
+exports.HTML_VOID_ELEMENTS = HTML_VOID_ELEMENTS;
+exports.isHTMLBooleanAttribute = isHTMLBooleanAttribute;
+exports.isHTMLRawTextElement = isHTMLRawTextElement;
+exports.isHTMLEscapableRawTextElement = isHTMLEscapableRawTextElement;
+exports.isHTMLVoidElement = isHTMLVoidElement;
+exports.MIME_TYPE = MIME_TYPE;
+exports.NAMESPACE = NAMESPACE;