@xh/hoist 79.0.0-SNAPSHOT.1766259546947 → 79.0.0-SNAPSHOT.1766275267656

package/CHANGELOG.md

@@ -24,6 +24,9 @@
   Some apps may need to update their imports.
 * `TabContainerConfig.switcher` has been repurposed to accept a `TabSwitcherConfig`. To pass
   `TabSwitcherProps` via a parent `TabContainer`, use `TabContainerProps.switcher`.
+* Tightened the typing of `LocalDate` adjustment methods with new `LocalDateUnit` type. Some less
+  common or ambiguous units (e.g. `date` or `d`) are no longer supported. Also typed the adjustment
+  `value` args to `number` where applicable.
 
 ### 🐞 Bug Fixes
 
@@ -40,6 +43,8 @@
     * `GroupingChooserProps.popoverTitle` - use `editorTitle`
     * `RelativeTimestampProps.options` - provide directly as top-level props
 
+* Improved the efficiency and logging of MsalClient.
+*
 ## 78.1.4 - 2025-12-05
 
 ### 🐞 Bug Fixes
@@ -50,7 +55,7 @@
 
 ### 🐞 Bug Fixes
 
-* Fix to Highchart timezone handling regression from version 77.  Applications should note that
+* Fix to Highchart timezone handling regression from version 77. Applications should note that
   Highcharts has deprecated the `time.useUTC` option and its functioning seem suspect. Apps
   should set `time.timezone` instead. See https://api.highcharts.com/highcharts/time.useUTC.
 
@@ -61,14 +66,15 @@
 ## 78.1.0 - 2025-12-02
 
 ### ⚙️ Technical
+
 * New property `MsalClientConfig.enableSsoSilent` to govern use of MSAL SSO api.
 
 * Existing property `MsalClientConfig.enableTelemetry` now defaults to `true`.
 
-* Improved use of MSAL client API, to maximize effectiveness of SSO.  Improved documentation
- and logging.  Iframe attempts will now time out by default after 3 seconds vs. 10 seconds.
- This can be further modified by apps via the option
- `MsalClientConfig.msalClientOptions.system.iFrameHashTimeout`
+* Improved use of MSAL client API, to maximize effectiveness of SSO. Improved documentation
+  and logging. Iframe attempts will now time out by default after 3 seconds vs. 10 seconds.
+  This can be further modified by apps via the option
+  `MsalClientConfig.msalClientOptions.system.iFrameHashTimeout`
 
 ### 📚 Libraries
 
@@ -110,7 +116,8 @@
 
 ### 💥 Breaking Changes (upgrade difficulty: 🟢 LOW)
 
-* Apps that use and provide the `highcharts` library should be sure to update the version to v12.4.0.
+* Apps that use and provide the `highcharts` library should be sure to update the version to
+  v12.4.0.
   Refer to `Bootstrap.js` in Toolbox for required import changes.
     * Visit https://www.highcharts.com/blog/changelog/ for specific changes.
 

package/appcontainer/AppContainerModel.ts

@@ -197,7 +197,7 @@ export class AppContainerModel extends HoistModel {
 
             // Check auth, locking out, or showing login if possible
             this.setAppState('AUTHENTICATING');
-            XH.authModel = createSingleton(this.appSpec.authModelClass);
+            XH.authModel = createSingleton(appSpec.authModelClass);
             const isAuthenticated = await XH.authModel.completeAuthAsync();
             if (!isAuthenticated) {
                 throwIf(

package/appcontainer/AppStateModel.ts

@@ -28,8 +28,8 @@ export class AppStateModel extends HoistModel {
      * Read from timestamp set on window within index.html.
      */
     readonly loadStarted: number = window['_xhLoadTimestamp'];
+    readonly timings: Record<AppState, number> = {} as Record<AppState, number>;
 
-    private timings: Record<AppState, number> = {} as Record<AppState, number>;
     private lastStateChangeTime: number = this.loadStarted;
 
     constructor() {
@@ -85,7 +85,7 @@ export class AppStateModel extends HoistModel {
         const {timings, loadStarted} = this;
         this.addReaction({
             when: () => this.state === 'RUNNING',
-            run: () =>
+            run: () => {
                 XH.track({
                     category: 'App',
                     message: `Loaded ${XH.clientAppCode}`,
@@ -98,7 +98,9 @@ export class AppStateModel extends HoistModel {
                         screen: this.getScreenData()
                     },
                     omit: !XH.appSpec.trackAppLoad
-                })
+                });
+                this.logDebug('Load timings', this.timings);
+            }
         });
     }
 

package/build/types/appcontainer/AppStateModel.d.ts

@@ -15,7 +15,7 @@ export declare class AppStateModel extends HoistModel {
      * Read from timestamp set on window within index.html.
      */
     readonly loadStarted: number;
-    private timings;
+    readonly timings: Record<AppState, number>;
     private lastStateChangeTime;
     constructor();
     setAppState(nextState: AppState): void;

package/build/types/core/types/Types.d.ts

@@ -42,6 +42,8 @@ export type DebounceSpec = number | (DebounceSettings & {
  */
 export type Content = ReactElement | FunctionComponent | Component | ElementFactory | (() => ReactElement);
 export type DateLike = Date | LocalDate | MomentInput;
+/** Valid units for the {@link LocalDate} adjustment methods. */
+export type LocalDateUnit = 'year' | 'years' | 'quarter' | 'quarters' | 'month' | 'months' | 'week' | 'weeks' | 'day' | 'days';
 export type PageState = 
 /**
  * Window/tab is visible and focused.

package/build/types/utils/datetime/LocalDate.d.ts

@@ -1,4 +1,5 @@
-import moment, { Moment, MomentInput } from 'moment';
+import { LocalDateUnit } from '@xh/hoist/core';
+import { Moment, MomentInput } from 'moment';
 /**
  * A Date representation that does not contain time information. Useful for business day or calendar
  * day data where time and time zone should be explicitly ignored.  Client-side equivalent of the
@@ -8,15 +9,13 @@ import moment, { Moment, MomentInput } from 'moment';
  * For efficiency and to enable strict equality checks, instances of this class are memoized:
  * only a single version of the object will be created and returned for each calendar day,
  * as long as the caller uses one of the *public factory methods*, which they always should!
- *
- * Unit accepted by manipulation methods are ['year', 'quarter', 'month', 'week', 'day', 'date'].
  */
 export declare class LocalDate {
+    static readonly VALID_UNITS: Set<LocalDateUnit>;
     private static _instances;
-    static VALID_UNITS: string[];
-    private _isoString;
-    private _moment;
-    private _date;
+    private readonly _isoString;
+    private readonly _moment;
+    private readonly _date;
     /**
      * Get an instance of this class.
      * This is the standard way to get an instance of this object from serialized server-side data.
@@ -64,11 +63,11 @@ export declare class LocalDate {
     toJSON(): string;
     valueOf(): string;
     get isLocalDate(): boolean;
-    add(value: any, unit?: string): LocalDate;
-    subtract(value: any, unit?: string): LocalDate;
-    addWeekdays(value: any): LocalDate;
-    subtractWeekdays(value: any): LocalDate;
-    startOf(unit: any): LocalDate;
+    add(value: number, unit?: LocalDateUnit): LocalDate;
+    subtract(value: number, unit?: LocalDateUnit): LocalDate;
+    addWeekdays(value: number): LocalDate;
+    subtractWeekdays(value: number): LocalDate;
+    startOf(unit: LocalDateUnit): LocalDate;
     startOfMonth(): LocalDate;
     startOfQuarter(): LocalDate;
     startOfYear(): LocalDate;
@@ -84,13 +83,10 @@ export declare class LocalDate {
     currentOrNextWeekday(): LocalDate;
     /** The same date if already a weekday, or the previous weekday. */
     currentOrPreviousWeekday(): LocalDate;
-    diff(other: LocalDate, unit?: moment.unitOfTime.Diff): number;
+    diff(other: LocalDate, unit?: LocalDateUnit): number;
     /** @internal - use one of the static factory methods instead. */
     private constructor();
     private ensureUnitValid;
 }
-/**
- * Is the input value a local Date?
- * Convenience alias for LocalDate.isLocalDate()
- */
+/** @returns true if the input value is a `LocalDate` instance. */
 export declare function isLocalDate(val: any): val is LocalDate;

package/core/types/Types.ts

@@ -63,6 +63,19 @@ export type Content =
 
 export type DateLike = Date | LocalDate | MomentInput;
 
+/** Valid units for the {@link LocalDate} adjustment methods. */
+export type LocalDateUnit =
+    | 'year'
+    | 'years'
+    | 'quarter'
+    | 'quarters'
+    | 'month'
+    | 'months'
+    | 'week'
+    | 'weeks'
+    | 'day'
+    | 'days';
+
 export type PageState =
     /**
      * Window/tab is visible and focused.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "79.0.0-SNAPSHOT.1766259546947",
+  "version": "79.0.0-SNAPSHOT.1766275267656",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/security/msal/MsalClient.ts

@@ -170,17 +170,19 @@ export class MsalClient extends BaseOAuthClient<MsalClientConfig, MsalTokenSpec>
         const account =
             accounts.length == 1
                 ? accounts[0]
-                : accounts.find(a => (a.username = this.getSelectedUsername()));
+                : accounts.find(a => a.username == this.getSelectedUsername());
+        let trySsoSilent = enableSsoSilent;
         if (account) {
             this.setAccount(account);
             try {
-                this.initialTokenLoad = true;
                 this.logDebug('Attempting silent token load.');
+                this.initialTokenLoad = true;
                 const ret = await this.fetchAllTokensAsync({eagerOnly: true});
                 this.noteAuthComplete('acquireSilent');
                 return ret;
             } catch (e) {
-                this.logDebug('Failed to load tokens on init, fall back to login', e.message ?? e);
+                if (e instanceof InteractionRequiredAuthError) trySsoSilent = false;
+                this.logDebug('AcquireSilent failed', e.message ?? e);
             } finally {
                 this.initialTokenLoad = false;
             }
@@ -189,15 +191,18 @@ export class MsalClient extends BaseOAuthClient<MsalClientConfig, MsalTokenSpec>
         // 2) Try `ssoSilent` API to potentially reuse logged-in user on other apps
         // in same domain without interaction.  This should never trigger popup/redirect, and will
         // use an iFrame (3rd party cookies required). Must fail gently.
-        if (enableSsoSilent) {
+        if (trySsoSilent) {
             try {
                 this.logDebug('Attempting SSO');
                 await this.loginSsoAsync();
+                this.initialTokenLoad = true;
                 const ret = await this.fetchAllTokensAsync({eagerOnly: true});
                 this.noteAuthComplete('ssoSilent');
                 return ret;
             } catch (e) {
                 this.logDebug('SSO failed', e.message ?? e);
+            } finally {
+                this.initialTokenLoad = false;
             }
         }
 
@@ -453,7 +458,7 @@ export class MsalClient extends BaseOAuthClient<MsalClientConfig, MsalTokenSpec>
 
     private noteAuthComplete(authMethod: AuthMethod) {
         if (this.telemetry) this.telemetry.authMethod = authMethod;
-        this.logInfo(`Authenticated user ${this.account.username} via ${authMethod}`);
+        this.logInfo(`Authenticated user '${this.account.username}' via ${authMethod}`);
     }
 
     private authRequestCore(): AuthRequestCore {