@xh/hoist 77.0.0-SNAPSHOT.1761672695220 → 77.0.0-SNAPSHOT.1761690719868

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## 77.0.0-SNAPSHOT - unreleased
 
+### 🐞 Bug Fixes
+* Fixes regressions in grid context menu for filtering and copy/paste introduced by agGrid v34.
+
+* Note: AgGrid no longer supports html markup in context menus.  Applications setting the
+RecordGridAction `text` property to markup should be sure to convert to a simpler form.
+
 ### 💥 Breaking Changes
 
 * The `disableXssProtection` flag supported by `AppSpec` and `FieldSpec` has been removed and
@@ -14,7 +20,7 @@
     * Apps that were previously opting-out via `disableXssProtection` should simply remove that
       flag. Apps for which this protection remains important should enable at either the app level
       or for selected Fields and/or Stores.
-      
+
 ## 76.2.0 - 2025-10-22
 
 ### ⚙️ Technical

package/cmp/grid/Grid.ts

@@ -273,6 +273,7 @@ export class GridLocalModel extends HoistModel {
                 mode: selModel.mode == 'single' ? 'singleRow' : 'multiRow',
                 enableClickSelection: selModel.isEnabled,
                 isRowSelectable: () => selModel.isEnabled,
+                copySelectedRows: selModel.isEnabled,
                 checkboxes: false,
                 headerCheckbox: false
             };
@@ -321,7 +322,7 @@ export class GridLocalModel extends HoistModel {
     getContextMenuItems = (params: GetContextMenuItemsParams) => {
         const {model} = this,
             {contextMenu} = model;
-        if (!contextMenu || XH.isMobileApp || model.isEditing) return null;
+        if (!contextMenu || XH.isMobileApp || model.isEditing) return [];
 
         // Manipulate selection if needed.
         if (model.selModel.isEnabled) {
@@ -336,7 +337,7 @@ export class GridLocalModel extends HoistModel {
         }
 
         const ret = getAgGridMenuItems(params, model, contextMenu);
-        if (isEmpty(ret)) return null;
+        if (isEmpty(ret)) return [];
 
         return ret;
     };

package/cmp/grid/impl/MenuSupport.ts

@@ -12,7 +12,6 @@ import {filterConsecutiveMenuSeparators} from '@xh/hoist/utils/impl';
 import copy from 'clipboard-copy';
 import {isEmpty, isFunction, isNil, isString, uniq} from 'lodash';
 import {isValidElement} from 'react';
-import {renderToStaticMarkup} from '@xh/hoist/utils/react';
 import {GridContextMenuItemLike, GridContextMenuSpec} from '../GridContextMenu';
 
 import type {GetContextMenuItemsParams, MenuItemDef} from '@xh/hoist/kit/ag-grid';
@@ -179,21 +178,17 @@ function replaceHoistToken(token: string, gridModel: GridModel): Some<RecordActi
                     const values = getValues(selectedRecords, field);
                     if (values.length > 1) return {text: `${values.length} values`};
 
-                    const renderer = fieldSpec.renderer ?? column.renderer,
-                        elem = renderer
-                            ? renderer(values[0], {
-                                  record,
-                                  column,
-                                  gridModel
-                              })
-                            : (values[0] ?? '[blank]'),
-                        // Grid col renderers will very typically return elements, but we need this to be a string.
-                        // That's the contract for `RecordAction.text`, but even more importantly, we end up piping
-                        // those actions into Ag-Grid context menus, which *only* accept strings / HTML markup
-                        // and *not* ReactElements (as of AG v28.2).
-                        text = isValidElement(elem) ? renderToStaticMarkup(elem) : elem;
+                    // Grid col renderers will very typically return elements, but we need this to be a string.
+                    // As of AG v34.2.0 actions into Ag-Grid context menus *only* accept strings.
+                    let raw = values[0],
+                        renderer = fieldSpec.renderer ?? column.renderer,
+                        text = renderer?.(raw, {record, column, gridModel});
+                    if (!isString(text)) {
+                        text = raw?.toString();
+                    }
+                    text = text?.trim();
 
-                    return {text};
+                    return {text: text ?? '[blank]'};
                 };
 
             return new RecordAction({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "77.0.0-SNAPSHOT.1761672695220",
+  "version": "77.0.0-SNAPSHOT.1761690719868",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",