@xh/hoist 77.0.0-SNAPSHOT.1759338550975 → 77.0.0-SNAPSHOT.1759414848931

package/build/types/desktop/cmp/dash/DashViewModel.d.ts

@@ -1,5 +1,6 @@
 import { HoistModel, MenuItemLike, PlainObject, RefreshMode, RenderMode } from '@xh/hoist/core';
 import '@xh/hoist/desktop/register';
+import { IReactionDisposer } from 'mobx/dist/internal';
 import { ReactElement } from 'react';
 import { DashViewSpec } from './DashViewSpec';
 export type DashViewState = PlainObject;
@@ -23,7 +24,7 @@ export declare class DashViewModel<T extends DashViewSpec = DashViewSpec> extend
      * constructing these models - no need to specify manually.
      */
     containerModel: any;
-    /** Title with which to initialize the view. */
+    /** Title with which to initialize the view.  Value is persisted. */
     title: string;
     /**
      * Additional info that will be displayed after the title.
@@ -31,6 +32,8 @@ export declare class DashViewModel<T extends DashViewSpec = DashViewSpec> extend
      * Value is not persisted.
      **/
     titleDetails: string;
+    get fullTitle(): string;
+    fullTitleReaction: IReactionDisposer;
     /** Icon with which to initialize the view. */
     icon: ReactElement;
     /** State with which to initialize the view. */

package/desktop/cmp/dash/DashViewModel.ts

@@ -16,6 +16,7 @@ import {
 import '@xh/hoist/desktop/register';
 import {makeObservable, bindable} from '@xh/hoist/mobx';
 import {throwIf} from '@xh/hoist/utils/js';
+import {IReactionDisposer} from 'mobx/dist/internal';
 import {ReactElement} from 'react';
 import {DashViewSpec} from './DashViewSpec';
 
@@ -44,7 +45,7 @@ export class DashViewModel<T extends DashViewSpec = DashViewSpec> extends HoistM
      */
     containerModel: any;
 
-    /** Title with which to initialize the view. */
+    /** Title with which to initialize the view.  Value is persisted. */
     @bindable title: string;
 
     /**
@@ -54,6 +55,12 @@ export class DashViewModel<T extends DashViewSpec = DashViewSpec> extends HoistM
      **/
     @bindable titleDetails: string;
 
+    get fullTitle(): string {
+        return this.title + (this.titleDetails ? ' ' + this.titleDetails : '');
+    }
+
+    fullTitleReaction: IReactionDisposer;
+
     /** Icon with which to initialize the view. */
     @bindable.ref icon: ReactElement;
 

package/desktop/cmp/dash/canvas/impl/DashCanvasView.ts

@@ -34,13 +34,12 @@ export const dashCanvasView = hoistCmp.factory({
     model: uses(DashCanvasViewModel, {publishMode: 'limited'}),
 
     render({model, className}) {
-        const {viewSpec, ref, hidePanelHeader, headerItems, autoHeight, titleDetails, title, icon} =
-                model,
+        const {viewSpec, ref, hidePanelHeader, headerItems, autoHeight, fullTitle, icon} = model,
             headerProps = hidePanelHeader
                 ? {}
                 : {
                       compactHeader: true,
-                      title: title + (titleDetails ? ' ' + titleDetails : ''),
+                      title: fullTitle,
                       icon,
                       headerItems: [...headerItems, headerMenu({model})]
                   };

package/desktop/cmp/dash/container/DashContainerModel.ts

@@ -531,7 +531,7 @@ export class DashContainerModel
                 $titleEl = $el.find('.lm_title').first(),
                 iconSelector = 'svg.svg-inline--fa',
                 viewSpec = this.getViewSpec(item.config.component),
-                {icon, title} = viewModel;
+                {icon} = viewModel;
 
             $el.off('contextmenu').contextmenu(e => {
                 const index = stack.contentItems.indexOf(item);
@@ -551,22 +551,18 @@ export class DashContainerModel
                 }
             }
 
-            if (title) {
-                const currentTitle = $titleEl.text();
-                if (currentTitle !== title) $titleEl.text(title);
-            }
-
             if (viewSpec.allowRename) {
                 this.insertTitleForm($el, viewModel);
                 $titleEl.off('dblclick').dblclick(() => this.showTitleForm($el, viewModel));
             }
 
-            viewModel.addReaction({
-                track: () => viewModel.titleDetails,
+            viewModel.fullTitleReaction?.();
+            viewModel.fullTitleReaction = viewModel.addReaction({
+                track: () => viewModel.fullTitle,
                 run: () => {
                     const currentTitle = $titleEl.text(),
-                        {title, titleDetails} = viewModel,
-                        newTitle = title + (titleDetails ? ' ' + titleDetails : '');
+                        newTitle = viewModel.fullTitle;
+
                     if (currentTitle !== newTitle) $titleEl.text(newTitle);
                 }
             });
@@ -589,7 +585,6 @@ export class DashContainerModel
         $formEl.submit(() => {
             const title = $inputEl.val();
             if (title.length) {
-                $titleEl.text(title);
                 viewModel.title = title;
             }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "77.0.0-SNAPSHOT.1759338550975",
+  "version": "77.0.0-SNAPSHOT.1759414848931",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",