@xh/hoist 75.0.0-SNAPSHOT.1752854198386 → 75.0.0-SNAPSHOT.1752873581842

package/core/persist/PersistenceProvider.ts

@@ -12,8 +12,10 @@ import {
     compact,
     debounce as lodashDebounce,
     get,
+    isArray,
     isEmpty,
     isNumber,
+    isObject,
     isString,
     isUndefined,
     omit,
@@ -88,6 +90,7 @@ export abstract class PersistenceProvider<S = any> {
 
             const providerClass = this.parseProviderClass<S>(cfg.persistOptions);
             ret = new providerClass(cfg);
+            ret.ensureValid();
             ret.bindToTarget(cfg.target);
             return ret;
         } catch (e) {
@@ -252,4 +255,13 @@ export abstract class PersistenceProvider<S = any> {
 
         return ret;
     }
+
+    private ensureValid() {
+        const data = this.readRaw();
+        throwIf(
+            !(isObject(data) && !isArray(data)),
+            `PersistenceProvider for ${this.path} may not be configured correctly.  The provider ` +
+                'should produce a javascript object for reading property values.'
+        );
+    }
 }

package/data/RecordAction.ts

@@ -34,7 +34,7 @@ export interface RecordActionSpec extends TestSupportProps {
     actionFn?: (data: ActionFnData) => void;
 
     /** Function called prior to showing this item. */
-    displayFn?: (data: DisplayFnData) => PlainObject;
+    displayFn?: (data: ActionFnData) => RecordActionSpec;
 
     /** Sub-actions for this action. */
     items?: RecordActionLike[];
@@ -107,7 +107,7 @@ export class RecordAction {
     className: string;
     tooltip: string;
     actionFn: (data: ActionFnData) => void;
-    displayFn: (data: DisplayFnData) => PlainObject;
+    displayFn: (data: ActionFnData) => PlainObject;
     items: Array<RecordAction | string>;
     disabled: boolean;
     hidden: boolean;
@@ -207,8 +207,3 @@ export class RecordAction {
         );
     }
 }
-
-interface DisplayFnData extends ActionFnData {
-    /** Default display config for the action */
-    defaultConfig?: PlainObject;
-}

package/desktop/cmp/leftrightchooser/LeftRightChooser.ts

@@ -4,7 +4,8 @@
  *
  * Copyright © 2025 Extremely Heavy Industries Inc.
  */
-import {grid, GridProps} from '@xh/hoist/cmp/grid';
+import {GridOptions} from '@ag-grid-community/core';
+import {grid} from '@xh/hoist/cmp/grid';
 import {hframe, vbox} from '@xh/hoist/cmp/layout';
 import {BoxProps, hoistCmp, HoistProps, uses} from '@xh/hoist/core';
 import '@xh/hoist/desktop/register';
@@ -12,7 +13,6 @@ import {chooserToolbar} from './impl/ChooserToolbar';
 import {description} from './impl/Description';
 import './LeftRightChooser.scss';
 import {LeftRightChooserModel} from './LeftRightChooserModel';
-import {cloneDeep} from 'lodash';
 
 export interface LeftRightChooserProps extends HoistProps<LeftRightChooserModel>, BoxProps {}
 
@@ -28,19 +28,11 @@ export const [LeftRightChooser, leftRightChooser] = hoistCmp.withFactory<LeftRig
     className: 'xh-lr-chooser',
 
     render({model, ...props}, ref) {
-        const {leftModel, rightModel, leftGroupingExpanded, rightGroupingExpanded} = model,
-            gridOptions: GridProps = {
-                agOptions: {
-                    defaultColDef: {
-                        resizable: false
-                    }
-                }
-            },
-            leftGridOptions = cloneDeep(gridOptions),
-            rightGridOptions = cloneDeep(gridOptions);
-
-        if (!leftGroupingExpanded) leftGridOptions.agOptions.groupDefaultExpanded = 0;
-        if (!rightGroupingExpanded) rightGridOptions.agOptions.groupDefaultExpanded = 0;
+        const agOptions: GridOptions = {
+            defaultColDef: {
+                resizable: false
+            }
+        };
 
         return vbox({
             ref,
@@ -48,9 +40,9 @@ export const [LeftRightChooser, leftRightChooser] = hoistCmp.withFactory<LeftRig
                 hframe({
                     className: 'xh-lr-chooser__grid-frame',
                     items: [
-                        grid({model: leftModel, ...leftGridOptions}),
+                        grid({model: model.leftModel, agOptions}),
                         chooserToolbar(),
-                        grid({model: rightModel, ...rightGridOptions})
+                        grid({model: model.rightModel, agOptions})
                     ]
                 }),
                 description()

package/desktop/cmp/leftrightchooser/LeftRightChooserModel.ts

@@ -186,6 +186,7 @@ export class LeftRightChooserModel extends HoistModel {
             onRowDoubleClicked: e => this.onRowDoubleClicked(e),
             columns: [leftTextCol, groupCol],
             contextMenu: false,
+            expandToLevel: leftGroupingExpanded ? 1 : 0,
             xhImpl: true
         });
 
@@ -197,6 +198,7 @@ export class LeftRightChooserModel extends HoistModel {
             onRowDoubleClicked: e => this.onRowDoubleClicked(e),
             columns: [rightTextCol, groupCol],
             contextMenu: false,
+            expandToLevel: rightGroupingExpanded ? 1 : 0,
             xhImpl: true
         });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "75.0.0-SNAPSHOT.1752854198386",
+  "version": "75.0.0-SNAPSHOT.1752873581842",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",