@xh/hoist 75.0.0-SNAPSHOT.1752777363110 → 75.0.0-SNAPSHOT.1752854198386

package/build/types/core/exception/ExceptionHandler.d.ts

@@ -1,4 +1,4 @@
-import { HoistException } from '../';
+import { HoistException, PlainObject } from '../';
 export interface ExceptionHandlerOptions {
     /** Text (ideally user-friendly) describing the error. */
     message?: string;
@@ -113,8 +113,13 @@ export declare class ExceptionHandler {
      */
     logOnServerAsync(options: ExceptionHandlerLoggingOptions): Promise<boolean>;
     /**
-     * Serialize an error object safely for submission to server, or user display.
-     * This method will avoid circular references and will trim the depth of the object.
+     * Sanitize an exception for submission to server. This method will avoid circular references
+     * trim the depth of the object, and redact sensitive info (e.g. passwords).
+     */
+    sanitizeException(exception: HoistException): PlainObject;
+    /**
+     * Serialize an error object safely for user display.  This method will avoid circular
+     * references, trim the depth of the object, and redact sensitive info (e.g. passwords).
      */
     stringifyErrorSafely(exception: HoistException): string;
     private parseArgs;
@@ -122,6 +127,5 @@ export declare class ExceptionHandler {
     private logException;
     private parseOptions;
     private sessionMismatch;
-    private cleanStack;
     private cloneAndTrim;
 }

package/core/exception/Exception.ts

@@ -210,7 +210,7 @@ export class Exception {
 
     private static createInternal(attributes: PlainObject, baseError?: Error) {
         const {message, ...rest} = attributes;
-        return Object.assign(
+        const ret = Object.assign(
             baseError ?? new Error(message),
             {
                 isRoutine: false,
@@ -218,6 +218,11 @@ export class Exception {
             },
             rest
         ) as HoistException;
+
+        // statuses of 0, 4XX, 5XX are server errors, so stack irrelevant and potentially misleading
+        if (ret.stack == null || /^[045]/.test(ret.httpStatus)) delete ret.stack;
+
+        return ret;
     }
 }
 

package/core/exception/ExceptionHandler.ts

@@ -185,8 +185,7 @@ export class ExceptionHandler {
     async logOnServerAsync(options: ExceptionHandlerLoggingOptions): Promise<boolean> {
         const {exception, userAlerted, userMessage} = options;
         try {
-            const error = this.stringifyErrorSafely(exception),
-                username = XH.getUsername();
+            const username = XH.getUsername();
 
             if (!username) {
                 logWarn('Error report cannot be submitted to UI server - user unknown', this);
@@ -194,7 +193,7 @@ export class ExceptionHandler {
             }
 
             const data: PlainObject = {
-                error: JSON.parse(error),
+                error: this.sanitizeException(exception),
                 userAlerted
             };
             if (userMessage) data.userMessage = stripTags(userMessage);
@@ -216,8 +215,16 @@ export class ExceptionHandler {
     }
 
     /**
-     * Serialize an error object safely for submission to server, or user display.
-     * This method will avoid circular references and will trim the depth of the object.
+     * Sanitize an exception for submission to server. This method will avoid circular references
+     * trim the depth of the object, and redact sensitive info (e.g. passwords).
+     */
+    sanitizeException(exception: HoistException): PlainObject {
+        return JSON.parse(this.stringifyErrorSafely(exception));
+    }
+
+    /**
+     * Serialize an error object safely for user display.  This method will avoid circular
+     * references, trim the depth of the object, and redact sensitive info (e.g. passwords).
      */
     stringifyErrorSafely(exception: HoistException): string {
         try {
@@ -287,8 +294,6 @@ export class ExceptionHandler {
             this.hideParams(e, opts);
         }
 
-        this.cleanStack(e);
-
         return {e, opts};
     }
 
@@ -342,12 +347,6 @@ export class ExceptionHandler {
         return e.name === 'SessionMismatchException';
     }
 
-    private cleanStack(e: HoistException) {
-        // statuses of 0, 4XX, 5XX are server errors, so the javascript stack
-        // is irrelevant and potentially misleading
-        if (/^[045]/.test(e.httpStatus)) delete e.stack;
-    }
-
     private cloneAndTrim(obj, depth = 5) {
         // Create a depth-constrained, deep copy of an object for safe-use in stringify
         //   - Skip private _XXXX properties.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "75.0.0-SNAPSHOT.1752777363110",
+  "version": "75.0.0-SNAPSHOT.1752854198386",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/promise/Promise.ts

@@ -202,8 +202,10 @@ const enhancePromise = promisePrototype => {
             if (!options) return this;
 
             const startTime = Date.now(),
-                doTrack = (exception: unknown = null) => {
-                    if (exception && exception['isRoutine']) return;
+                doTrack = (rejectReason: unknown = null) => {
+                    const exception = rejectReason != null ? Exception.create(rejectReason) : null;
+
+                    if (exception?.isRoutine) return;
 
                     const endTime = Date.now(),
                         opts: TrackOptions = isString(options) ? {message: options} : {...options};
@@ -222,7 +224,14 @@ const enhancePromise = promisePrototype => {
                     ) {
                         opts.elapsed = null;
                     }
-                    if (exception) opts.severity = 'ERROR';
+                    if (exception) {
+                        opts.severity = 'ERROR';
+                        opts.data = {
+                            error: XH.exceptionHandler.sanitizeException(exception),
+                            data: opts.data
+                        };
+                        opts.correlationId = opts.correlationId ?? exception.correlationId;
+                    }
 
                     XH.track(opts);
                 };