@xh/hoist 75.0.0-SNAPSHOT.1751426116456 → 75.0.0-SNAPSHOT.1751484541223

package/CHANGELOG.md

@@ -9,6 +9,11 @@
   * Deprecated `popoverTitle` prop - use `editorTitle` instead.
   * Moved "Save as Favorite" button to a new compact toolbar within the popover.
 
+### 🐞 Bug Fixes
+
+* Fixed a bug where `TrackService` was not properly verifying that tracked `data` was below the
+  configured `maxDataLength` limit.
+
 ## v74.1.0 - 2025-06-30
 
 ### 🎁 New Features

package/build/types/core/types/Interfaces.d.ts

@@ -177,7 +177,7 @@ export interface TrackOptions {
     /** Correlation ID to save along with track log. */
     correlationId?: string;
     /** App-supplied data to save along with track log.*/
-    data?: PlainObject | PlainObject[];
+    data?: PlainObject | Array<unknown>;
     /**
      * Set true to log on the server all primitive values in the 'data' property.
      * May also be specified as list of specific property keys that should be logged.

package/core/types/Interfaces.ts

@@ -6,8 +6,8 @@
  */
 
 import {RuleLike} from '@xh/hoist/data';
-import {MouseEvent, ReactElement, ReactNode, isValidElement} from 'react';
 import {isString} from 'lodash';
+import {isValidElement, MouseEvent, ReactElement, ReactNode} from 'react';
 import {LoadSpec} from '../load';
 import {Intent, PlainObject, Thunkable} from './Types';
 
@@ -224,7 +224,7 @@ export interface TrackOptions {
     correlationId?: string;
 
     /** App-supplied data to save along with track log.*/
-    data?: PlainObject | PlainObject[];
+    data?: PlainObject | Array<unknown>;
 
     /**
      * Set true to log on the server all primitive values in the 'data' property.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "75.0.0-SNAPSHOT.1751426116456",
+  "version": "75.0.0-SNAPSHOT.1751484541223",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/svc/TrackService.ts

@@ -132,10 +132,11 @@ export class TrackService extends HoistService {
         if (options.logData !== undefined) ret.logData = options.logData;
         if (options.elapsed !== undefined) ret.elapsed = options.elapsed;
 
-        const {maxDataLength} = this.conf;
-        if (ret.data?.length > maxDataLength) {
+        const {maxDataLength} = this.conf,
+            dataLength = JSON.stringify(ret.data)?.length ?? 0;
+        if (dataLength > maxDataLength) {
             this.logWarn(
-                `Track log includes ${ret.data.length} chars of JSON data`,
+                `Track log includes ${dataLength} chars of JSON data`,
                 `exceeds limit of ${maxDataLength}`,
                 'data will not be persisted',
                 options.data