@xh/hoist 74.0.0-SNAPSHOT.1748449301934 → 74.0.0-SNAPSHOT.1748449592533

package/CHANGELOG.md

@@ -2,13 +2,6 @@
 
 ## 74.0.0-SNAPSHOT - unreleased
 
-### 🎁 New Features
-+ Add `ViewManagerModel.preserveUnsavedChanges` flag to opt-out of that behaviour.
-
-### 🐞 Bug Fixes
-+ Improves `ViewManagerModel.settleTime` by comparing to when the view is pushed to components
-  rather than when view is loaded from the server.
-
 ## v73.0.1 - 2025-05-19
 
 ### 🐞 Bug Fixes

package/build/types/cmp/viewmanager/ViewManagerModel.d.ts

@@ -43,11 +43,6 @@ export interface ViewManagerConfig {
      * True (default) to allow users to share their views with other users.
      */
     enableSharing?: boolean;
-    /**
-     * True (default) to save pending state to SessionStorage so that it can be restored across
-     * browser refreshes. Unlike auto-save, this does not write to the database.
-     */
-    preserveUnsavedChanges?: boolean;
     /**
      * Function to determine the initial view for a user, when no view has already been persisted.
      * Will be passed a list of views available to the current user.  Implementations where
@@ -137,7 +132,6 @@ export declare class ViewManagerModel<T = PlainObject> extends HoistModel {
     readonly enableDefault: boolean;
     readonly enableGlobal: boolean;
     readonly enableSharing: boolean;
-    readonly preserveUnsavedChanges: boolean;
     readonly manageGlobal: boolean;
     readonly settleTime: number;
     readonly initialViewSpec: (views: ViewInfo[]) => ViewInfo;
@@ -204,7 +198,6 @@ export declare class ViewManagerModel<T = PlainObject> extends HoistModel {
     resetAsync(): Promise<void>;
     getValue(): Partial<T>;
     setValue(value: Partial<T>): void;
-    noteStatePushed(): void;
     userPin(view: ViewInfo): void;
     userUnpin(view: ViewInfo): void;
     isUserPinned(view: ViewInfo): boolean | null;

package/build/types/core/persist/provider/ViewManagerProvider.d.ts

@@ -1,12 +1,10 @@
-import { Persistable } from '@xh/hoist/core';
 import { PersistenceProvider, PersistenceProviderConfig } from '../PersistenceProvider';
 import type { ViewManagerModel } from '@xh/hoist/cmp/viewmanager/ViewManagerModel';
 export declare class ViewManagerProvider<S> extends PersistenceProvider<S> {
     readonly viewManagerModel: ViewManagerModel;
     constructor(cfg: PersistenceProviderConfig<S>);
     pushStateToTarget(): void;
-    bindToTarget(target: Persistable<S>): void;
-    readRaw(): Partial<import("@xh/hoist/core").PlainObject>;
+    readRaw(): Partial<import("../..").PlainObject>;
     writeRaw(data: Record<typeof this.path, S>): void;
     destroy(): void;
 }

package/cmp/viewmanager/ViewManagerModel.ts

@@ -74,12 +74,6 @@ export interface ViewManagerConfig {
      */
     enableSharing?: boolean;
 
-    /**
-     * True (default) to save pending state to SessionStorage so that it can be restored across
-     * browser refreshes. Unlike auto-save, this does not write to the database.
-     */
-    preserveUnsavedChanges?: boolean;
-
     /**
      * Function to determine the initial view for a user, when no view has already been persisted.
      * Will be passed a list of views available to the current user.  Implementations where
@@ -182,7 +176,6 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
     readonly enableDefault: boolean;
     readonly enableGlobal: boolean;
     readonly enableSharing: boolean;
-    readonly preserveUnsavedChanges: boolean;
     readonly manageGlobal: boolean;
     readonly settleTime: number;
     readonly initialViewSpec: (views: ViewInfo[]) => ViewInfo;
@@ -303,7 +296,6 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         enableDefault = true,
         enableGlobal = true,
         enableSharing = true,
-        preserveUnsavedChanges = true,
         settleTime = 1000,
         initialViewSpec = null
     }: ViewManagerConfig) {
@@ -325,7 +317,6 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         this.enableGlobal = enableGlobal;
         this.enableSharing = enableSharing;
         this.enableAutoSave = enableAutoSave;
-        this.preserveUnsavedChanges = preserveUnsavedChanges;
         this.settleTime = settleTime;
         this.initialViewSpec = initialViewSpec;
 
@@ -447,10 +438,6 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         }
     }
 
-    noteStatePushed() {
-        this.lastPushed = Date.now();
-    }
-
     //------------------
     // Pinning
     //------------------
@@ -528,9 +515,7 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
                 this.views = views;
                 this.userPinned = state.userPinned;
                 this.autoSave = state.autoSave;
-                if (this.preserveUnsavedChanges) {
-                    this.pendingValue = XH.sessionStorageService.get(pendingValueStorageKey);
-                }
+                this.pendingValue = XH.sessionStorageService.get(pendingValueStorageKey);
             });
 
             // 2) Initialize/choose initial view.  Null is ok, and will yield default.
@@ -552,7 +537,7 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         }
 
         this.addReaction(
-            this.preserveUnsavedChanges ? this.pendingValueReaction() : null,
+            this.pendingValueReaction(),
             this.autoSaveReaction(),
             ...this.stateReactions(initialState)
         );
@@ -603,6 +588,7 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
             .thenAction(latest => {
                 this.setAsView(latest, pendingValue?.token == token ? pendingValue : null);
                 this.providers.forEach(it => it.pushStateToTarget());
+                this.lastPushed = Date.now();
             })
             .linkTo(this.selectTask);
     }

package/core/persist/provider/ViewManagerProvider.ts

@@ -5,7 +5,6 @@
  * Copyright © 2025 Extremely Heavy Industries Inc.
  */
 
-import {Persistable} from '@xh/hoist/core';
 import {throwIf} from '@xh/hoist/utils/js';
 import {pull} from 'lodash';
 import {PersistenceProvider, PersistenceProviderConfig} from '../PersistenceProvider';
@@ -25,17 +24,11 @@ export class ViewManagerProvider<S> extends PersistenceProvider<S> {
     pushStateToTarget() {
         const state = this.read();
         this.target.setPersistableState(state ? state : this.defaultState);
-        this.viewManagerModel.noteStatePushed();
     }
 
     //----------------
     // Implementation
     //----------------
-    override bindToTarget(target: Persistable<S>) {
-        super.bindToTarget(target);
-        this.viewManagerModel.noteStatePushed();
-    }
-
     override readRaw() {
         return this.viewManagerModel.getValue();
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "74.0.0-SNAPSHOT.1748449301934",
+  "version": "74.0.0-SNAPSHOT.1748449592533",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",