@xh/hoist 73.0.0-SNAPSHOT.1744144713361 → 73.0.0-SNAPSHOT.1744145292985

package/CHANGELOG.md

@@ -4,8 +4,8 @@
 
 ### 🎁 New Features
 
-`ViewManagerConfig` takes new key `viewRouteParam` to allow ViewManagers implemented with routing to
-have the view buttons on their menu items be right clickable/Ctrl+ Click to open views in new tabs or windows.
+`ViewManagerConfig` takes new key `customViewMenuItem` to allow ViewManagers implementations to customize
+ the menu items for views in the view manager menu.
 
 ## v72.3.0 - 2025-04-08
 

package/build/types/cmp/viewmanager/ViewManagerModel.d.ts

@@ -1,5 +1,6 @@
 import { HoistModel, LoadSpec, PlainObject, TaskObserver, Thunkable } from '@xh/hoist/core';
 import type { ViewManagerProvider } from '@xh/hoist/core';
+import { ReactNode } from 'react';
 import { ViewInfo } from './ViewInfo';
 import { View } from './View';
 export interface ViewCreateSpec {
@@ -90,7 +91,7 @@ export interface ViewManagerConfig {
      * ViewManager implementation to be routable, and you want users to be able to Ctrl+Click or
      * ContextMenu Click to open views from the view menu in new tabs or windows.
      */
-    viewRouteParam?: string;
+    customViewMenuItem?: (view: ViewInfo) => ReactNode;
 }
 /**
  *  ViewManagerModel coordinates the loading, saving, and management of user-defined bundles of
@@ -127,7 +128,7 @@ export declare class ViewManagerModel<T = PlainObject> extends HoistModel {
     readonly instance: string;
     readonly typeDisplayName: string;
     readonly globalDisplayName: string;
-    readonly viewRouteParam: string;
+    readonly customViewMenuItem: (view: ViewInfo) => ReactNode;
     readonly enableAutoSave: boolean;
     readonly enableDefault: boolean;
     readonly enableGlobal: boolean;

package/cmp/viewmanager/ViewManagerModel.ts

@@ -129,7 +129,7 @@ export interface ViewManagerConfig {
      * ViewManager implementation to be routable, and you want users to be able to Ctrl+Click or
      * ContextMenu Click to open views from the view menu in new tabs or windows.
      */
-    viewRouteParam?: string;
+    customViewMenuItem?: (view: ViewInfo) => ReactNode;
 }
 
 /**
@@ -172,7 +172,7 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
     readonly instance: string;
     readonly typeDisplayName: string;
     readonly globalDisplayName: string;
-    readonly viewRouteParam: string;
+    readonly customViewMenuItem: (view: ViewInfo) => ReactNode;
     readonly enableAutoSave: boolean;
     readonly enableDefault: boolean;
     readonly enableGlobal: boolean;
@@ -291,7 +291,7 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         instance = 'default',
         typeDisplayName,
         globalDisplayName = 'global',
-        viewRouteParam,
+        customViewMenuItem,
         manageGlobal = false,
         enableAutoSave = true,
         enableDefault = true,
@@ -308,16 +308,11 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
             "ViewManagerModel requires 'initialViewSpec' if 'enableDefault' is false."
         );
 
-        throwIf(
-            viewRouteParam && isNil(XH.routerState),
-            "Cannot use 'viewRouteParam' if your app does not define a router."
-        );
-
         this.type = type;
         this.instance = instance;
         this.typeDisplayName = lowerCase(typeDisplayName ?? genDisplayName(type));
         this.globalDisplayName = globalDisplayName;
-        this.viewRouteParam = viewRouteParam;
+        this.customViewMenuItem = customViewMenuItem;
         this.manageGlobal = executeIfFunction(manageGlobal) ?? false;
         this.enableDefault = enableDefault;
         this.enableGlobal = enableGlobal;

package/desktop/cmp/viewmanager/ViewMenu.ts

@@ -5,12 +5,12 @@
  * Copyright © 2025 Extremely Heavy Industries Inc.
  */
 
-import {hoistCmp, XH} from '@xh/hoist/core';
+import {hoistCmp} from '@xh/hoist/core';
 import {ViewManagerModel, ViewInfo} from '@xh/hoist/cmp/viewmanager';
 import {switchInput} from '@xh/hoist/desktop/cmp/input';
 import {Icon} from '@xh/hoist/icon';
 import {menu, menuDivider, menuItem} from '@xh/hoist/kit/blueprint';
-import {consumeEvent, pluralize} from '@xh/hoist/utils/js';
+import {pluralize} from '@xh/hoist/utils/js';
 import {Dictionary} from 'express-serve-static-core';
 import {each, filter, groupBy, isEmpty, orderBy, some, startCase} from 'lodash';
 import {ReactNode} from 'react';
@@ -157,34 +157,19 @@ function getGroupedMenuItems(
 
 function viewMenuItem(view: ViewInfo, model: ViewManagerModel): ReactNode {
     const icon = view.isCurrentView ? Icon.check() : Icon.placeholder(),
-        title = [],
-        usingRouting = !!(XH.routerState && model.viewRouteParam);
+        title = [];
 
     if (!view.isOwned && view.owner) title.push(view.owner);
     if (view.description) title.push(view.description);
 
-    const href = usingRouting
-        ? XH.router.buildUrl(XH.routerState.name, {
-              ...XH.routerState.params,
-              [model.viewRouteParam]: view.token
-          })
-        : undefined;
-
-    return menuItem({
-        className: 'xh-view-manager__menu-item',
-        key: view.token,
-        text: view.name,
-        title: title.join(' | '),
-        icon,
-        href,
-        onClick: e => {
-            if (!usingRouting || (e.button === 0 && !e.ctrlKey && !e.metaKey)) {
-                consumeEvent(e);
-                model.selectViewAsync(view).catchDefault();
-                return false;
-            }
-
-            return true;
-        }
-    });
+    return model.customViewMenuItem
+        ? model.customViewMenuItem(view)
+        : menuItem({
+              className: 'xh-view-manager__menu-item',
+              key: view.token,
+              text: view.name,
+              title: title.join(' | '),
+              icon,
+              onClick: () => model.selectViewAsync(view).catchDefault()
+          });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "73.0.0-SNAPSHOT.1744144713361",
+  "version": "73.0.0-SNAPSHOT.1744145292985",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",