@xh/hoist 73.0.0-SNAPSHOT.1744142206373 → 73.0.0-SNAPSHOT.1744144713361

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## v73.0.0-SNAPSHOT - unreleased
 
+### 🎁 New Features
+
+`ViewManagerConfig` takes new key `viewRouteParam` to allow ViewManagers implemented with routing to
+have the view buttons on their menu items be right clickable/Ctrl+ Click to open views in new tabs or windows.
+
 ## v72.3.0 - 2025-04-08
 
 ### 🎁 New Features

package/cmp/viewmanager/ViewManagerModel.ts

@@ -305,7 +305,12 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
 
         throwIf(
             !enableDefault && !initialViewSpec,
-            "ViewManagerModel requires 'initialViewSpec' if `enableDefault` is false."
+            "ViewManagerModel requires 'initialViewSpec' if 'enableDefault' is false."
+        );
+
+        throwIf(
+            viewRouteParam && isNil(XH.routerState),
+            "Cannot use 'viewRouteParam' if your app does not define a router."
         );
 
         this.type = type;

package/desktop/cmp/viewmanager/ViewMenu.ts

@@ -158,7 +158,7 @@ function getGroupedMenuItems(
 function viewMenuItem(view: ViewInfo, model: ViewManagerModel): ReactNode {
     const icon = view.isCurrentView ? Icon.check() : Icon.placeholder(),
         title = [],
-        usingRouting = XH.routerState && model.viewRouteParam;
+        usingRouting = !!(XH.routerState && model.viewRouteParam);
 
     if (!view.isOwned && view.owner) title.push(view.owner);
     if (view.description) title.push(view.description);
@@ -178,18 +178,12 @@ function viewMenuItem(view: ViewInfo, model: ViewManagerModel): ReactNode {
         icon,
         href,
         onClick: e => {
-            if (!usingRouting) {
+            if (!usingRouting || (e.button === 0 && !e.ctrlKey && !e.metaKey)) {
                 consumeEvent(e);
                 model.selectViewAsync(view).catchDefault();
                 return false;
             }
 
-            if (e.button === 0 && !e.ctrlKey && !e.metaKey) {
-                consumeEvent(e);
-                XH.navigate(href);
-                return false;
-            }
-
             return true;
         }
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "73.0.0-SNAPSHOT.1744142206373",
+  "version": "73.0.0-SNAPSHOT.1744144713361",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",