@xh/hoist 73.0.0-SNAPSHOT.1740517958946 → 73.0.0-SNAPSHOT.1741787114903

package/CHANGELOG.md

@@ -7,6 +7,10 @@
 * Modify `TabContainerModel` to make more methods `protected`, improving extensibility for advanced
 use-cases.
 
+* Enhance exception handling in `FetchService` to capture messages returned as raw strings, or without
+explicit names.
+
+
 ## v72.1.0 - 2025-02-13
 
 ### 🎁 New Features

package/build/types/security/BaseOAuthClient.d.ts

@@ -63,11 +63,10 @@ export interface BaseOAuthClientConfig<S> {
  * suitable concrete implementation to power a client-side OauthService. See `MsalClient` and
  * `AuthZeroClient`
  *
- * Initialize such a service and this client within the `preAuthInitAsync()` lifecycle method of
- * `AppModel` to use the tokens it acquires to authenticate with the Hoist server. (Note this
- * requires a suitable server-side `AuthenticationService` implementation to validate the token and
- * actually resolve the user.) On init, the client implementation will initiate a pop-up or redirect
- * flow as necessary.
+ * Initialize such a service and this client within an app's primary {@link HoistAuthModel} to use
+ * the tokens it acquires to authenticate with the Hoist server. (Note this requires a suitable
+ * server-side `AuthenticationService` implementation to validate the token and actually resolve
+ * the user.) On init, the client impl will initiate a pop-up or redirect flow as necessary.
  */
 export declare abstract class BaseOAuthClient<C extends BaseOAuthClientConfig<S>, S> extends HoistBase {
     /** Config loaded from UI server + init method. */

package/core/exception/Exception.ts

@@ -7,7 +7,7 @@
 import {PlainObject, XH} from '@xh/hoist/core';
 import {FetchOptions} from '@xh/hoist/svc';
 import {pluralize} from '@xh/hoist/utils/js';
-import {isPlainObject} from 'lodash';
+import {isPlainObject, truncate} from 'lodash';
 import {FetchException, HoistException, TimeoutException, TimeoutExceptionConfig} from './Types';
 
 /**
@@ -90,17 +90,16 @@ export class Exception {
         // Try to "smart" decode as server provided JSON Exception (with a name)
         try {
             const cType = headers.get('Content-Type');
-            if (cType && cType.includes('application/json')) {
-                const serverDetails = JSON.parse(responseText);
-                if (serverDetails?.name) {
-                    return this.createFetchException({
-                        ...defaults,
-                        name: serverDetails.name,
-                        message: serverDetails.message,
-                        isRoutine: serverDetails.isRoutine ?? false,
-                        serverDetails
-                    });
-                }
+            if (cType?.includes('application/json')) {
+                const obj = safeParseJson(responseText),
+                    message = obj ? obj.message : truncate(responseText?.trim(), {length: 255});
+                return this.createFetchException({
+                    ...defaults,
+                    name: obj?.name ?? defaults.name,
+                    message: message ?? statusText,
+                    isRoutine: obj?.isRoutine ?? false,
+                    serverDetails: obj ?? responseText
+                });
             }
         } catch (ignored) {}
 
@@ -222,6 +221,14 @@ export class Exception {
     }
 }
 
+function safeParseJson(txt: string): PlainObject {
+    try {
+        return JSON.parse(txt);
+    } catch (ignored) {
+        return null;
+    }
+}
+
 export function isHoistException(src: unknown): src is HoistException {
     return src?.['isHoistException'];
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "73.0.0-SNAPSHOT.1740517958946",
+  "version": "73.0.0-SNAPSHOT.1741787114903",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/security/BaseOAuthClient.ts

@@ -89,11 +89,10 @@ export interface BaseOAuthClientConfig<S> {
  * suitable concrete implementation to power a client-side OauthService. See `MsalClient` and
  * `AuthZeroClient`
  *
- * Initialize such a service and this client within the `preAuthInitAsync()` lifecycle method of
- * `AppModel` to use the tokens it acquires to authenticate with the Hoist server. (Note this
- * requires a suitable server-side `AuthenticationService` implementation to validate the token and
- * actually resolve the user.) On init, the client implementation will initiate a pop-up or redirect
- * flow as necessary.
+ * Initialize such a service and this client within an app's primary {@link HoistAuthModel} to use
+ * the tokens it acquires to authenticate with the Hoist server. (Note this requires a suitable
+ * server-side `AuthenticationService` implementation to validate the token and actually resolve
+ * the user.) On init, the client impl will initiate a pop-up or redirect flow as necessary.
  */
 export abstract class BaseOAuthClient<C extends BaseOAuthClientConfig<S>, S> extends HoistBase {
     /** Config loaded from UI server + init method. */