@xh/hoist 71.0.0-SNAPSHOT.1734551243081 → 71.0.0-SNAPSHOT.1734627276913

package/build/types/cmp/viewmanager/ViewManagerModel.d.ts

@@ -2,7 +2,7 @@ import { HoistModel, LoadSpec, PersistOptions, PlainObject, TaskObserver, Thunka
 import type { ViewManagerProvider } from '@xh/hoist/core';
 import { ViewInfo } from './ViewInfo';
 import { View } from './View';
-import { ViewToBlobApi, ViewCreateSpec } from './ViewToBlobApi';
+import { ViewCreateSpec, ViewUpdateSpec } from './ViewToBlobApi';
 export interface ViewManagerConfig {
     /**
      * True (default) to allow user to opt in to automatically saving changes to their current view.
@@ -143,11 +143,9 @@ export declare class ViewManagerModel<T = PlainObject> extends HoistModel {
      * @internal
      */
     providers: ViewManagerProvider<any>[];
-    /**
-     * Data access for persisting views.
-     * @internal
-     */
-    api: ViewToBlobApi<T>;
+    /** Data access for persisting views. */
+    private api;
+    /** Last time changes were pushed to linked persistence providers */
     private lastPushed;
     get isValueDirty(): boolean;
     get isViewSavable(): boolean;
@@ -179,6 +177,10 @@ export declare class ViewManagerModel<T = PlainObject> extends HoistModel {
     userUnpin(view: ViewInfo): void;
     isUserPinned(view: ViewInfo): boolean | null;
     validateViewNameAsync(name: string, existing?: ViewInfo): Promise<string>;
+    /** Update all aspects of a view's metadata.*/
+    updateViewInfoAsync(view: ViewInfo, updates: ViewUpdateSpec): Promise<View<T>>;
+    /** Promote a view to global visibility/ownership status. */
+    makeViewGlobalAsync(view: ViewInfo): Promise<View<T>>;
     deleteViewsAsync(toDelete: ViewInfo[]): Promise<void>;
     private initAsync;
     private loadViewAsync;

package/cmp/viewmanager/ViewManagerModel.ts

@@ -29,7 +29,7 @@ import {runInAction} from 'mobx';
 import {ReactNode} from 'react';
 import {ViewInfo} from './ViewInfo';
 import {View} from './View';
-import {ViewToBlobApi, ViewCreateSpec} from './ViewToBlobApi';
+import {ViewToBlobApi, ViewCreateSpec, ViewUpdateSpec} from './ViewToBlobApi';
 
 export interface ViewManagerConfig {
     /**
@@ -201,13 +201,10 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
      */
     providers: ViewManagerProvider<any>[] = [];
 
-    /**
-     * Data access for persisting views.
-     * @internal
-     */
-    api: ViewToBlobApi<T>;
+    /** Data access for persisting views. */
+    private api: ViewToBlobApi<T>;
 
-    // Last time changes were pushed to linked persistence providers
+    /** Last time changes were pushed to linked persistence providers */
     private lastPushed: number = null;
 
     //---------------
@@ -442,6 +439,16 @@ export class ViewManagerModel<T = PlainObject> extends HoistModel {
         return null;
     }
 
+    /** Update all aspects of a view's metadata.*/
+    async updateViewInfoAsync(view: ViewInfo, updates: ViewUpdateSpec): Promise<View<T>> {
+        return this.api.updateViewInfoAsync(view, updates);
+    }
+
+    /** Promote a view to global visibility/ownership status. */
+    async makeViewGlobalAsync(view: ViewInfo): Promise<View<T>> {
+        return this.api.makeViewGlobalAsync(view);
+    }
+
     async deleteViewsAsync(toDelete: ViewInfo[]): Promise<void> {
         let exception;
         try {

package/desktop/cmp/viewmanager/ViewManager.ts

@@ -64,14 +64,24 @@ export const [ViewManager, viewManager] = hoistCmp.withFactory<ViewManagerProps>
         showRevertButton = 'never',
         buttonSide = 'right'
     }: ViewManagerProps) {
-        const locModel = useLocalModel(() => new ViewManagerLocalModel(model)),
+        const {loadModel} = model,
+            locModel = useLocalModel(() => new ViewManagerLocalModel(model)),
             save = saveButton({model: locModel, mode: showSaveButton, ...saveButtonProps}),
             revert = revertButton({model: locModel, mode: showRevertButton, ...revertButtonProps}),
             menu = popover({
                 disabled: !locModel.isVisible, // Prevent orphaned popover menu
                 item: menuButton({model: locModel, ...menuButtonProps}),
-                content: viewMenu({model: locModel}),
-                placement: 'bottom-start',
+                content: loadModel.isPending
+                    ? box({
+                          item: spinner({compact: true}),
+                          alignItems: 'center',
+                          justifyContent: 'center',
+                          height: 30,
+                          width: 30
+                      })
+                    : viewMenu({model: locModel}),
+                onOpening: () => model.refreshAsync(),
+                placement: 'bottom',
                 popoverClassName: 'xh-view-manager__popover'
             });
         return fragment(

package/desktop/cmp/viewmanager/ViewMenu.ts

@@ -5,15 +5,12 @@
  * Copyright © 2024 Extremely Heavy Industries Inc.
  */
 
-import {box} from '@xh/hoist/cmp/layout';
-import {spinner} from '@xh/hoist/cmp/spinner';
 import {hoistCmp} from '@xh/hoist/core';
 import {ViewManagerModel, ViewInfo} from '@xh/hoist/cmp/viewmanager';
 import {switchInput} from '@xh/hoist/desktop/cmp/input';
 import {Icon} from '@xh/hoist/icon';
 import {menu, menuDivider, menuItem} from '@xh/hoist/kit/blueprint';
-import {wait} from '@xh/hoist/promise';
-import {consumeEvent, pluralize} from '@xh/hoist/utils/js';
+import {pluralize} from '@xh/hoist/utils/js';
 import {Dictionary} from 'express-serve-static-core';
 import {each, filter, groupBy, isEmpty, orderBy, some, startCase} from 'lodash';
 import {ReactNode} from 'react';
@@ -83,7 +80,6 @@ function getOtherMenuItems(model: ViewManagerLocalModel): ReactNode[] {
         isViewSavable,
         views,
         isValueDirty,
-        loadModel,
         typeDisplayName
     } = parent;
 
@@ -126,21 +122,6 @@ function getOtherMenuItems(model: ViewManagerLocalModel): ReactNode[] {
             disabled: isEmpty(views),
             text: `Manage ${pluralName}...`,
             onClick: () => model.manageDialogModel.open()
-        }),
-        menuItem({
-            icon: !loadModel.isPending
-                ? Icon.refresh()
-                : box({
-                      height: 20,
-                      item: spinner({width: 16.25, height: 16.25})
-                  }),
-            disabled: loadModel.isPending,
-            text: `Refresh ${pluralName}`,
-            onClick: e => {
-                // Ensure at least 100ms delay to render spinner
-                Promise.all([wait(100), parent.refreshAsync()]).linkTo(loadModel);
-                consumeEvent(e);
-            }
         })
     ];
 }

package/desktop/cmp/viewmanager/dialog/ManageDialogModel.ts

@@ -17,7 +17,7 @@ import {viewsGrid} from '@xh/hoist/desktop/cmp/viewmanager/dialog/ManageDialog';
 import {Icon} from '@xh/hoist/icon';
 import {action, bindable, computed, makeObservable, observable, runInAction} from '@xh/hoist/mobx';
 import {pluralize} from '@xh/hoist/utils/js';
-import {capitalize, compact, isEmpty, some, startCase} from 'lodash';
+import {capitalize, compact, every, isEmpty, some, startCase} from 'lodash';
 import {ReactNode} from 'react';
 import {ViewPanelModel} from './ViewPanelModel';
 
@@ -128,7 +128,11 @@ export class ManageDialogModel extends HoistModel {
 
     @action
     togglePinned(views: ViewInfo[]) {
-        views.forEach(v => this.viewManagerModel.togglePinned(v));
+        const allPinned = every(views, 'isPinned'),
+            {viewManagerModel} = this;
+        views.forEach(v =>
+            allPinned ? viewManagerModel.userUnpin(v) : viewManagerModel.userPin(v)
+        );
         this.refreshAsync();
     }
 
@@ -173,7 +177,7 @@ export class ManageDialogModel extends HoistModel {
 
     private async doUpdateAsync(view: ViewInfo, update: ViewUpdateSpec) {
         const {viewManagerModel} = this;
-        await viewManagerModel.api.updateViewInfoAsync(view, update);
+        await viewManagerModel.updateViewInfoAsync(view, update);
         await viewManagerModel.refreshAsync();
         await this.refreshAsync();
     }
@@ -235,7 +239,7 @@ export class ManageDialogModel extends HoistModel {
         if (!confirmed) return;
 
         const {viewManagerModel} = this;
-        const updated = await viewManagerModel.api.makeViewGlobalAsync(view);
+        const updated = await viewManagerModel.makeViewGlobalAsync(view);
         await viewManagerModel.refreshAsync();
         await this.refreshAsync();
         await this.selectViewAsync(updated.info); // reselect -- will have moved tabs!
@@ -293,7 +297,7 @@ export class ManageDialogModel extends HoistModel {
                 {field: 'name', flex: true},
                 {field: 'group', hidden: true},
                 {field: 'owner', hidden: true},
-                {field: 'lastUpdated', ...dateTimeCol},
+                {field: 'lastUpdated', ...dateTimeCol, hidden: true},
                 {
                     field: 'isPinned',
                     width: 40,

package/desktop/cmp/viewmanager/dialog/ViewMultiPanel.ts

@@ -11,7 +11,7 @@ import {button} from '@xh/hoist/desktop/cmp/button';
 import {panel} from '@xh/hoist/desktop/cmp/panel';
 import {Icon} from '@xh/hoist/icon';
 import {pluralize} from '@xh/hoist/utils/js';
-import {every, isEmpty, some} from 'lodash';
+import {every, isEmpty} from 'lodash';
 import {ManageDialogModel} from './ManageDialogModel';
 
 export const viewMultiPanel = hoistCmp.factory<ManageDialogModel>({
@@ -38,8 +38,7 @@ const buttons = hoistCmp.factory<ManageDialogModel>({
     render({model}) {
         const views = model.selectedViews,
             allEditable = every(views, 'isEditable'),
-            allPinned = every(views, 'isPinned'),
-            allUnpinned = !some(views, 'isPinned');
+            allPinned = every(views, 'isPinned');
 
         return vbox({
             style: {gap: 10, alignItems: 'center'},
@@ -52,7 +51,6 @@ const buttons = hoistCmp.factory<ManageDialogModel>({
                     }),
                     width: 200,
                     outlined: true,
-                    omit: !(allPinned || allUnpinned),
                     onClick: () => model.togglePinned(views)
                 }),
                 button({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "71.0.0-SNAPSHOT.1734551243081",
+  "version": "71.0.0-SNAPSHOT.1734627276913",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",