@xh/hoist 70.0.0-SNAPSHOT.1731374612473 → 70.0.0-SNAPSHOT.1731694945674

package/CHANGELOG.md

@@ -19,7 +19,10 @@
     * `DashModel|GroupingChooserModel|FilterChooserModel|PanelModel|TabContainerModel.provider`
     * `PersistenceProvider.clearRaw()`
 * Renamed `ZoneGridModelPersistOptions.persistMappings`, adding the trailing `s` for consistency.
-* Updated `JsonBlobService.listAsync` to inline `loadSpec` with all other args in a single object.
+* Changed signature of `JsonBlobService.listAsync()` to inline `loadSpec` with all other args in a
+  single options object.
+* Changed signature of `waitFor()` to take its optional `interval` and `timeout` arguments in a
+  single options object.
 
 ### 🎁 New Features
 

package/build/types/promise/Promise.d.ts

@@ -87,15 +87,16 @@ export type PromiseLinkSpec = TaskObserver | {
  */
 export declare function wait<T>(interval?: number): Promise<T>;
 /**
- * Return a promise that will resolve after a condition has been met, polling at the specified
- * interval.
- *
- * @param condition - function that should return true when condition is met
+ * Return a promise that will resolve after a condition has been met, or reject if timed out.
+ * @param condition - function returning true when expected condition is met.
  * @param interval - milliseconds to wait between checks (default 50). Note that the actual time
  *      will be subject to the minimum delay for `setTimeout()` in the browser.
  * @param timeout - milliseconds after which the Promise should be rejected (default 5000).
  */
-export declare function waitFor(condition: () => boolean, interval?: number, timeout?: number): Promise<void>;
+export declare function waitFor(condition: () => boolean, { interval, timeout }?: {
+    interval?: number;
+    timeout?: number;
+}): Promise<void>;
 /**
  * Return a promise that resolves immediately.
  * @param value - the value to be returned by the resulting Promise.

package/data/cube/View.ts

@@ -472,6 +472,12 @@ export class View extends HoistBase {
             'Store.reuseRecords cannot be used on a Store that is connected to a Cube View'
         );
 
+        throwIf(
+            ret.some(s => s.idEncodesTreePath) &&
+                (!isNil(this.cube.bucketSpecFn) || !isNil(this.cube.omitFn)),
+            'Store.idEncodesTreePath cannot be used on a Store that is connected to a Cube with a `bucketSpecFn` or `omitFn`'
+        );
+
         return ret;
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "70.0.0-SNAPSHOT.1731374612473",
+  "version": "70.0.0-SNAPSHOT.1731694945674",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/promise/Promise.ts

@@ -121,21 +121,20 @@ export function wait<T>(interval: number = 0): Promise<T> {
 }
 
 /**
- * Return a promise that will resolve after a condition has been met, polling at the specified
- * interval.
- *
- * @param condition - function that should return true when condition is met
+ * Return a promise that will resolve after a condition has been met, or reject if timed out.
+ * @param condition - function returning true when expected condition is met.
  * @param interval - milliseconds to wait between checks (default 50). Note that the actual time
  *      will be subject to the minimum delay for `setTimeout()` in the browser.
  * @param timeout - milliseconds after which the Promise should be rejected (default 5000).
  */
 export function waitFor(
     condition: () => boolean,
-    interval: number = 50,
-    timeout: number = 5 * SECONDS
+    {interval = 50, timeout = 5 * SECONDS}: {interval?: number; timeout?: number} = {}
 ): Promise<void> {
-    const startTime = Date.now();
+    if (!isNumber(interval) || interval <= 0) throw new Error('Invalid interval');
+    if (!isNumber(timeout) || timeout <= 0) throw new Error('Invalid timeout');
 
+    const startTime = Date.now();
     return new Promise((resolve, reject) => {
         const resolveOnMet = () => {
             if (condition()) {