@xh/hoist 55.2.1 → 55.3.0

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## v55.3.0 - 2023-03-03
+
+### 🐞 Bug Fixes
+* Grid column filters scroll their internal grid horizontally to avoid clipping longer values.
+* Minor improvements to the same grid filter dialog's alignment and labelling.
+
+### ⚙️ Technical
+* Use native `structuredClone` instead of lodash `deepClone` throughout toolkit.
+
 ## v55.2.1 - 2023-02-24
 
 ### 🐞 Bug Fixes

package/admin/differ/DifferModel.ts

@@ -13,7 +13,7 @@ import {Icon} from '@xh/hoist/icon';
 import {bindable, makeObservable, observable, action} from '@xh/hoist/mobx';
 import {pluralize} from '@xh/hoist/utils/js';
 import {hbox} from '@xh/hoist/cmp/layout';
-import {cloneDeep, isEqual, isString, isNil, omit, remove, trimEnd} from 'lodash';
+import {isEqual, isString, isNil, omit, remove, trimEnd} from 'lodash';
 import {hspacer} from '../../cmp/layout';
 
 import {DifferDetailModel} from './DifferDetailModel';
@@ -151,7 +151,7 @@ export class DifferModel extends HoistModel {
             const resp = await Promise.all([
                 XH.fetchJson({url: `${url}/${entityName}s`, loadSpec}),
                 this.clipboardContent ?
-                    Promise.resolve(cloneDeep(this.clipboardContent)) :
+                    Promise.resolve(structuredClone(this.clipboardContent)) :
                     XH.fetchJson({url: `${remoteBaseUrl}${url}/${entityName}s`, loadSpec})
             ]);
             this.processResponse(resp);
@@ -250,8 +250,8 @@ export class DifferModel extends HoistModel {
 
     rawRecordsAreEqual(local, remote) {
         // cloning to avoid disturbing the source data.
-        local = cloneDeep(local);
-        remote = cloneDeep(remote);
+        local = structuredClone(local);
+        remote = structuredClone(remote);
 
         // For JSON records, parse JSON to do an accurate value compare,
         if (local?.valueType === 'json' && remote?.valueType === 'json') {

package/cmp/ag-grid/AgGrid.scss

@@ -306,14 +306,6 @@
     .ag-cell {
       padding-left: var(--xh-grid-tiny-cell-lr-pad-px);
       padding-right: var(--xh-grid-tiny-cell-lr-pad-px);
-
-      .xh-check-box {
-        padding-top: 1px;
-
-        .bp4-control-indicator {
-          font-size: calc(var(--xh-grid-tiny-font-size-px) + 2px);
-        }
-      }
     }
 
     .ag-header-cell,
@@ -377,6 +369,11 @@
       color: var(--xh-grid-empty-text-color);
     }
   }
+
+  // Set Blueprint controls - specifically checkboxes - to match grid size.
+  .bp4-control .bp4-control-indicator {
+    font-size: 1em;
+  }
 }
 
 //------------------------

package/cmp/ag-grid/AgGridModel.ts

@@ -9,7 +9,6 @@ import {action, bindable, computed, makeObservable, observable} from '@xh/hoist/
 import {throwIf} from '@xh/hoist/utils/js';
 import {
     castArray,
-    cloneDeep,
     concat,
     find,
     has,
@@ -306,7 +305,7 @@ export class AgGridModel extends HoistModel {
     setSortState(sortState: AgGridColumnSortState[]) {
         this.throwIfNotReady();
 
-        const sortedColumnState = cloneDeep(sortState),
+        const sortedColumnState = structuredClone(sortState),
             [primaryColumnState, secondaryColumnState] = partition(sortedColumnState, it => !isArray(it.colId)),
             {agColumnApi: colApi, agApi} = this,
             isPivot = colApi.isPivotMode(),
@@ -390,7 +389,7 @@ export class AgGridModel extends HoistModel {
         const {agColumnApi} = this,
             validColIds = [
                 AgGridModel.AUTO_GROUP_COL_ID,
-                ...agColumnApi.getAllColumns().map(it => it.colId)
+                ...agColumnApi.getColumns().map(it => it.colId)
             ];
 
         let {isPivot, columns} = colState;

package/cmp/chart/Chart.ts

@@ -355,7 +355,7 @@ class ChartLocalModel extends HoistModel {
     }
 
     getThemeConfig() {
-        return XH.darkTheme ? cloneDeep(DarkTheme) : cloneDeep(LightTheme);
+        return XH.darkTheme ? structuredClone(DarkTheme) : structuredClone(LightTheme);
     }
 
     getModelConfig() {

package/cmp/chart/ChartModel.ts

@@ -6,7 +6,7 @@
  */
 import {HoistModel, PlainObject, Some} from '@xh/hoist/core';
 import {action, makeObservable, observable} from '@xh/hoist/mobx';
-import {castArray, cloneDeep, merge} from 'lodash';
+import {castArray, merge} from 'lodash';
 
 interface ChartConfig {
 
@@ -84,7 +84,7 @@ export class ChartModel extends HoistModel {
      */
     @action
     updateHighchartsConfig(update: any) {
-        this.highchartsConfig = merge(cloneDeep(this.highchartsConfig), update);
+        this.highchartsConfig = merge(structuredClone(this.highchartsConfig), update);
     }
 
     /** @param series - one or more data series to be charted. */

package/cmp/filter/FilterChooserModel.ts

@@ -29,7 +29,6 @@ import {throwIf, withDefault} from '@xh/hoist/utils/js';
 import {createObservableRef} from '@xh/hoist/utils/react';
 import {ReactNode} from 'react';
 import {
-    cloneDeep,
     compact,
     flatMap,
     flatten,
@@ -374,7 +373,7 @@ export class FilterChooserModel extends HoistModel {
             // it's internal `value`. Force synchronise its `value` to our bound `selectValue`
             // to get it back inline. Note we're intentionally not using `setSelectValue()`,
             // which returns early if the actual filter value hasn't changed.
-            this.selectValue = cloneDeep(this.selectValue);
+            this.selectValue = structuredClone(this.selectValue);
         });
     }
 

package/cmp/grid/GridModel.ts

@@ -60,7 +60,6 @@ import equal from 'fast-deep-equal';
 import {
     castArray,
     clone,
-    cloneDeep,
     compact,
     defaults,
     defaultsDeep,
@@ -1061,7 +1060,7 @@ export class GridModel extends HoistModel {
     applyColumnStateChanges(colStateChanges: Partial<ColumnState>[]) {
         if (isEmpty(colStateChanges)) return;
 
-        let columnState = cloneDeep(this.columnState);
+        let columnState = structuredClone(this.columnState);
 
         throwIf(colStateChanges.some(({colId}) => !find(columnState, {colId})),
             'Invalid columns detected in column changes!');

package/cmp/grouping/GroupingChooserModel.ts

@@ -10,7 +10,7 @@ import {action, computed, observable, makeObservable} from '@xh/hoist/mobx';
 import {genDisplayName} from '@xh/hoist/data';
 import {throwIf} from '@xh/hoist/utils/js';
 import {createObservableRef} from '@xh/hoist/utils/react';
-import {cloneDeep, difference, isFunction, isArray, isEmpty, isEqual, isString, keys, sortBy} from 'lodash';
+import {difference, isFunction, isArray, isEmpty, isEqual, isString, keys, sortBy} from 'lodash';
 
 export interface GroupingChooserConfig {
     /**
@@ -128,7 +128,7 @@ export class GroupingChooserModel extends HoistModel {
                 this.persistValue = persistWith.persistValue ?? true;
                 this.persistFavorites = persistWith.persistFavorites ?? true;
 
-                const state = cloneDeep(this.provider.read());
+                const state = structuredClone(this.provider.read());
                 if (this.persistValue && state?.value && this.validateValue(state?.value)) {
                     value = state.value;
                 }

package/core/HoistBase.ts

@@ -8,7 +8,6 @@ import {XH, PersistenceProvider, PersistOptions, DebounceSpec} from './';
 import {throwIf, getOrCreate} from '@xh/hoist/utils/js';
 import {
     debounce as lodashDebounce,
-    cloneDeep,
     isFunction,
     isNil,
     isNumber,
@@ -220,7 +219,7 @@ export abstract class HoistBase {
                 provider = this.markManaged(PersistenceProvider.create(persistWith)),
                 providerState = provider.read();
             if (!isUndefined(providerState)) {
-                runInAction(() => this[property] = cloneDeep(providerState));
+                runInAction(() => this[property] = structuredClone(providerState));
             }
             this.addReaction({
                 track: () => this[property],

package/core/HoistBaseDecorators.ts

@@ -6,7 +6,7 @@
 */
 import {PersistenceProvider, PersistOptions, HoistBaseClass} from './';
 
-import {cloneDeep, isUndefined} from 'lodash';
+import {isUndefined} from 'lodash';
 import {wait} from '../promise';
 import {throwIf} from '../utils/js';
 
@@ -75,7 +75,7 @@ function createPersistDescriptor(target: HoistBaseClass, property: string, descr
         try {
             const persistWith = {path: property, ...this.persistWith, ...options},
                 provider = this.markManaged(PersistenceProvider.create(persistWith));
-            providerState = cloneDeep(provider.read());
+            providerState = structuredClone(provider.read());
             wait().then(() => {
                 this.addReaction({
                     track: () => this[property],

package/core/persist/PersistenceProvider.ts

@@ -9,7 +9,6 @@ import {DebounceSpec, XH} from '../';
 import {LocalStorageProvider, PrefProvider, DashViewProvider, CustomProvider, PersistOptions} from './';
 import {
     isUndefined,
-    cloneDeep,
     get,
     set,
     unset,
@@ -96,7 +95,7 @@ export class PersistenceProvider {
      * Clear any state saved by this object at a path
      */
     clear(path: string = this.path) {
-        const obj = cloneDeep(this.readRaw());
+        const obj = structuredClone(this.readRaw());
         unset(obj, this.path);
         this.writeRaw(obj);
     }
@@ -112,7 +111,7 @@ export class PersistenceProvider {
     // Implementation
     //----------------
     protected writeInternal(data: object) {
-        const obj = cloneDeep(this.readRaw());
+        const obj = structuredClone(this.readRaw());
         set(obj, this.path, data);
         this.writeRaw(obj);
     }

package/desktop/cmp/dash/container/DashContainerModel.ts

@@ -22,7 +22,6 @@ import {debounced, ensureUniqueBy, throwIf} from '@xh/hoist/utils/js';
 import {createObservableRef} from '@xh/hoist/utils/react';
 import {isOmitted} from '@xh/hoist/utils/impl';
 import {
-    cloneDeep,
     defaultsDeep,
     find,
     isFinite,
@@ -540,7 +539,7 @@ export class DashContainerModel extends DashModel<DashContainerViewSpec, DashVie
     private createGoldenLayout(containerEl: HTMLElement, state: any): GoldenLayout {
         const {viewSpecs} = this,
             ret = new GoldenLayout({
-                content: convertStateToGL(cloneDeep(state), this),
+                content: convertStateToGL(structuredClone(state), this),
                 settings: {
                     // Remove icons by default
                     showPopoutIcon: false,

package/desktop/cmp/grid/impl/filter/ColumnHeaderFilter.ts

@@ -70,24 +70,27 @@ const content = hoistCmp.factory({
 const bbar = hoistCmp.factory<ColumnHeaderFilterModel>({
     render({model}) {
         const {commitOnChange} = model;
-        return toolbar(
-            filler(),
-            button({
-                icon: Icon.delete(),
-                text: 'Clear Filter',
-                intent: 'danger',
-                disabled: !model.hasFilter,
-                onClick: () => model.clear()
-            }),
-            button({
-                omit: commitOnChange,
-                icon: Icon.check(),
-                text: 'Apply Filter',
-                intent: 'success',
-                disabled: !model.hasFilter && !model.hasPendingFilter,
-                onClick: () => model.commit()
-            })
-        );
+        return toolbar({
+            compact: true,
+            items: [
+                filler(),
+                button({
+                    icon: Icon.delete(),
+                    text: 'Clear Filter',
+                    intent: 'danger',
+                    disabled: !model.hasFilter,
+                    onClick: () => model.clear()
+                }),
+                button({
+                    omit: commitOnChange,
+                    icon: Icon.check(),
+                    text: 'Apply Filter',
+                    intent: 'success',
+                    disabled: !model.hasFilter && !model.hasPendingFilter,
+                    onClick: () => model.commit()
+                })
+            ]
+        });
     }
 });
 

package/desktop/cmp/grid/impl/filter/values/ValuesTab.scss

@@ -24,4 +24,23 @@
       margin-top: var(--xh-pad-px);
     }
   }
-}
+
+  // Fix up alignment on first checkbox column.
+  .ag-header-cell.xh-column-header-align-center {
+    padding: 0 !important;
+  }
+
+  .ag-pinned-left-header,
+  .ag-cell.ag-cell-last-left-pinned {
+    .bp4-control.bp4-inline {
+      margin-right: -8px;
+
+      input {
+        margin: 0;
+      }
+    }
+
+    // Less obvious pinning for the checkbox column.
+    border-right: none !important;
+  }
+}

package/desktop/cmp/grid/impl/filter/values/ValuesTabModel.ts

@@ -105,6 +105,12 @@ export class ValuesTabModel extends HoistModel {
             without(this.pendingValues, ...values);
     }
 
+    toggleAllRecsChecked() {
+        const setAllToChecked = !this.allVisibleRecsChecked,
+            values = this.gridModel.store.records.map(it => it.get('value'));
+        this.setRecsChecked(setAllToChecked, values);
+    }
+
     //-------------------
     // Implementation
     //-------------------
@@ -175,13 +181,13 @@ export class ValuesTabModel extends HoistModel {
 
     private createGridModel() {
         const {BLANK_PLACEHOLDER} = GridFilterModel,
-            {align, headerAlign, displayName} = this.headerFilterModel.column,
-            {fieldType} = this.headerFilterModel,
-            renderer = this.fieldSpec.renderer ?? (fieldType !== 'tags' ? this.headerFilterModel.column.renderer : null);
+            {headerFilterModel, fieldSpec} = this,
+            {fieldType} = headerFilterModel,
+            renderer = fieldSpec.renderer ?? (fieldType !== 'tags' ? this.headerFilterModel.column.renderer : null);
 
         return new GridModel({
             store: {
-                idSpec: (raw) => this.fieldSpec.getUniqueValue(raw.value).toString(),
+                idSpec: (raw) => fieldSpec.getUniqueValue(raw.value).toString(),
                 fields: [
                     {name: 'value', type: 'auto'},
                     {name: 'isChecked', type: 'bool'}
@@ -190,7 +196,10 @@ export class ValuesTabModel extends HoistModel {
             selModel: 'disabled',
             emptyText: 'No records found...',
             contextMenu: null,
-            autosizeOptions: {mode: 'disabled'},
+            // Autosize enabled to ensure that long values don't get clipped and user can scroll
+            // right if necessary to view full string. For longer strings that differ only in their
+            // endings this is important - e.g. instrument or contract names ending in a date.
+            autosizeOptions: {mode: 'managed'},
             sizingMode: 'compact',
             stripeRows: false,
             sortBy: 'value',
@@ -202,16 +211,18 @@ export class ValuesTabModel extends HoistModel {
                 {
                     field: 'isChecked',
                     headerName: ({gridModel}) => {
-                        const {store} = gridModel,
-                            values = store.records.map(it => it.get('value'));
                         return checkbox({
-                            disabled: store.empty,
+                            disabled: gridModel.store.empty,
                             displayUnsetState: true,
                             value: this.allVisibleRecsChecked,
-                            onChange: () => this.setRecsChecked(!this.allVisibleRecsChecked, values)
+                            onChange: () => this.toggleAllRecsChecked()
                         });
                     },
-                    width: 30,
+                    width: 28,
+                    autosizable: false,
+                    pinned: true,
+                    align: 'center',
+                    headerAlign: 'center',
                     rendererIsComplex: true,
                     renderer: (v, {record}) => {
                         return checkbox({
@@ -223,10 +234,8 @@ export class ValuesTabModel extends HoistModel {
                 },
                 {
                     field: 'value',
-                    flex: 1,
-                    displayName,
-                    align,
-                    headerAlign,
+                    displayName: '(Select All)',
+                    align: 'left',
                     comparator: (v1, v2, sortDir, abs, {defaultComparator}) => {
                         const mul = sortDir === 'desc' ? -1 : 1;
                         if (v1 === BLANK_PLACEHOLDER) return 1 * mul;

package/desktop/cmp/leftrightchooser/LeftRightChooser.ts

@@ -8,7 +8,6 @@ import {grid, GridProps} from '@xh/hoist/cmp/grid';
 import {hframe, vbox} from '@xh/hoist/cmp/layout';
 import {BoxProps, hoistCmp, HoistProps, uses} from '@xh/hoist/core';
 import '@xh/hoist/desktop/register';
-import {cloneDeep} from 'lodash';
 import {chooserToolbar} from './impl/ChooserToolbar';
 import {description} from './impl/Description';
 import './LeftRightChooser.scss';
@@ -37,8 +36,8 @@ export const [LeftRightChooser, leftRightChooser] = hoistCmp.withFactory<LeftRig
                     }
                 }
             },
-            leftGridOptions = cloneDeep(gridOptions),
-            rightGridOptions = cloneDeep(gridOptions);
+            leftGridOptions = structuredClone(gridOptions),
+            rightGridOptions = structuredClone(gridOptions);
 
         if (!leftGroupingExpanded) leftGridOptions.agOptions.groupDefaultExpanded = 0;
         if (!rightGroupingExpanded) rightGridOptions.agOptions.groupDefaultExpanded = 0;

package/desktop/cmp/treemap/TreeMapModel.ts

@@ -13,7 +13,7 @@ import {numberRenderer} from '@xh/hoist/format';
 import {action, bindable, computed, makeObservable, observable} from '@xh/hoist/mobx';
 import {throwIf, withDefault} from '@xh/hoist/utils/js';
 import {ReactNode} from 'react';
-import {cloneDeep, get, isEmpty, isFinite, max, set, sortBy, sumBy, unset} from 'lodash';
+import {get, isEmpty, isFinite, max, set, sortBy, sumBy, unset} from 'lodash';
 
 /**
  * Core Model for a TreeMap.
@@ -442,7 +442,7 @@ export class TreeMapModel extends HoistModel {
 
     toggleNodeExpanded(treePath) {
         const {gridModel} = this,
-            expandState = cloneDeep(gridModel.expandState);
+            expandState = structuredClone(gridModel.expandState);
 
         if (get(expandState, treePath)) {
             unset(expandState, treePath);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xh/hoist",
-  "version": "55.2.1",
+  "version": "55.3.0",
   "description": "Hoist add-on for building and deploying React Applications.",
   "repository": "github:xh/hoist-react",
   "homepage": "https://xh.io",

package/svc/PrefService.ts

@@ -7,7 +7,7 @@
 import {HoistService, XH} from '@xh/hoist/core';
 import {SECONDS} from '@xh/hoist/utils/datetime';
 import {deepFreeze, throwIf} from '@xh/hoist/utils/js';
-import {cloneDeep, debounce, forEach, isEmpty, isEqual, isNil, pickBy} from 'lodash';
+import {debounce, forEach, isEmpty, isEqual, isNil, pickBy} from 'lodash';
 
 /**
  * Service to read and set user-specific preference values.
@@ -92,7 +92,7 @@ export class PrefService extends HoistService {
         if (isEqual(oldValue, value)) return;
 
         // Change local value to sanitized copy and fire.
-        value = deepFreeze(cloneDeep(value));
+        value = deepFreeze(structuredClone(value));
         this._data[key].value = value;
 
         // Schedule serialization to storage
@@ -198,7 +198,7 @@ export class PrefService extends HoistService {
         for (let key in data) {
             if (data[key].local) {
                 data[key].value = !isNil(localPrefs[key]) ?
-                    deepFreeze(cloneDeep(localPrefs[key])) :
+                    deepFreeze(structuredClone(localPrefs[key])) :
                     data[key].defaultValue;
             }
         }