@xevy/skills 0.1.60 → 0.1.62
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
"name": "xevy",
|
|
3
3
|
"displayName": "Xevy",
|
|
4
4
|
"description": "Native /xevy:* SDLC workflow commands driven through the Xevy MCP server. Analyze, plan, execute, fix, and move-to-qa run locally by default and accept --cloud for the server Web Agent. Merge stays local; merge-pull-request evaluates and lands the remote PR.",
|
|
5
|
-
"version": "0.1.
|
|
5
|
+
"version": "0.1.62",
|
|
6
6
|
"author": {
|
|
7
7
|
"name": "Xevy"
|
|
8
8
|
},
|
package/README.md
CHANGED
|
@@ -117,6 +117,7 @@ with `codex mcp add`.
|
|
|
117
117
|
| `fix [task] [--cloud]` | Rework after review (local by default) |
|
|
118
118
|
| `merge [task]` | Merge a task branch locally for review; leaves remotes and pull requests unchanged |
|
|
119
119
|
| `merge-pull-request [URL\|number\|branch]` | Evaluate a PR, repair conflicts, handle blockers, and merge it remotely |
|
|
120
|
+
| `review-pull-request [URL\|number\|branch]` | Read-only PR review with evidence-based merge safety verdicts |
|
|
120
121
|
| `move-to-qa [task] [--cloud]` | QA handoff (local by default) |
|
|
121
122
|
| `move-to-verified [task]` | Record explicit QA approval and move an eligible task from For QA to Verified |
|
|
122
123
|
| `deploy` | Coolify preview/main |
|
|
@@ -137,7 +138,7 @@ Use generate-guide to make docs/guides/customer-form/manual.md with screenshots
|
|
|
137
138
|
|
|
138
139
|
Computer works across desktop and browser apps and projects. Windows uses the signed-in desktop; macOS 14+ requires native Screen Recording and Accessibility consent. The guide workflow stays in the active engine, respects blocks and human take-over, and identifies incomplete verification or publication. Execute/fix use it for UI journeys when an authorized test environment is available.
|
|
139
140
|
|
|
140
|
-
The package version is `0.1.
|
|
141
|
+
The package version is `0.1.62`. Run `npx @xevy/skills update -y` after that version is published.
|
|
141
142
|
|
|
142
143
|
## Security
|
|
143
144
|
|
package/package.json
CHANGED
|
@@ -0,0 +1,62 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: review-pull-request
|
|
3
|
+
description: Read-only review of a GitHub pull request for merge conflicts, code defects, verification failures, and coverage of a linked Xevy task's requirements. Use when asked to review, assess, or check a PR before merge; do not merge or change the PR.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Review a pull request
|
|
7
|
+
|
|
8
|
+
Review the exact PR and report evidence-based findings. This skill is **read-only**: do not edit source files, resolve conflicts, push, post a GitHub review/comment, merge, deploy, or change Xevy records unless the user separately requests and authorizes that action under its own workflow.
|
|
9
|
+
|
|
10
|
+
## 1. Identify the PR and working directory
|
|
11
|
+
|
|
12
|
+
- Accept a PR URL, number, or branch. If omitted, use the current branch's PR only when exactly one open PR matches; otherwise ask which PR.
|
|
13
|
+
- Identify the repository from the PR URL/metadata; do not ask the user to select a project directory or worktree when the PR uniquely identifies them. Ask only if repository identity is ambiguous or inaccessible.
|
|
14
|
+
- Review the PR's remote source and target branches, pinning their actual SHAs and merge-base. For required local verification, automatically locate an existing Git worktree where the PR source branch is checked out. Use that worktree only if it belongs to this PR/source branch and is safe to use; do not disrupt unrelated changes or another active task. If no suitable worktree exists, create a dedicated worktree for the PR source branch and record its path. Never ask the user which worktree to use. Do not switch branches in an existing checkout.
|
|
15
|
+
- Read the applicable `AGENTS.md` / `AGENTS.override.md` chain from the selected worktree. Keep review actions non-mutating: do not edit tracked files, commit, push, post comments, or merge. Fetch/update remote refs as needed without altering another checkout. If the PR source branch is not available locally, fetch it and create the worktree at the exact reviewed head SHA; ensure the worktree represents the PR head, not a stale local branch.
|
|
16
|
+
- Testing is required. In the PR source worktree, run the repository's relevant focused tests and applicable lint, type-check, and build checks when feasible; include regression tests for suspected issues where practical. Avoid exposing secrets and do not run destructive commands. If dependencies, credentials, environment, or infrastructure prevent a check, report the exact limitation and mark that verification unverified; do not imply tests passed or issue an unqualified safe-to-merge verdict. Preserve pre-existing worktree changes and do not clean/reset them.
|
|
17
|
+
- Check whether this session is locked to a different task; do not switch its scope without the user's explicit approval under the session-lock rules.
|
|
18
|
+
- For a remote Dev Session, use `read_dev_session_pull_request` with the linked repository ID and PR number to read authenticated PR evidence; select the `dev_session` capability group if needed. Outside a session, use `code_pull_request` with the project and linked repository. Read `metadata`, then paginate `files`, `commits`, `reviews`, and `checks` until `nextPage` is null; inspect `diff` and every `truncated` flag. Use the returned top-level `headSha` and `baseSha` for current commit identity; `data.base.sha` retains GitHub's recorded PR base and can differ from the current target. Treat truncated or unavailable evidence as incomplete. Credentials stay in the toolbox; these tools require no `gh` login or token in the agent shell. If access is expired, ask the GitHub connection owner to reconnect and retry.
|
|
19
|
+
- For local verification in a remote Dev Session, use `prepare_dev_session_pull_request_review` with that repository ID and PR number. It fetches the exact PR head and current target into a fresh detached checkout and returns `dir`, `headSha`, `baseSha`, and `mergeBaseSha`. Run inspection and tests in `/workspace/<dir>`; preserve the original session checkout. The PR target comes from GitHub metadata and can differ from the session's configured base. Follow the returned evidence and report any incomplete fetch or history.
|
|
20
|
+
- On a local checkout outside a remote Dev Session, verify `gh` authentication before using it. Verify the checkout's repository identity and that the PR belongs to that repository. Read the PR URL, number, state, draft status, head/base repositories and branches, head SHA, review status, mergeability, checks, commits, and changed files. Stop if missing, closed, or already merged.
|
|
21
|
+
|
|
22
|
+
## 2. Establish task intent (when linked)
|
|
23
|
+
|
|
24
|
+
- Look for an explicit Xevy task code/link in the PR title, body, branch, or project metadata. Do not assume a coincidental code is a link; ask if ambiguous.
|
|
25
|
+
- Resolve the linked task by code and read its original requirements plus relevant Analysis, specs, subtasks, decisions, and QA/review notes as needed. Check open decisions before task-based review; surface unresolved decisions rather than inventing expected behavior.
|
|
26
|
+
- Inspect the full commit history contributing to the PR, not only the final diff or latest commit. Review commit messages, per-commit diffs, and relevant earlier versions to understand intent, identify inherited/unrelated work, and distinguish deliberate changes from regressions or accidental omissions. Compare the PR head to its current base for the final behavior; history provides intent/context and does not excuse a defect in the final state.
|
|
27
|
+
- Check for multiple tasks in the PR title/body, branch, every commit message, and changed scope, including inherited commits. Deduplicate aliases that reference the same task (for example a Xevy code and its external tracker code); multiple identifiers alone do not prove multiple tasks. Distinguish intentionally included work from historical references or dependencies. Resolve identifiable additional Xevy tasks with targeted reads and check their status, remaining requirements, and relevance to the intended task. Do not assume a task is complete from its status alone or incomplete solely because it is not done.
|
|
28
|
+
- If no task is linked, review against the PR's stated objective and repository conventions. State that task-requirement coverage could not be assessed.
|
|
29
|
+
|
|
30
|
+
## 3. Inspect mergeability and implementation
|
|
31
|
+
|
|
32
|
+
- Fetch current remote base and head refs without altering the checked-out branch. Pin and report both **actual fetched commit SHAs**, the merge-base SHA, and the diff range used; do not substitute the PR's original/recorded base for its current target. If the base moves, reassess the resulting diff and mergeability before concluding. In the prepared checkout, use `git diff <mergeBaseSha> <headSha>` as the authoritative current comparison. GitHub's files, commits, and diff sections describe its PR view and can reflect the recorded base; use the pinned current target for the merge simulation below.
|
|
33
|
+
- Enumerate every changed file and affected user flow before judging any finding. Inspect the complete PR diff, relevant callers, tests, interfaces, migrations, configuration, and affected workflows. Maintain a coverage ledger for each changed file/flow: reviewed logic, relevant tests, and any uninspected region with its reason. Do not stop review after finding the first blocker or an apparent fix; finish the full inventory.
|
|
34
|
+
- For each changed decision path, trace inputs through selection, filtering, aggregation, attribution, presentation, and export. Check positive/negative cases, multiple candidate records, ordering, unrelated-but-plausible records, missing/partial data, authorization, and state changes where applicable. Check that a predicate used to justify an outcome belongs to the *same record* named in the outcome. Mark irrelevant cases not applicable rather than skipping the checklist silently.
|
|
35
|
+
- Check GitHub's `mergeable` / `mergeStateStatus` and required checks. If GitHub reports `UNKNOWN`, re-query when feasible; distinguish unknown from a confirmed conflict.
|
|
36
|
+
- Use a non-mutating merge simulation (for example, `git merge-tree` with the exact fetched refs) to detect textual conflicts. Do **not** merge the base into the head or resolve conflicts during review. Report conflicting paths and whether GitHub agrees; distinguish textual conflicts from blocked checks or branch protection.
|
|
37
|
+
- Evaluate correctness, security, permissions, error handling, data integrity, compatibility, accessibility (for UI), edge cases, and regression risk. For linked tasks, map each acceptance expectation to actual code or test evidence; identify missing or contradictory behavior.
|
|
38
|
+
- Investigate each suspected issue before reporting it: first establish intended behavior from the linked task and acceptance criteria, explicit decisions, PR description, design/spec documentation, and established surrounding behavior; then trace reachable callers, affected users/data, triggering conditions, existing guards, and consequences if left unfixed. Use a safe reproduction or test where feasible. Do not call an intentional change or omission a defect merely because a control, feature, behavior, or test is absent compared with the base branch. For example, a removed button is not a finding if its removal is required or explicitly intended. Report only behavior that conflicts with established intent or is an unintended consequence of the change as a confirmed finding. If intent is ambiguous or cannot be resolved, put it under **Warnings / Questions** with the missing evidence and potential impact; do not state it as a defect or release blocker. Classify each confirmed issue as **Release blocker** or **Non-blocking** independently of severity. A release blocker prevents a required flow, violates a critical task requirement, causes materially incorrect decisions, or creates significant security, data-integrity, or operational risk. Explain the concrete unfixed consequence; do not infer blocker status from severity alone. If reachability or impact cannot be established, report it under Questions/Risks with blocker status unverified, not as a confirmed blocker.
|
|
39
|
+
- Identify risky changes even when no defect is confirmed: destructive/bulk data operations; auth and permissions; financial or business-decision logic; API/integration contracts; jobs, retries and concurrency; deployment/configuration/dependencies; critical UI actions; broad refactors or unrelated/inherited scope. Assess affected users/data, reversibility, compatibility, test coverage, and recovery safeguards. Do not treat a risk category alone as a defect or release blocker; escalate only when evidence supports an unsafe condition, and mark material unresolved safety questions unverified.
|
|
40
|
+
- Build a risk-based test matrix from every changed behavior: expected outcome, counterexample, overlapping/multiple records, ordering, and relevant boundary conditions. Identify what was exercised by local tests or CI, what was assessed only by code inspection, and what remains unverified. Prioritize tests for high-impact paths over indiscriminate test runs. A passing test suite does not replace tracing untested combinations.
|
|
41
|
+
- On a repeat review, obtain the previous review report (ask the user for it if not accessible) and record its reviewed head/base SHAs, findings, coverage ledger, and unverified items. Recheck every previous finding and all changed lines since the earlier head, **then repeat the full changed-file and affected-flow inventory**; do not limit review to the fix diff. Attribute each new finding as: introduced by subsequent changes, exposed by a base change, or pre-existing but missed previously. Compare relevant blame/diffs and state uncertainty when origin cannot be established; never imply a newly reported issue was introduced by the fix without evidence.
|
|
42
|
+
- Run relevant tests, lint, type-check, and build checks only where safe in the permitted working directory; avoid commands that rewrite tracked files or require secrets. If not run, explain why. Separate PR-introduced failures from baseline/infrastructure failures where evidence supports it. Never claim there are no code issues solely because CI is green.
|
|
43
|
+
- Immediately before the verdict, re-read the PR's head and base SHAs. If either changed during review, refresh affected diff, mergeability, checks, and verification or mark the verdict stale/inconclusive; never present an earlier SHA's results as current.
|
|
44
|
+
|
|
45
|
+
## 4. Deliver a verdict
|
|
46
|
+
|
|
47
|
+
- Use plain-text headings and numbered or bulleted lists only; **never use Markdown tables**. Keep the developer-facing response short, actionable, and easy to copy and paste. Do the full review and maintain internal ledgers, but do not print exhaustive inventories or checklists unless requested. Avoid repeating evidence across sections.
|
|
48
|
+
- At response time, obtain the actual current datetime from the system clock and convert it to **GMT+8** (UTC+08:00), for example with `TZ=Etc/GMT-8 date --iso-8601=seconds`; do not guess it. Immediately after the opening merge indicator, include **Reviewed at:** with an ISO 8601 datetime ending in `+08:00`. If the clock cannot be read, explicitly state that the timestamp is unavailable.
|
|
49
|
+
- Start with exactly one explicit merge indicator, then the linked task code immediately before the PR URL, followed by a brief reason and the reviewed head/base SHAs. Format: `**<MERGE INDICATOR>** — <TASK-CODE> — <PR-URL>`. If multiple distinct tasks are linked, list their codes comma-separated before the PR URL. If no task is resolved, use `NO LINKED TASK` before the PR URL:
|
|
50
|
+
- **NOT SAFE TO MERGE** — a confirmed release blocker, conflict, failed required check, draft status, or unmet review/branch-protection gate remains. Distinguish code-safety blockers from procedural merge gates in the reason. This takes precedence over unverified checks; still report verification gaps.
|
|
51
|
+
- **SAFE TO MERGE WITH NON-BLOCKING ISSUES** — full changed scope reviewed, no confirmed blockers or unresolved material safety questions, no conflicts, required checks passed and merge gates satisfied; only non-blocking findings remain.
|
|
52
|
+
- **SAFE TO MERGE** — the same verification and gate conditions are satisfied, with no outstanding findings in the reviewed scope. This is a scoped recommendation, not a guarantee of defect-free code.
|
|
53
|
+
- **MERGE SAFETY UNVERIFIED** — no confirmed blocker is established, but missing evidence, checks, incomplete scope, or stale SHAs prevent a supported safe verdict.
|
|
54
|
+
- Do not use a generic Ready/Changes requested verdict instead of the explicit merge indicator. A clean GitHub mergeability status alone never establishes merge safety.
|
|
55
|
+
- For each confirmed finding, use one compact numbered bullet: severity, **Release blocker / Non-blocking**, file:line, investigated failure scenario, and smallest practical fix. Add a short explicitly labeled **If not fixed:** sentence to every issue, explaining the concrete user/business/system consequence and triggering conditions in plain language. Do not merely repeat the severity or say “may cause issues”; do not exaggerate uncertain impact. Also include **Error if not fixed: Yes / No / Unverified** for every issue, based on investigation. “Yes” means a demonstrated or code-established crash, exception, failed request, build/test failure, or visible error under stated triggering conditions; specify the error and trigger. “No” means no such error is expected in the investigated scenario, but explicitly describe any silent incorrect behavior or other consequence; it does not mean safe to merge. “Unverified” means evidence cannot establish whether an error occurs; state what verification is missing. Keep error occurrence separate from severity and release-blocker status. For Questions/Risks, also include **If not fixed:** with the potential consequence clearly qualified and state what evidence is missing. If a line reference is unavailable, explain why briefly. Put uncertain concerns in **Questions/Risks**, not confirmed findings. Summarize conflict status, CI/local checks, and review/branch-protection blockers once. Complete the full review before publishing findings.
|
|
56
|
+
- If multiple distinct tasks contribute changes to the PR, include **WARNING — Multiple tasks in this PR**, listing their identifiers, completion/verification status, and whether their inclusion is approved and necessary for the intended task. Explain briefly that unrelated or unfinished work would merge together. If additional work is suspected but task linkage cannot be established, label it suspected and state the missing evidence. Ask for clarification when scope approval is ambiguous; do not invent approval. Treat confirmed critical scope violations or unsafe unfinished behavior as blockers, and material unresolved scope/safety questions as unverified—not every multi-task PR as automatically unsafe.
|
|
57
|
+
- Include a short **Warnings / Questions** section when needed for intentional changes that may surprise reviewers, ambiguous intent, suspected risks, multiple-task scope, or material unverified behavior. Explain what is observed, why it may matter, and what intent/evidence needs confirmation. Do not list intended behavior as a finding; when intent is confirmed, describe it only as an informational warning if it is useful to alert reviewers. Keep warnings separate from confirmed defects and blockers. Reflect unresolved material safety questions in the merge indicator. Omit the section when there is nothing material to flag.
|
|
58
|
+
- On repeat reviews, provide a finding ledger: each prior finding marked fixed/still present/unverified, plus each new finding's evidenced origin (fix change, base change, pre-existing miss, or unknown). Explicitly acknowledge a pre-existing miss rather than calling it a regression. Compare coverage gaps with the earlier report.
|
|
59
|
+
- Summarize verification in 1–3 bullets: what passed, material unverified flows, and access limitations. Keep the complete risk-based test matrix and every affected file/flow in the internal coverage ledger; include detail in the response only for consequential gaps or on request. If the full changed scope cannot be reviewed, use **MERGE SAFETY UNVERIFIED** unless a confirmed blocker already requires **NOT SAFE TO MERGE**.
|
|
60
|
+
- When a task is linked, list requirements as concise bullets labeled met, partial, unmet, or unverified, each with evidence. Without a task, explicitly note that task coverage was not assessed.
|
|
61
|
+
- State limitations (missing credentials, unavailable checks, unrun tests, stale mergeability, uncertain task link). Say “no issues found in the reviewed scope,” not “no issues exist,” when appropriate.
|
|
62
|
+
- Do not merge or modify records as a consequence of a favorable verdict. Offer a separate follow-up if fixes or a merge are wanted.
|