@xeplr/actions 1.1.1 → 1.1.6

package/lib/builtins/db/fetch.js

@@ -33,9 +33,38 @@ module.exports = {
   requires: [],   // per-driver requires checked at runtime once dbType is known
 
   inputSchema: [
-    { name: 'dbType',         type: 'string',  required: true, default: 'postgres', order: 1,
-      description: 'postgres | mysql | mssql' },
-    { name: 'connection',     type: 'object',  required: true, order: 2,
+    // ── WHICH DATABASE ──────────────────────────────────────────────────
+    //
+    // Two routes in, and only one of them is fit for a UI.
+    //
+    // connectionInfoId + dbInfoId — pick a SAVED connection. The ids are all
+    // that is ever stored or sent to a browser; the host swaps them for real
+    // credentials server-side, immediately before this runs (see @xeplr/jobs'
+    // resolveInputs). dbType comes from the connection too, because the
+    // connection already knows what it is.
+    //
+    // connection + dbType — pass the login literally. Kept because this
+    // package must work with no host at all: a script, a test, a standalone
+    // worker. NOT for the job editor — a job's inputs are fetched by the
+    // browser on every list load and snapshotted into every occurrence row,
+    // so a password there is a password everywhere, forever.
+    { name: 'connectionInfoId', type: 'string', order: 1,
+      optionsFrom: 'connections',
+      description: 'A saved connection. Resolved to credentials server-side.' },
+    { name: 'dbInfoId',         type: 'string', order: 2,
+      optionsFrom: 'databases', dependsOn: 'connectionInfoId',
+      description: 'Which database on that connection.' },
+
+    // Filled by the host from the two ids above, or supplied literally by a
+    // caller with no host. `system` keeps them out of the form either way —
+    // they must stay DECLARED, because @xeplr/schema-handler drops any field
+    // a schema does not mention, which would strip the resolved connection on
+    // its way to execute().
+    { name: 'dbType',         type: 'string',  required: true, default: 'postgres', order: 3,
+      system: true, options: ['postgres', 'mysql', 'mssql'],
+      description: 'Taken from the connection when one is chosen.' },
+    { name: 'connection',     type: 'object',  required: true, order: 4,
+      system: true,
       description: 'Connection config: { host, port, user, password, database }' },
     { name: 'mode',           type: 'string',  default: 'table', order: 3,
       description: '"table" (SELECT * FROM input.table) or "query" (raw input.sql)' },
@@ -45,9 +74,9 @@ module.exports = {
       description: 'Raw SQL to stream (mode="query").' },
     { name: 'params',         type: 'array',   order: 6,
       description: 'Bind params for mode="query".' },
-    { name: 'streaming_mode', type: 'boolean', default: true, order: 7,
+    { name: 'streaming_mode', type: 'boolean', default: true, order: 7, group: 'Performance',
       description: 'Default TRUE → spool to NDJSON file. false → inline output.rows (small reads only).' },
-    { name: 'batchSize',      type: 'number',  default: 1000, order: 8,
+    { name: 'batchSize',      type: 'number',  default: 1000, order: 8, group: 'Performance',
       description: 'Rows pulled per cursor round-trip / stream highWaterMark.' }
   ],