@xeokit/xeokit-sdk 2.6.93 → 2.6.94

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xeokit/xeokit-sdk",
-  "version": "2.6.93",
+  "version": "2.6.94",
   "description": "3D BIM IFC Viewer SDK for AEC engineering applications. Open Source JavaScript Toolkit based on pure WebGL for top performance, real-world coordinates and full double precision",
   "module": "./dist/xeokit-sdk.es.js",
   "main": "./dist/xeokit-sdk.cjs.js",

package/src/viewer/scene/lights/DirLight.js

@@ -111,7 +111,7 @@ class DirLight extends Light {
      * @param {Number[]} [cfg.dir=[1.0, 1.0, 1.0]]  A unit vector indicating the direction that the light is shining,  given in either World or View space, depending on the value of the ````space```` parameter.
      * @param {Number[]} [cfg.color=[0.7, 0.7, 0.8 ]] The color of this DirLight.
      * @param {Number} [cfg.intensity=1.0] The intensity of this DirLight, as a factor in range ````[0..1]````.
-     * @param {String} [cfg.space="view"] The coordinate system the DirLight is defined in - ````"view"```` or ````"space"````.
+     * @param {String} [cfg.space="view"] The coordinate system the DirLight is defined in - ````"view"```` or ````"world"````.
      * @param {Boolean} [cfg.castsShadow=false] Flag which indicates if this DirLight casts a castsShadow.
      */
     constructor(owner, cfg = {}) {

package/src/viewer/scene/mesh/draw/DrawShaderSource.js

@@ -345,7 +345,7 @@ export const DrawShaderSource = function(meshDrawHash, programVariables, geometr
                             src.push("shadow /= 9.0;");
                         }
                         src.push(`vec3 lightColor${i} = ${light.getColor()}${light.shadowParameters ? (" * " + "shadow") : ""};`);
-                        src.push(`vec3 lightDirection${i} = ${light.isWorldSpace ? vDirectionals[i].vViewLightReverseDir : light.getDirection(null, vViewPosition)};`);
+                        src.push(`vec3 lightDirection${i} = ${light.isViewSpace ? light.getDirection(null, vViewPosition) : vDirectionals[i].vViewLightReverseDir};`);
                         const dotNL = `${saturate}(dot(viewNormal, lightDirection${i}))`;
                         src.push(`vec3 irradiance${i} = ${dotNL} * lightColor${i};`);
                         src.push(`reflDiff += irradiance${i};`);

package/src/viewer/scene/scene/Scene.js

@@ -2655,7 +2655,7 @@ class Scene extends Component {
      *
      * @param {String[]} ids Array of {@link Entity#id} values.
      * @param {Number[]} [colorize=(1,1,1)] RGB colorize factors, multiplied by the rendered pixel colors.
-     * @returns {Boolean} True if any {@link Entity}s changed opacity, else false if all updates were redundant and not applied.
+     * @returns {Boolean} True if any {@link Entity}s were colorized, else false if all updates were redundant and not applied.
      */
     setObjectsColorized(ids, colorize) {
         return this.withObjects(ids, entity => {

package/src/viewer/scene/webgl/WebGLRenderer.js

@@ -442,7 +442,7 @@ export const createLightSetup = function(programVariables, lightsState) {
         const withViewLightDir = getDirection => {
             return {
                 glslLight: {
-                    isWorldSpace: light.space === "world",
+                    isViewSpace: light.space === "view",
                     getColor: () => `${lightUniforms.color}.rgb * ${lightUniforms.color}.a`,
                     getDirection: (viewMatrix, viewPosition) => `normalize(${getDirection(viewMatrix, viewPosition)})`,
                     shadowParameters: light.castsShadow && {