@xenonbyte/da-vinci-workflow 0.1.24 → 0.1.26

package/scripts/test-audit-design-supervisor.js

@@ -1,537 +0,0 @@
-const assert = require("assert/strict");
-const fs = require("fs");
-const os = require("os");
-const path = require("path");
-const { spawnSync } = require("child_process");
-
-const { auditProject } = require("../lib/audit");
-
-const repo = path.resolve(__dirname, "..");
-const cli = path.join(repo, "bin", "da-vinci.js");
-const fixture = JSON.parse(
-  fs.readFileSync(path.join(__dirname, "fixtures", "complex-sample.pen"), "utf8")
-);
-const changeId = "redesign-001";
-
-function runTest(name, fn) {
-  try {
-    fn();
-    console.log(`PASS ${name}`);
-  } catch (error) {
-    console.error(`FAIL ${name}`);
-    throw error;
-  }
-}
-
-function createHarness() {
-  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-audit-supervisor-"));
-  return {
-    base,
-    home: path.join(base, "home")
-  };
-}
-
-function runCli(harness, args) {
-  const [command, ...rest] = args;
-  const result = spawnSync(process.execPath, [cli, command, "--home", harness.home, ...rest], {
-    cwd: repo,
-    encoding: "utf8",
-    maxBuffer: 8 * 1024 * 1024
-  });
-
-  return {
-    code: result.status,
-    stdout: (result.stdout || "").trim(),
-    stderr: (result.stderr || "").trim()
-  };
-}
-
-function expectOk(step, result) {
-  assert.equal(result.code, 0, `${step} failed:\n${result.stderr || result.stdout}`);
-}
-
-function writeJson(filePath, payload) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, JSON.stringify(payload, null, 2));
-}
-
-function writeText(filePath, text) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, text);
-}
-
-function setupProject(harness, name, options = {}) {
-  const root = path.join(harness.base, name);
-  const daVinciDir = path.join(root, ".da-vinci");
-  const changeDir = path.join(daVinciDir, "changes", changeId);
-  const penPath = path.join(daVinciDir, "designs", `${name}.pen`);
-  const nodesFile = path.join(root, `${name}-nodes.json`);
-  const variablesFile = path.join(root, `${name}-variables.json`);
-  const configureReviewers = options.configureReviewers !== false;
-  const requireSupervisorReview = options.requireSupervisorReview === true;
-
-  const visualAssistLines = [
-    "# DA-VINCI",
-    "",
-    "## Visual Assist",
-    "- Preferred adapters:",
-    "  - frontend-skill"
-  ];
-
-  if (configureReviewers) {
-    visualAssistLines.push("- Design-supervisor reviewers:");
-    visualAssistLines.push("  - frontend-skill");
-    visualAssistLines.push("- Design-supervisor review mode:");
-    visualAssistLines.push("  - screenshot-and-theme");
-    visualAssistLines.push("- Design-supervisor review inputs:");
-    visualAssistLines.push("  - screenshots");
-    visualAssistLines.push("  - pencil variables");
-  }
-
-  visualAssistLines.push("- Require Supervisor Review:");
-  visualAssistLines.push(`  - ${requireSupervisorReview ? "true" : "false"}`);
-  visualAssistLines.push("");
-
-  writeText(
-    path.join(root, "DA-VINCI.md"),
-    visualAssistLines.join("\n")
-  );
-  writeText(path.join(daVinciDir, "project-inventory.md"), "# Inventory\n");
-  writeText(path.join(daVinciDir, "page-map.md"), "# Page Map\n");
-  writeText(
-    path.join(daVinciDir, "design-registry.md"),
-    `# Registry\n- Preferred .pen: .da-vinci/designs/${name}.pen\n`
-  );
-  writeText(path.join(changeDir, "design-brief.md"), "# Brief\n");
-  writeText(path.join(changeDir, "design.md"), "# Design\n");
-  writeText(path.join(changeDir, "pencil-bindings.md"), "# Bindings\n");
-
-  writeJson(nodesFile, { nodes: fixture.children });
-  writeJson(variablesFile, { variables: fixture.variables });
-
-  expectOk(
-    `${name} begin`,
-    runCli(harness, ["pencil-session", "begin", "--project", root, "--pen", penPath])
-  );
-  expectOk(
-    `${name} persist`,
-    runCli(harness, [
-      "pencil-session",
-      "persist",
-      "--project",
-      root,
-      "--pen",
-      penPath,
-      "--nodes-file",
-      nodesFile,
-      "--variables-file",
-      variablesFile,
-      "--version",
-      fixture.version
-    ])
-  );
-  expectOk(
-    `${name} end`,
-    runCli(harness, [
-      "pencil-session",
-      "end",
-      "--project",
-      root,
-      "--pen",
-      penPath,
-      "--nodes-file",
-      nodesFile,
-      "--variables-file",
-      variablesFile,
-      "--version",
-      fixture.version
-    ])
-  );
-
-  return {
-    root,
-    changeDir,
-    pencilDesignPath: path.join(changeDir, "pencil-design.md")
-  };
-}
-
-runTest("completion audit warns when supervisor reviewers are configured but not required and no review is recorded", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "missing-supervisor-review");
-
-  writeText(project.pencilDesignPath, "# Pencil Design\n");
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "WARN");
-  assert.match(
-    result.warnings.join("\n"),
-    /Design-supervisor reviewers.*does not record a `## Design-Supervisor Review` section/i
-  );
-});
-
-runTest("completion audit fails when supervisor review is required but no review is recorded", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "required-supervisor-review", {
-    requireSupervisorReview: true
-  });
-
-  writeText(project.pencilDesignPath, "# Pencil Design\n");
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /Design-supervisor reviewers.*does not record a `## Design-Supervisor Review` section/i
-  );
-});
-
-runTest("completion audit fails when supervisor review is required but no reviewers are configured", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "missing-supervisor-reviewers", {
-    configureReviewers: false,
-    requireSupervisorReview: true
-  });
-
-  writeText(project.pencilDesignPath, "# Pencil Design\n");
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /Require Supervisor Review: true.*no `Design-supervisor reviewers` are configured/i
-  );
-});
-
-runTest("completion audit does not treat an empty reviewers field as configured", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "empty-supervisor-reviewers", {
-    configureReviewers: false,
-    requireSupervisorReview: false
-  });
-
-  writeText(
-    path.join(project.root, "DA-VINCI.md"),
-    [
-      "# DA-VINCI",
-      "",
-      "## Visual Assist",
-      "- Preferred adapters:",
-      "  - frontend-skill",
-      "- Design-supervisor reviewers:",
-      "- Design-supervisor review mode:",
-      "  - screenshot-and-theme",
-      "- Design-supervisor review inputs:",
-      "  - screenshots",
-      "  - pencil variables",
-      "- Require Supervisor Review:",
-      "  - false",
-      ""
-    ].join("\n")
-  );
-  writeText(project.pencilDesignPath, "# Pencil Design\n");
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "PASS");
-  assert.doesNotMatch(
-    result.warnings.join("\n"),
-    /Design-supervisor reviewers.*does not record a `## Design-Supervisor Review` section/i
-  );
-});
-
-runTest("integrity audit warns when supervisor review is required but no review is recorded", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "warn-supervisor-review", {
-    requireSupervisorReview: true
-  });
-
-  writeText(project.pencilDesignPath, "# Pencil Design\n");
-
-  const result = auditProject(project.root, {
-    mode: "integrity"
-  });
-
-  assert.equal(result.status, "WARN");
-  assert.match(
-    result.warnings.join("\n"),
-    /Design-supervisor reviewers.*does not record a `## Design-Supervisor Review` section/i
-  );
-});
-
-runTest("completion audit fails when required supervisor review is missing Issue list or Revision outcome", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "malformed-supervisor-review", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Review mode: screenshot-and-theme",
-      "- Review inputs: screenshots, pencil variables",
-      "- Status: PASS",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /missing required field\(s\): Issue list and Revision outcome/i
-  );
-});
-
-runTest("completion audit passes when required supervisor review is recorded as PASS", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "pass-supervisor-review", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Executed reviewers: frontend-skill",
-      "- Review source: skill",
-      "- Review mode: screenshot-and-theme",
-      "- Review inputs: screenshots, pencil variables, visual thesis, content plan, interaction thesis",
-      "- Status: PASS",
-      "- Issue list: none",
-      "- Revision outcome: approved",
-      "- Broad expansion approved: yes",
-      "- Implementation-task handoff approved: yes",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(
-    result.status,
-    "PASS",
-    `expected completion audit to pass:\n${JSON.stringify(result, null, 2)}`
-  );
-  assert.match(
-    result.notes.join("\n"),
-    /Detected design-supervisor review status PASS/i
-  );
-});
-
-runTest("completion audit accepts the latest round section when multiple Design-Supervisor Review headings exist", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "latest-supervisor-round-wins", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Executed reviewers: frontend-skill",
-      "- Review source: skill",
-      "- Status: BLOCK",
-      "- Issue list: command not found",
-      "- Revision outcome: blocked",
-      "",
-      "## Design-Supervisor Review (Round 2 Attempt)",
-      "- Configured reviewers: frontend-skill",
-      "- Executed reviewers: frontend-skill",
-      "- Review source: skill",
-      "- Status: PASS",
-      "- Issue list: none",
-      "- Revision outcome: accepted",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(
-    result.status,
-    "PASS",
-    `expected completion audit to use latest review section:\n${JSON.stringify(result, null, 2)}`
-  );
-  assert.match(
-    result.notes.join("\n"),
-    /Detected design-supervisor review status PASS/i
-  );
-});
-
-runTest("completion audit accepts multiline Issue list and Revision outcome fields", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "multiline-supervisor-fields", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Executed reviewers: frontend-skill",
-      "- Review source: skill",
-      "- Status: WARN",
-      "- Issue list:",
-      "  - icon alignment drift on top bar",
-      "  - hierarchy contrast needs one more pass",
-      "- Revision outcome:",
-      "  - accepted with follow-up in next visual pass",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(
-    result.status,
-    "PASS",
-    `expected accepted WARN with multiline fields to pass:\n${JSON.stringify(result, null, 2)}`
-  );
-  assert.match(
-    result.notes.join("\n"),
-    /Detected design-supervisor review status WARN/i
-  );
-});
-
-runTest("completion audit fails when required supervisor review is not skill-backed", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "required-supervisor-skill-source", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Review source: inferred",
-      "- Status: PASS",
-      "- Issue list: none",
-      "- Revision outcome: approved",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /must be skill-backed.*Require Supervisor Review: true/i
-  );
-});
-
-runTest("completion audit fails when required supervisor review omits executed reviewers", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "required-supervisor-executed-missing", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Review source: skill",
-      "- Status: PASS",
-      "- Issue list: none",
-      "- Revision outcome: approved",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /missing required field\(s\): Executed reviewers/i
-  );
-});
-
-runTest("completion audit fails when required supervisor review did not execute all configured reviewers", () => {
-  const harness = createHarness();
-  const project = setupProject(harness, "required-supervisor-executed-incomplete", {
-    requireSupervisorReview: true
-  });
-
-  writeText(
-    project.pencilDesignPath,
-    [
-      "# Pencil Design",
-      "",
-      "## Design-Supervisor Review",
-      "- Configured reviewers: frontend-skill",
-      "- Executed reviewers: ui-ux-pro-max",
-      "- Review source: skill",
-      "- Status: PASS",
-      "- Issue list: none",
-      "- Revision outcome: approved",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "completion",
-    changeId
-  });
-
-  assert.equal(result.status, "FAIL");
-  assert.match(
-    result.failures.join("\n"),
-    /did not execute configured reviewer skill\(s\): frontend-skill/i
-  );
-});
-
-console.log("All design-supervisor audit tests passed.");

package/scripts/test-audit-safety.js

@@ -1,92 +0,0 @@
-const assert = require("assert/strict");
-const fs = require("fs");
-const os = require("os");
-const path = require("path");
-
-const { auditProject } = require("../lib/audit");
-
-function runTest(name, fn) {
-  try {
-    fn();
-    console.log(`PASS ${name}`);
-  } catch (error) {
-    console.error(`FAIL ${name}`);
-    throw error;
-  }
-}
-
-function writeText(filePath, text) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, text);
-}
-
-function setupProject(name) {
-  const root = fs.mkdtempSync(path.join(os.tmpdir(), `da-vinci-audit-safety-${name}-`));
-  const daVinciDir = path.join(root, ".da-vinci");
-  const designsDir = path.join(daVinciDir, "designs");
-  const designRegistryPath = path.join(daVinciDir, "design-registry.md");
-
-  writeText(path.join(root, "DA-VINCI.md"), "# DA-VINCI\n");
-  writeText(path.join(daVinciDir, "project-inventory.md"), "# Inventory\n");
-  writeText(path.join(daVinciDir, "page-map.md"), "# Page Map\n");
-  fs.mkdirSync(designsDir, { recursive: true });
-
-  return {
-    root,
-    daVinciDir,
-    designsDir,
-    designRegistryPath
-  };
-}
-
-runTest("integrity audit warns when registry contains out-of-root .pen reference", () => {
-  const project = setupProject("escaped-registry");
-  writeText(path.join(project.designsDir, "main.pen"), "{}");
-  writeText(
-    project.designRegistryPath,
-    [
-      "# Registry",
-      "- Preferred .pen: .da-vinci/designs/main.pen",
-      "- Legacy .pen: .da-vinci/designs/../../../outside.pen",
-      ""
-    ].join("\n")
-  );
-
-  const result = auditProject(project.root, {
-    mode: "integrity"
-  });
-
-  assert.equal(result.failures.length, 0);
-  assert.match(result.warnings.join("\n"), /escapes project root and will be ignored/i);
-});
-
-runTest("integrity audit surfaces traversal truncation warnings on deep trees", () => {
-  const project = setupProject("truncated-scan");
-  writeText(path.join(project.designsDir, "main.pen"), "{}");
-  writeText(
-    project.designRegistryPath,
-    [
-      "# Registry",
-      "- Preferred .pen: .da-vinci/designs/main.pen",
-      ""
-    ].join("\n")
-  );
-
-  let current = project.designsDir;
-  for (let depth = 0; depth < 30; depth += 1) {
-    current = path.join(current, `deep-${depth}`);
-    fs.mkdirSync(current, { recursive: true });
-  }
-  writeText(path.join(current, "deep-tree.pen"), "{}");
-
-  const result = auditProject(project.root, {
-    mode: "integrity"
-  });
-
-  assert.match(
-    result.warnings.join("\n"),
-    /File scan truncated under \.da-vinci[\/\\]designs/i
-  );
-});
-
-console.log("All audit safety tests passed.");