@xenonbyte/da-vinci-workflow 0.1.23 → 0.1.24

package/scripts/test-supervisor-review-cli.js

@@ -0,0 +1,619 @@
+const assert = require("assert/strict");
+const fs = require("fs");
+const os = require("os");
+const path = require("path");
+const { spawnSync } = require("child_process");
+
+const repo = path.resolve(__dirname, "..");
+const daVinciBin = path.join(repo, "bin", "da-vinci.js");
+const designSupervisorBin = path.join(repo, "bin", "design-supervisor.js");
+const fixture = JSON.parse(
+  fs.readFileSync(path.join(__dirname, "fixtures", "complex-sample.pen"), "utf8")
+);
+
+function runTest(name, fn) {
+  try {
+    fn();
+    console.log(`PASS ${name}`);
+  } catch (error) {
+    console.error(`FAIL ${name}`);
+    throw error;
+  }
+}
+
+function runNodeScript(scriptPath, args, env = process.env) {
+  return spawnSync(process.execPath, [scriptPath, ...args], {
+    cwd: repo,
+    encoding: "utf8",
+    maxBuffer: 8 * 1024 * 1024,
+    env
+  });
+}
+
+function runDaVinci(args, options = {}) {
+  const finalArgs = Array.isArray(args) ? [...args] : [];
+  if (options.home && finalArgs.length > 0) {
+    finalArgs.splice(1, 0, "--home", options.home);
+  }
+  return runNodeScript(daVinciBin, finalArgs, options.env || process.env);
+}
+
+function writeText(filePath, text) {
+  fs.mkdirSync(path.dirname(filePath), { recursive: true });
+  fs.writeFileSync(filePath, text);
+}
+
+function writeJson(filePath, payload) {
+  fs.mkdirSync(path.dirname(filePath), { recursive: true });
+  fs.writeFileSync(filePath, JSON.stringify(payload, null, 2));
+}
+
+function writeDaVinci(root, reviewers = ["frontend-skill"]) {
+  writeText(
+    path.join(root, "DA-VINCI.md"),
+    [
+      "# DA-VINCI",
+      "",
+      "## Visual Assist",
+      "- Preferred adapters:",
+      "  - frontend-skill",
+      "- Design-supervisor reviewers:",
+      ...reviewers.map((reviewer) => `  - ${reviewer}`),
+      "- Require Supervisor Review:",
+      "  - true",
+      ""
+    ].join("\n")
+  );
+}
+
+runTest("design-supervisor alias writes a structured review section", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    "change-001",
+    "pencil-design.md"
+  );
+
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      "",
+      "## Context Delta",
+      "- time: 2026-03-29T12:00:00Z",
+      "- checkpoint_type: Design checkpoint",
+      "- decision: supervisor review closed with PASS",
+      "- status: PASS",
+      "- next_action: run completion audit",
+      ""
+    ].join("\n")
+  );
+  writeDaVinci(projectRoot);
+
+  const result = runNodeScript(designSupervisorBin, [
+    "review",
+    "--project",
+    projectRoot,
+    "--change",
+    "change-001",
+    "--status",
+    "PASS",
+    "--issue-list",
+    "none",
+    "--revision-outcome",
+    "approved",
+    "--write"
+  ]);
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const updated = fs.readFileSync(pencilDesignPath, "utf8");
+  assert.match(updated, /## Design-Supervisor Review \(CLI /);
+  assert.match(updated, /- Status: PASS/);
+  assert.match(updated, /- Issue list: none/);
+  assert.match(updated, /- Revision outcome: approved/);
+});
+
+runTest("design-supervisor alias supports review --help", () => {
+  const result = runNodeScript(designSupervisorBin, ["review", "--help"]);
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  assert.match(String(result.stdout || ""), /da-vinci supervisor-review/i);
+});
+
+runTest("da-vinci supervisor-review infers WARN from checkpoint state", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    "change-002",
+    "pencil-design.md"
+  );
+
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `WARN`",
+      ""
+    ].join("\n")
+  );
+  writeDaVinci(projectRoot);
+
+  const result = runNodeScript(daVinciBin, [
+    "supervisor-review",
+    "--project",
+    projectRoot,
+    "--change",
+    "change-002",
+    "--json"
+  ]);
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const payload = JSON.parse(String(result.stdout || "{}").trim());
+  assert.equal(payload.status, "WARN");
+  assert.match(payload.issueList, /Design checkpoint/i);
+  assert.equal(payload.source, "inferred");
+});
+
+runTest("da-vinci supervisor-review skill source auto-populates executed reviewers from config", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    "change-003",
+    "pencil-design.md"
+  );
+
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      "",
+      "## Context Delta",
+      "- time: 2026-03-29T12:00:00Z",
+      "- checkpoint_type: Design checkpoint",
+      "- decision: supervisor review closed with PASS",
+      "- status: PASS",
+      "- next_action: run completion audit",
+      ""
+    ].join("\n")
+  );
+  writeDaVinci(projectRoot, ["frontend-skill", "ui-ux-pro-max"]);
+
+  const result = runNodeScript(daVinciBin, [
+    "supervisor-review",
+    "--project",
+    projectRoot,
+    "--change",
+    "change-003",
+    "--source",
+    "skill",
+    "--status",
+    "PASS",
+    "--issue-list",
+    "none",
+    "--revision-outcome",
+    "approved",
+    "--json"
+  ]);
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const payload = JSON.parse(String(result.stdout || "{}").trim());
+  assert.equal(payload.source, "skill");
+  assert.deepEqual(payload.configuredReviewers, ["frontend-skill", "ui-ux-pro-max"]);
+  assert.deepEqual(payload.executedReviewers, ["frontend-skill", "ui-ux-pro-max"]);
+});
+
+runTest("da-vinci supervisor-review can auto-run configured reviewers via codex bridge", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    "change-004",
+    "pencil-design.md"
+  );
+  const exportsDir = path.join(projectRoot, ".da-vinci", "changes", "change-004", "exports");
+  fs.mkdirSync(exportsDir, { recursive: true });
+  fs.writeFileSync(path.join(exportsDir, "anchor.png"), "fake");
+  writeDaVinci(projectRoot, ["frontend-skill", "ui-ux-pro-max"]);
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      ""
+    ].join("\n")
+  );
+
+  const fakeCodexPath = path.join(base, "fake-codex.js");
+  writeText(
+    fakeCodexPath,
+    [
+      "#!/usr/bin/env node",
+      "const fs = require('fs');",
+      "const args = process.argv.slice(2);",
+      "const outputFlag = args.indexOf('--output-last-message');",
+      "if (outputFlag < 0) { process.exit(2); }",
+      "const outPath = args[outputFlag + 1];",
+      "const prompt = args[args.length - 1] || '';",
+      "const reviewer = /`([^`]+)`/.exec(prompt);",
+      "const reviewerName = reviewer ? reviewer[1] : 'unknown';",
+      "const payload = {",
+      "  status: 'PASS',",
+      "  issues: [],",
+      "  revision_outcome: `approved by ${reviewerName}`",
+      "};",
+      "fs.writeFileSync(outPath, JSON.stringify(payload));"
+    ].join("\n")
+  );
+  fs.chmodSync(fakeCodexPath, 0o755);
+
+  const result = runNodeScript(
+    daVinciBin,
+    [
+      "supervisor-review",
+      "--project",
+      projectRoot,
+      "--change",
+      "change-004",
+      "--run-reviewers",
+      "--codex-bin",
+      fakeCodexPath,
+      "--write",
+      "--json"
+    ],
+    {
+      ...process.env,
+      DA_VINCI_CODEX_BIN: fakeCodexPath
+    }
+  );
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const payload = JSON.parse(String(result.stdout || "{}").trim());
+  assert.equal(payload.source, "skill");
+  assert.deepEqual(payload.executedReviewers, ["frontend-skill", "ui-ux-pro-max"]);
+  assert.equal(payload.wrote, true);
+
+  const updated = fs.readFileSync(pencilDesignPath, "utf8");
+  assert.match(updated, /- Review source: skill/);
+  assert.match(updated, /- Executed reviewers: frontend-skill, ui-ux-pro-max/);
+});
+
+runTest("da-vinci supervisor-review retries transient reviewer failures", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const changeId = "change-004b";
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    changeId,
+    "pencil-design.md"
+  );
+
+  writeDaVinci(projectRoot, ["frontend-skill"]);
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      ""
+    ].join("\n")
+  );
+
+  const fakeCodexPath = path.join(base, "fake-codex-retry.js");
+  const statePath = path.join(base, "retry-state.json");
+  writeText(
+    fakeCodexPath,
+    [
+      "#!/usr/bin/env node",
+      "const fs = require('fs');",
+      "const args = process.argv.slice(2);",
+      "const outputFlag = args.indexOf('--output-last-message');",
+      "if (outputFlag < 0) { process.exit(2); }",
+      "const outPath = args[outputFlag + 1];",
+      "const statePath = process.env.DA_VINCI_FAKE_STATE;",
+      "let count = 0;",
+      "if (statePath && fs.existsSync(statePath)) {",
+      "  const payload = JSON.parse(fs.readFileSync(statePath, 'utf8'));",
+      "  count = Number(payload.count || 0);",
+      "}",
+      "count += 1;",
+      "if (statePath) {",
+      "  fs.writeFileSync(statePath, JSON.stringify({ count }));",
+      "}",
+      "if (count === 1) {",
+      "  console.error('transient failure');",
+      "  process.exit(1);",
+      "}",
+      "const payload = { status: 'PASS', issues: [], revision_outcome: 'approved' };",
+      "fs.writeFileSync(outPath, JSON.stringify(payload));"
+    ].join("\n")
+  );
+  fs.chmodSync(fakeCodexPath, 0o755);
+
+  const result = runNodeScript(
+    daVinciBin,
+    [
+      "supervisor-review",
+      "--project",
+      projectRoot,
+      "--change",
+      changeId,
+      "--run-reviewers",
+      "--review-retries",
+      "1",
+      "--review-retry-delay-ms",
+      "10",
+      "--codex-bin",
+      fakeCodexPath,
+      "--json"
+    ],
+    {
+      ...process.env,
+      DA_VINCI_CODEX_BIN: fakeCodexPath,
+      DA_VINCI_FAKE_STATE: statePath
+    }
+  );
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const payload = JSON.parse(String(result.stdout || "{}").trim());
+  assert.equal(payload.status, "PASS");
+  assert.equal(payload.reviewerAttempts["frontend-skill"], 2);
+});
+
+runTest("da-vinci supervisor-review can run reviewers in parallel", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const projectRoot = path.join(base, "project");
+  const changeId = "change-004c";
+  const pencilDesignPath = path.join(
+    projectRoot,
+    ".da-vinci",
+    "changes",
+    changeId,
+    "pencil-design.md"
+  );
+
+  writeDaVinci(projectRoot, ["frontend-skill", "ui-ux-pro-max"]);
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      ""
+    ].join("\n")
+  );
+
+  const fakeCodexPath = path.join(base, "fake-codex-parallel.js");
+  writeText(
+    fakeCodexPath,
+    [
+      "#!/usr/bin/env node",
+      "const fs = require('fs');",
+      "const args = process.argv.slice(2);",
+      "const outputFlag = args.indexOf('--output-last-message');",
+      "if (outputFlag < 0) { process.exit(2); }",
+      "const outPath = args[outputFlag + 1];",
+      "Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 800);",
+      "const payload = { status: 'PASS', issues: [], revision_outcome: 'approved' };",
+      "fs.writeFileSync(outPath, JSON.stringify(payload));"
+    ].join("\n")
+  );
+  fs.chmodSync(fakeCodexPath, 0o755);
+
+  const start = Date.now();
+  const result = runNodeScript(
+    daVinciBin,
+    [
+      "supervisor-review",
+      "--project",
+      projectRoot,
+      "--change",
+      changeId,
+      "--run-reviewers",
+      "--review-concurrency",
+      "2",
+      "--review-retries",
+      "0",
+      "--codex-bin",
+      fakeCodexPath,
+      "--json"
+    ],
+    {
+      ...process.env,
+      DA_VINCI_CODEX_BIN: fakeCodexPath
+    }
+  );
+  const elapsedMs = Date.now() - start;
+
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  const payload = JSON.parse(String(result.stdout || "{}").trim());
+  assert.equal(payload.reviewConcurrency, 2);
+  assert.equal(payload.reviewerAttempts["frontend-skill"], 1);
+  assert.equal(payload.reviewerAttempts["ui-ux-pro-max"], 1);
+  assert.ok(elapsedMs < 1450, `expected parallel execution under 1450ms, got ${elapsedMs}ms`);
+});
+
+runTest("completion audit passes after skill-based supervisor-review write", () => {
+  const base = fs.mkdtempSync(path.join(os.tmpdir(), "da-vinci-supervisor-cli-"));
+  const home = path.join(base, "home");
+  const projectRoot = path.join(base, "project");
+  const changeId = "change-005";
+  const daVinciDir = path.join(projectRoot, ".da-vinci");
+  const changeDir = path.join(daVinciDir, "changes", changeId);
+  const pencilDesignPath = path.join(changeDir, "pencil-design.md");
+  const penPath = path.join(daVinciDir, "designs", "reviewed.pen");
+  const nodesFile = path.join(base, "nodes.json");
+  const variablesFile = path.join(base, "variables.json");
+  const exportsDir = path.join(changeDir, "exports");
+
+  writeDaVinci(projectRoot, ["frontend-skill", "ui-ux-pro-max"]);
+  writeText(path.join(daVinciDir, "project-inventory.md"), "# Inventory\n");
+  writeText(path.join(daVinciDir, "page-map.md"), "# Page Map\n");
+  writeText(
+    path.join(daVinciDir, "design-registry.md"),
+    "# Registry\n- Preferred .pen: .da-vinci/designs/reviewed.pen\n"
+  );
+  writeText(path.join(changeDir, "design-brief.md"), "# Brief\n");
+  writeText(path.join(changeDir, "design.md"), "# Design\n");
+  writeText(path.join(changeDir, "pencil-bindings.md"), "# Bindings\n");
+  writeText(
+    pencilDesignPath,
+    [
+      "# Pencil Design",
+      "",
+      "## Screenshot Review Records",
+      "- `A_HOME` => `PASS`",
+      "",
+      "## Checkpoint Status",
+      "- Design checkpoint: `PASS`",
+      "",
+      "## Context Delta",
+      "- time: 2026-03-29T12:00:00Z",
+      "- checkpoint_type: Design checkpoint",
+      "- decision: supervisor review closed with PASS",
+      "- status: PASS",
+      "- next_action: run completion audit",
+      ""
+    ].join("\n")
+  );
+  fs.mkdirSync(exportsDir, { recursive: true });
+  fs.writeFileSync(path.join(exportsDir, "anchor.png"), "fake");
+  writeJson(nodesFile, { nodes: fixture.children });
+  writeJson(variablesFile, { variables: fixture.variables });
+
+  let result = runDaVinci(
+    ["pencil-session", "begin", "--project", projectRoot, "--pen", penPath],
+    { home }
+  );
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+
+  result = runDaVinci(
+    [
+      "pencil-session",
+      "persist",
+      "--project",
+      projectRoot,
+      "--pen",
+      penPath,
+      "--nodes-file",
+      nodesFile,
+      "--variables-file",
+      variablesFile,
+      "--version",
+      fixture.version
+    ],
+    { home }
+  );
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+
+  result = runDaVinci(
+    [
+      "pencil-session",
+      "end",
+      "--project",
+      projectRoot,
+      "--pen",
+      penPath,
+      "--nodes-file",
+      nodesFile,
+      "--variables-file",
+      variablesFile,
+      "--version",
+      fixture.version
+    ],
+    { home }
+  );
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+
+  const fakeCodexPath = path.join(base, "fake-codex.js");
+  writeText(
+    fakeCodexPath,
+    [
+      "#!/usr/bin/env node",
+      "const fs = require('fs');",
+      "const args = process.argv.slice(2);",
+      "const outputFlag = args.indexOf('--output-last-message');",
+      "if (outputFlag < 0) { process.exit(2); }",
+      "const outPath = args[outputFlag + 1];",
+      "const payload = {",
+      "  status: 'PASS',",
+      "  issues: [],",
+      "  revision_outcome: 'approved'",
+      "};",
+      "fs.writeFileSync(outPath, JSON.stringify(payload));"
+    ].join("\n")
+  );
+  fs.chmodSync(fakeCodexPath, 0o755);
+
+  result = runDaVinci(
+    [
+      "supervisor-review",
+      "--project",
+      projectRoot,
+      "--change",
+      changeId,
+      "--run-reviewers",
+      "--codex-bin",
+      fakeCodexPath,
+      "--write"
+    ],
+    {
+      home,
+      env: {
+        ...process.env,
+        DA_VINCI_CODEX_BIN: fakeCodexPath
+      }
+    }
+  );
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+
+  result = runDaVinci(
+    ["audit", "--project", projectRoot, "--mode", "completion", "--change", changeId],
+    { home }
+  );
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  assert.match(String(result.stdout || ""), /Status: PASS/);
+});
+
+console.log("All supervisor-review CLI tests passed.");