@xenonbyte/da-vinci-workflow 0.1.20 → 0.1.21

package/docs/zh-CN/visual-assist-presets/web-app.md

@@ -18,20 +18,10 @@
 
 ```md
 ## Visual Assist
-- Preferred adapters:
-  - ui-ux-pro-max
-  - frontend-skill
-- Scope:
-  - visual contract refinement
-  - page composition
-  - hierarchy and spacing
-  - responsive motion guidance
-  - anchor-surface composition
-  - Pencil design refinement
-- Fallback:
-  - native-da-vinci
-- Require Adapter:
-  - false
+- Preferred adapters: ui-ux-pro-max, frontend-skill
+- Scope: visual contract refinement, page composition, hierarchy and spacing, responsive motion guidance, anchor-surface composition, Pencil design refinement
+- Fallback: native-da-vinci
+- Require Adapter: false
 ```
 
 ### 变体 2：reviewer 建议性审查
@@ -43,33 +33,14 @@
 
 ```md
 ## Visual Assist
-- Preferred adapters:
-  - ui-ux-pro-max
-  - frontend-skill
-- Design-supervisor reviewers:
-  - frontend-skill
-  - ui-ux-pro-max
-- Design-supervisor review mode:
-  - screenshot-and-theme
-- Design-supervisor review inputs:
-  - screenshots
-  - pencil variables
-  - visual thesis
-  - content plan
-  - interaction thesis
-- Scope:
-  - visual contract refinement
-  - page composition
-  - hierarchy and spacing
-  - responsive motion guidance
-  - anchor-surface composition
-  - Pencil design refinement
-- Fallback:
-  - native-da-vinci
-- Require Adapter:
-  - false
-- Require Supervisor Review:
-  - false
+- Preferred adapters: ui-ux-pro-max, frontend-skill
+- Design-supervisor reviewers: frontend-skill, ui-ux-pro-max
+- Design-supervisor review mode: screenshot-and-theme
+- Design-supervisor review inputs: screenshots, pencil variables, visual thesis, content plan, interaction thesis
+- Scope: visual contract refinement, page composition, hierarchy and spacing, responsive motion guidance, anchor-surface composition, Pencil design refinement
+- Fallback: native-da-vinci
+- Require Adapter: false
+- Require Supervisor Review: false
 ```
 
 ### 变体 3：reviewer 硬签字
@@ -82,33 +53,14 @@
 
 ```md
 ## Visual Assist
-- Preferred adapters:
-  - frontend-skill
-  - ui-ux-pro-max
-- Design-supervisor reviewers:
-  - frontend-skill
-  - ui-ux-pro-max
-- Design-supervisor review mode:
-  - screenshot-and-theme
-- Design-supervisor review inputs:
-  - screenshots
-  - pencil variables
-  - visual thesis
-  - content plan
-  - interaction thesis
-- Scope:
-  - visual contract refinement
-  - page composition
-  - hierarchy and spacing
-  - responsive motion guidance
-  - anchor-surface composition
-  - Pencil design refinement
-- Fallback:
-  - native-da-vinci
-- Require Adapter:
-  - true
-- Require Supervisor Review:
-  - true
+- Preferred adapters: frontend-skill, ui-ux-pro-max
+- Design-supervisor reviewers: frontend-skill, ui-ux-pro-max
+- Design-supervisor review mode: screenshot-and-theme
+- Design-supervisor review inputs: screenshots, pencil variables, visual thesis, content plan, interaction thesis
+- Scope: visual contract refinement, page composition, hierarchy and spacing, responsive motion guidance, anchor-surface composition, Pencil design refinement
+- Fallback: native-da-vinci
+- Require Adapter: true
+- Require Supervisor Review: true
 ```
 
 通用说明：

package/examples/greenfield-spec-markupflow/DA-VINCI.md

@@ -35,19 +35,10 @@
 - CTA regions should preserve the same dark product language
 
 ## Visual Assist
-- Preferred adapters:
-  - frontend-skill
-  - ui-ux-pro-max
-- Scope:
-  - visual contract refinement
-  - page composition
-  - hierarchy and spacing
-  - anchor-surface composition
-  - Pencil design refinement
-- Fallback:
-  - native-da-vinci
-- Require Adapter:
-  - false
+- Preferred adapters: frontend-skill, ui-ux-pro-max
+- Scope: visual contract refinement, page composition, hierarchy and spacing, anchor-surface composition, Pencil design refinement
+- Fallback: native-da-vinci
+- Require Adapter: false
 
 ## Do
 - keep page sections clearly bounded

package/lib/cli.js

@@ -100,7 +100,7 @@ function printHelp() {
       "  da-vinci pencil-lock status",
       "  da-vinci pencil-session begin --project <path> --pen <path>",
       "  da-vinci pencil-session persist --project <path> --pen <path> --nodes-file <path> [--variables-file <path>]",
-      "  da-vinci pencil-session end --project <path> --pen <path> [--nodes-file <path>]",
+      "  da-vinci pencil-session end --project <path> --pen <path> --nodes-file <path> [--variables-file <path>]",
       "  da-vinci pencil-session status --project <path>",
       "  da-vinci --version",
       "",
@@ -456,6 +456,11 @@ async function runCli(argv) {
       if (!penPath) {
         throw new Error("`pencil-session end` requires `--pen <path>`.");
       }
+      if (!nodesFile && !force) {
+        throw new Error(
+          "`pencil-session end` requires `--nodes-file <path>` (and `--variables-file <path>` when available). Use `--force` only for emergency lock release."
+        );
+      }
 
       const result = endPencilSession({
         projectPath,

package/lib/pencil-session.js

@@ -168,6 +168,12 @@ function endPencilSession(options) {
     throw new Error("A registered `.pen` path is required for session shutdown.");
   }
 
+  if (!options.nodesFile && !options.force) {
+    throw new Error(
+      "Cannot end Pencil session without a live MCP snapshot. Provide `--nodes-file` (and `--variables-file` when available), or use `--force` for emergency shutdown."
+    );
+  }
+
   let syncResult = null;
   if (options.nodesFile) {
     syncResult = comparePenSync({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xenonbyte/da-vinci-workflow",
-  "version": "0.1.20",
+  "version": "0.1.21",
   "description": "Requirement-to-design-to-code workflow skill for Codex, Claude, and Gemini",
   "bin": {
     "da-vinci": "bin/da-vinci.js"

package/scripts/test-mode-consistency.js

@@ -286,4 +286,54 @@ runTest("design-supervisor review stays distinct from preferred adapters and is
   }
 });
 
+runTest("build prompts require completion audit and do not treat compile success as workflow completion", () => {
+  const buildPrompts = [
+    "commands/claude/dv/build.md",
+    "commands/codex/prompts/dv-build.md",
+    "commands/gemini/dv/build.toml"
+  ];
+
+  for (const file of buildPrompts) {
+    const content = read(file);
+    assert.match(content, /BUILD SUCCESSFUL/, `${file} should explicitly treat build success as compile-only evidence`);
+    assert.match(
+      content,
+      /da-vinci audit --mode completion --change <change-id> <project-path>/,
+      `${file} should require completion audit before terminal completion claims`
+    );
+    assert.match(
+      content,
+      /do not report `design complete` or `workflow complete`/i,
+      `${file} should prevent terminal completion claims while in-scope tasks remain`
+    );
+  }
+});
+
+runTest("continue prompts keep build routing blocked while design gates are unresolved", () => {
+  const continuePrompts = [
+    "commands/claude/dv/continue.md",
+    "commands/codex/prompts/dv-continue.md",
+    "commands/gemini/dv/continue.toml"
+  ];
+
+  for (const file of continuePrompts) {
+    const content = read(file);
+    assert.match(
+      content,
+      /missing shell-visible project-local `.pen`/,
+      `${file} should block build routing when project-local .pen persistence is unresolved`
+    );
+    assert.match(
+      content,
+      /active\/unclosed Pencil session/,
+      `${file} should block build routing when Pencil session is still active`
+    );
+    assert.match(
+      content,
+      /design-supervisor review still BLOCK\/unaccepted/,
+      `${file} should block build routing when required design-supervisor review has not cleared`
+    );
+  }
+});
+
 console.log("All mode consistency tests passed.");

package/scripts/test-pencil-session.js

@@ -149,4 +149,44 @@ runTest("pencil-session end fails when live payload is stale", () => {
   });
 });
 
+runTest("pencil-session end requires live payload unless force is used", () => {
+  const fixture = JSON.parse(fs.readFileSync(fixturePath, "utf8"));
+  const tempDir = createTempDir();
+  const projectRoot = path.join(tempDir, "project");
+  const homeDir = path.join(tempDir, "home");
+  const penPath = path.join(projectRoot, ".da-vinci", "designs", "cipher.pen");
+  const { nodesFile, variablesFile } = writePayloadFiles(tempDir, fixture);
+
+  beginPencilSession({
+    projectPath: projectRoot,
+    penPath,
+    homeDir
+  });
+  persistPencilSession({
+    projectPath: projectRoot,
+    penPath,
+    nodesFile,
+    variablesFile,
+    version: fixture.version,
+    homeDir
+  });
+
+  assert.throws(
+    () =>
+      endPencilSession({
+        projectPath: projectRoot,
+        penPath,
+        homeDir
+      }),
+    /without a live MCP snapshot/i
+  );
+
+  endPencilSession({
+    projectPath: projectRoot,
+    penPath,
+    homeDir,
+    force: true
+  });
+});
+
 console.log("All Pencil session tests passed.");

package/scripts/test-persistence-flows.js

@@ -241,9 +241,39 @@ runTest("parallel mixed projects are serialized by the global Pencil lock", () =
     runCli(harness, ["pencil-session", "begin", "--project", existing.root, "--pen", existing.penPath]),
     /lock is already held/i
   );
+  expectOk(
+    "parallel A persist",
+    runCli(harness, [
+      "pencil-session",
+      "persist",
+      "--project",
+      freshA.root,
+      "--pen",
+      freshA.penPath,
+      "--nodes-file",
+      freshA.nodesFile,
+      "--variables-file",
+      freshA.variablesFile,
+      "--version",
+      fixture.version
+    ])
+  );
   expectOk(
     "parallel A end",
-    runCli(harness, ["pencil-session", "end", "--project", freshA.root, "--pen", freshA.penPath])
+    runCli(harness, [
+      "pencil-session",
+      "end",
+      "--project",
+      freshA.root,
+      "--pen",
+      freshA.penPath,
+      "--nodes-file",
+      freshA.nodesFile,
+      "--variables-file",
+      freshA.variablesFile,
+      "--version",
+      fixture.version
+    ])
   );
 
   expectOk(