@xenon-device-management/xenon 2.13.1 → 2.14.0

package/lib/test/unit/device-settings-survive.spec.js

@@ -0,0 +1,555 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const events_1 = require("events");
+const chai_1 = require("chai");
+const sinon_1 = __importDefault(require("sinon"));
+const express_1 = __importDefault(require("express"));
+const typedi_1 = require("typedi");
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
+const scratch_database_1 = require("../helpers/scratch-database");
+const container_registration_1 = require("../helpers/container-registration");
+const own_node_id_1 = require("../helpers/own-node-id");
+const grid_1 = __importDefault(require("../../src/app/routers/grid"));
+const reservation_1 = __importDefault(require("../../src/app/routers/reservation"));
+const prisma_1 = require("../../src/prisma");
+const prisma_store_1 = require("../../src/data-service/prisma-store");
+const device_store_1 = require("../../src/data-service/device-store");
+const device_service_1 = require("../../src/data-service/device-service");
+const device_utils_1 = require("../../src/device-utils");
+const helpers = __importStar(require("../../src/helpers"));
+const AndroidDeviceManager_1 = __importDefault(require("../../src/device-managers/AndroidDeviceManager"));
+const IOSDiscoveryService_1 = require("../../src/device-managers/ios/IOSDiscoveryService");
+const iOSTracker_1 = require("../../src/device-managers/iOSTracker");
+const device_managers_1 = require("../../src/device-managers");
+const localDeviceHosts_1 = require("../../src/device-managers/localDeviceHosts");
+const deviceSettings_1 = require("../../src/data-service/deviceSettings");
+const PluginContext_1 = require("../../src/PluginContext");
+const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
+const SocketServer_1 = require("../../src/services/SocketServer");
+const NotificationService_1 = require("../../src/services/NotificationService");
+const TeamService_1 = require("../../src/services/TeamService");
+/**
+ * A phone's Device row is deleted whenever the phone goes: unplugged,
+ * rebooted, offline or unauthorized in adb, an iPhone detached, a simulator
+ * no longer reported, a restart of the server, and on a hub its node gone or
+ * missing one health probe. The row was the only place an admin's settings
+ * for the phone lived (team, tags, maintenance, reservation), so each of
+ * those reset them. A team is a device boundary: a team's phone came back in
+ * the shared pool, visible to every member.
+ *
+ * These run the real PrismaDeviceStore on a scratch database.
+ */
+const IP = '10.0.0.1';
+const OWN = `http://${IP}:4723`;
+const NODE = `http://${IP}:4725`;
+const UDID = 'R5CT32ABCDE';
+const HOUR = 60 * 60 * 1000;
+const ADMIN = { userId: 'usr_admin', role: 'ADMIN', scopes: 'admin,devices,sessions,read' };
+const MEMBER = {
+    userId: 'usr_member',
+    role: 'MEMBER',
+    scopes: 'devices,sessions,read',
+    teamIds: [],
+};
+const phone = (udid, host = OWN, over = {}) => (Object.assign({ udid,
+    host, name: `Phone ${udid}`, platform: 'android', deviceType: 'real', realDevice: true, state: 'device', sdk: '14', busy: false, userBlocked: false, totalUtilizationTimeMilliSec: 0, sessionStartTime: 0, nodeId: host === OWN ? own_node_id_1.OWN_NODE_ID : 'node-1' }, over));
+function appAs(caller, args) {
+    const app = (0, express_1.default)();
+    app.use(express_1.default.json());
+    app.use((req, _res, next) => {
+        req.auth = Object.assign({ kind: 'user-session', rateLimit: 1000 }, caller);
+        next();
+    });
+    const router = express_1.default.Router();
+    grid_1.default.register(router, args);
+    router.use('/reservation', reservation_1.default);
+    app.use(router);
+    return app;
+}
+describe('An admin’s settings for a phone outlive its Device row', () => {
+    const scratch = (0, scratch_database_1.useScratchDatabase)();
+    let args;
+    let context;
+    let savedContext;
+    let savedStore;
+    let restoreContainer;
+    let events;
+    let discover;
+    let usbmux;
+    const local = () => (0, localDeviceHosts_1.localDeviceHosts)(args, 4723);
+    const admin = () => appAs(ADMIN, args);
+    const member = () => appAs(MEMBER, args);
+    const row = (udid = UDID, host = OWN) => device_store_1.DeviceStoreFactory.getStore().findDevice({ udid, host });
+    /** Team, tags and maintenance, through the routes the dashboard calls. */
+    function configure() {
+        return __awaiter(this, arguments, void 0, function* (udid = UDID, host = OWN) {
+            const team = yield (0, loopbackRequest_1.default)(admin()).put(`/device/${udid}/team`).send({ teamId: 'team-a' });
+            (0, chai_1.expect)(team.status, JSON.stringify(team.body)).to.equal(200);
+            const tags = yield (0, loopbackRequest_1.default)(admin())
+                .post('/device/tags')
+                .send({ udid, host, tags: ['lab-1', 'smoke'] });
+            (0, chai_1.expect)(tags.status, JSON.stringify(tags.body)).to.equal(200);
+            const block = yield (0, loopbackRequest_1.default)(admin()).post('/block').send({ udid, host });
+            (0, chai_1.expect)(block.status, JSON.stringify(block.body)).to.equal(200);
+        });
+    }
+    function expectConfigured(device) {
+        (0, chai_1.expect)(device, 'the phone is back').to.not.equal(null);
+        (0, chai_1.expect)(device).to.include({ teamId: 'team-a', userBlocked: true });
+        (0, chai_1.expect)(device === null || device === void 0 ? void 0 : device.tags).to.deep.equal(['lab-1', 'smoke']);
+    }
+    beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        events = [];
+        discover = () => __awaiter(void 0, void 0, void 0, function* () { return []; });
+        usbmux = new events_1.EventEmitter();
+        restoreContainer = (0, container_registration_1.saveRegistrations)(SocketServer_1.SocketServer, NotificationService_1.NotificationService, device_managers_1.XenonManager, iOSTracker_1.IosTracker);
+        typedi_1.Container.set({
+            id: SocketServer_1.SocketServer,
+            value: {
+                emitToDashboard: () => undefined,
+                emitToDashboardForDevices: (event, data, scope) => __awaiter(void 0, void 0, void 0, function* () {
+                    events.push({ event, data, scope });
+                }),
+                hasScopedDashboard: () => false,
+            },
+        });
+        typedi_1.Container.set({ id: NotificationService_1.NotificationService, value: { dispatchEvent: () => __awaiter(void 0, void 0, void 0, function* () { return undefined; }) } });
+        typedi_1.Container.set({
+            id: device_managers_1.XenonManager,
+            value: { getDevices: (known) => discover(known) },
+        });
+        typedi_1.Container.set({ id: iOSTracker_1.IosTracker, value: { getListener: () => usbmux } });
+        args = Object.assign(Object.assign({}, IPluginArgs_1.DefaultPluginArgs), { bindHostOrIp: IP });
+        context = typedi_1.Container.get(PluginContext_1.PluginContext);
+        savedContext = Object.assign({}, context);
+        context.setContext(args, 4723, own_node_id_1.OWN_NODE_ID, '');
+        savedStore = device_store_1.DeviceStoreFactory._deviceStore;
+        device_store_1.DeviceStoreFactory._deviceStore = new prisma_store_1.PrismaDeviceStore();
+        yield scratch.db.deviceSetting.deleteMany({});
+        yield scratch.db.device.deleteMany({});
+        yield scratch.db.team.deleteMany({});
+        yield scratch.db.team.create({ data: { id: 'team-a', name: 'Team A' } });
+        yield scratch.db.team.create({ data: { id: 'team-b', name: 'Team B' } });
+    }));
+    afterEach(() => {
+        device_store_1.DeviceStoreFactory._deviceStore = savedStore;
+        Object.assign(context, savedContext);
+        sinon_1.default.restore();
+        restoreContainer();
+    });
+    describe('on this server’s own phones', () => {
+        it('keeps them when the phone is unplugged and plugged back in', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            yield (0, device_service_1.removeDevice)([{ udid: UDID, host: OWN }]);
+            (0, chai_1.expect)(yield row()).to.equal(null);
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            expectConfigured(yield row());
+        }));
+        it('keeps them when adb reports the phone offline, then back', () => __awaiter(void 0, void 0, void 0, function* () {
+            const manager = new AndroidDeviceManager_1.default(context);
+            sinon_1.default.stub(manager, 'waitBootComplete').resolves();
+            sinon_1.default.stub(manager, 'isRealDevice').resolves(true);
+            sinon_1.default.stub(manager, 'deviceInfo').callsFake((d) => __awaiter(void 0, void 0, void 0, function* () { return phone(d.udid); }));
+            const tracker = new events_1.EventEmitter();
+            yield manager.createLocalAdbTracker(tracker, {})();
+            const change = tracker.listeners('change')[0];
+            yield change({ id: UDID, type: 'device' });
+            yield configure();
+            yield change({ id: UDID, type: 'offline' });
+            (0, chai_1.expect)(yield row()).to.equal(null);
+            yield change({ id: UDID, type: 'device' });
+            expectConfigured(yield row());
+        }));
+        it('keeps them when an iPhone is detached and attached again', () => __awaiter(void 0, void 0, void 0, function* () {
+            const ios = new IOSDiscoveryService_1.IOSDiscoveryService(context);
+            sinon_1.default
+                .stub(ios, 'getDeviceInfo')
+                .callsFake((udid) => __awaiter(void 0, void 0, void 0, function* () { return phone(udid, OWN, { platform: 'ios' }); }));
+            ios.trackIOSDevices();
+            const attached = usbmux.listeners('attached')[0];
+            const detached = usbmux.listeners('detached')[0];
+            yield attached('iphone-1');
+            yield configure('iphone-1');
+            yield detached('iphone-1');
+            (0, chai_1.expect)(yield row('iphone-1')).to.equal(null);
+            yield attached('iphone-1');
+            expectConfigured(yield row('iphone-1'));
+        }));
+        it('keeps them when discovery stops reporting the phone, then reports it again', () => __awaiter(void 0, void 0, void 0, function* () {
+            const sim = phone('sim-1', OWN, { platform: 'ios', deviceType: 'simulator' });
+            discover = () => __awaiter(void 0, void 0, void 0, function* () { return [sim]; });
+            yield (0, device_utils_1.updateDeviceList)(local());
+            yield configure('sim-1');
+            discover = () => __awaiter(void 0, void 0, void 0, function* () { return []; }); // shut down, with bootedSimulators on
+            yield (0, device_utils_1.updateDeviceList)(local());
+            (0, chai_1.expect)(yield row('sim-1')).to.equal(null);
+            discover = () => __awaiter(void 0, void 0, void 0, function* () { return [sim]; });
+            yield (0, device_utils_1.updateDeviceList)(local());
+            expectConfigured(yield row('sim-1'));
+        }));
+        it('keeps them across a restart of the server', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            yield (0, deviceSettings_1.resetDevicesAtBoot)(device_store_1.DeviceStoreFactory.getStore(), args, local());
+            (0, chai_1.expect)(yield row()).to.equal(null);
+            discover = () => __awaiter(void 0, void 0, void 0, function* () { return [phone(UDID)]; });
+            yield (0, device_utils_1.updateDeviceList)(local());
+            expectConfigured(yield row());
+        }));
+        it('saves, at the first start after an upgrade, the settings rows kept only on the row', () => __awaiter(void 0, void 0, void 0, function* () {
+            // Written before this change: the settings live on the row alone.
+            yield scratch.db.device.create({
+                data: {
+                    udid: UDID,
+                    host: OWN,
+                    nodeId: 'the-previous-boot',
+                    platform: 'android',
+                    teamId: 'team-a',
+                    tags: JSON.stringify(['lab-1', 'smoke']),
+                    userBlocked: true,
+                },
+            });
+            yield (0, deviceSettings_1.resetDevicesAtBoot)(device_store_1.DeviceStoreFactory.getStore(), args, local());
+            (0, chai_1.expect)(yield row()).to.equal(null);
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            expectConfigured(yield row());
+        }));
+        it('starts the phone in its team in the same write: a member never sees it in between', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            yield (0, device_service_1.removeDevice)([{ udid: UDID, host: OWN }]);
+            // useScratchDatabase stubs the delegate already: read its calls.
+            const upsert = prisma_1.prisma.device.upsert;
+            upsert.resetHistory();
+            events = [];
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            // The row is created with its team: no later write puts it there.
+            (0, chai_1.expect)(upsert.callCount).to.equal(1);
+            (0, chai_1.expect)(upsert.firstCall.args[0].create).to.include({ teamId: 'team-a' });
+            // The dashboards that may see it are told, and only those.
+            const added = events.find((e) => e.event === 'device_added');
+            (0, chai_1.expect)(added === null || added === void 0 ? void 0 : added.scope).to.deep.equal({ udid: UDID, teamId: 'team-a' });
+            // A member of no team doesn't get it from the device list.
+            const list = yield (0, loopbackRequest_1.default)(member()).get('/devices');
+            (0, chai_1.expect)(list.status).to.equal(200);
+            (0, chai_1.expect)(list.body.map((d) => d.udid)).to.not.include(UDID);
+        }));
+        it('keeps a reservation until it ends, and not after', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a, _b, _c;
+            yield (0, device_service_1.addNewDevice)([phone(UDID), phone('other')]);
+            for (const udid of [UDID, 'other']) {
+                const r = yield (0, loopbackRequest_1.default)(admin())
+                    .post('/reservation')
+                    .send({ udid, host: OWN, reservedBy: 'Dana', duration: '1h', reason: 'release' });
+                (0, chai_1.expect)(r.status, JSON.stringify(r.body)).to.equal(200);
+            }
+            // 'other' ends while it is unplugged.
+            yield (0, device_service_1.removeDevice)([
+                { udid: UDID, host: OWN },
+                { udid: 'other', host: OWN },
+            ]);
+            const now = Date.now();
+            sinon_1.default.stub(Date, 'now').returns(now + 30 * 60 * 1000);
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            Date.now.returns(now + 2 * HOUR);
+            yield (0, device_service_1.addNewDevice)([phone('other')]);
+            (0, chai_1.expect)(yield row()).to.include({
+                reservedBy: 'Dana',
+                reservedByUserId: 'usr_admin',
+                reservationReason: 'release',
+            });
+            (0, chai_1.expect)((_a = (yield row())) === null || _a === void 0 ? void 0 : _a.reservedUntil).to.be.closeTo(now + HOUR, 5000);
+            const other = yield row('other');
+            (0, chai_1.expect)((_b = other === null || other === void 0 ? void 0 : other.reservedBy) !== null && _b !== void 0 ? _b : null).to.equal(null);
+            (0, chai_1.expect)((_c = other === null || other === void 0 ? void 0 : other.reservedUntil) !== null && _c !== void 0 ? _c : null).to.equal(null);
+        }));
+        it('keeps what was cleared cleared', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a, _b;
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(admin()).put(`/device/${UDID}/team`).send({ teamId: null })).status).to.equal(200);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(admin()).post('/device/tags').send({ udid: UDID, host: OWN, tags: [] }))
+                .status).to.equal(200);
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(admin()).post('/unblock').send({ udid: UDID, host: OWN })).status).to.equal(200);
+            yield (0, device_service_1.removeDevice)([{ udid: UDID, host: OWN }]);
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            const back = yield row();
+            (0, chai_1.expect)((_a = back === null || back === void 0 ? void 0 : back.teamId) !== null && _a !== void 0 ? _a : null).to.equal(null);
+            (0, chai_1.expect)(back === null || back === void 0 ? void 0 : back.userBlocked).to.equal(false);
+            (0, chai_1.expect)((_b = back === null || back === void 0 ? void 0 : back.tags) !== null && _b !== void 0 ? _b : []).to.deep.equal([]);
+        }));
+    });
+    describe('on a hub, for a node’s phones', () => {
+        const report = (over = {}) => (0, loopbackRequest_1.default)(admin())
+            .post('/register?type=add')
+            .send([phone('node-phone', NODE, over)]);
+        it('keeps them when the node unregisters and registers again', () => __awaiter(void 0, void 0, void 0, function* () {
+            (0, chai_1.expect)((yield report()).status).to.equal(200);
+            yield configure('node-phone', NODE);
+            const gone = yield (0, loopbackRequest_1.default)(admin()).post(`/register?type=unregister&host=${encodeURIComponent(NODE)}&nodeId=node-1`);
+            (0, chai_1.expect)(gone.status).to.equal(200);
+            (0, chai_1.expect)(yield row('node-phone', NODE)).to.equal(null);
+            (0, chai_1.expect)((yield report()).status).to.equal(200);
+            expectConfigured(yield row('node-phone', NODE));
+        }));
+        it('keeps them when the node misses a health probe', () => __awaiter(void 0, void 0, void 0, function* () {
+            (0, chai_1.expect)((yield report()).status).to.equal(200);
+            yield configure('node-phone', NODE);
+            sinon_1.default.stub(helpers, 'isXenonRunning').resolves(false);
+            yield (0, device_utils_1.removeStaleDevices)(local());
+            (0, chai_1.expect)(yield row('node-phone', NODE)).to.equal(null);
+            (0, chai_1.expect)((yield report()).status).to.equal(200);
+            expectConfigured(yield row('node-phone', NODE));
+        }));
+        it('takes no setting from the node’s report, on a new row or a known one', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            const own = { teamId: 'team-b', tags: ['from-node'], userBlocked: true };
+            (0, chai_1.expect)((yield report(own)).status).to.equal(200);
+            let hubRow = yield row('node-phone', NODE);
+            (0, chai_1.expect)((_a = hubRow === null || hubRow === void 0 ? void 0 : hubRow.teamId) !== null && _a !== void 0 ? _a : null).to.equal(null);
+            (0, chai_1.expect)(hubRow === null || hubRow === void 0 ? void 0 : hubRow.userBlocked).to.equal(false);
+            yield configure('node-phone', NODE);
+            yield (0, loopbackRequest_1.default)(admin()).post('/unblock').send({ udid: 'node-phone', host: NODE });
+            yield (0, loopbackRequest_1.default)(admin()).post(`/register?type=unregister&host=${encodeURIComponent(NODE)}&nodeId=node-1`);
+            (0, chai_1.expect)((yield report(own)).status).to.equal(200);
+            hubRow = yield row('node-phone', NODE);
+            (0, chai_1.expect)(hubRow).to.include({ teamId: 'team-a', userBlocked: false });
+            (0, chai_1.expect)(hubRow === null || hubRow === void 0 ? void 0 : hubRow.tags).to.deep.equal(['lab-1', 'smoke']);
+        }));
+        it('never gives a node’s phone the settings of the hub’s own phone with that udid', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            // emulator-5554 is on every machine that runs an emulator.
+            yield (0, device_service_1.addNewDevice)([phone('emulator-5554')]);
+            yield (0, loopbackRequest_1.default)(admin())
+                .post('/device/tags')
+                .send({ udid: 'emulator-5554', host: OWN, tags: ['hub-only'] });
+            yield (0, loopbackRequest_1.default)(admin()).post('/block').send({ udid: 'emulator-5554', host: OWN });
+            const r = yield (0, loopbackRequest_1.default)(admin())
+                .post('/register?type=add')
+                .send([phone('emulator-5554', NODE)]);
+            (0, chai_1.expect)(r.status).to.equal(200);
+            const nodeRow = yield row('emulator-5554', NODE);
+            (0, chai_1.expect)(nodeRow === null || nodeRow === void 0 ? void 0 : nodeRow.userBlocked).to.equal(false);
+            (0, chai_1.expect)((_a = nodeRow === null || nodeRow === void 0 ? void 0 : nodeRow.tags) !== null && _a !== void 0 ? _a : null).to.equal(null);
+        }));
+        it('keeps them across a restart of the hub, which keeps its nodes’ phones', () => __awaiter(void 0, void 0, void 0, function* () {
+            (0, chai_1.expect)((yield report()).status).to.equal(200);
+            yield configure('node-phone', NODE);
+            yield (0, deviceSettings_1.resetDevicesAtBoot)(device_store_1.DeviceStoreFactory.getStore(), args, local());
+            expectConfigured(yield row('node-phone', NODE));
+        }));
+    });
+    describe('what the dashboard and the API save', () => {
+        const saved = (udid = UDID, host = OWN) => scratch.db.deviceSetting.findUnique({ where: { udid_host: { udid, host } } });
+        it('saves a team on every phone of the udid, connected or not', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID), phone(UDID, NODE)]);
+            yield scratch.db.deviceSetting.create({ data: { udid: UDID, host: 'http://10.0.0.9:4723' } });
+            const r = yield (0, loopbackRequest_1.default)(admin()).put(`/device/${UDID}/team`).send({ teamId: 'team-a' });
+            (0, chai_1.expect)(r.status).to.equal(200);
+            (0, chai_1.expect)(r.body).to.deep.equal({ ok: true, updated: 3 });
+            for (const host of [OWN, NODE, 'http://10.0.0.9:4723']) {
+                (0, chai_1.expect)(yield saved(UDID, host), host).to.include({ teamId: 'team-a' });
+            }
+            (0, chai_1.expect)(yield row(UDID, OWN)).to.include({ teamId: 'team-a' });
+            (0, chai_1.expect)(yield row(UDID, NODE)).to.include({ teamId: 'team-a' });
+        }));
+        it('answers 404 for a udid it has neither a row nor saved settings for', () => __awaiter(void 0, void 0, void 0, function* () {
+            const r = yield (0, loopbackRequest_1.default)(admin()).put('/device/nobody/team').send({ teamId: 'team-a' });
+            (0, chai_1.expect)(r.status).to.equal(404);
+            (0, chai_1.expect)(yield scratch.db.deviceSetting.count()).to.equal(0);
+        }));
+        it('saves tags and maintenance on the phone named, and only for a phone it has', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID), phone(UDID, NODE)]);
+            yield (0, loopbackRequest_1.default)(admin())
+                .post('/device/tags')
+                .send({ udid: UDID, host: OWN, tags: ['lab-1'] });
+            yield (0, loopbackRequest_1.default)(admin()).post('/block').send({ udid: UDID, host: OWN });
+            const unknown = yield (0, loopbackRequest_1.default)(admin())
+                .post('/device/tags')
+                .send({ udid: 'nobody', host: OWN, tags: ['x'] });
+            (0, chai_1.expect)(yield saved()).to.include({ tags: '["lab-1"]', userBlocked: true, teamId: null });
+            (0, chai_1.expect)(yield saved(UDID, NODE)).to.equal(null);
+            (0, chai_1.expect)(unknown.status).to.equal(404);
+            (0, chai_1.expect)(yield saved('nobody')).to.equal(null);
+            yield (0, loopbackRequest_1.default)(admin()).post('/unblock').send({ udid: UDID, host: OWN });
+            (0, chai_1.expect)(yield saved()).to.include({ tags: '["lab-1"]', userBlocked: false });
+        }));
+        it('saves a reservation, its extension and its release', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            const host = encodeURIComponent(OWN);
+            yield (0, loopbackRequest_1.default)(member())
+                .post('/reservation')
+                .send({ udid: UDID, host: OWN, reservedBy: 'Dana', duration: '1h', reason: 'release' });
+            const taken = yield saved();
+            (0, chai_1.expect)(taken).to.include({
+                reservedBy: 'Dana',
+                reservedByUserId: 'usr_member',
+                reservationReason: 'release',
+            });
+            yield (0, loopbackRequest_1.default)(member()).post(`/reservation/${UDID}/${host}/extend`).send({ duration: '1h' });
+            (0, chai_1.expect)((_a = (yield saved())) === null || _a === void 0 ? void 0 : _a.reservedUntil).to.be.closeTo(Number(taken === null || taken === void 0 ? void 0 : taken.reservedUntil) + HOUR, 1000);
+            yield (0, loopbackRequest_1.default)(member()).delete(`/reservation/${UDID}/${host}`);
+            (0, chai_1.expect)(yield saved()).to.include({
+                reservedBy: null,
+                reservedByUserId: null,
+                reservedUntil: null,
+                reservationReason: null,
+            });
+        }));
+        it('clears a reservation the sweep ends', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield (0, loopbackRequest_1.default)(member())
+                .post('/reservation')
+                .send({ udid: UDID, host: OWN, reservedBy: 'Dana', duration: '1h' });
+            const later = Date.now() + 2 * HOUR;
+            sinon_1.default.stub(Date, 'now').returns(later);
+            yield (0, device_service_1.cleanExpiredReservations)();
+            (0, chai_1.expect)(yield saved()).to.include({ reservedBy: null, reservedUntil: null });
+        }));
+    });
+    describe('a setting saved while the phone’s row is being made', () => {
+        it('is on the new row, and in its event, though it came after the row read the settings', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            yield (0, device_service_1.removeDevice)([{ udid: UDID, host: OWN }]);
+            // An admin moves the phone to team B after addDevices read its saved
+            // settings and before it created the row: the row isn't there to write.
+            const upsert = prisma_1.prisma.device.upsert;
+            upsert.callsFake((call) => __awaiter(void 0, void 0, void 0, function* () {
+                yield device_store_1.DeviceStoreFactory.getStore().updateDevice(UDID, OWN, { teamId: 'team-b' });
+                return scratch.db.device.upsert(call);
+            }));
+            events = [];
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            (0, chai_1.expect)(yield row()).to.include({ teamId: 'team-b', userBlocked: true });
+            const added = events.find((e) => e.event === 'device_added');
+            (0, chai_1.expect)(added === null || added === void 0 ? void 0 : added.scope).to.deep.equal({ udid: UDID, teamId: 'team-b' });
+        }));
+    });
+    describe('removeDevicesFromDatabaseBeforeRunningThePlugin', () => {
+        it('forgets the saved settings of this server’s own phones at start, and keeps its nodes’', () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a, _b;
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            yield configure();
+            (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(admin())
+                .post('/register?type=add')
+                .send([phone('node-phone', NODE)])).status).to.equal(200);
+            yield configure('node-phone', NODE);
+            yield (0, deviceSettings_1.resetDevicesAtBoot)(device_store_1.DeviceStoreFactory.getStore(), Object.assign(Object.assign({}, args), { removeDevicesFromDatabaseBeforeRunningThePlugin: true }), local());
+            yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+            const own = yield row();
+            (0, chai_1.expect)((_a = own === null || own === void 0 ? void 0 : own.teamId) !== null && _a !== void 0 ? _a : null).to.equal(null);
+            (0, chai_1.expect)(own === null || own === void 0 ? void 0 : own.userBlocked).to.equal(false);
+            (0, chai_1.expect)((_b = own === null || own === void 0 ? void 0 : own.tags) !== null && _b !== void 0 ? _b : null).to.equal(null);
+            expectConfigured(yield row('node-phone', NODE));
+            (0, chai_1.expect)(yield scratch.db.deviceSetting.findMany({ select: { udid: true, host: true } })).to.deep.equal([{ udid: 'node-phone', host: NODE }]);
+        }));
+        it('on a node, forgets those of every phone, as it clears every phone', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield (0, device_service_1.addNewDevice)([phone(UDID), phone('other', 'http://10.0.0.1:4799')]);
+            yield (0, loopbackRequest_1.default)(admin()).post('/block').send({ udid: UDID, host: OWN });
+            yield (0, loopbackRequest_1.default)(admin()).post('/block').send({ udid: 'other', host: 'http://10.0.0.1:4799' });
+            yield (0, deviceSettings_1.resetDevicesAtBoot)(device_store_1.DeviceStoreFactory.getStore(), Object.assign(Object.assign({}, args), { hub: 'http://10.0.0.2:4723', removeDevicesFromDatabaseBeforeRunningThePlugin: true }), local());
+            (0, chai_1.expect)(yield scratch.db.device.count()).to.equal(0);
+            (0, chai_1.expect)(yield scratch.db.deviceSetting.count()).to.equal(0);
+        }));
+    });
+});
+describe('Saved phone settings: team deletion', () => {
+    const scratch = (0, scratch_database_1.useScratchDatabase)();
+    let savedStore;
+    let restoreContainer;
+    beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        restoreContainer = (0, container_registration_1.saveRegistrations)(SocketServer_1.SocketServer, NotificationService_1.NotificationService);
+        typedi_1.Container.set({
+            id: SocketServer_1.SocketServer,
+            value: {
+                emitToDashboard: () => undefined,
+                emitToDashboardForDevices: () => __awaiter(void 0, void 0, void 0, function* () { return undefined; }),
+                hasScopedDashboard: () => false,
+            },
+        });
+        typedi_1.Container.set({ id: NotificationService_1.NotificationService, value: { dispatchEvent: () => __awaiter(void 0, void 0, void 0, function* () { return undefined; }) } });
+        savedStore = device_store_1.DeviceStoreFactory._deviceStore;
+        device_store_1.DeviceStoreFactory._deviceStore = new prisma_store_1.PrismaDeviceStore();
+        yield scratch.db.deviceSetting.deleteMany({});
+        yield scratch.db.device.deleteMany({});
+        yield scratch.db.team.deleteMany({});
+        yield scratch.db.team.create({ data: { id: 'team-a', name: 'Team A' } });
+    }));
+    afterEach(() => {
+        device_store_1.DeviceStoreFactory._deviceStore = savedStore;
+        sinon_1.default.restore();
+        restoreContainer();
+    });
+    it('refuses to delete a team one of whose phones is not connected now', () => __awaiter(void 0, void 0, void 0, function* () {
+        const args = Object.assign(Object.assign({}, IPluginArgs_1.DefaultPluginArgs), { bindHostOrIp: IP });
+        yield (0, device_service_1.addNewDevice)([phone(UDID)]);
+        (0, chai_1.expect)((yield (0, loopbackRequest_1.default)(appAs(ADMIN, args)).put(`/device/${UDID}/team`).send({ teamId: 'team-a' }))
+            .status).to.equal(200);
+        yield (0, device_service_1.removeDevice)([{ udid: UDID, host: OWN }]);
+        let refusal;
+        try {
+            yield typedi_1.Container.get(TeamService_1.TeamService).delete('team-a');
+        }
+        catch (err) {
+            refusal = err;
+        }
+        (0, chai_1.expect)(refusal === null || refusal === void 0 ? void 0 : refusal.message).to.match(/1 device\(s\) \(1 not connected now\)/);
+        (0, chai_1.expect)(yield scratch.db.team.count({ where: { id: 'team-a' } })).to.equal(1);
+        // The way out: the phone back in the shared pool, by its udid.
+        const back = yield (0, loopbackRequest_1.default)(appAs(ADMIN, args))
+            .put(`/device/${UDID}/team`)
+            .send({ teamId: null });
+        (0, chai_1.expect)(back.status, JSON.stringify(back.body)).to.equal(200);
+        yield typedi_1.Container.get(TeamService_1.TeamService).delete('team-a');
+        (0, chai_1.expect)(yield scratch.db.team.count({ where: { id: 'team-a' } })).to.equal(0);
+    }));
+});

package/lib/test/unit/device-sync-lost-update.spec.js

@@ -68,6 +68,11 @@ describe('Device sync keeps writes made while it ran (lost update)', () => {
         for (const m of Object.keys(table.delegate)) {
             sinon_1.default.stub(prisma_1.prisma.device, m).callsFake(table.delegate[m]);
         }
+        // The phones' saved settings (deviceSettings.ts), so none reach a database.
+        const settings = (0, fake_device_table_1.fakeDeviceSettingTable)();
+        for (const m of Object.keys(settings.delegate)) {
+            sinon_1.default.stub(prisma_1.prisma.deviceSetting, m).callsFake(settings.delegate[m]);
+        }
     };
     beforeEach(() => {
         emits = [];