@xenon-device-management/xenon 2.0.0 → 2.1.0

package/lib/test/unit/node-hub-session-owner.spec.js

@@ -0,0 +1,223 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const express_1 = __importDefault(require("express"));
+const fs_1 = __importDefault(require("fs"));
+const http_1 = __importDefault(require("http"));
+const os_1 = __importDefault(require("os"));
+const path_1 = __importDefault(require("path"));
+const sinon_1 = __importDefault(require("sinon"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
+const typedi_1 = require("typedi");
+const plugin_1 = require("../../src/plugin");
+const registerCommandAuth_1 = require("../../src/app/registerCommandAuth");
+const defaultGateway_1 = require("../../src/gateway/defaultGateway");
+const hubSessionToken_1 = require("../../src/gateway/hubSessionToken");
+const JwtKeyService_1 = require("../../src/services/token/JwtKeyService");
+const PluginContext_1 = require("../../src/PluginContext");
+const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
+const device_managers_1 = require("../../src/device-managers");
+const device_store_1 = require("../../src/data-service/device-store");
+const prisma_store_1 = require("../../src/data-service/prisma-store");
+const SessionManager_1 = require("../../src/sessions/SessionManager");
+const SessionOwnerResolver_1 = require("../../src/services/device-access/SessionOwnerResolver");
+const LiveSessionOwners_1 = require("../../src/services/device-access/LiveSessionOwners");
+const deviceAccessGuard_1 = require("../../src/middleware/deviceAccessGuard");
+const config_1 = require("../../src/config");
+const container_registration_1 = require("../helpers/container-registration");
+const scratch_database_1 = require("../helpers/scratch-database");
+const appium_umbrella_1 = require("../helpers/appium-umbrella");
+/**
+ * Who owns a session the hub created on a node, as the node's own checks see
+ * it: SessionOwnerResolver, behind the /control ownership guard, the logcat
+ * WebSocket and the session listing.
+ *
+ * The node writes no Session row for a hub's session (the hub keeps the
+ * record), so the resolver, which read only rows, found no owner, and the
+ * fail-closed rule refused the device to everyone but admins, its owner
+ * included. The owner the hub's create token named is now known for as long
+ * as the session lives.
+ */
+const quiet = { info: () => undefined, warn: () => undefined, error: () => undefined };
+const NODE_ID = 'node-1';
+describe('the owner of a hub’s session, on the node', function () {
+    this.timeout(60000);
+    const scratch = (0, scratch_database_1.useScratchDatabase)();
+    const servers = [];
+    let dirs;
+    let hubKeys;
+    let appiumLogs;
+    let restore;
+    let saved;
+    let authDisabledBefore;
+    let nodeOrigin;
+    before(() => __awaiter(this, void 0, void 0, function* () {
+        appiumLogs = (0, appium_umbrella_1.quietAppiumLogs)();
+        dirs = [fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'xenon-node-owner-keys-'))];
+        hubKeys = new JwtKeyService_1.JwtKeyService();
+        yield hubKeys.init(dirs[0]);
+    }));
+    after(() => {
+        appiumLogs.restore();
+        for (const dir of dirs)
+            fs_1.default.rmSync(dir, { recursive: true, force: true });
+    });
+    beforeEach(() => __awaiter(this, void 0, void 0, function* () {
+        restore = (0, container_registration_1.saveRegistrations)(JwtKeyService_1.JwtKeyService, hubSessionToken_1.HubSessionTokenIssuer, device_managers_1.XenonManager, SessionOwnerResolver_1.SessionOwnerResolver, LiveSessionOwners_1.LiveSessionOwners);
+        typedi_1.Container.set(JwtKeyService_1.JwtKeyService, hubKeys);
+        typedi_1.Container.set(hubSessionToken_1.HubSessionTokenIssuer, new hubSessionToken_1.HubSessionTokenIssuer());
+        typedi_1.Container.set(SessionOwnerResolver_1.SessionOwnerResolver, new SessionOwnerResolver_1.SessionOwnerResolver());
+        typedi_1.Container.set(LiveSessionOwners_1.LiveSessionOwners, new LiveSessionOwners_1.LiveSessionOwners());
+        typedi_1.Container.set(device_managers_1.XenonManager, {
+            getMaxSessionCount: () => undefined,
+            deviceInstances: () => __awaiter(this, void 0, void 0, function* () { return []; }),
+        });
+        const context = typedi_1.Container.get(PluginContext_1.PluginContext);
+        saved = {
+            store: device_store_1.DeviceStoreFactory._deviceStore,
+            pending: device_store_1.DeviceStoreFactory._pendingSessionStore,
+            context: Object.assign({}, context),
+        };
+        device_store_1.DeviceStoreFactory._deviceStore = new prisma_store_1.PrismaDeviceStore();
+        device_store_1.DeviceStoreFactory._pendingSessionStore = new prisma_store_1.PrismaPendingSessionStore();
+        authDisabledBefore = config_1.config.authDisabled;
+        config_1.config.authDisabled = false;
+        yield scratch.db.pendingSession.deleteMany({});
+        yield scratch.db.session.deleteMany({});
+        yield scratch.db.device.deleteMany({});
+        yield boot();
+    }));
+    afterEach(() => __awaiter(this, void 0, void 0, function* () {
+        for (const s of SessionManager_1.SESSION_MANAGER.getAllSessions())
+            SessionManager_1.SESSION_MANAGER.removeSession(s.getId());
+        device_store_1.DeviceStoreFactory._deviceStore = saved.store;
+        device_store_1.DeviceStoreFactory._pendingSessionStore = saved.pending;
+        Object.assign(typedi_1.Container.get(PluginContext_1.PluginContext), saved.context);
+        config_1.config.authDisabled = authDisabledBefore;
+        sinon_1.default.restore();
+        restore();
+        for (const s of servers.splice(0)) {
+            s.closeAllConnections();
+            yield new Promise((resolve) => http_1.default.Server.prototype.close.call(s, () => resolve()));
+        }
+    }));
+    const port = (s) => s.address().port;
+    function boot() {
+        return __awaiter(this, void 0, void 0, function* () {
+            const baseDriver = (0, appium_umbrella_1.appiumBaseDriver)();
+            const hubServer = yield baseDriver.server({
+                routeConfiguringFunction: baseDriver.routeConfiguringFunction((0, appium_umbrella_1.umbrellaWith)([])),
+                port: 0,
+                hostname: '127.0.0.1',
+                basePath: '/wd/hub',
+                cliArgs: { basePath: '/wd/hub' },
+                serverUpdaters: [
+                    (app) => {
+                        app.get('/xenon/api/auth/jwks.json', (_req, res) => res.json(hubKeys.jwks()));
+                    },
+                ],
+            });
+            servers.push(hubServer);
+            const hubUrl = `http://127.0.0.1:${port(hubServer)}`;
+            const nodeServer = yield baseDriver.server({
+                routeConfiguringFunction: baseDriver.routeConfiguringFunction((0, appium_umbrella_1.umbrellaWith)([[plugin_1.XenonPlugin, 'xenon']])),
+                port: 0,
+                hostname: '127.0.0.1',
+                basePath: '/node',
+                cliArgs: { basePath: '/node' },
+                serverUpdaters: [
+                    (app) => {
+                        (0, registerCommandAuth_1.registerSessionGateway)(app, { basePath: '/node' }, (0, registerCommandAuth_1.commandAuthDeps)({ enabled: () => false, authDisabled: () => false, logger: quiet }), (0, defaultGateway_1.nodeGatewayOptions)(hubUrl));
+                        // The node's /control ownership guard, with a caller named by a header.
+                        const control = express_1.default.Router();
+                        control.use((0, deviceAccessGuard_1.deviceAccessGuard)());
+                        control.post('/:udid/tap', (_req, res) => res.json({ success: true }));
+                        app.use('/control', (req, _res, next) => {
+                            req.auth = { userId: req.headers['x-test-user'], role: 'MEMBER', scopes: 'devices' };
+                            next();
+                        }, control);
+                    },
+                ],
+            });
+            servers.push(nodeServer);
+            nodeOrigin = `http://127.0.0.1:${port(nodeServer)}`;
+            // The node's dashboard is off, as it usually is.
+            typedi_1.Container.get(PluginContext_1.PluginContext).setContext(Object.assign(Object.assign({}, IPluginArgs_1.DefaultPluginArgs), { hub: hubUrl, bindHostOrIp: '127.0.0.1', enableDashboard: false, deviceAvailabilityTimeoutMs: 1000, deviceAvailabilityQueryIntervalMs: 100 }), port(nodeServer), NODE_ID, '/node');
+            yield scratch.db.device.create({
+                data: {
+                    udid: 'phone-1',
+                    host: nodeOrigin,
+                    nodeId: NODE_ID,
+                    platform: 'android',
+                    name: 'phone-1',
+                    sdk: '14',
+                    busy: false,
+                    userBlocked: false,
+                    offline: false,
+                },
+            });
+        });
+    }
+    /** alice's session on phone-1, created as the hub creates it. */
+    function hubSession() {
+        return __awaiter(this, void 0, void 0, function* () {
+            const token = yield typedi_1.Container.get(hubSessionToken_1.HubSessionTokenIssuer).createTokenFor({
+                userId: 'alice',
+                udid: 'phone-1',
+                host: nodeOrigin,
+            });
+            const res = yield (0, loopbackRequest_1.default)(nodeOrigin)
+                .post('/node/session')
+                .set(hubSessionToken_1.HUB_TOKEN_HEADER, token)
+                .send({
+                capabilities: {
+                    alwaysMatch: {
+                        platformName: 'Android',
+                        'appium:automationName': appium_umbrella_1.FAKE_AUTOMATION,
+                        'appium:newCommandTimeout': 0,
+                        'appium:udid': 'phone-1',
+                        'xe:options': { recordVideo: false },
+                    },
+                    firstMatch: [{}],
+                },
+            });
+            (0, chai_1.expect)(res.status, JSON.stringify(res.body)).to.equal(200);
+            return res.body.value.sessionId;
+        });
+    }
+    const tap = (user) => (0, loopbackRequest_1.default)(nodeOrigin).post('/control/phone-1/tap').set('x-test-user', user).send({ x: 1, y: 1 });
+    it('is the owner the hub’s create token named, while the session lives', () => __awaiter(this, void 0, void 0, function* () {
+        const sessionId = yield hubSession();
+        (0, chai_1.expect)(yield scratch.db.session.count(), 'Session rows on the node').to.equal(0);
+        const owners = typedi_1.Container.get(SessionOwnerResolver_1.SessionOwnerResolver);
+        (0, chai_1.expect)(yield owners.ownerOf(sessionId)).to.equal('alice');
+        (0, chai_1.expect)((yield owners.ownersOf([sessionId])).get(sessionId)).to.equal('alice');
+    }));
+    it('lets its owner use the phone on the node, and nobody else', () => __awaiter(this, void 0, void 0, function* () {
+        yield hubSession();
+        const alice = yield tap('alice');
+        (0, chai_1.expect)(alice.status, JSON.stringify(alice.body)).to.equal(200);
+        const bob = yield tap('bob');
+        (0, chai_1.expect)(bob.status).to.equal(409);
+        (0, chai_1.expect)(bob.body.error).to.equal('device_in_use_by_session');
+    }));
+    it('is forgotten when the session ends', () => __awaiter(this, void 0, void 0, function* () {
+        const sessionId = yield hubSession();
+        (0, chai_1.expect)(typedi_1.Container.get(LiveSessionOwners_1.LiveSessionOwners).ownerOf(sessionId)).to.equal('alice');
+        yield (0, loopbackRequest_1.default)(nodeOrigin).delete(`/node/session/${sessionId}`).expect(200);
+        (0, chai_1.expect)(typedi_1.Container.get(LiveSessionOwners_1.LiveSessionOwners).ownerOf(sessionId)).to.equal(undefined);
+    }));
+});

package/lib/test/unit/omni-vision.spec.js

@@ -19,13 +19,16 @@ const typedi_1 = require("typedi");
 const OmniVisionService_1 = require("../../src/services/omni-vision/OmniVisionService");
 const tesseract_js_1 = __importDefault(require("tesseract.js"));
 const AIService_1 = require("../../src/services/AIService");
+const container_registration_1 = require("../helpers/container-registration");
 describe('OmniVisionService Unit Tests', () => {
     let omniService;
     let mockDriver;
+    let restoreContainer;
     beforeEach(() => {
-        // Reset container to ensure clean state
-        typedi_1.Container.reset();
-        omniService = typedi_1.Container.get(OmniVisionService_1.OmniVisionService);
+        // A fresh service for each test, registered only until it ends.
+        restoreContainer = (0, container_registration_1.saveRegistrations)(OmniVisionService_1.OmniVisionService);
+        omniService = new OmniVisionService_1.OmniVisionService();
+        typedi_1.Container.set(OmniVisionService_1.OmniVisionService, omniService);
         mockDriver = {
             getScreenshot: sinon_1.default.stub().resolves('mock_screenshot_base64'),
             sessionId: 'test_session',
@@ -33,6 +36,7 @@ describe('OmniVisionService Unit Tests', () => {
     });
     afterEach(() => {
         sinon_1.default.restore();
+        restoreContainer();
     });
     const createMockWorker = () => ({
         setParameters: sinon_1.default.stub().resolves(),

package/lib/test/unit/plugin.spec.js

@@ -1,4 +1,37 @@
 "use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
     return new (P || (P = Promise))(function (resolve, reject) {
@@ -12,14 +45,21 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const device_utils_1 = require("../../src/device-utils");
 const chai_1 = require("chai");
-const pluginArgs_1 = require("../../src/data-service/pluginArgs");
 const cliArgs_1 = require("../integration/cliArgs");
 const db_1 = require("../../src/data-service/db");
 const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
+const loki_stores_1 = require("../helpers/loki-stores");
 const pluginArgs = IPluginArgs_1.DefaultPluginArgs;
 describe('Device filter tests', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
     it('Get Device filters for real device', () => __awaiter(void 0, void 0, void 0, function* () {
-        yield (0, pluginArgs_1.addCLIArgs)(cliArgs_1.serverCliArgs);
+        // Imported here, not at the top: the module keeps the store it gets when
+        // it loads, and only here is that the in-memory one on a file run alone.
+        const { addCLIArgs } = yield Promise.resolve().then(() => __importStar(require('../../src/data-service/pluginArgs')));
+        yield addCLIArgs(cliArgs_1.serverCliArgs);
         (yield db_1.XenonDatabase.CLIArgs)
             .chain()
             .find()
@@ -111,7 +151,8 @@ describe('Device filter tests', () => {
         });
     });
 });
-describe('Pending sessions', () => __awaiter(void 0, void 0, void 0, function* () {
+describe('Pending sessions', () => {
+    (0, loki_stores_1.useLokiStores)();
     beforeEach(() => __awaiter(void 0, void 0, void 0, function* () {
         (yield db_1.XenonDatabase.PendingSessionsModel).removeDataOnly();
     }));
@@ -131,4 +172,4 @@ describe('Pending sessions', () => __awaiter(void 0, void 0, void 0, function* (
         const pendingSessions = (yield db_1.XenonDatabase.PendingSessionsModel).chain().data();
         (0, chai_1.expect)(pendingSessions.length).to.equal(1);
     }));
-}));
+});

package/lib/test/unit/port-allocator-os-probe.spec.js

@@ -0,0 +1,151 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+require("reflect-metadata");
+const chai_1 = require("chai");
+const net_1 = __importDefault(require("net"));
+const sinon_1 = __importDefault(require("sinon"));
+const PortAllocator_1 = require("../../src/services/PortAllocator");
+const scratch_port_leases_1 = require("../helpers/scratch-port-leases");
+const SHAPES = [
+    { host: '127.0.0.1', label: 'IPv4 loopback (127.0.0.1)' },
+    { host: '::1', label: 'IPv6 loopback (::1)' },
+    { host: '0.0.0.0', label: 'IPv4 wildcard (0.0.0.0)' },
+    { host: '::', label: 'IPv6 wildcard, dual-stack (::) — what iproxy does' },
+    { host: '::', ipv6Only: true, label: 'IPv6 wildcard, v6-only (::)' },
+];
+function listen(port, host, ipv6Only = false) {
+    return new Promise((resolve, reject) => {
+        const server = net_1.default.createServer((socket) => socket.destroy());
+        server.once('error', reject);
+        server.listen({ port, host, ipv6Only }, () => resolve(server));
+    });
+}
+function close(server) {
+    return new Promise((resolve) => server.close(() => resolve()));
+}
+describe('PortAllocator OS probe and lease ownership (real sockets, scratch DB)', () => {
+    const scratch = (0, scratch_port_leases_1.useScratchPortLeases)();
+    let allocator;
+    let servers;
+    beforeEach(() => {
+        allocator = new PortAllocator_1.PortAllocator();
+        allocator.configure({
+            mjpeg: [scratch.base, scratch.base + 1],
+            wda: [scratch.base + 50, scratch.base + 51],
+        });
+        servers = [];
+    });
+    afterEach(() => __awaiter(void 0, void 0, void 0, function* () {
+        yield Promise.all(servers.map(close));
+        sinon_1.default.restore();
+    }));
+    function occupy(port, shape) {
+        return __awaiter(this, void 0, void 0, function* () {
+            servers.push(yield listen(port, shape.host, shape.ipv6Only));
+        });
+    }
+    function leaseOf(port) {
+        return __awaiter(this, void 0, void 0, function* () {
+            return scratch.db.portLease.findUnique({ where: { port } });
+        });
+    }
+    describe('acquire skips a port something is listening on', () => {
+        for (const shape of SHAPES) {
+            it(`a listener on ${shape.label}`, () => __awaiter(void 0, void 0, void 0, function* () {
+                var _a;
+                yield occupy(scratch.base, shape);
+                const port = yield allocator.acquire('mjpeg', 'android-s9');
+                (0, chai_1.expect)(port, `must not lease a port with a listener on ${shape.host}`).to.equal(scratch.base + 1);
+                (0, chai_1.expect)(yield leaseOf(scratch.base)).to.equal(null);
+                (0, chai_1.expect)((_a = (yield leaseOf(scratch.base + 1))) === null || _a === void 0 ? void 0 : _a.leasedToUdid).to.equal('android-s9');
+            }));
+        }
+        it("drops the udid's own stale lease when an iproxy-shaped listener holds the port", () => __awaiter(void 0, void 0, void 0, function* () {
+            // The reuse path: the S9+ still has a lease row on the port while the
+            // iPhone's iproxy is the one listening there.
+            const now = Date.now();
+            yield scratch.db.portLease.create({
+                data: {
+                    port: scratch.base,
+                    purpose: 'mjpeg',
+                    leasedToUdid: 'android-s9',
+                    leasedAt: now,
+                    expiresAt: now + 60000,
+                },
+            });
+            yield occupy(scratch.base, SHAPES[3]);
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            (0, chai_1.expect)(port).to.equal(scratch.base + 1);
+            (0, chai_1.expect)(yield leaseOf(scratch.base)).to.equal(null);
+        }));
+    });
+    it('still leases a port nothing is listening on', () => __awaiter(void 0, void 0, void 0, function* () {
+        const port = yield allocator.acquire('mjpeg', 'android-s9');
+        (0, chai_1.expect)(port).to.equal(scratch.base);
+        const row = yield leaseOf(scratch.base);
+        (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.leasedToUdid).to.equal('android-s9');
+        (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.purpose).to.equal('mjpeg');
+    }));
+    describe('a host without IPv6', () => {
+        it('does not count an IPv6 address it cannot bind as "in use"', () => __awaiter(void 0, void 0, void 0, function* () {
+            const probe = sinon_1.default.stub(allocator, 'bindProbe').callsFake((...args) => __awaiter(void 0, void 0, void 0, function* () {
+                const host = args[1];
+                if (host === '::')
+                    return 'EAFNOSUPPORT';
+                if (host === '::1')
+                    return 'EADDRNOTAVAIL';
+                return null;
+            }));
+            (0, chai_1.expect)(yield allocator.acquire('mjpeg', 'android-s9')).to.equal(scratch.base);
+            const hosts = probe.getCalls().map((c) => c.args[1]);
+            (0, chai_1.expect)(hosts).to.include.members(['127.0.0.1', '0.0.0.0', '::1', '::']);
+        }));
+        it('still counts EADDRINUSE on an IPv6 address as in use', () => __awaiter(void 0, void 0, void 0, function* () {
+            sinon_1.default.stub(allocator, 'bindProbe').callsFake((...args) => __awaiter(void 0, void 0, void 0, function* () {
+                const [port, host] = args;
+                return host === '::' && port === scratch.base ? 'EADDRINUSE' : null;
+            }));
+            (0, chai_1.expect)(yield allocator.acquire('mjpeg', 'android-s9')).to.equal(scratch.base + 1);
+        }));
+    });
+    describe('release is scoped to the lease holder', () => {
+        it("leaves another udid's lease on the same port alone", () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            yield allocator.release(port, 'iphone-17');
+            (0, chai_1.expect)((_a = (yield leaseOf(port))) === null || _a === void 0 ? void 0 : _a.leasedToUdid, 'a stale owner must not free a live lease').to.equal('android-s9');
+        }));
+        it('deletes the lease when the holder releases it', () => __awaiter(void 0, void 0, void 0, function* () {
+            const port = yield allocator.acquire('mjpeg', 'android-s9');
+            yield allocator.release(port, 'android-s9');
+            (0, chai_1.expect)(yield leaseOf(port)).to.equal(null);
+        }));
+    });
+    describe('claim: leasing a port the udid is already serving on', () => {
+        it('leases a port with a live listener, which acquire would refuse', () => __awaiter(void 0, void 0, void 0, function* () {
+            yield occupy(scratch.base + 50, SHAPES[3]);
+            (0, chai_1.expect)(yield allocator.claim('wda', 'iphone-17', scratch.base + 50)).to.equal(true);
+            const row = yield leaseOf(scratch.base + 50);
+            (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.leasedToUdid).to.equal('iphone-17');
+            (0, chai_1.expect)(row === null || row === void 0 ? void 0 : row.purpose).to.equal('wda');
+        }));
+        it("refuses, and keeps the row, when another udid holds the port's lease", () => __awaiter(void 0, void 0, void 0, function* () {
+            var _a;
+            const held = yield allocator.acquire('wda', 'iphone-other');
+            (0, chai_1.expect)(yield allocator.claim('wda', 'iphone-17', held)).to.equal(false);
+            (0, chai_1.expect)((_a = (yield leaseOf(held))) === null || _a === void 0 ? void 0 : _a.leasedToUdid).to.equal('iphone-other');
+        }));
+    });
+});

package/lib/test/unit/profile-router.test.js

@@ -16,7 +16,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const profile_1 = require("../../src/app/routers/profile");
 const typedi_1 = require("typedi");
 const ApiKeyService_1 = require("../../src/services/ApiKeyService");
@@ -34,13 +34,13 @@ describe('profile router', () => {
     it('GET /profile/access-key returns the caller accessKey', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(typedi_1.Container.get(UserService_1.UserService), 'findById').resolves({ accessKey: 'xen_abc' });
         const app = appWithAuth({ userId: 'u1', role: 'ADMIN', scopes: 'devices,sessions,read' });
-        const r = yield (0, supertest_1.default)(app).get('/profile/access-key');
+        const r = yield (0, loopbackRequest_1.default)(app).get('/profile/access-key');
         (0, chai_1.expect)(r.body.accessKey).to.equal('xen_abc');
     }));
     it('POST /profile/access-key/rotate returns a new accessKey', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(typedi_1.Container.get(UserService_1.UserService), 'rotateAccessKey').resolves({ id: 'u1', accessKey: 'xen_NEW' });
         const app = appWithAuth({ userId: 'u1', role: 'ADMIN', scopes: 'devices,sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/access-key/rotate');
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/access-key/rotate');
         (0, chai_1.expect)(r.body.accessKey).to.equal('xen_NEW');
     }));
     it('GET /profile/tokens lists caller tokens without secrets', () => __awaiter(void 0, void 0, void 0, function* () {
@@ -48,7 +48,7 @@ describe('profile router', () => {
             { id: 'k1', name: 'CI', scopes: 'sessions,read', expiresAt: null, createdAt: new Date(), lastUsedAt: null },
         ]);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).get('/profile/tokens');
+        const r = yield (0, loopbackRequest_1.default)(app).get('/profile/tokens');
         (0, chai_1.expect)(r.body[0].name).to.equal('CI');
         (0, chai_1.expect)(r.body[0].keyHash).to.be.undefined;
     }));
@@ -56,14 +56,14 @@ describe('profile router', () => {
         const create = sinon_1.default.stub(typedi_1.Container.get(ApiKeyService_1.ApiKeyService), 'create')
             .resolves({ id: 'k2', raw: 'rawsecret' });
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI' });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI' });
         (0, chai_1.expect)(r.status).to.equal(201);
         (0, chai_1.expect)(r.body.token).to.equal('rawsecret');
         (0, chai_1.expect)(create.firstCall.args[0].scopes).to.deep.equal(['sessions', 'read']);
     }));
     it('POST /profile/tokens rejects an attempt to widen scopes', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', scopes: ['admin'] });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', scopes: ['admin'] });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/cannot widen/);
     }));
@@ -73,7 +73,7 @@ describe('profile router', () => {
             .resolves({ id: 'k3', raw: 'rawsecret' });
         const future = new Date(Date.now() + 30 * 24 * 60 * 60000).toISOString();
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: future });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: future });
         (0, chai_1.expect)(r.status).to.equal(201);
         (0, chai_1.expect)(r.body.expiresAt).to.equal(future);
         (0, chai_1.expect)((_a = create.firstCall.args[0].expiresAt) === null || _a === void 0 ? void 0 : _a.toISOString()).to.equal(future);
@@ -81,13 +81,13 @@ describe('profile router', () => {
     it('POST /profile/tokens rejects a past expiresAt with 400', () => __awaiter(void 0, void 0, void 0, function* () {
         const past = new Date(Date.now() - 60000).toISOString();
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: past });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: past });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/future/);
     }));
     it('POST /profile/tokens rejects an unparseable expiresAt with 400', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: 'not-a-date' });
+        const r = yield (0, loopbackRequest_1.default)(app).post('/profile/tokens').send({ name: 'CI', expiresAt: 'not-a-date' });
         (0, chai_1.expect)(r.status).to.equal(400);
         (0, chai_1.expect)(r.body.error).to.match(/ISO-8601/);
     }));
@@ -95,14 +95,14 @@ describe('profile router', () => {
         sinon_1.default.stub(prisma_1.prisma.apiKey, 'findFirst').resolves({ id: 'k1', userId: 'u1' });
         const revoke = sinon_1.default.stub(typedi_1.Container.get(ApiKeyService_1.ApiKeyService), 'revoke').resolves(undefined);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).delete('/profile/tokens/k1');
+        const r = yield (0, loopbackRequest_1.default)(app).delete('/profile/tokens/k1');
         (0, chai_1.expect)(r.status).to.equal(204);
         (0, chai_1.expect)(revoke.calledOnceWithExactly('k1')).to.be.true;
     }));
     it('DELETE /profile/tokens/:id 404s when the token belongs to someone else', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(prisma_1.prisma.apiKey, 'findFirst').resolves(null);
         const app = appWithAuth({ userId: 'u1', role: 'MEMBER', scopes: 'sessions,read' });
-        const r = yield (0, supertest_1.default)(app).delete('/profile/tokens/k1');
+        const r = yield (0, loopbackRequest_1.default)(app).delete('/profile/tokens/k1');
         (0, chai_1.expect)(r.status).to.equal(404);
     }));
 });

package/lib/test/unit/queue-requester.spec.js

@@ -61,6 +61,7 @@ const IPluginArgs_1 = require("../../src/interfaces/IPluginArgs");
 const config_1 = require("../../src/config");
 const prisma_1 = require("../../src/prisma");
 const container_registration_1 = require("../helpers/container-registration");
+const loki_stores_1 = require("../helpers/loki-stores");
 /**
  * createSession writes who asked onto the pending-session row, so the queue
  * can show a member her own and her team's requests. It goes on that row only:
@@ -79,6 +80,10 @@ const caps = (extra = {}) => ({
 });
 const withKey = (accessKey, extra = {}) => caps(Object.assign({ 'xe:options': { accessKey, token: 'tk' } }, extra));
 describe('createSession records who asked on the pending-session row', () => {
+    // The in-memory stores, also when this file runs on its own: without
+    // NODE_ENV=test the factory handed out the Prisma stores, which are the
+    // developer's ~/.cache/xenon/xenon.db.
+    (0, loki_stores_1.useLokiStores)();
     let svc;
     let device;
     let context;