@xenon-device-management/xenon 1.10.1 → 1.10.2

package/lib/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@xenon-device-management/xenon",
-    "version": "1.10.1",
+    "version": "1.10.2",
     "description": "Xenon - Intelligent Mobile Infrastructure. A self-healing device orchestration platform for Appium.",
     "main": "./lib/src/index.js",
     "exports": {

package/lib/src/device-managers/android/ScrcpyServerSession.js

@@ -45,8 +45,9 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ScrcpyServerSession = exports.SCRCPY_DEVICE_JAR_PATH = void 0;
+exports.ScrcpyServerSession = exports.SCRCPY_CMDLINE_BUDGET = exports.SCRCPY_DEVICE_JAR_PATH = void 0;
 exports.buildScrcpyServerArgs = buildScrcpyServerArgs;
+exports.scrcpyCmdlineLength = scrcpyCmdlineLength;
 exports.scrcpyMaxSizeFromDims = scrcpyMaxSizeFromDims;
 exports.parseAdbForwardPort = parseAdbForwardPort;
 const child_process_1 = require("child_process");
@@ -69,6 +70,17 @@ exports.SCRCPY_DEVICE_JAR_PATH = '/data/local/tmp/scrcpy-server-manual.jar';
  * Arg NAMES verified against the vendored scrcpy 2.7 jar's dex; the version
  * constant and this argv move together (see scrcpyVersion.ts / vendor/README.md).
  * No `scid` → the server listens on `localabstract:scrcpy` (per-device namespace).
+ *
+ * KEEP THIS ARGV SHORT — hard cap enforced below. Samsung's Android 10
+ * libstagefright patch (`ACodec::reconfigEncoder4OtherApps`) copies the
+ * encoder process's cmdline into a fixed ~256-byte stack buffer; if the
+ * app_process command line reaches that length, the copy trips the stack
+ * canary and the server dies at MediaCodec configure with
+ * `stack corruption detected (-fstack-protector)` (SIGABRT). Verified on
+ * SM-G965F/Android 10: identical options stream at ≤248 chars and abort at
+ * ≥267 — the abort depends only on total length, never on which options.
+ * That is why args that merely restate scrcpy 2.7 defaults (`video=true`,
+ * `video_codec=h264`, `cleanup=true`) are omitted rather than spelled out.
  */
 function buildScrcpyServerArgs(opts) {
     return [
@@ -81,8 +93,6 @@ function buildScrcpyServerArgs(opts) {
         'tunnel_forward=true',
         'audio=false',
         'control=false',
-        'video=true',
-        'video_codec=h264',
         `max_size=${opts.maxSize}`,
         'video_bit_rate=4000000',
         'max_fps=30',
@@ -90,9 +100,19 @@ function buildScrcpyServerArgs(opts) {
         'send_codec_meta=false',
         'send_frame_meta=false',
         'send_dummy_byte=true',
-        'cleanup=true',
     ];
 }
+/**
+ * Samsung's buggy cmdline copy (see buildScrcpyServerArgs doc) aborts at
+ * ~256 chars; crash observed at 267, clean at 248. Budget 240 leaves margin
+ * for a wider `max_size` while staying safely under the observed floor.
+ */
+exports.SCRCPY_CMDLINE_BUDGET = 240;
+/** The on-device `app_process …` cmdline length for a built argv (drops the host-side `shell` + CLASSPATH env prefix). */
+function scrcpyCmdlineLength(argv) {
+    const appProcessIdx = argv.indexOf('app_process');
+    return argv.slice(appProcessIdx).join(' ').length;
+}
 /**
  * scrcpy `max_size` caps the device's LONGER edge (single int, aspect preserved).
  * Derive it so the SHORTER edge lands near `targetShortEdge` (matches today's

package/lib/test/unit/scrcpy-server-session.spec.js

@@ -15,8 +15,6 @@ describe('buildScrcpyServerArgs', () => {
             'tunnel_forward=true',
             'audio=false',
             'control=false',
-            'video=true',
-            'video_codec=h264',
             'max_size=1560',
             'video_bit_rate=4000000',
             'max_fps=30',
@@ -24,9 +22,22 @@ describe('buildScrcpyServerArgs', () => {
             'send_codec_meta=false',
             'send_frame_meta=false',
             'send_dummy_byte=true',
-            'cleanup=true',
         ]);
     });
+    it('does not restate scrcpy defaults (video/video_codec/cleanup) — every char counts toward the Samsung cap', () => {
+        const argv = (0, ScrcpyServerSession_1.buildScrcpyServerArgs)({ version: '2.7', jarDevicePath: ScrcpyServerSession_1.SCRCPY_DEVICE_JAR_PATH, maxSize: 1560 });
+        for (const restated of ['video=true', 'video_codec=h264', 'cleanup=true']) {
+            (0, chai_1.expect)(argv, `${restated} restates a scrcpy 2.7 default`).to.not.include(restated);
+        }
+    });
+    it(`keeps the on-device cmdline under the ${ScrcpyServerSession_1.SCRCPY_CMDLINE_BUDGET}-char Samsung stack-buffer budget`, () => {
+        // Samsung Android 10 libstagefright (ACodec::reconfigEncoder4OtherApps) SIGABRTs
+        // when the encoding process's cmdline hits a ~256-byte stack buffer. Observed on
+        // SM-G965F: streams at ≤248 chars, aborts at ≥267. Use the widest realistic
+        // max_size (5 digits) so this guard covers the worst case.
+        const argv = (0, ScrcpyServerSession_1.buildScrcpyServerArgs)({ version: '2.7', jarDevicePath: ScrcpyServerSession_1.SCRCPY_DEVICE_JAR_PATH, maxSize: 99999 });
+        (0, chai_1.expect)((0, ScrcpyServerSession_1.scrcpyCmdlineLength)(argv)).to.be.at.most(ScrcpyServerSession_1.SCRCPY_CMDLINE_BUDGET);
+    });
 });
 describe('scrcpyMaxSizeFromDims', () => {
     it('caps the LONGER edge so the shorter edge lands near the target', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xenon-device-management/xenon",
-  "version": "1.10.1",
+  "version": "1.10.2",
   "description": "Xenon - Intelligent Mobile Infrastructure. A self-healing device orchestration platform for Appium.",
   "main": "./lib/src/index.js",
   "exports": {