@xen-orchestra/rest-api 0.13.1 → 0.15.0

package/dist/pools/pool.controller.mjs

@@ -17,7 +17,7 @@ import { asynchronousActionResp, createdResp, featureUnauthorized, internalServe
 import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs';
 import { AlarmService } from '../alarms/alarm.service.mjs';
 import { genericAlarmsExample } from '../open-api/oa-examples/alarm.oa-example.mjs';
-import { createVm, importVm, partialPools, pool, poolDashboard, poolIds, poolStats, } from '../open-api/oa-examples/pool.oa-example.mjs';
+import { createVm, importVm, partialPools, pool, poolDashboard, poolIds, poolMissingPatches, poolStats, } from '../open-api/oa-examples/pool.oa-example.mjs';
 import { taskLocation } from '../open-api/oa-examples/task.oa-example.mjs';
 import { createNetwork } from '../open-api/oa-examples/schedule.oa-example.mjs';
 import { BASE_URL } from '../index.mjs';
@@ -221,6 +221,14 @@ let PoolController = class PoolController extends XapiXoController {
         });
         return this.sendObjects(Object.values(alarms), req, 'alarms');
     }
+    /**
+     * @example id "355ee47d-ff4c-4924-3db2-fd86ae629676"
+     */
+    async getPoolMissingPatches(id) {
+        const pool = this.getObject(id);
+        const { missingPatches } = await this.#poolService.getMissingPatches(pool.id);
+        return missingPatches;
+    }
 };
 __decorate([
     Example(poolIds),
@@ -335,6 +343,13 @@ __decorate([
     __param(4, Query()),
     __param(5, Query())
 ], PoolController.prototype, "getPoolAlarms", null);
+__decorate([
+    Example(poolMissingPatches),
+    Get('{id}/missing_patches'),
+    Response(notFoundResp.status, notFoundResp.description),
+    Response(featureUnauthorized.status, featureUnauthorized.description),
+    __param(0, Path())
+], PoolController.prototype, "getPoolMissingPatches", null);
 PoolController = __decorate([
     Route('pools'),
     Security('*'),

package/dist/pools/pool.service.mjs

@@ -1,4 +1,5 @@
 import { createLogger } from '@xen-orchestra/log';
+import { featureUnauthorized } from 'xo-common/api-errors.js';
 import { HOST_POWER_STATE, VM_POWER_STATE, } from '@vates/types';
 import { HostService } from '../hosts/host.service.mjs';
 import { VmService } from '../vms/vm.service.mjs';
@@ -45,13 +46,13 @@ export class PoolService {
         const alarms = this.#alarmService.getAlarms({ filter: alarm => alarm.$pool === poolId });
         return Object.keys(alarms);
     }
-    async #getMissingPatches(poolId) {
-        const missingPatchesInfo = await this.#hostService.getMissingPatchesInfo({ filter: host => host.$pool === poolId });
-        if (!missingPatchesInfo.hasAuthorization) {
-            return {
-                hasAuthorization: false,
-            };
-        }
+    /**
+     * Throw if no authorization
+     */
+    async getMissingPatches(poolId) {
+        const missingPatchesInfo = await this.#hostService.getMissingPatchesInfo({
+            filter: host => host.$pool === poolId,
+        });
         const { hasAuthorization, missingPatches } = missingPatchesInfo;
         return {
             hasAuthorization,
@@ -182,7 +183,16 @@ export class PoolService {
             promiseWriteInStream({ maybePromise: this.#getHostsStatus(id), path: 'hosts.status', stream }),
             promiseWriteInStream({ maybePromise: this.#getVmsStatus(id), path: 'vms.status', stream }),
             promiseWriteInStream({ maybePromise: this.#getAlarms(id), path: 'alarms', stream }),
-            promiseWriteInStream({ maybePromise: this.#getMissingPatches(id), path: 'hosts.missingPatches', stream }),
+            promiseWriteInStream({
+                maybePromise: this.getMissingPatches(id).catch(err => {
+                    if (featureUnauthorized.is(err)) {
+                        return { hasAuthorization: false };
+                    }
+                    throw err;
+                }),
+                path: 'hosts.missingPatches',
+                stream,
+            }),
             promiseWriteInStream({ maybePromise: this.#getTopFiveSrsUsage(id), path: 'srs.topFiveUsage', stream }),
             promiseWriteInStream({ maybePromise: this.#getTopFiveHostsRamUsage(id), path: 'hosts.topFiveUsage.ram', stream }),
             promiseWriteInStream({ maybePromise: this.#getTopFiveHostsCpuUsage(id), path: 'hosts.topFiveUsage.cpu', stream }),

package/dist/rest-api/rest-api.mjs

@@ -1,3 +1,6 @@
+import { createLogger } from '@xen-orchestra/log';
+import { invalidCredentials } from 'xo-common/api-errors.js';
+const log = createLogger('xo:rest-api:error-handler');
 export class RestApi {
     #ioc;
     #xoApp;
@@ -17,8 +20,13 @@ export class RestApi {
     authenticateUser(...args) {
         return this.#xoApp.authenticateUser(...args);
     }
-    getCurrentUser() {
-        return this.#xoApp.apiContext.user;
+    getCurrentUser({ throwUnauthenticated = true } = {}) {
+        const user = this.#xoApp.apiContext.user;
+        if (user === undefined && throwUnauthenticated) {
+            log.error('getCurrentUser received an unauthenticated API call');
+            throw invalidCredentials();
+        }
+        return user;
     }
     getObject(id, type) {
         return this.#xoApp.getObject(id, type);

package/dist/tasks/task.controller.mjs

@@ -0,0 +1,121 @@
+var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
+    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
+    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
+    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
+    return c > 3 && r && Object.defineProperty(target, key, r), r;
+};
+var __param = (this && this.__param) || function (paramIndex, decorator) {
+    return function (target, key) { decorator(target, key, paramIndex); }
+};
+import * as CM from 'complex-matcher';
+import { XoController } from '../abstract-classes/xo-controller.mjs';
+import { Get, Path, Query, Request, Route, Security, Tags, Response, Example } from 'tsoa';
+import { badRequestResp, notFoundResp, unauthorizedResp } from '../open-api/common/response.common.mjs';
+import { provide } from 'inversify-binding-decorators';
+import { partialTasks, task, taskIds } from '../open-api/oa-examples/task.oa-example.mjs';
+import pDefer from 'promise-toolbox/defer';
+import { ApiError } from '../helpers/error.helper.mjs';
+import { Transform } from 'node:stream';
+import { makeObjectMapper } from '../helpers/object-wrapper.helper.mjs';
+let TaskController = class TaskController extends XoController {
+    async getAllCollectionObjects() {
+        const result = [];
+        for await (const task of this.restApi.tasks.list()) {
+            result.push(task);
+        }
+        return result;
+    }
+    getCollectionObject(id) {
+        return this.restApi.tasks.get(id);
+    }
+    /**
+     *
+     * If watch is true, ndjson must also be true
+     *
+     * @example fields "status,id,properties"
+     * @example filter "status:failure"
+     * @example limit 42
+     */
+    async getTasks(req, fields, ndjson, watch, filter, limit) {
+        if (watch) {
+            if (!ndjson) {
+                throw new ApiError('watch=true requires ndjson=true', 400);
+            }
+            const userFilter = filter === undefined ? undefined : CM.parse(filter).createPredicate();
+            const stream = new Transform({
+                objectMode: true,
+                transform([event, object], encoding, callback) {
+                    const mapper = makeObjectMapper(req);
+                    callback(null, JSON.stringify([event, mapper(object)]) + '\n');
+                },
+            });
+            stream.on('close', () => {
+                this.restApi.tasks.off('update', update).off('remove', remove);
+            });
+            req.on('close', () => {
+                stream.destroy();
+            });
+            process.on('SIGTERM', () => {
+                req.destroy();
+            });
+            function update(task) {
+                if (userFilter === undefined || userFilter(task)) {
+                    stream.write(['update', task]);
+                }
+            }
+            function remove(taskId) {
+                stream.write(['remove', { id: taskId }]);
+            }
+            this.restApi.tasks.on('update', update).on('remove', remove);
+            return stream;
+        }
+        const tasks = Object.values(await this.getObjects({ filter, limit }));
+        return this.sendObjects(tasks, req);
+    }
+    /**
+     * @example id "0mdd1basu"
+     */
+    async getTask(req, id, wait) {
+        const taskId = id;
+        if (wait) {
+            const { promise, resolve } = pDefer();
+            const stopWatch = await this.restApi.tasks.watch(taskId, task => {
+                if (task.status !== 'pending') {
+                    stopWatch();
+                    resolve(task);
+                }
+            });
+            req.on('close', stopWatch);
+            return promise;
+        }
+        return this.getObject(taskId);
+    }
+};
+__decorate([
+    Example(taskIds),
+    Example(partialTasks),
+    Get(''),
+    Response(badRequestResp.status, badRequestResp.description),
+    __param(0, Request()),
+    __param(1, Query()),
+    __param(2, Query()),
+    __param(3, Query()),
+    __param(4, Query()),
+    __param(5, Query())
+], TaskController.prototype, "getTasks", null);
+__decorate([
+    Example(task),
+    Get('{id}'),
+    Response(notFoundResp.status, notFoundResp.description),
+    __param(0, Request()),
+    __param(1, Path()),
+    __param(2, Query())
+], TaskController.prototype, "getTask", null);
+TaskController = __decorate([
+    Route('tasks'),
+    Security('*'),
+    Response(unauthorizedResp.status, unauthorizedResp.description),
+    Tags('tasks'),
+    provide(TaskController)
+], TaskController);
+export { TaskController };

package/dist/users/user.controller.mjs

@@ -57,9 +57,6 @@ let UserController = class UserController extends XoController {
      */
     async updateUser(id, body) {
         const currentUser = this.restApi.getCurrentUser();
-        if (currentUser === undefined) {
-            throw new Error('current user is not defined');
-        }
         const isAdmin = currentUser.permission === 'admin';
         if (isAdmin) {
             if (body.permission !== undefined && currentUser.id === id) {

package/dist/vm-controller/vm-controller.controller.mjs

@@ -12,16 +12,19 @@ import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs';
 import { RestApi } from '../rest-api/rest-api.mjs';
 import { Example, Get, Path, Query, Request, Response, Route, Security, Tags } from 'tsoa';
 import { AlarmService } from '../alarms/alarm.service.mjs';
-import { escapeUnsafeComplexMatcher } from '../helpers/utils.helper.mjs';
+import { escapeUnsafeComplexMatcher, limitAndFilterArray } from '../helpers/utils.helper.mjs';
 import { genericAlarmsExample } from '../open-api/oa-examples/alarm.oa-example.mjs';
 import { notFoundResp, unauthorizedResp } from '../open-api/common/response.common.mjs';
 import { provide } from 'inversify-binding-decorators';
-import { partialVmControllers, vmController, vmControllerIds, } from '../open-api/oa-examples/vm-controller.oa-example.mjs';
+import { partialVmControllers, vmController, vmControllerIds, vmControllerVdis, } from '../open-api/oa-examples/vm-controller.oa-example.mjs';
+import { VmService } from '../vms/vm.service.mjs';
 let VmControllerController = class VmControllerController extends XapiXoController {
     #alarmService;
-    constructor(restApi, alarmService) {
+    #vmService;
+    constructor(restApi, alarmService, vmService) {
         super('VM-controller', restApi);
         this.#alarmService = alarmService;
+        this.#vmService = vmService;
     }
     /**
      *
@@ -52,6 +55,16 @@ let VmControllerController = class VmControllerController extends XapiXoControll
         });
         return this.sendObjects(Object.values(alarms), req, 'alarms');
     }
+    /**
+     * @example id "9b4775bd-9493-490a-9afa-f786a44caa4f"
+     * @example fields "VDI_type,id,name_label"
+     * @example filter "VDI_type:user"
+     * @example limit 42
+     */
+    getVmControllerVdis(req, id, fields, ndjson, filter, limit) {
+        const vdis = this.#vmService.getVmVdis(id, 'VM-controller');
+        return this.sendObjects(limitAndFilterArray(vdis, { filter, limit }), req, obj => obj.type.toLowerCase() + 's');
+    }
 };
 __decorate([
     Example(vmControllerIds),
@@ -81,6 +94,18 @@ __decorate([
     __param(4, Query()),
     __param(5, Query())
 ], VmControllerController.prototype, "getVmControllerAlarms", null);
+__decorate([
+    Example(vmControllerVdis),
+    Get('{id}/vdis'),
+    Tags('vdis'),
+    Response(notFoundResp.status, notFoundResp.description),
+    __param(0, Request()),
+    __param(1, Path()),
+    __param(2, Query()),
+    __param(3, Query()),
+    __param(4, Query()),
+    __param(5, Query())
+], VmControllerController.prototype, "getVmControllerVdis", null);
 VmControllerController = __decorate([
     Route('vm-controllers'),
     Security('*'),
@@ -88,6 +113,7 @@ VmControllerController = __decorate([
     Tags('vms'),
     provide(VmControllerController),
     __param(0, inject(RestApi)),
-    __param(1, inject(AlarmService))
+    __param(1, inject(AlarmService)),
+    __param(2, inject(VmService))
 ], VmControllerController);
 export { VmControllerController };

package/dist/vm-snapshots/vm-snapshot.controller.mjs

@@ -10,18 +10,21 @@ var __param = (this && this.__param) || function (paramIndex, decorator) {
 import { Example, Get, Path, Query, Request, Response, Route, Security, Tags } from 'tsoa';
 import { inject } from 'inversify';
 import { AlarmService } from '../alarms/alarm.service.mjs';
-import { escapeUnsafeComplexMatcher } from '../helpers/utils.helper.mjs';
+import { escapeUnsafeComplexMatcher, limitAndFilterArray } from '../helpers/utils.helper.mjs';
 import { genericAlarmsExample } from '../open-api/oa-examples/alarm.oa-example.mjs';
 import { notFoundResp, unauthorizedResp } from '../open-api/common/response.common.mjs';
 import { RestApi } from '../rest-api/rest-api.mjs';
 import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs';
 import { provide } from 'inversify-binding-decorators';
-import { partialVmSnapshots, vmSnapshot, vmSnapshotIds } from '../open-api/oa-examples/vm-snapshot.oa-example.mjs';
+import { partialVmSnapshots, vmSnapshot, vmSnapshotIds, vmSnapshotVdis, } from '../open-api/oa-examples/vm-snapshot.oa-example.mjs';
+import { VmService } from '../vms/vm.service.mjs';
 let VmSnapshotController = class VmSnapshotController extends XapiXoController {
     #alarmService;
-    constructor(restApi, alarmService) {
+    #vmService;
+    constructor(restApi, alarmService, vmService) {
         super('VM-snapshot', restApi);
         this.#alarmService = alarmService;
+        this.#vmService = vmService;
     }
     /**
      *
@@ -52,6 +55,16 @@ let VmSnapshotController = class VmSnapshotController extends XapiXoController {
         });
         return this.sendObjects(Object.values(alarms), req, 'alarms');
     }
+    /**
+     * @example id "d68fca2c-41e6-be87-d790-105c1642a090"
+     * @example fields "VDI_type,id,name_label"
+     * @example filter "VDI_type:user"
+     * @example limit 42
+     */
+    getVmSnapshotVdis(req, id, fields, ndjson, filter, limit) {
+        const vdis = this.#vmService.getVmVdis(id, 'VM-snapshot');
+        return this.sendObjects(limitAndFilterArray(vdis, { filter, limit }), req, obj => obj.type.toLowerCase() + 's');
+    }
 };
 __decorate([
     Example(vmSnapshotIds),
@@ -81,6 +94,18 @@ __decorate([
     __param(4, Query()),
     __param(5, Query())
 ], VmSnapshotController.prototype, "getVmSnapshotAlarms", null);
+__decorate([
+    Example(vmSnapshotVdis),
+    Get('{id}/vdis'),
+    Tags('vdis'),
+    Response(notFoundResp.status, notFoundResp.description),
+    __param(0, Request()),
+    __param(1, Path()),
+    __param(2, Query()),
+    __param(3, Query()),
+    __param(4, Query()),
+    __param(5, Query())
+], VmSnapshotController.prototype, "getVmSnapshotVdis", null);
 VmSnapshotController = __decorate([
     Route('vm-snapshots'),
     Security('*'),
@@ -88,6 +113,7 @@ VmSnapshotController = __decorate([
     Tags('vms'),
     provide(VmSnapshotController),
     __param(0, inject(RestApi)),
-    __param(1, inject(AlarmService))
+    __param(1, inject(AlarmService)),
+    __param(2, inject(VmService))
 ], VmSnapshotController);
 export { VmSnapshotController };

package/dist/vm-templates/vm-template.controller.mjs

@@ -11,17 +11,20 @@ import { Example, Get, Security, Query, Request, Response, Route, Tags, Path } f
 import { inject } from 'inversify';
 import { provide } from 'inversify-binding-decorators';
 import { AlarmService } from '../alarms/alarm.service.mjs';
-import { escapeUnsafeComplexMatcher } from '../helpers/utils.helper.mjs';
+import { escapeUnsafeComplexMatcher, limitAndFilterArray } from '../helpers/utils.helper.mjs';
 import { genericAlarmsExample } from '../open-api/oa-examples/alarm.oa-example.mjs';
 import { notFoundResp, unauthorizedResp } from '../open-api/common/response.common.mjs';
 import { RestApi } from '../rest-api/rest-api.mjs';
 import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs';
-import { partialVmTemplates, vmTemplate, vmTemplateIds } from '../open-api/oa-examples/vm-template.oa-example.mjs';
+import { partialVmTemplates, vmTemplate, vmTemplateIds, vmTemplateVdis, } from '../open-api/oa-examples/vm-template.oa-example.mjs';
+import { VmService } from '../vms/vm.service.mjs';
 let VmTemplateController = class VmTemplateController extends XapiXoController {
     #alarmService;
-    constructor(restApi, alarmService) {
+    #vmService;
+    constructor(restApi, alarmService, vmService) {
         super('VM-template', restApi);
         this.#alarmService = alarmService;
+        this.#vmService = vmService;
     }
     /**
      * @example fields "id,isDefaultTemplate,name_label"
@@ -51,6 +54,16 @@ let VmTemplateController = class VmTemplateController extends XapiXoController {
         });
         return this.sendObjects(Object.values(alarms), req, 'alarms');
     }
+    /**
+     * @example id "6d50ba76-0f11-1ff1-4f6a-b502afc31b8e"
+     * @example fields "VDI_type,id,name_label"
+     * @example filter "VDI_type:user"
+     * @example limit 42
+     */
+    getVmTemplateVdis(req, id, fields, ndjson, filter, limit) {
+        const vdis = this.#vmService.getVmVdis(id, 'VM-template');
+        return this.sendObjects(limitAndFilterArray(vdis, { filter, limit }), req, obj => obj.type.toLowerCase() + 's');
+    }
 };
 __decorate([
     Example(vmTemplateIds),
@@ -80,6 +93,18 @@ __decorate([
     __param(4, Query()),
     __param(5, Query())
 ], VmTemplateController.prototype, "getVmTemplateAlarms", null);
+__decorate([
+    Example(vmTemplateVdis),
+    Get('{id}/vdis'),
+    Tags('vdis'),
+    Response(notFoundResp.status, notFoundResp.description),
+    __param(0, Request()),
+    __param(1, Path()),
+    __param(2, Query()),
+    __param(3, Query()),
+    __param(4, Query()),
+    __param(5, Query())
+], VmTemplateController.prototype, "getVmTemplateVdis", null);
 VmTemplateController = __decorate([
     Route('vm-templates'),
     Security('*'),
@@ -87,6 +112,7 @@ VmTemplateController = __decorate([
     Tags('vms'),
     provide(VmTemplateController),
     __param(0, inject(RestApi)),
-    __param(1, inject(AlarmService))
+    __param(1, inject(AlarmService)),
+    __param(2, inject(VmService))
 ], VmTemplateController);
 export { VmTemplateController };

package/dist/vms/vm.controller.mjs

@@ -14,18 +14,21 @@ import { provide } from 'inversify-binding-decorators';
 import { AlarmService } from '../alarms/alarm.service.mjs';
 import { asynchronousActionResp, createdResp, internalServerErrorResp, noContentResp, notFoundResp, unauthorizedResp, } from '../open-api/common/response.common.mjs';
 import { BASE_URL } from '../index.mjs';
-import { escapeUnsafeComplexMatcher } from '../helpers/utils.helper.mjs';
+import { escapeUnsafeComplexMatcher, limitAndFilterArray } from '../helpers/utils.helper.mjs';
 import { genericAlarmsExample } from '../open-api/oa-examples/alarm.oa-example.mjs';
-import { partialVms, vm, vmIds, vmStatsExample } from '../open-api/oa-examples/vm.oa-example.mjs';
+import { partialVms, vm, vmIds, vmStatsExample, vmVdis } from '../open-api/oa-examples/vm.oa-example.mjs';
 import { RestApi } from '../rest-api/rest-api.mjs';
 import { taskLocation } from '../open-api/oa-examples/task.oa-example.mjs';
 import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs';
+import { VmService } from './vm.service.mjs';
 const IGNORED_VDIS_TAG = '[NOSNAP]';
 let VmController = class VmController extends XapiXoController {
     #alarmService;
-    constructor(restApi, alarmService) {
+    #vmService;
+    constructor(restApi, alarmService, vmService) {
         super('VM', restApi);
         this.#alarmService = alarmService;
+        this.#vmService = vmService;
     }
     /**
      *
@@ -313,6 +316,16 @@ let VmController = class VmController extends XapiXoController {
         });
         return this.sendObjects(Object.values(alarms), req, 'alarms');
     }
+    /**
+     * @example id "f07ab729-c0e8-721c-45ec-f11276377030"
+     * @example fields "VDI_type,id,name_label"
+     * @example filter "VDI_type:user"
+     * @example limit 42
+     */
+    getVmVdis(req, id, fields, ndjson, filter, limit) {
+        const vdis = this.#vmService.getVmVdis(id, 'VM');
+        return this.sendObjects(limitAndFilterArray(vdis, { filter, limit }), req, obj => obj.type.toLowerCase() + 's');
+    }
 };
 __decorate([
     Example(vmIds),
@@ -464,6 +477,18 @@ __decorate([
     __param(4, Query()),
     __param(5, Query())
 ], VmController.prototype, "getVmAlarms", null);
+__decorate([
+    Example(vmVdis),
+    Get('{id}/vdis'),
+    Tags('vdis'),
+    Response(notFoundResp.status, notFoundResp.description),
+    __param(0, Request()),
+    __param(1, Path()),
+    __param(2, Query()),
+    __param(3, Query()),
+    __param(4, Query()),
+    __param(5, Query())
+], VmController.prototype, "getVmVdis", null);
 VmController = __decorate([
     Route('vms'),
     Security('*'),
@@ -474,6 +499,7 @@ VmController = __decorate([
     ,
     provide(VmController),
     __param(0, inject(RestApi)),
-    __param(1, inject(AlarmService))
+    __param(1, inject(AlarmService)),
+    __param(2, inject(VmService))
 ], VmController);
 export { VmController };

package/dist/vms/vm.service.mjs

@@ -13,7 +13,7 @@ export class VmService {
         const xoApp = this.#restApi.xoApp;
         const xapi = xoApp.getXapi(pool);
         const currentUser = this.#restApi.getCurrentUser();
-        const xapiVm = await xapi.createVm(template, rest, undefined, currentUser?.id);
+        const xapiVm = await xapi.createVm(template, rest, undefined, currentUser.id);
         $defer.onFailure(() => xapi.VM_destroy(xapiVm.$ref));
         const xoVm = this.#restApi.getObject(xapiVm.uuid, 'VM');
         let cloudConfigVdi;
@@ -84,4 +84,17 @@ export class VmService {
             total,
         };
     }
+    getVmVdis(id, vmType) {
+        const getObject = this.#restApi.getObject.bind(this.#restApi);
+        const vdis = [];
+        const vm = getObject(id, vmType);
+        for (const vbdId of vm.$VBDs) {
+            const vbd = getObject(vbdId, 'VBD');
+            if (vbd.VDI !== undefined) {
+                const vdi = getObject(vbd.VDI, ['VDI-snapshot', 'VDI']);
+                vdis.push(vdi);
+            }
+        }
+        return vdis;
+    }
 }

package/dist/xoa/xoa.service.mjs

@@ -1,4 +1,5 @@
 import groupBy from 'lodash/groupBy.js';
+import { featureUnauthorized } from 'xo-common/api-errors.js';
 import semver from 'semver';
 import { BACKUP_TYPE, VM_POWER_STATE, } from '@vates/types';
 import { createLogger } from '@xen-orchestra/log';
@@ -167,11 +168,11 @@ export class XoaService {
         }
         return nHostsEol;
     }
+    /**
+     * Throw if no authorization
+     */
     async #getMissingPatchesInfo() {
         const missingPatchesInfo = await this.#hostService.getMissingPatchesInfo();
-        if (!missingPatchesInfo.hasAuthorization) {
-            return { hasAuthorization: false };
-        }
         const { hasAuthorization, nHostsFailed, nHostsWithMissingPatches, nPoolsWithMissingPatches } = missingPatchesInfo;
         return {
             hasAuthorization,
@@ -437,7 +438,16 @@ export class XoaService {
                 handleError: true,
             }),
             promiseWriteInStream({ maybePromise: this.#getPoolsStatus(), path: 'poolsStatus', stream }),
-            promiseWriteInStream({ maybePromise: this.#getMissingPatchesInfo(), path: 'missingPatches', stream }),
+            promiseWriteInStream({
+                maybePromise: this.#getMissingPatchesInfo().catch(err => {
+                    if (featureUnauthorized.is(err)) {
+                        return { hasAuthorization: false };
+                    }
+                    throw err;
+                }),
+                path: 'missingPatches',
+                stream,
+            }),
             promiseWriteInStream({
                 maybePromise: this.#getBackupRepositoriesSizeInfo(),
                 path: 'backupRepositories',