@xen-orchestra/backups 0.69.2 → 0.69.4

package/_runners/_vmRunners/_AbstractXapi.mjs

@@ -310,6 +310,7 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
       // if not => remove it from the list to ensure we won't half destroy VM later
       vm.$VBDs
         .filter(({ $VDI }) => !!$VDI) // filter missing keys
+        .filter(({ $VDI }) => $VDI.$snapshot_of !== undefined) // skip non-snapshot VDIs (e.g., ISOs/CD-ROMs)
         .filter(({ $VDI }) => $VDI && vdiCandidates[$VDI.uuid] === undefined)
         .forEach(({ $VDI: outOfSnapshotsVdi, ...other }) => {
           warn(

package/disks/MergeRemoteDisk.mjs

@@ -190,6 +190,7 @@ export class MergeRemoteDisk {
    */
   async #step_mergeBlocks(parentDisk, childDisk) {
     const getMaxBlockCount = childDisk.getMaxBlockCount()
+    await parentDisk.resize(getMaxBlockCount)
 
     if (this.#isResuming) {
       const alreadyMergedBlocks = []

package/disks/RemoteDisk.mjs

@@ -72,11 +72,10 @@ export class RemoteDisk extends RandomAccessDisk {
   }
 
   /**
-   * Abstract
    * @returns {number} getMaxBlockCount
    */
   getMaxBlockCount() {
-    throw new Error(`getMaxBlockCount must be implemented`)
+    return Math.ceil(this.getVirtualSize() / this.getBlockSize())
   }
 
   /**
@@ -148,6 +147,15 @@ export class RemoteDisk extends RandomAccessDisk {
     throw new Error(`setAllocatedBlocks must be implemented`)
   }
 
+  /**
+   * Abstract
+   * @param {number} blockCount
+   * @returns {Promise<void>}
+   */
+  async resize(blockCount) {
+    throw new Error(`resize must be implemented`)
+  }
+
   /**
    * Abstract
    * @param {RemoteDisk} childDisk

package/disks/RemoteVhdDisk.mjs

@@ -165,17 +165,6 @@ export class RemoteVhdDisk extends RemoteDisk {
     return await this.isDirectory()
   }
 
-  /**
-   * @returns {number} getMaxBlockCount
-   */
-  getMaxBlockCount() {
-    if (this.#vhd === undefined) {
-      throw new Error(`can't call getMaxBlockCount of a RemoteVhdDisk before init`)
-    }
-
-    return this.#vhd.header.maxTableEntries
-  }
-
   /**
    * Checks if the VHD contains a specific block.
    * @param {number} index
@@ -327,6 +316,20 @@ export class RemoteVhdDisk extends RemoteDisk {
     }
   }
 
+  /**
+   * Ensure that the disk can handle at least the new block count.
+   * @param {number} blockCount
+   * @returns {Promise<void>}
+   */
+  async resize(blockCount) {
+    if (this.#vhd === undefined) {
+      throw new Error(`can't call resize of a RemoteVhdDisk before init`)
+    }
+
+    // Checks that the BAT is at least as big as the provided block count, if not, increases it and shift the blocks position
+    await this.#vhd.ensureBatSize(blockCount)
+  }
+
   /**
    * Writes Block Allocation Table
    * @param {RemoteDisk} childDisk

package/package.json

@@ -8,7 +8,7 @@
     "type": "git",
     "url": "https://github.com/vatesfr/xen-orchestra.git"
   },
-  "version": "0.69.2",
+  "version": "0.69.4",
   "engines": {
     "node": ">=14.18"
   },