@xemahq/repo-build-tooling 0.8.0 → 0.8.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xemahq/repo-build-tooling",
-  "version": "0.8.0",
+  "version": "0.8.2",
   "description": "Dev-time build tooling shared by every Xema repository. Ships as plain ESM with zero dependencies so the published artifact is the reviewed source.",
   "license": "Apache-2.0",
   "author": "Neuralchowder Inc. <developer@xema.dev> (https://xema.dev)",

package/src/readiness.mjs

@@ -62,7 +62,8 @@
  * honestly.
  */
 import { execFileSync } from 'node:child_process';
-import { existsSync, readdirSync, readFileSync, realpathSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import { existsSync, readdirSync, readFileSync, realpathSync, rmSync } from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import process from 'node:process';
@@ -228,6 +229,38 @@ function exportsNamedByRefusal(output) {
   return [...named];
 }
 
+/** Tracked-or-untracked paths under `dir` git reports as dirty, as a Set of `XY path` lines. */
+function trackedDirtyPaths(dir) {
+  try {
+    return new Set(
+      sh(['git', 'status', '--porcelain', '--untracked-files=all', '--', dir], { capture: true })
+        .split('\n')
+        .filter(Boolean),
+    );
+  } catch {
+    return new Set(); // not a git checkout: nothing can be restored, and nothing is claimed
+  }
+}
+
+/**
+ * Put back what a refused regeneration wrote: every path under `packages/clients`
+ * that is dirty NOW and was not dirty BEFORE the attempt. Tracked files return
+ * to HEAD; files the refusal created are removed. Nothing that was already
+ * dirty before the attempt is touched — that is somebody's in-flight work.
+ */
+export function newlyDirtyPaths(before, after) {
+  return [...after].filter((line) => !before.has(line));
+}
+
+function restoreWhatTheRefusalWrote(dirtyBefore) {
+  const lines = newlyDirtyPaths(dirtyBefore, trackedDirtyPaths('packages/clients'));
+  const created = lines.filter((l) => l.startsWith('??')).map((l) => l.slice(3));
+  const modified = lines.filter((l) => !l.startsWith('??')).map((l) => l.slice(3));
+  if (modified.length > 0) sh(['git', 'checkout', '--', ...modified], { capture: true });
+  for (const rel of created) rmSync(path.join(ROOT, rel), { force: true });
+  return [...modified, ...created];
+}
+
 function sh(argv, { capture = false, env } = {}) {
   return execFileSync(argv[0], argv.slice(1), {
     cwd: ROOT,
@@ -252,6 +285,13 @@ function servicesWith(script) {
   }
   const names = [];
   for (const entry of Array.isArray(parsed) ? parsed : [parsed]) {
+    // The ROOT is not a service. A root `client:generate: turbo run
+    // client:generate` is an AGGREGATE over every service, so running it here
+    // regenerates all of them at once, turbo-prefixes the one refusal that
+    // matters, and then applies a recorded decision to services it was never
+    // recorded for. Measured 2026-09-20 in xema-community. The per-service
+    // loop below is the whole point: a failure NAMES the service.
+    if (path.resolve(entry.path ?? '') === ROOT) continue;
     const manifest = path.join(entry.path ?? '', 'package.json');
     if (!existsSync(manifest)) continue;
     try {
@@ -399,10 +439,18 @@ export function packagesOwningPaths(root, relPaths, script = 'test') {
  *                     REPO-WIDE, labelled, because skipping would drop a proof.
  *   - `inapplicable`— nothing declares it. Genuinely nothing to run.
  */
-export function affectedStagePlan({ base, paths, packages, rootDeclares }) {
-  if (!base) return { mode: 'workspace', viaRoot: rootDeclares };
+export function affectedStagePlan({ base, paths, packages, rootDeclares, membersDeclare }) {
+  // REPO-WIDE means WHAT CI RUNS, and every CI in this fleet runs the stage as
+  // `pnpm -r --if-present run <script>` — per member, never the root script.
+  // Measured 2026-09-20 in xema-kernel-sdk: the root `lint` is `eslint .`,
+  // which also lints `tooling/**` and re-lints every package under the ROOT
+  // config, and reports 139 errors CI has never seen. Running it here made
+  // readiness a SECOND lint authority that disagreed with the first. The root
+  // script is used only where no member declares the stage at all.
+  if (!base) return { mode: 'workspace', viaRoot: rootDeclares && !membersDeclare };
   if (packages.length > 0) return { mode: 'affected', packages };
-  if (paths.length > 0 && rootDeclares) return { mode: 'root' };
+  if (paths.length > 0 && rootDeclares && !membersDeclare) return { mode: 'root' };
+  if (paths.length > 0 && membersDeclare) return { mode: 'workspace', viaRoot: false };
   return { mode: 'inapplicable' };
 }
 
@@ -415,6 +463,7 @@ function runAffectedStage({ id, script, why }) {
     paths,
     packages,
     rootDeclares: Boolean(scripts[script]),
+    membersDeclare: servicesWith(script).length > 0,
   });
   switch (plan.mode) {
     case 'workspace':
@@ -442,10 +491,9 @@ function runAffectedStage({ id, script, why }) {
       return;
     case 'root':
       // FALLBACK, and it is the difference between "inapplicable" and "not
-      // checked". Some repositories own a stage only at the root — `lint:
-      // eslint .` covers every package without any of them declaring `lint`.
-      // Skipping there would silently drop a real proof, so the root script
-      // runs, LABELLED as repo-wide rather than affected.
+      // checked": a repository that owns a stage ONLY at the root (no member
+      // declares it). Skipping there would silently drop a real proof, so the
+      // root script runs, LABELLED as repo-wide rather than affected.
       console.log(
         `  ${paths.length} changed path(s) since ${base.slice(0, 9)}; no changed` +
           ` package declares \`${script}\`, but the ROOT does — running it\n` +
@@ -497,8 +545,34 @@ function runReleaseReadiness() {
     );
     return;
   }
-  console.log('  delegating to `pnpm verify:release-readiness` — the checker CI runs');
-  sh(['pnpm', 'run', 'verify:release-readiness']);
+  // This runs BEFORE the commit, over the clients and ledgers the stages above
+  // just regenerated — so the checker's committed-tree refusal would report
+  // every package this run touched as NOT JUDGED, i.e. red exactly when
+  // readiness did its job. `--check --working-tree` (release-policy >= 12.2.0)
+  // grades the bytes the next commit would pack; an older checker is called
+  // without it and says so, rather than being passed a flag it refuses.
+  const flag = releasePolicySupportsWorkingTree() ? ['--working-tree'] : [];
+  console.log(
+    `  delegating to \`pnpm verify:release-readiness${flag.length ? ' --working-tree' : ''}\` — the checker CI runs` +
+      (flag.length
+        ? ''
+        : '\n  (the installed @xemahq/release-policy predates --working-tree; packages this run\n' +
+          '  regenerated will read NOT JUDGED until they are committed — raise it to >=12.2.0)'),
+  );
+  sh(['pnpm', 'run', 'verify:release-readiness', ...flag]);
+}
+
+/** Does the checker this repository resolves accept `--check --working-tree`? Added in 12.2.0. */
+function releasePolicySupportsWorkingTree() {
+  try {
+    const manifest = createRequire(path.join(ROOT, 'package.json')).resolve(
+      '@xemahq/release-policy/package.json',
+    );
+    const [major, minor] = JSON.parse(readFileSync(manifest, 'utf8')).version.split('.').map(Number);
+    return major > 12 || (major === 12 && minor >= 2);
+  } catch {
+    return false;
+  }
 }
 
 function run() {
@@ -575,6 +649,7 @@ function run() {
     for (const name of services) {
       // One at a time on purpose: a failure must name the service, and a single
       // `--filter a --filter b` invocation reports only the first.
+      const dirtyBefore = trackedDirtyPaths('packages/clients');
       try {
         sh(['pnpm', '--filter', name, step.perService]);
       } catch (error) {
@@ -612,6 +687,20 @@ function run() {
           throw error;
         }
 
+        // The refused run may have REGENERATED before it refused — every
+        // `@xemahq/api-client-generator` below 1.0.2 does — and a re-run over
+        // the regenerated bytes compares them with themselves, holds the
+        // version line, and leaves changed client bytes under a served
+        // version. Measured 2026-09-20 in xema-operator and xema-store-api. So
+        // what the refusal wrote is put back to the committed bytes first; a
+        // refused run has produced nothing worth keeping.
+        const written = restoreWhatTheRefusalWrote(dirtyBefore);
+        if (written.length > 0) {
+          console.log(
+            `  ${name}: the refused run had already written ${written.length} client file(s); ` +
+              'restored to the committed bytes so the re-run sees the real change',
+          );
+        }
         // Not a retry loop: ONE re-run, driven by recorded data rather than by hope,
         // for a refusal whose every subject is already decided.
         console.log(
@@ -696,6 +785,14 @@ try {
     // imported for its exports; nothing to do
   } else process.exit(run());
 } catch (error) {
+  // `sh` PIPES stderr so a generator refusal can be matched against a recorded
+  // decision — which means a failing stage's own explanation never reached the
+  // terminal. Measured 2026-09-20: `verify:release-readiness` refused a
+  // first-party override with a full paragraph naming the package and the
+  // remedy, and this report showed only "Command failed: pnpm run
+  // verify:release-readiness". The captured text is re-emitted here, whole.
+  const captured = typeof error?.stderr === 'string' ? error.stderr.trim() : '';
+  if (captured.length > 0) console.error(`\n${captured}\n`);
   console.error(
     `\nreadiness: FAILED at the step above. That is the ROOT cause — the steps after it\n` +
       'were not reached, so do not read their absence as a second failure.\n' +

package/src/readiness.test.mjs

@@ -4,7 +4,7 @@ import os from 'node:os';
 import path from 'node:path';
 import test from 'node:test';
 
-import { affectedStagePlan, invokedDirectly, packagesOwningPaths } from './readiness.mjs';
+import { affectedStagePlan, invokedDirectly, newlyDirtyPaths, packagesOwningPaths } from './readiness.mjs';
 
 /** A throwaway workspace: root + four members with different shapes. */
 async function fixture() {
@@ -218,28 +218,55 @@ test('an affected stage with NO branch point runs REPO-WIDE — it never skips',
   // The defect this pins: a scratch export or an archive has no origin/develop,
   // and the stage used to SKIP and let the run end "converged — safe to push"
   // with typecheck, lint and tests all unexecuted. Green over nothing.
+  // Members declare it: CI's `pnpm -r` form, even when the root ALSO has a
+  // script — the root's is a second authority (kernel-sdk's `eslint .`).
   assert.deepEqual(
-    affectedStagePlan({ base: undefined, paths: [], packages: [], rootDeclares: true }),
+    affectedStagePlan({ base: undefined, paths: [], packages: [], rootDeclares: true, membersDeclare: true }),
+    { mode: 'workspace', viaRoot: false },
+  );
+  // Only the root declares it: the root script is the only place it lives.
+  assert.deepEqual(
+    affectedStagePlan({ base: undefined, paths: [], packages: [], rootDeclares: true, membersDeclare: false }),
     { mode: 'workspace', viaRoot: true },
   );
   assert.deepEqual(
-    affectedStagePlan({ base: undefined, paths: [], packages: [], rootDeclares: false }),
+    affectedStagePlan({ base: undefined, paths: [], packages: [], rootDeclares: false, membersDeclare: false }),
     { mode: 'workspace', viaRoot: false },
   );
   // A base with owning packages is the ordinary affected run.
   assert.deepEqual(
-    affectedStagePlan({ base: 'abc', paths: ['a/x.ts'], packages: ['a'], rootDeclares: true }),
+    affectedStagePlan({ base: 'abc', paths: ['a/x.ts'], packages: ['a'], rootDeclares: true, membersDeclare: true }),
     { mode: 'affected', packages: ['a'] },
   );
   // A base where only the ROOT declares the script runs the root, labelled.
   assert.deepEqual(
-    affectedStagePlan({ base: 'abc', paths: ['README.md'], packages: [], rootDeclares: true }),
+    affectedStagePlan({ base: 'abc', paths: ['README.md'], packages: [], rootDeclares: true, membersDeclare: false }),
     { mode: 'root' },
   );
+  // A root-only path change where members own the stage: CI's form, not the root's.
+  assert.deepEqual(
+    affectedStagePlan({ base: 'abc', paths: ['README.md'], packages: [], rootDeclares: true, membersDeclare: true }),
+    { mode: 'workspace', viaRoot: false },
+  );
   // Nothing declares it: the only outcome that runs nothing, and it needs a
   // base to be trusted — without one it is the workspace run above.
   assert.deepEqual(
-    affectedStagePlan({ base: 'abc', paths: ['README.md'], packages: [], rootDeclares: false }),
+    affectedStagePlan({ base: 'abc', paths: ['README.md'], packages: [], rootDeclares: false, membersDeclare: false }),
     { mode: 'inapplicable' },
   );
 });
+
+test('only what the REFUSED run wrote is restored — in-flight work that was dirty before is untouched', () => {
+  const before = new Set([' M packages/clients/a/src/models/x.ts', '?? packages/clients/a/src/models/draft.ts']);
+  const after = new Set([
+    ' M packages/clients/a/src/models/x.ts',          // was dirty before: somebody's work
+    '?? packages/clients/a/src/models/draft.ts',       // was there before: somebody's work
+    ' M packages/clients/a/src/models/problem.ts',     // the refusal wrote this
+    '?? packages/clients/b/src/endpoints/new.ts',      // and created this
+  ]);
+  assert.deepEqual(newlyDirtyPaths(before, after), [
+    ' M packages/clients/a/src/models/problem.ts',
+    '?? packages/clients/b/src/endpoints/new.ts',
+  ]);
+  assert.deepEqual(newlyDirtyPaths(new Set(), new Set()), []);
+});