@xchainjs/xchain-thorchain-amm 0.3.0 → 0.3.1

package/README.md

@@ -28,11 +28,11 @@ Following peer dependencies have to be installed into your project. These are no
     "@xchainjs/xchain-ethereum": "^0.27.0",
     "@xchainjs/xchain-evm": "^0.1.0-alpha2",
     "@xchainjs/xchain-avax": "^0.1.0-alpha3",
-    "@xchainjs/xchain-litecoin": "^0.10.0",
+    "@xchainjs/xchain-litecoin": "^0.10.3",
     "@xchainjs/xchain-midgard": "^0.1.0",
     "@xchainjs/xchain-terra": "^0.3.0",
     "@xchainjs/xchain-thorchain": "^0.26.0",
-    "@xchainjs/xchain-thorchain-query": "^0.1.0",
+    "@xchainjs/xchain-thorchain-query": "^0.1.2",
     "@xchainjs/xchain-thornode": "^0.1.0",
     "@xchainjs/xchain-util": "^0.9.0",
     "axios": "^0.27.2",

package/lib/index.esm.js

@@ -779,22 +779,22 @@ class Wallet {
             const txSubmitted = [];
             // symmetrical add
             if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.gt(0)) {
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}:${addressRune}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}:${addressAsset}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `+:${params.assetPool}:${addressRune}`;
+                txSubmitted.push(yield this.addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `+:${params.assetPool}:${addressAsset}`;
+                txSubmitted.push(yield this.addRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
             else if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.eq(0)) {
                 // asymmetrical asset only
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `+:${params.assetPool}`;
+                txSubmitted.push(yield this.addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
                 return txSubmitted;
             }
             else {
                 // asymmetrical rune only
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `+:${params.assetPool}`;
+                txSubmitted.push(yield this.addRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
         });
@@ -806,33 +806,31 @@ class Wallet {
      */
     removeLiquidity(params) {
         return __awaiter(this, void 0, void 0, function* () {
-            const assetClient = this.clients[params.asset.asset.chain];
-            const inboundAsgard = (yield this.thorchainQuery.thorchainCache.getInboundDetails())[params.asset.asset.chain];
-            if (!(inboundAsgard === null || inboundAsgard === void 0 ? void 0 : inboundAsgard.address)) {
-                throw new Error('Vault address is not defined');
-            }
+            const assetClient = this.clients[params.assetFee.asset.chain];
+            const inboundAsgard = (yield this.thorchainQuery.thorchainCache.getInboundDetails())[params.assetFee.asset.chain]
+                .address;
             const waitTimeSeconds = params.waitTimeSeconds;
-            const thorchainClient = this.clients[params.rune.asset.chain];
+            const thorchainClient = this.clients[params.runeFee.asset.chain];
             const basisPoints = (params.percentage * 100).toFixed(); // convert to basis points
             let constructedMemo = '';
             const txSubmitted = [];
-            if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.gt(0)) {
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard.address));
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+            if (params.assetAddress && params.runeAddress) {
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
-            else if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.eq(0)) {
+            else if (params.assetAddress && !params.runeAddress) {
                 // asymmetrical asset only
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard.address));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
                 return txSubmitted;
             }
             else {
                 // asymmetrical rune only
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
         });
@@ -846,7 +844,7 @@ class Wallet {
      * @param inboundAsgard - inbound Asgard address for the LP
      * @returns - tx object
      */
-    addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
+    addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
         return __awaiter(this, void 0, void 0, function* () {
             if (params.asset.asset.chain === Chain.Ethereum) {
                 const addParams = {
@@ -856,7 +854,6 @@ class Wallet {
                     feeOption: FeeOption.Fast,
                     memo: constructedMemo,
                 };
-                console.log(addParams.amount.amount().toNumber());
                 const hash = yield this.ethHelper.sendDeposit(addParams);
                 return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
             }
@@ -881,7 +878,6 @@ class Wallet {
                     memo: constructedMemo,
                 };
                 try {
-                    console.log(addParams);
                     const hash = yield assetClient.transfer(addParams);
                     return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
                 }
@@ -892,13 +888,67 @@ class Wallet {
             }
         });
     }
+    /**
+     *
+     * @param params - parameters for remove liquidity
+     * @param constructedMemo - memo needed for thorchain execution
+     * @param assetClient - asset client to call transfer
+     * @param waitTimeSeconds - return back estimated wait
+     * @param inboundAsgard - destination address
+     * @returns - tx object
+     */
+    removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (params.assetFee.asset.chain === Chain.Ethereum) {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    feeOption: FeeOption.Fast,
+                    memo: constructedMemo,
+                };
+                // console.log(removeParams.amount.amount().toNumber())
+                const hash = yield this.ethHelper.sendDeposit(removeParams);
+                return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+            }
+            else if (params.assetFee.asset.chain === Chain.Avalanche) {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    feeOption: FeeOption.Fast,
+                    memo: constructedMemo,
+                };
+                const evmHelper = new EvmHelper(this.clients.AVAX, this.thorchainQuery.thorchainCache);
+                const hash = yield evmHelper.sendDeposit(removeParams);
+                return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+            }
+            else {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    recipient: inboundAsgard,
+                    memo: constructedMemo,
+                };
+                try {
+                    const hash = yield assetClient.transfer(removeParams);
+                    return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+                }
+                catch (err) {
+                    const hash = JSON.stringify(err);
+                    return { hash, url: assetClient.getExplorerAddressUrl(assetClient.getAddress()), waitTimeSeconds };
+                }
+            }
+        });
+    }
     /**
      *
      * @param params - deposit parameters
      * @param memo - memo needed to withdraw lp
      * @returns - tx object
      */
-    addOrRemoveRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
+    addRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
         return __awaiter(this, void 0, void 0, function* () {
             const thorClient = this.clients.THOR;
             const addParams = {
@@ -906,7 +956,26 @@ class Wallet {
                 amount: params.rune.baseAmount,
                 memo: memo,
             };
-            console.log(addParams);
+            // console.log(addParams)
+            const hash = yield thorClient.deposit(addParams);
+            return { hash, url: thorchainClient.getExplorerTxUrl(hash), waitTimeSeconds };
+        });
+    }
+    /**
+     *
+     * @param params - remove parameters
+     * @param memo - memo needed to withdraw lp
+     * @returns - tx object
+     */
+    removeRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const thorClient = this.clients.THOR;
+            const addParams = {
+                asset: params.runeFee.asset,
+                amount: params.runeFee.baseAmount,
+                memo: memo,
+            };
+            // console.log(addParams)
             const hash = yield thorClient.deposit(addParams);
             return { hash, url: thorchainClient.getExplorerTxUrl(hash), waitTimeSeconds };
         });
@@ -997,6 +1066,7 @@ class ThorchainAMM {
                 asset: params.asset,
                 rune: params.rune,
                 waitTimeSeconds: checkLPAdd.estimatedWaitSeconds,
+                assetPool: checkLPAdd.assetPool,
             });
         });
     }
@@ -1009,12 +1079,15 @@ class ThorchainAMM {
     removeLiquidityPosition(wallet, params) {
         return __awaiter(this, void 0, void 0, function* () {
             // Caution Dust Limits: BTC,BCH,LTC chains 10k sats; DOGE 1m Sats; ETH 0 wei; THOR 0 RUNE.
-            const estimateWithrawLp = yield this.thorchainQuery.estimateWithdrawLP(params);
+            const withdrawParams = yield this.thorchainQuery.estimateWithdrawLP(params);
             return wallet.removeLiquidity({
-                asset: estimateWithrawLp.transactionFee.assetFee,
-                rune: estimateWithrawLp.transactionFee.runeFee,
+                assetFee: withdrawParams.transactionFee.assetFee,
+                runeFee: withdrawParams.transactionFee.runeFee,
+                waitTimeSeconds: withdrawParams.estimatedWaitSeconds,
                 percentage: params.percentage,
-                waitTimeSeconds: estimateWithrawLp.estimatedWaitSeconds,
+                assetPool: withdrawParams.assetPool,
+                assetAddress: withdrawParams.assetAddress,
+                runeAddress: withdrawParams.runeAddress,
             });
         });
     }

package/lib/index.js

@@ -783,22 +783,22 @@ class Wallet {
             const txSubmitted = [];
             // symmetrical add
             if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.gt(0)) {
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}:${addressRune}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}:${addressAsset}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `+:${params.assetPool}:${addressRune}`;
+                txSubmitted.push(yield this.addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `+:${params.assetPool}:${addressAsset}`;
+                txSubmitted.push(yield this.addRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
             else if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.eq(0)) {
                 // asymmetrical asset only
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `+:${params.assetPool}`;
+                txSubmitted.push(yield this.addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
                 return txSubmitted;
             }
             else {
                 // asymmetrical rune only
-                constructedMemo = `+:${params.asset.asset.chain}.${params.asset.asset.symbol}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `+:${params.assetPool}`;
+                txSubmitted.push(yield this.addRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
         });
@@ -810,33 +810,31 @@ class Wallet {
      */
     removeLiquidity(params) {
         return __awaiter(this, void 0, void 0, function* () {
-            const assetClient = this.clients[params.asset.asset.chain];
-            const inboundAsgard = (yield this.thorchainQuery.thorchainCache.getInboundDetails())[params.asset.asset.chain];
-            if (!(inboundAsgard === null || inboundAsgard === void 0 ? void 0 : inboundAsgard.address)) {
-                throw new Error('Vault address is not defined');
-            }
+            const assetClient = this.clients[params.assetFee.asset.chain];
+            const inboundAsgard = (yield this.thorchainQuery.thorchainCache.getInboundDetails())[params.assetFee.asset.chain]
+                .address;
             const waitTimeSeconds = params.waitTimeSeconds;
-            const thorchainClient = this.clients[params.rune.asset.chain];
+            const thorchainClient = this.clients[params.runeFee.asset.chain];
             const basisPoints = (params.percentage * 100).toFixed(); // convert to basis points
             let constructedMemo = '';
             const txSubmitted = [];
-            if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.gt(0)) {
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard.address));
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+            if (params.assetAddress && params.runeAddress) {
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
-            else if (params.asset.assetAmount.gt(0) && params.rune.assetAmount.eq(0)) {
+            else if (params.assetAddress && !params.runeAddress) {
                 // asymmetrical asset only
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard.address));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard));
                 return txSubmitted;
             }
             else {
                 // asymmetrical rune only
-                constructedMemo = `-:${params.asset.asset.chain}.${params.asset.asset.symbol}:${basisPoints}`;
-                txSubmitted.push(yield this.addOrRemoveRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
+                constructedMemo = `-:${params.assetPool}:${basisPoints}`;
+                txSubmitted.push(yield this.removeRuneLP(params, constructedMemo, thorchainClient, waitTimeSeconds));
                 return txSubmitted;
             }
         });
@@ -850,7 +848,7 @@ class Wallet {
      * @param inboundAsgard - inbound Asgard address for the LP
      * @returns - tx object
      */
-    addOrRemoveAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
+    addAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
         return __awaiter(this, void 0, void 0, function* () {
             if (params.asset.asset.chain === xchainUtil.Chain.Ethereum) {
                 const addParams = {
@@ -860,7 +858,6 @@ class Wallet {
                     feeOption: xchainClient.FeeOption.Fast,
                     memo: constructedMemo,
                 };
-                console.log(addParams.amount.amount().toNumber());
                 const hash = yield this.ethHelper.sendDeposit(addParams);
                 return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
             }
@@ -885,7 +882,6 @@ class Wallet {
                     memo: constructedMemo,
                 };
                 try {
-                    console.log(addParams);
                     const hash = yield assetClient.transfer(addParams);
                     return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
                 }
@@ -896,13 +892,67 @@ class Wallet {
             }
         });
     }
+    /**
+     *
+     * @param params - parameters for remove liquidity
+     * @param constructedMemo - memo needed for thorchain execution
+     * @param assetClient - asset client to call transfer
+     * @param waitTimeSeconds - return back estimated wait
+     * @param inboundAsgard - destination address
+     * @returns - tx object
+     */
+    removeAssetLP(params, constructedMemo, assetClient, waitTimeSeconds, inboundAsgard) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (params.assetFee.asset.chain === xchainUtil.Chain.Ethereum) {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    feeOption: xchainClient.FeeOption.Fast,
+                    memo: constructedMemo,
+                };
+                // console.log(removeParams.amount.amount().toNumber())
+                const hash = yield this.ethHelper.sendDeposit(removeParams);
+                return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+            }
+            else if (params.assetFee.asset.chain === xchainUtil.Chain.Avalanche) {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    feeOption: xchainClient.FeeOption.Fast,
+                    memo: constructedMemo,
+                };
+                const evmHelper = new EvmHelper(this.clients.AVAX, this.thorchainQuery.thorchainCache);
+                const hash = yield evmHelper.sendDeposit(removeParams);
+                return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+            }
+            else {
+                const removeParams = {
+                    wallIndex: 0,
+                    asset: params.assetFee.asset,
+                    amount: params.assetFee.baseAmount,
+                    recipient: inboundAsgard,
+                    memo: constructedMemo,
+                };
+                try {
+                    const hash = yield assetClient.transfer(removeParams);
+                    return { hash, url: assetClient.getExplorerTxUrl(hash), waitTimeSeconds };
+                }
+                catch (err) {
+                    const hash = JSON.stringify(err);
+                    return { hash, url: assetClient.getExplorerAddressUrl(assetClient.getAddress()), waitTimeSeconds };
+                }
+            }
+        });
+    }
     /**
      *
      * @param params - deposit parameters
      * @param memo - memo needed to withdraw lp
      * @returns - tx object
      */
-    addOrRemoveRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
+    addRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
         return __awaiter(this, void 0, void 0, function* () {
             const thorClient = this.clients.THOR;
             const addParams = {
@@ -910,7 +960,26 @@ class Wallet {
                 amount: params.rune.baseAmount,
                 memo: memo,
             };
-            console.log(addParams);
+            // console.log(addParams)
+            const hash = yield thorClient.deposit(addParams);
+            return { hash, url: thorchainClient.getExplorerTxUrl(hash), waitTimeSeconds };
+        });
+    }
+    /**
+     *
+     * @param params - remove parameters
+     * @param memo - memo needed to withdraw lp
+     * @returns - tx object
+     */
+    removeRuneLP(params, memo, thorchainClient, waitTimeSeconds) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const thorClient = this.clients.THOR;
+            const addParams = {
+                asset: params.runeFee.asset,
+                amount: params.runeFee.baseAmount,
+                memo: memo,
+            };
+            // console.log(addParams)
             const hash = yield thorClient.deposit(addParams);
             return { hash, url: thorchainClient.getExplorerTxUrl(hash), waitTimeSeconds };
         });
@@ -1001,6 +1070,7 @@ class ThorchainAMM {
                 asset: params.asset,
                 rune: params.rune,
                 waitTimeSeconds: checkLPAdd.estimatedWaitSeconds,
+                assetPool: checkLPAdd.assetPool,
             });
         });
     }
@@ -1013,12 +1083,15 @@ class ThorchainAMM {
     removeLiquidityPosition(wallet, params) {
         return __awaiter(this, void 0, void 0, function* () {
             // Caution Dust Limits: BTC,BCH,LTC chains 10k sats; DOGE 1m Sats; ETH 0 wei; THOR 0 RUNE.
-            const estimateWithrawLp = yield this.thorchainQuery.estimateWithdrawLP(params);
+            const withdrawParams = yield this.thorchainQuery.estimateWithdrawLP(params);
             return wallet.removeLiquidity({
-                asset: estimateWithrawLp.transactionFee.assetFee,
-                rune: estimateWithrawLp.transactionFee.runeFee,
+                assetFee: withdrawParams.transactionFee.assetFee,
+                runeFee: withdrawParams.transactionFee.runeFee,
+                waitTimeSeconds: withdrawParams.estimatedWaitSeconds,
                 percentage: params.percentage,
-                waitTimeSeconds: estimateWithrawLp.estimatedWaitSeconds,
+                assetPool: withdrawParams.assetPool,
+                assetAddress: withdrawParams.assetAddress,
+                runeAddress: withdrawParams.runeAddress,
             });
         });
     }

package/lib/types.d.ts

@@ -22,23 +22,26 @@ export declare type TxSubmitted = {
     url: string;
     waitTimeSeconds: number;
 };
-export declare type AddLiquidity = {
-    asset: CryptoAmount;
-    rune: CryptoAmount;
-    waitTimeSeconds: number;
-};
 export declare type LiquidityPosition = {
     assetPool: LiquidityPool;
     assetAmount: CryptoAmount;
     runeAmount: CryptoAmount;
     impermanentLossProtection: number;
 };
-export declare type RemoveLiquidity = {
+export declare type AddLiquidity = {
     asset: CryptoAmount;
     rune: CryptoAmount;
-    percentage: number;
     waitTimeSeconds: number;
-    asymmetricalWithdraw?: Asset;
+    assetPool: string;
+};
+export declare type RemoveLiquidity = {
+    assetFee: CryptoAmount;
+    runeFee: CryptoAmount;
+    waitTimeSeconds: number;
+    percentage: number;
+    assetPool: string;
+    assetAddress?: string;
+    runeAddress?: string;
 };
 export declare type DepositParams = {
     walletIndex?: number;

package/lib/wallet.d.ts

@@ -61,13 +61,30 @@ export declare class Wallet {
      * @param inboundAsgard - inbound Asgard address for the LP
      * @returns - tx object
      */
-    private addOrRemoveAssetLP;
+    private addAssetLP;
+    /**
+     *
+     * @param params - parameters for remove liquidity
+     * @param constructedMemo - memo needed for thorchain execution
+     * @param assetClient - asset client to call transfer
+     * @param waitTimeSeconds - return back estimated wait
+     * @param inboundAsgard - destination address
+     * @returns - tx object
+     */
+    private removeAssetLP;
     /**
      *
      * @param params - deposit parameters
      * @param memo - memo needed to withdraw lp
      * @returns - tx object
      */
-    private addOrRemoveRuneLP;
+    private addRuneLP;
+    /**
+     *
+     * @param params - remove parameters
+     * @param memo - memo needed to withdraw lp
+     * @returns - tx object
+     */
+    private removeRuneLP;
 }
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xchainjs/xchain-thorchain-amm",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "module that exposes estimating & swappping cryptocurrency assets on thorchain",
   "keywords": [
     "THORChain",
@@ -50,10 +50,10 @@
     "@xchainjs/xchain-ethereum": "^0.27.0",
     "@xchainjs/xchain-evm": "^0.1.0-alpha2",
     "@xchainjs/xchain-avax": "^0.1.0-alpha3",
-    "@xchainjs/xchain-litecoin": "^0.10.0",
+    "@xchainjs/xchain-litecoin": "^0.10.3",
     "@xchainjs/xchain-midgard": "0.1.0",
     "@xchainjs/xchain-thorchain": "^0.27.0",
-    "@xchainjs/xchain-thorchain-query": "^0.1.0",
+    "@xchainjs/xchain-thorchain-query": "^0.1.2",
     "@xchainjs/xchain-thornode": "^0.1.0",
     "@xchainjs/xchain-util": "^0.11.0",
     "axios": "^0.25.0",