@xaliksss/eslint-config 4.0.1 → 4.0.2

package/LICENSE

@@ -1,21 +1,21 @@
-MIT License
-
-Copyright (c) 2024 Xaliks
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2024 Xaliks
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/dist/index.d.ts

@@ -1,2 +1,2 @@
-declare const _default: import("eslint/config").Config[];
+declare const _default: import("eslint/config").ConfigObject[];
 export default _default;

package/dist/index.js

@@ -2,10 +2,11 @@ import { defineConfig } from 'eslint/config';
 import globals from "globals";
 import tseslint from "typescript-eslint";
 import stylisticPlugin from "@stylistic/eslint-plugin";
-import importPlugin from "eslint-plugin-import";
+import importPlugin from "eslint-plugin-import-x";
+import nPlugin from "eslint-plugin-n";
 import { eslintRules } from "./rules/eslint.js";
 import { stylisticRules } from "./rules/stylistic.js";
-import { importRules } from "./rules/import.js";
+import { importRules } from "./rules/import-x.js";
 import { typescriptRules, typescriptTypeAwareRules } from "./rules/typescript.js";
 const IGNORES = [
     "**/dist/**",
@@ -29,7 +30,8 @@ export default defineConfig({
     },
     plugins: {
         "@stylistic": stylisticPlugin,
-        import: importPlugin,
+        "import-x": importPlugin,
+        n: nPlugin,
     },
     rules: {
         ...eslintRules,

package/dist/rules/eslint.js

@@ -9,7 +9,7 @@ export const eslintRules = {
     "no-compare-neg-zero": "error",
     "no-cond-assign": "error",
     "no-const-assign": "error", // [TS]
-    "no-constant-binary-expression": "error",
+    "no-constant-binary-expression": ["error", { checkRelationalComparisons: true }],
     "no-constant-condition": "error",
     "no-constructor-return": "error",
     "no-control-regex": "off", // запрещает делать regex с контрол-символами,
@@ -44,7 +44,7 @@ export const eslintRules = {
     "no-unassigned-vars": "error",
     "no-undef": "error", // [TS]
     "no-unexpected-multiline": "error",
-    "no-unmodified-loop-condition": "error",
+    "no-unmodified-loop-condition": ["error", { checkConditionalExpressions: true }],
     "no-unreachable": "error", // [TS]
     "no-unreachable-loop": "error",
     "no-unsafe-finally": "error",
@@ -143,7 +143,7 @@ export const eslintRules = {
     "max-depth": "off",
     "max-lines": "off",
     "max-lines-per-function": "off",
-    "max-nested-callbacks": ["error", { max: 3 }],
+    "max-nested-callbacks": ["error", { max: 3, checkConstructorCallCallbacks: true }],
     "max-params": ["error", { max: 6 }],
     "max-statements": "off",
     "new-cap": "off",

package/dist/rules/import-x.js

@@ -0,0 +1,61 @@
+import { Linter } from "eslint";
+export const importRules = {
+    "import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
+    "import-x/default": "error",
+    "import-x/dynamic-import-chunkname": "off",
+    "import-x/export": "error",
+    "import-x/exports-last": "off",
+    "import-x/extensions": "off", // Для каждого проекта должно быть свое решение
+    "import-x/first": "error",
+    "import-x/group-exports": "off",
+    "import-x/max-dependencies": "off",
+    "import-x/named": "error",
+    "import-x/namespace": "error",
+    "import-x/newline-after-import": ["error", { count: 1, considerComments: true }],
+    "import-x/no-absolute-path": "error",
+    "import-x/no-amd": "error",
+    "import-x/no-anonymous-default-export": "error",
+    "import-x/no-commonjs": "error",
+    "import-x/no-cycle": ["error", {
+            maxDepth: 4, // Возможно придется обновить на 1
+            ignoreExternal: true,
+            allowUnsafeDynamicCyclicDependency: false
+        }],
+    "import-x/no-default-export": "off",
+    "import-x/no-deprecated": "off", // С этим лучше справляется @typescript-eslint/no-deprecated
+    "import-x/no-duplicates": "off", // уже используем extensions
+    "import-x/no-dynamic-require": "error",
+    "import-x/no-empty-named-blocks": "error",
+    "import-x/no-extraneous-dependencies": "error",
+    "import-x/no-import-module-exports": "error",
+    "import-x/no-internal-modules": "off",
+    "import-x/no-mutable-exports": "error",
+    "import-x/no-named-as-default-member": "error",
+    "import-x/no-named-as-default": "error",
+    "import-x/no-named-default": "error",
+    "import-x/no-named-export": "off",
+    "import-x/no-namespace": "off",
+    "import-x/no-nodejs-modules": "off",
+    "import-x/no-relative-packages": "off",
+    "import-x/no-relative-parent-imports": "off",
+    "import-x/no-rename-default": "error",
+    "import-x/no-restricted-paths": "off", // в связке с no-restricted-imports от Eslint
+    "import-x/no-self-import": "error",
+    "import-x/no-unassigned-import": "off",
+    "import-x/no-unresolved": "off",
+    "import-x/no-unused-modules": ["error", { unusedExports: true, missingExports: false }],
+    "import-x/no-useless-path-segments": "error",
+    "import-x/no-webpack-loader-syntax": "error",
+    "import-x/order": ["error",
+        {
+            groups: ["builtin", "external", "type", "internal", "parent", "sibling", "index", "object"],
+            "newlines-between": "always",
+            alphabetize: { order: "asc" },
+            named: true,
+            "newlines-between-types": "ignore",
+        },
+    ],
+    "import-x/prefer-default-export": "off",
+    "import-x/prefer-namespace-import": "off",
+    "import-x/unambiguous": "error",
+};

package/dist/rules/n.d.ts

@@ -0,0 +1,2 @@
+import { Linter } from "eslint";
+export declare const nRules: Linter.RulesRecord;

package/dist/rules/n.js

@@ -0,0 +1,46 @@
+import { Linter } from "eslint";
+export const nRules = {
+    "n/callback-return": "error",
+    "n/exports-style": ["error", "exports"],
+    "n/file-extension-in-import": "off", // TypeScript знает лучше
+    "n/global-require": "error",
+    "n/handle-callback-err": "error",
+    "n/hashbang": "error",
+    "n/no-callback-literal": "off",
+    "n/no-deprecated-api": "error",
+    "n/no-exports-assign": "error",
+    "n/no-extraneous-import": "off", // есть import-x/no-extraneous-dependencies
+    "n/no-extraneous-require": "off", // есть import-x/no-extraneous-dependencies
+    "n/no-missing-import": "off", // есть import-x/no-unresolved
+    "n/no-missing-require": "off", // есть import-x/no-unresolved
+    "n/no-mixed-requires": "error", // есть import-x/order
+    "n/no-new-require": "error",
+    "n/no-path-concat": "error",
+    "n/no-process-env": "off",
+    "n/no-process-exit": "off",
+    "n/no-restricted-import": "off", // есть import-x/no-restricted-paths
+    "n/no-restricted-require": "off", // есть import-x/no-restricted-paths
+    "n/no-sync": "off",
+    "n/no-top-level-await": "off",
+    "n/no-unpublished-bin": "off", // > npm v10
+    "n/no-unpublished-import": "off",
+    "n/no-unpublished-require": "off",
+    "n/no-unsupported-features/es-builtins": "error",
+    "n/no-unsupported-features/es-syntax": "error",
+    "n/no-unsupported-features/node-builtins": "error",
+    "n/prefer-global/buffer": "error",
+    "n/prefer-global/console": "error",
+    "n/prefer-global/crypto": "error", // webcrypto
+    "n/prefer-global/process": "error",
+    "n/prefer-global/text-decoder": "error",
+    "n/prefer-global/text-encoder": "error",
+    "n/prefer-global/timers": "error",
+    "n/prefer-global/url": "error",
+    "n/prefer-global/url-search-params": "error",
+    "n/prefer-import/assert-strict": "error",
+    "n/prefer-node-protocol": "error",
+    "n/prefer-process-get-builtin-module": "off", // Мир пока не готов к process.getBuiltinModule()
+    "n/prefer-promises/dns": "error",
+    "n/prefer-promises/fs": "error",
+    "n/process-exit-as-throw": "error",
+};

package/dist/rules/typescript.js

@@ -40,6 +40,7 @@ export const typescriptRules = {
     "@typescript-eslint/method-signature-style": ["error", "method"],
     "@typescript-eslint/no-array-constructor": "off", // есть no-array-constructor
     "@typescript-eslint/no-confusing-non-null-assertion": "error",
+    "@typescript-eslint/no-deprecated": "error",
     "@typescript-eslint/no-dupe-class-members": "off", // оно в TS вообще не нужно
     "@typescript-eslint/no-duplicate-enum-values": "error",
     "@typescript-eslint/no-dynamic-delete": "error",
@@ -52,7 +53,6 @@ export const typescriptRules = {
     "@typescript-eslint/no-inferrable-types": "error",
     "@typescript-eslint/no-invalid-this": "off", // есть no-invalid-this
     "@typescript-eslint/no-invalid-void-type": ["error", { allowAsThisParameter: true }],
-    "@typescript-eslint/no-loop-func": "off", // есть no-loop-func
     "@typescript-eslint/no-magic-numbers": "off", // есть no-magic-numbers
     "@typescript-eslint/no-misused-new": "error",
     "@typescript-eslint/no-namespace": "error",
@@ -61,7 +61,6 @@ export const typescriptRules = {
     "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/no-redeclare": "off", // TS сам справится
     "@typescript-eslint/no-require-imports": "error",
-    "@typescript-eslint/no-restricted-imports": "off", // есть no-restricted-imports
     "@typescript-eslint/no-restricted-types": "off",
     "@typescript-eslint/no-shadow": "off", // есть no-shadow
     "@typescript-eslint/no-this-alias": "error",
@@ -137,11 +136,7 @@ export const typescriptTypeAwareRules = {
     ],
     "@typescript-eslint/no-array-delete": "error",
     "@typescript-eslint/no-base-to-string": "error",
-    "@typescript-eslint/no-confusing-void-expression": ["error",
-        {
-            ignoreVoidReturningFunctions: true,
-        }
-    ],
+    "@typescript-eslint/no-confusing-void-expression": "off",
     "@typescript-eslint/no-floating-promises": ["error", {
             ignoreIIFE: true,
         }],

package/package.json

@@ -1,34 +1,35 @@
-{
-  "name": "@xaliksss/eslint-config",
-  "version": "4.0.1",
-  "main": "dist/index.js",
-  "type": "module",
-  "author": {
-    "name": "Xaliks",
-    "url": "https://github.com/Xaliks"
-  },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/Xaliks/eslint-config.git"
-  },
-  "files": [
-    "dist"
-  ],
-  "exports": {
-    ".": "./dist/index.js"
-  },
-  "scripts": {
-    "build": "tsc"
-  },
-  "license": "MIT",
-  "dependencies": {
-    "@stylistic/eslint-plugin": "^5.10.0",
-    "eslint": "^10.5.0",
-    "eslint-plugin-import": "git+https://github.com/Xaliks/eslint-plugin-import.git#pr-3230",
-    "globals": "^17.7.0",
-    "typescript-eslint": "^8.62.0"
-  },
-  "devDependencies": {
-    "typescript": "^6.0.3"
-  }
-}
+{
+  "name": "@xaliksss/eslint-config",
+  "version": "4.0.2",
+  "main": "dist/index.js",
+  "type": "module",
+  "author": {
+    "name": "Xaliks",
+    "url": "https://github.com/Xaliks"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/Xaliks/eslint-config.git"
+  },
+  "files": [
+    "dist"
+  ],
+  "exports": {
+    ".": "./dist/index.js"
+  },
+  "scripts": {
+    "build": "tsc"
+  },
+  "license": "MIT",
+  "dependencies": {
+    "@stylistic/eslint-plugin": "5.10.0",
+    "eslint": "10.10.0",
+    "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-n": "^18.3.0",
+    "globals": "17.12.0",
+    "typescript-eslint": "8.69.0"
+  },
+  "devDependencies": {
+    "typescript": "^6.0.3"
+  }
+}

package/dist/rules/import.js

@@ -1,57 +0,0 @@
-import { Linter } from "eslint";
-export const importRules = {
-    "import/export": "error",
-    "import/no-deprecated": "error",
-    "import/no-empty-named-blocks": "error",
-    "import/no-extraneous-dependencies": "error",
-    "import/no-mutable-exports": "error",
-    "import/no-named-as-default-member": "error",
-    "import/no-unused-modules": "error",
-    "import/no-amd": "error",
-    "import/no-commonjs": "error",
-    "import/no-import-module-exports": "error",
-    "import/no-nodejs-modules": "off",
-    "import/unambiguous": "error",
-    "import/default": "error", // Под вопросом
-    "import/enforce-node-protocol-usage": ["error", "always"],
-    "import/named": "error", // Под вопросом
-    "import/namespace": "error",
-    "import/no-absolute-path": "error",
-    "import/no-cycle": ["error", {
-            maxDepth: 2, // Возможно придется обновить на 1
-            ignoreExternal: true,
-            allowUnsafeDynamicCyclicDependency: false
-        }],
-    "import/no-dynamic-require": "error",
-    "import/no-internal-modules": "off",
-    "import/no-relative-packages": "off",
-    "import/no-relative-parent-imports": "off",
-    "import/no-self-import": "error",
-    "import/no-unresolved": "off",
-    "import/no-useless-path-segments": "error",
-    "import/no-webpack-loader-syntax": "error",
-    "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
-    "import/dynamic-import-chunkname": "off",
-    "import/exports-last": "off",
-    "import/extensions": "off",
-    "import/first": "error",
-    "import/group-exports": "off",
-    "import/max-dependencies": "off",
-    "import/newline-after-import": ["error", { count: 1, considerComments: false }],
-    "import/no-anonymous-default-export": "error",
-    "import/no-default-export": "off",
-    "import/no-duplicates": "error",
-    "import/no-named-default": "error",
-    "import/no-named-export": "off",
-    "import/no-namespace": "off",
-    "import/no-unassigned-import": "off",
-    "import/order": ["error",
-        {
-            groups: ["builtin", "external", "type", "internal", "parent", "sibling", "index", "object"],
-            "newlines-between": "always",
-            named: true,
-            alphabetize: { order: "asc" },
-        },
-    ],
-    "import/prefer-default-export": "off",
-};