@x-otto/plugin-github-copilot 0.1.0-alpha.4 → 0.1.0-alpha.9

package/src/provider.test.ts

@@ -5,6 +5,7 @@ import {
   inferCopilotInitiator,
   hasCopilotVisionInput,
   buildCopilotDynamicHeaders,
+  buildCopilotHeaders,
 } from './provider'
 
 import type {
@@ -152,6 +153,24 @@ describe('hasCopilotVisionInput', () => {
   })
 })
 
+describe('buildCopilotHeaders + dynamic 合并：openai-intent 无同名异 case 冲突（findings-backlog B2）', () => {
+  it('#then 静态 headers 不含 openai-intent（由 dynamic 单一真源提供）', () => {
+    const staticHeaders = buildCopilotHeaders('tok')
+    const keys = Object.keys(staticHeaders).map((k) => k.toLowerCase())
+    expect(keys).not.toContain('openai-intent')
+  })
+
+  it('#then 合并后（static ∪ dynamic）openai-intent 大小写不敏感恰一处，值为 dynamic 的 conversation-edits', () => {
+    const merged = {
+      ...buildCopilotHeaders('tok'),
+      ...buildCopilotDynamicHeaders({ messages: [makeUserMessage('hi')], hasImages: false }),
+    }
+    const intentKeys = Object.keys(merged).filter((k) => k.toLowerCase() === 'openai-intent')
+    expect(intentKeys).toHaveLength(1) // 此前静态 'openai-intent' + 动态 'Openai-Intent' 共存 = 2，会被服务端视为 header 重复
+    expect(merged[intentKeys[0]!]).toBe('conversation-edits')
+  })
+})
+
 describe('buildCopilotDynamicHeaders', () => {
   it('sets X-Initiator and Openai-Intent', () => {
     const messages: Message[] = [makeUserMessage('hello')]

package/src/provider.ts

@@ -25,15 +25,13 @@ import {
   type StreamOptions,
   type ProviderStream,
   type WireProtocolLogger,
+  noopWireProtocolLogger,
 } from '@x-otto/provider'
 
-/** RFC-185 D3：日志走宿主注入端口，缺省 no-op——插件源码禁 createLogger（防第二单例直写 stderr）。 */
-const noopLogger: WireProtocolLogger = { debug: () => {}, info: () => {}, warn: () => {}, error: () => {} }
-
 const PROVIDER_VERSION = '1.0.0'
 const DEFAULT_COPILOT_INTEGRATION_ID = 'vscode-chat'
 
-function buildCopilotHeaders(token: string): Record<string, string> {
+export function buildCopilotHeaders(token: string): Record<string, string> {
   const integrationId = process.env['OTTO_COPILOT_INTEGRATION_ID'] || DEFAULT_COPILOT_INTEGRATION_ID
 
   return {
@@ -41,7 +39,12 @@ function buildCopilotHeaders(token: string): Record<string, string> {
     'copilot-integration-id': integrationId,
     'editor-version': `otto-coding/${PROVIDER_VERSION}`,
     'editor-plugin-version': `otto-coding/${PROVIDER_VERSION}`,
-    'openai-intent': 'conversation-panel',
+    // 注意：openai-intent **不在此处设**——它由 buildCopilotDynamicHeaders 的
+    // `Openai-Intent` 单一真源提供（值随发起方 initiator 变化）。此前这里静态设
+    // `'openai-intent': 'conversation-panel'` 与动态的 `'Openai-Intent': 'conversation-edits'`
+    // 同名异 case 共存：JS object 是两个 key、HTTP header 名却大小写不敏感，合并后同一
+    // header 出现两次、取值歧义（服务端行为未定义）。删静态项，动态项恒设（两者都无条件
+    // spread，见 converse），故无覆盖缺口。
   }
 }
 
@@ -89,7 +92,7 @@ class GitHubCopilotStream implements ProviderStream {
 
   constructor(
     private readonly resolveOAuthAccessKey?: CopilotCredentialResolver,
-    private readonly logger: WireProtocolLogger = noopLogger,
+    private readonly logger: WireProtocolLogger = noopWireProtocolLogger,
   ) {}
 
   /** 统一鉴权解析（RFC-140 D5，`ProviderStream.resolveAuth`）——Copilot 用户令牌走 oauth 模式。 */