@wyattjoh/demur 0.6.0 → 0.7.0

package/src/training-review-tui.tsx

@@ -14,6 +14,7 @@ import {
 } from "../extensions/demur/cost-tracker.ts";
 import type { DemurSettings } from "../extensions/demur/settings.ts";
 import type {
+  TrainingCorrectionReason,
   TrainingReview,
   TrainingReviewInput,
 } from "../extensions/demur/training-store.ts";
@@ -26,6 +27,7 @@ import {
   createTrainingReviewInput,
   filterTrainingReviewEntries,
   getLatestTrainingReview,
+  getTrainingCorrectionReason,
   getTrainingReviewFilter,
   type TrainingReviewEntry,
   type TrainingReviewFilter,
@@ -63,6 +65,21 @@ const FILTERS: ReadonlyArray<{
   { value: "deny", label: "deny" },
 ];
 
+const CORRECTION_REASONS: ReadonlyArray<{
+  value: TrainingCorrectionReason;
+  label: string;
+}> = [
+  { value: "inert-or-read-only", label: "Command is inert or read-only" },
+  { value: "sensitive-data", label: "Sensitive-data judgment" },
+  { value: "security-boundary", label: "Security-boundary judgment" },
+  { value: "recoverability", label: "Recoverability judgment" },
+  { value: "shared-infrastructure", label: "Local versus shared target" },
+  { value: "blast-radius", label: "Blast-radius judgment" },
+  { value: "static-uncertainty", label: "Static uncertainty gate" },
+  { value: "missing-context", label: "Model was missing objective context" },
+  { value: "service-failure", label: "TypeSafe or guard service failure" },
+];
+
 const SECTIONS: ReadonlyArray<{ value: AppSection; label: string }> = [
   { value: "reviews", label: "Reviews" },
   { value: "settings", label: "Settings" },
@@ -112,6 +129,7 @@ type TrainingReviewAppProps = {
 type NoteEditorState = {
   recordId: string;
   expectedDecision: Decision;
+  correctionReason: TrainingCorrectionReason | undefined;
 };
 
 type AppSection = "reviews" | "settings";
@@ -277,11 +295,16 @@ export function TrainingReviewApp(
   const persistDecision = async (
     entry: TrainingReviewEntry,
     expectedDecision: Decision,
+    correctionReason: TrainingCorrectionReason | undefined,
     note: string | undefined,
   ) => {
     if (saving) return;
     const previous = getLatestTrainingReview(entry);
-    if (previous?.expectedDecision === expectedDecision) {
+    if (
+      previous?.expectedDecision === expectedDecision &&
+      correctionReason === undefined &&
+      note === undefined
+    ) {
       setNoteEditor(undefined);
       return;
     }
@@ -291,7 +314,12 @@ export function TrainingReviewApp(
     const corrected = expectedDecision !== entry.record.verdict.decision;
     try {
       const review = await props.recordReview(
-        createTrainingReviewInput(entry.record, expectedDecision, note),
+        createTrainingReviewInput(
+          entry.record,
+          expectedDecision,
+          correctionReason,
+          note,
+        ),
       );
       setSnapshot((current) =>
         current.reviews.some((existing) =>
@@ -322,13 +350,14 @@ export function TrainingReviewApp(
   const chooseDecision = (decision: Decision) => {
     if (selected === undefined || saving) return;
     if (decision === selected.record.verdict.decision) {
-      void persistDecision(selected, decision, undefined);
+      void persistDecision(selected, decision, undefined, undefined);
       return;
     }
     setError(undefined);
     setNoteEditor({
       recordId: selected.record.id,
       expectedDecision: decision,
+      correctionReason: undefined,
     });
   };
 
@@ -387,9 +416,19 @@ export function TrainingReviewApp(
         key.preventDefault();
         setNoteEditor(undefined);
         setError(undefined);
-      } else if (key.name === "tab") {
-        key.preventDefault();
+        return;
+      }
+
+      if (noteEditor.correctionReason === undefined) {
+        const reason = correctionReasonForKey(key.name, key.sequence);
+        if (reason !== undefined) {
+          key.preventDefault();
+          setNoteEditor({ ...noteEditor, correctionReason: reason });
+        }
+        return;
       }
+
+      if (key.name === "tab") key.preventDefault();
       return;
     }
 
@@ -847,6 +886,13 @@ export function TrainingReviewApp(
                           <text fg={decisionColor(review.expectedDecision)}>
                             {`${index + 1}. ${review.expectedDecision.toUpperCase()} · ${review.reviewedAt}`}
                           </text>
+                          {getTrainingCorrectionReason(review) === undefined
+                            ? null
+                            : (
+                              <text fg={COLORS.muted} wrapMode="word">
+                                {`Reason: ${correctionReasonLabel(getTrainingCorrectionReason(review)!)}`}
+                              </text>
+                            )}
                           {review.note === undefined
                             ? null
                             : <text fg={COLORS.text} wrapMode="word">{review.note}</text>}
@@ -860,31 +906,52 @@ export function TrainingReviewApp(
       </box>
 
       {noteEditor !== undefined && editingEntry !== undefined
-        ? (
-          <box
-            title={` Review revision: ${statusLabel(getTrainingReviewFilter(editingEntry))} → ${noteEditor.expectedDecision} `}
-            titleColor={decisionColor(noteEditor.expectedDecision)}
-            border
-            borderColor={decisionColor(noteEditor.expectedDecision)}
-            height={5}
-            paddingLeft={1}
-            paddingRight={1}
-            flexDirection="column"
-          >
-            <input
-              placeholder="Optional correction note — Enter saves, Esc cancels"
-              focused
-              onSubmit={(note) => {
-                void persistDecision(
-                  editingEntry,
-                  noteEditor.expectedDecision,
-                  typeof note === "string" ? note : undefined,
-                );
-              }}
-            />
-            <text fg={COLORS.muted}>Enter save revision · Esc cancel</text>
-          </box>
-        )
+        ? noteEditor.correctionReason === undefined
+          ? (
+            <box
+              title={` Why ${statusLabel(getTrainingReviewFilter(editingEntry))} → ${noteEditor.expectedDecision}? `}
+              titleColor={decisionColor(noteEditor.expectedDecision)}
+              border
+              borderColor={decisionColor(noteEditor.expectedDecision)}
+              height={CORRECTION_REASONS.length + 3}
+              paddingLeft={1}
+              paddingRight={1}
+              flexDirection="column"
+            >
+              {CORRECTION_REASONS.map((reason, index) => (
+                <text key={reason.value} fg={COLORS.text}>
+                  {`${index + 1}. ${reason.label}`}
+                </text>
+              ))}
+              <text fg={COLORS.muted}>1–9 select reason · Esc cancel</text>
+            </box>
+          )
+          : (
+            <box
+              title={` ${correctionReasonLabel(noteEditor.correctionReason)} `}
+              titleColor={decisionColor(noteEditor.expectedDecision)}
+              border
+              borderColor={decisionColor(noteEditor.expectedDecision)}
+              height={5}
+              paddingLeft={1}
+              paddingRight={1}
+              flexDirection="column"
+            >
+              <input
+                placeholder="Optional correction note — Enter saves, Esc cancels"
+                focused
+                onSubmit={(note) => {
+                  void persistDecision(
+                    editingEntry,
+                    noteEditor.expectedDecision,
+                    noteEditor.correctionReason,
+                    typeof note === "string" ? note : undefined,
+                  );
+                }}
+              />
+              <text fg={COLORS.muted}>Enter save revision · Esc cancel</text>
+            </box>
+          )
         : null}
 
       {error === undefined
@@ -1130,6 +1197,19 @@ function decisionForKey(
   return undefined;
 }
 
+function correctionReasonForKey(
+  name: string,
+  sequence: string,
+): TrainingCorrectionReason | undefined {
+  const index = Number(sequence || name) - 1;
+  return Number.isInteger(index) ? CORRECTION_REASONS[index]?.value : undefined;
+}
+
+function correctionReasonLabel(reason: TrainingCorrectionReason): string {
+  return CORRECTION_REASONS.find((candidate) => candidate.value === reason)
+    ?.label ?? reason;
+}
+
 function statusLabel(filter: TrainingReviewFilter): string {
   return {
     all: "ALL",

package/src/types.ts

@@ -5,6 +5,24 @@ import type { CommandAnalysis } from "./analyze.ts";
  */
 export type Host = "pi" | "claude-code" | "cli";
 
+/**
+ * JSON-compatible value accepted by the TypeSafe state boundary.
+ */
+export type JsonValue =
+  | string
+  | number
+  | boolean
+  | null
+  | ReadonlyArray<JsonValue>
+  | { readonly [key: string]: JsonValue };
+
+/**
+ * Exact JSON object submitted as TypeSafe state for one command.
+ */
+export type RenderedCommandState = {
+  readonly [key: string]: JsonValue;
+};
+
 /**
  * Everything demur knows about a command before judging it.
  *
@@ -160,3 +178,41 @@ export type Verdict = {
    */
   usage: { inputTokens: number; outputTokens: number } | undefined;
 };
+
+/**
+ * Reproducible inputs and implementation versions behind one guard verdict.
+ */
+export type GuardEvidence = {
+  /**
+   * Exact JSON state submitted to TypeSafe.
+   */
+  modelState: RenderedCommandState;
+  /**
+   * Deterministic command analysis used only by the local policy gate.
+   */
+  analysis: CommandAnalysis | undefined;
+  /**
+   * TypeSafe model identifier used for the judgment.
+   */
+  model: string;
+  /**
+   * Version of the question definitions used for the judgment.
+   */
+  questionSetVersion: number;
+  /**
+   * Version of the policy composition used for the verdict.
+   */
+  policyVersion: number;
+  /**
+   * Exact numeric thresholds used for the verdict.
+   */
+  policyThresholds: { readonly [key: string]: number };
+};
+
+/**
+ * Guard verdict paired with replayable evidence when state collection occurred.
+ */
+export type GuardEvaluation = {
+  verdict: Verdict;
+  evidence: GuardEvidence | undefined;
+};