@wwdrew/expo-spotify-sdk 2.3.0 → 2.3.1

package/android/src/main/java/expo/modules/spotifysdk/ExpoSpotifySDKModule.kt

@@ -8,7 +8,7 @@ import expo.modules.kotlin.functions.Coroutine
 import expo.modules.kotlin.modules.Module
 import expo.modules.kotlin.modules.ModuleDefinition
 
-private const val SDK_VERSION = "2.3.0" // x-release-please-version
+private const val SDK_VERSION = "2.3.1" // x-release-please-version
 private const val EVENT_SESSION_CHANGE = "onSessionChange"
 private const val EVENT_CONNECTION_STATE_CHANGE = "onConnectionStateChange"
 private const val EVENT_CONNECTION_ERROR = "onConnectionError"

package/ios/ExpoSpotifySDKModule.swift

@@ -1,7 +1,7 @@
 import ExpoModulesCore
 import SpotifyiOS
 
-private let SDK_VERSION = "2.3.0" // x-release-please-version
+private let SDK_VERSION = "2.3.1" // x-release-please-version
 private let EVENT_SESSION_CHANGE = "onSessionChange"
 private let EVENT_CONNECTION_STATE_CHANGE = "onConnectionStateChange"
 private let EVENT_CONNECTION_ERROR = "onConnectionError"

package/ios/NSError+SafeLocalizedDescription.swift

@@ -0,0 +1,40 @@
+import Foundation
+
+extension NSError {
+  /// `NSError.localizedDescription` force-bridges `userInfo[NSLocalizedDescriptionKey]`
+  /// to `String`. When that value is a non-`String` object (Spotify's SDK can deliver an
+  /// empty `__NSDictionary0`), the bridge sends `-length` to a dictionary and aborts.
+  var safeLocalizedDescription: String {
+    guard let value = userInfo[NSLocalizedDescriptionKey] else {
+      return localizedDescription
+    }
+    return (value as? String) ?? ""
+  }
+
+  /// Same force-bridge hazard as `localizedDescription`, but for
+  /// `NSLocalizedFailureReasonErrorKey`.
+  var safeLocalizedFailureReason: String? {
+    guard let value = userInfo[NSLocalizedFailureReasonErrorKey] else {
+      return localizedFailureReason
+    }
+    return value as? String
+  }
+}
+
+extension Error {
+  /// Summary for logging that avoids `String(describing:)` / `localizedDescription`
+  /// force-bridges on poisoned `userInfo` values.
+  var safeLogSummary: String {
+    let nsError = self as NSError
+    let description = nsError.safeLocalizedDescription
+    if description.isEmpty {
+      return "\(nsError.domain) code \(nsError.code)"
+    }
+    return "\(nsError.domain) code \(nsError.code): \(description)"
+  }
+}
+
+func safeLogSummary(for error: (any Error)?) -> String {
+  guard let error else { return "nil" }
+  return error.safeLogSummary
+}

package/ios/SpotifyAppRemoteConnection.swift

@@ -210,12 +210,12 @@ final class SpotifyAppRemoteDelegateBridge: NSObject, SPTAppRemoteDelegate {
   }
 
   func appRemote(_ appRemote: SPTAppRemote, didFailConnectionAttemptWithError error: (any Error)?) {
-    NSLog("[ExpoSpotifySDK] AppRemote: connection failed — %@", String(describing: error))
+    NSLog("[ExpoSpotifySDK] AppRemote: connection failed — %@", safeLogSummary(for: error))
     Task { await coordinator?.didFailToConnect(error: error) }
   }
 
   func appRemote(_ appRemote: SPTAppRemote, didDisconnectWithError error: (any Error)?) {
-    NSLog("[ExpoSpotifySDK] AppRemote: disconnected — %@", String(describing: error))
+    NSLog("[ExpoSpotifySDK] AppRemote: disconnected — %@", safeLogSummary(for: error))
     Task { await coordinator?.didDisconnect(error: error) }
   }
 }

package/ios/SpotifyAppRemoteCoordinator.swift

@@ -421,7 +421,7 @@ actor SpotifyAppRemoteCoordinator {
 
   func describeNSError(_ error: NSError) -> String {
     var parts: [String] = ["\(error.domain) code \(error.code)"]
-    let desc = error.localizedDescription
+    let desc = error.safeLocalizedDescription
     if !desc.isEmpty { parts.append("\"\(desc)\"") }
     if let underlying = error.userInfo[NSUnderlyingErrorKey] as? NSError {
       parts.append("→ \(describeNSError(underlying))")

package/ios/SpotifyAppRemoteErrorMapping.swift

@@ -30,71 +30,75 @@ enum SpotifyAppRemoteErrorMapping {
   }
 
   static func mapPlayerError(_ error: NSError, callsite: String) -> NativePlayerError {
+    let desc = error.safeLocalizedDescription
     guard isSPTError(error) else {
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
     if isConnectionTerminated(error) {
       return .connectionLost(connectionLostMessage(callsite: callsite))
     }
     if isInvalidArguments(error) {
-      let desc = error.localizedDescription.lowercased()
-      if desc.contains("uri") {
-        return .invalidURI("\(callsite): \(error.localizedDescription)")
+      let lower = desc.lowercased()
+      if lower.contains("uri") {
+        return .invalidURI("\(callsite): \(desc)")
       }
-      return .invalidParameter(error.localizedDescription)
+      return .invalidParameter(desc)
     }
     if isRequestFailed(error) {
-      let desc = error.localizedDescription.lowercased()
-      if desc.contains("premium") {
+      let lower = desc.lowercased()
+      if lower.contains("premium") {
         return .premiumRequired("\(callsite): Spotify Premium is required for on-demand playback")
       }
-      if containsRestriction(error.localizedDescription) {
-        return .operationNotAllowed("\(callsite): \(error.localizedDescription)")
+      if containsRestriction(desc) {
+        return .operationNotAllowed("\(callsite): \(desc)")
       }
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
-    return .unknown(error.localizedDescription)
+    return .unknown(desc)
   }
 
   static func mapUserError(_ error: NSError, callsite: String) -> NativeUserError {
+    let desc = error.safeLocalizedDescription
     guard isSPTError(error) else {
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
     if isConnectionTerminated(error) {
       return .connectionLost(connectionLostMessage(callsite: callsite))
     }
     if isInvalidArguments(error) {
-      return .invalidURI("\(callsite): \(error.localizedDescription)")
+      return .invalidURI("\(callsite): \(desc)")
     }
     if isRequestFailed(error) {
-      if containsRestriction(error.localizedDescription) {
-        return .operationNotAllowed("\(callsite): \(error.localizedDescription)")
+      if containsRestriction(desc) {
+        return .operationNotAllowed("\(callsite): \(desc)")
       }
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
-    return .unknown(error.localizedDescription)
+    return .unknown(desc)
   }
 
   static func mapContentError(_ error: NSError, callsite: String) -> NativeContentError {
+    let desc = error.safeLocalizedDescription
     guard isSPTError(error) else {
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
     if isConnectionTerminated(error) {
       return .connectionLost(connectionLostMessage(callsite: callsite))
     }
     if isRequestFailed(error) {
-      let desc = error.localizedDescription.lowercased()
-      if desc.contains("not supported") || desc.contains("unsupported") {
+      let lower = desc.lowercased()
+      if lower.contains("not supported") || lower.contains("unsupported") {
         return .contentAPIUnavailable("\(callsite): content API is unavailable on this Spotify app version")
       }
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
-    return .unknown(error.localizedDescription)
+    return .unknown(desc)
   }
 
   static func mapImagesError(_ error: NSError, callsite: String) -> NativeImagesError {
+    let desc = error.safeLocalizedDescription
     guard isSPTError(error) else {
-      return .unknown(error.localizedDescription)
+      return .unknown(desc)
     }
     if isConnectionTerminated(error) {
       return .notConnected(connectionLostMessage(callsite: callsite))
@@ -105,6 +109,6 @@ enum SpotifyAppRemoteErrorMapping {
     if isRequestFailed(error) {
       return .imageLoadFailed("\(callsite): Spotify rejected image request")
     }
-    return .unknown(error.localizedDescription)
+    return .unknown(desc)
   }
 }

package/ios/SpotifyAuthCoordinator.swift

@@ -138,7 +138,7 @@ final class SpotifySessionDelegateBridge: NSObject, SPTSessionManagerDelegate {
   }
 
   func sessionManager(manager _: SPTSessionManager, didFailWith error: Error) {
-    NSLog("[ExpoSpotifySDK] didFailWithError %@", String(describing: error))
+    NSLog("[ExpoSpotifySDK] didFailWithError %@", error.safeLogSummary)
     let mapped = SpotifyAuthErrorMapping.classify(
       error,
       context: .init(tokenSwapConfigured: authContext?.tokenSwapURL != nil)

package/ios/SpotifyAuthErrorMapping.swift

@@ -176,10 +176,8 @@ enum SpotifyAuthErrorMapping {
       "server", "unauthorized", "forbidden", "invalid"
     ]
     let combined = [
-      error.localizedDescription,
-      error.localizedFailureReason ?? "",
-      error.userInfo[NSLocalizedDescriptionKey] as? String ?? "",
-      error.userInfo[NSLocalizedFailureReasonErrorKey] as? String ?? ""
+      error.safeLocalizedDescription,
+      error.safeLocalizedFailureReason ?? ""
     ].joined(separator: " ").lowercased()
 
     if negativeKeywords.contains(where: { combined.contains($0) }) {
@@ -212,7 +210,7 @@ enum SpotifyAuthErrorMapping {
   /// in-process classification heuristics only.
   private static func describeError(_ error: NSError, redactUserInfo: Bool = false) -> String {
     var parts: [String] = ["\(error.domain) code \(error.code)"]
-    let desc = error.localizedDescription
+    let desc = error.safeLocalizedDescription
     if !desc.isEmpty {
       parts.append("\"\(desc)\"")
     }

package/ios/SpotifyTokenRefreshClient.swift

@@ -23,7 +23,7 @@ enum SpotifyRefreshError: Error {
     case .invalidURL(let s):
       return "Invalid token refresh URL: \(s)"
     case .network(let err):
-      return err.localizedDescription
+      return (err as NSError).safeLocalizedDescription
     case .http(let status, let body):
       let trimmed = body.map { String($0.prefix(512)) } ?? ""
       return "Token refresh server returned HTTP \(status)\(trimmed.isEmpty ? "" : ": \(trimmed)")"
@@ -127,7 +127,9 @@ struct SpotifyTokenRefreshClient {
       }
       json = parsed
     } catch {
-      throw SpotifyRefreshError.parse("Refresh response was not valid JSON: \(error.localizedDescription)")
+      throw SpotifyRefreshError.parse(
+        "Refresh response was not valid JSON: \((error as NSError).safeLocalizedDescription)"
+      )
     }
 
     guard let accessToken = (json["access_token"] as? String), !accessToken.isEmpty else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wwdrew/expo-spotify-sdk",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "Expo module wrapping the native Spotify iOS (v5) and Android (v4) SDKs for OAuth authentication and App Remote playback control",
   "main": "build/index.js",
   "types": "build/index.d.ts",