@wtree/payload-ecommerce-coupon 3.78.6 → 3.78.8

package/dist/index.mjs

@@ -426,6 +426,17 @@ const createReferralCodesCollection = (pluginConfig) => {
 function toNumber(value) {
 	return typeof value === "number" && Number.isFinite(value) ? value : null;
 }
+/**
+* Scaling policy:
+*   - Admin inputs normal currency values (e.g. 100 means $100).
+*   - Internally, maxPartnerCommissionPerOrder, maxCustomerDiscountPerOrder, and
+*     minOrderAmount are stored in x100 (integer cents) form to avoid floating-point
+*     drift on monetary cap fields.
+*   - beforeChange  →  multiply by 100 before persisting.
+*   - afterRead     →  divide by 100 before returning to admin / calculation code.
+*   - partnerAmount / customerAmount per-rule fixed amounts are NOT scaled here;
+*     they represent per-item fixed currency amounts and are stored as-is.
+*/
 const createReferralProgramsCollection = (pluginConfig) => {
 	const { collections, access, adminGroups, referralConfig, integration } = pluginConfig;
 	const allowedTotalCommissionTypes = referralConfig.allowedTotalCommissionTypes;
@@ -448,88 +459,102 @@ const createReferralProgramsCollection = (pluginConfig) => {
 			update: access.isAdmin || (() => false),
 			delete: access.isAdmin || (() => false)
 		},
-		hooks: { beforeChange: [({ data }) => {
-			if (!data.commissionRules || !Array.isArray(data.commissionRules) || data.commissionRules.length === 0) throw new APIError("At least one commission rule is required", 400);
-			const maxPartnerCommissionPerOrder = toNumber(data.maxPartnerCommissionPerOrder);
-			if (maxPartnerCommissionPerOrder != null && maxPartnerCommissionPerOrder < 0) throw new APIError("Maximum commission per order for partner must be a non-negative number", 400);
-			const maxCustomerDiscountPerOrder = toNumber(data.maxCustomerDiscountPerOrder);
-			if (maxCustomerDiscountPerOrder != null && maxCustomerDiscountPerOrder < 0) throw new APIError("Maximum discount for customer per order must be a non-negative number", 400);
-			const minOrderAmount = toNumber(data.minOrderAmount);
-			if (minOrderAmount != null && minOrderAmount < 0) throw new APIError("Minimum Order Amount must be a non-negative number", 400);
-			data.maxPartnerCommissionPerOrder = maxPartnerCommissionPerOrder != null ? maxPartnerCommissionPerOrder : null;
-			data.maxCustomerDiscountPerOrder = maxCustomerDiscountPerOrder != null ? maxCustomerDiscountPerOrder : null;
-			data.minOrderAmount = minOrderAmount ?? null;
-			data.commissionRules = data.commissionRules.map((rule, index) => {
-				const r = rule;
-				if (!r.totalCommission) throw new APIError(`Commission rule ${index + 1}: Total Commission is required`, 400);
-				if (!r.totalCommission.type || !allowedTotalCommissionTypes.includes(r.totalCommission.type)) throw new APIError(`Commission rule ${index + 1}: Total Commission type must be one of ${allowedTotalCommissionTypes.join(", ")}`, 400);
-				const type = r.totalCommission.type;
-				const appliesTo = r.appliesTo ?? "all";
-				if (appliesTo === "products" && (!r.products || r.products.length === 0)) throw new APIError(`Commission rule ${index + 1}: At least one product is required`, 400);
-				if ((appliesTo === "segments" || appliesTo === "categories") && (!r.categories || r.categories.length === 0) && (!r.tags || r.tags.length === 0)) throw new APIError(`Commission rule ${index + 1}: At least one category or tag is required`, 400);
-				let partnerSplit;
-				let customerSplit;
-				let partnerPercent = null;
-				let customerPercent = null;
-				let partnerAmount = null;
-				let customerAmount = null;
-				let splitWarning = null;
-				if (type === "percentage") {
-					const partnerPctInput = toNumber(r.partnerPercent) ?? toNumber(r.partnerSplit);
-					const customerPctInput = toNumber(r.customerPercent) ?? toNumber(r.customerSplit);
-					if (partnerPctInput == null || partnerPctInput < 0 || partnerPctInput > 100) throw new APIError(`Commission rule ${index + 1}: Partner Split must be between 0 and 100`, 400);
-					if (customerPctInput != null && (customerPctInput < 0 || customerPctInput > 100)) throw new APIError(`Commission rule ${index + 1}: Customer percentage must be between 0 and 100`, 400);
-					const customerPctComputed = customerPctInput != null ? customerPctInput : 100 - partnerPctInput;
-					const percentTotal = partnerPctInput + customerPctComputed;
-					if (percentTotal > 100) throw new APIError(`Commission rule ${index + 1}: Partner percentage + Customer percentage cannot exceed 100`, 400);
-					if (percentTotal > 50) splitWarning = `High total split configured: ${percentTotal}% (partner + customer).`;
-					partnerPercent = partnerPctInput;
-					customerPercent = customerPctComputed;
-					partnerSplit = partnerPctInput;
-					customerSplit = customerPctComputed;
-				} else {
-					const partnerAmountInput = toNumber(r.partnerAmount);
-					const customerAmountInput = toNumber(r.customerAmount);
-					const legacyPartnerSplitInput = toNumber(r.partnerSplit);
-					const legacyCustomerSplitInput = toNumber(r.customerSplit);
-					const hasNewFixedInputs = partnerAmountInput != null || customerAmountInput != null;
-					const hasLegacyFixedInputs = legacyPartnerSplitInput != null || legacyCustomerSplitInput != null;
-					if (hasNewFixedInputs) {
-						if (partnerAmountInput == null || partnerAmountInput < 0) throw new APIError(`Commission rule ${index + 1}: Partner fixed amount must be a non-negative number`, 400);
-						if (customerAmountInput == null || customerAmountInput < 0) throw new APIError(`Commission rule ${index + 1}: Customer fixed amount must be a non-negative number`, 400);
-						partnerAmount = partnerAmountInput;
-						customerAmount = customerAmountInput;
-						partnerSplit = partnerAmountInput;
-						customerSplit = customerAmountInput;
-					} else if (hasLegacyFixedInputs) {
-						if (legacyPartnerSplitInput == null || legacyPartnerSplitInput < 0) throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be non-negative numbers`, 400);
-						const resolvedLegacyCustomerSplit = legacyCustomerSplitInput ?? 100 - legacyPartnerSplitInput;
-						if (resolvedLegacyCustomerSplit == null || resolvedLegacyCustomerSplit < 0) throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be non-negative numbers`, 400);
-						partnerSplit = legacyPartnerSplitInput;
-						customerSplit = resolvedLegacyCustomerSplit;
-						partnerAmount = null;
-						customerAmount = null;
-					} else throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be provided`, 400);
-				}
-				return {
-					...rule,
-					appliesTo: appliesTo === "categories" ? "segments" : appliesTo,
-					totalCommission: {
-						type,
-						...typeof r.totalCommission.value === "number" ? { value: r.totalCommission.value } : {},
-						...typeof r.totalCommission.maxAmount === "number" ? { maxAmount: r.totalCommission.maxAmount } : {}
-					},
-					partnerPercent,
-					customerPercent,
-					partnerAmount,
-					customerAmount,
-					partnerSplit,
-					customerSplit,
-					splitWarning
+		hooks: {
+			beforeChange: [({ data }) => {
+				if (!data.commissionRules || !Array.isArray(data.commissionRules) || data.commissionRules.length === 0) throw new APIError("At least one commission rule is required", 400);
+				const rawMaxPartner = toNumber(data.maxPartnerCommissionPerOrder);
+				if (rawMaxPartner != null && rawMaxPartner < 0) throw new APIError("Maximum commission per order for partner must be a non-negative number", 400);
+				const rawMaxCustomer = toNumber(data.maxCustomerDiscountPerOrder);
+				if (rawMaxCustomer != null && rawMaxCustomer < 0) throw new APIError("Maximum discount for customer per order must be a non-negative number", 400);
+				const rawMinOrder = toNumber(data.minOrderAmount);
+				if (rawMinOrder != null && rawMinOrder < 0) throw new APIError("Minimum Order Amount must be a non-negative number", 400);
+				data.maxPartnerCommissionPerOrder = rawMaxPartner != null ? Math.round(rawMaxPartner * 100) : null;
+				data.maxCustomerDiscountPerOrder = rawMaxCustomer != null ? Math.round(rawMaxCustomer * 100) : null;
+				data.minOrderAmount = rawMinOrder != null ? Math.round(rawMinOrder * 100) : null;
+				data.commissionRules = data.commissionRules.map((rule, index) => {
+					const r = rule;
+					if (!r.totalCommission) throw new APIError(`Commission rule ${index + 1}: Total Commission is required`, 400);
+					if (!r.totalCommission.type || !allowedTotalCommissionTypes.includes(r.totalCommission.type)) throw new APIError(`Commission rule ${index + 1}: Total Commission type must be one of ${allowedTotalCommissionTypes.join(", ")}`, 400);
+					const type = r.totalCommission.type;
+					const appliesTo = r.appliesTo ?? "all";
+					if (appliesTo === "products" && (!r.products || r.products.length === 0)) throw new APIError(`Commission rule ${index + 1}: At least one product is required`, 400);
+					if ((appliesTo === "segments" || appliesTo === "categories") && (!r.categories || r.categories.length === 0) && (!r.tags || r.tags.length === 0)) throw new APIError(`Commission rule ${index + 1}: At least one category or tag is required`, 400);
+					let partnerSplit;
+					let customerSplit;
+					let partnerPercent = null;
+					let customerPercent = null;
+					let partnerAmount = null;
+					let customerAmount = null;
+					let splitWarning = null;
+					if (type === "percentage") {
+						const partnerPctInput = toNumber(r.partnerPercent) ?? toNumber(r.partnerSplit);
+						const customerPctInput = toNumber(r.customerPercent) ?? toNumber(r.customerSplit);
+						if (partnerPctInput == null || partnerPctInput < 0 || partnerPctInput > 100) throw new APIError(`Commission rule ${index + 1}: Partner Split must be between 0 and 100`, 400);
+						if (customerPctInput != null && (customerPctInput < 0 || customerPctInput > 100)) throw new APIError(`Commission rule ${index + 1}: Customer percentage must be between 0 and 100`, 400);
+						const customerPctComputed = customerPctInput != null ? customerPctInput : 100 - partnerPctInput;
+						const percentTotal = partnerPctInput + customerPctComputed;
+						if (percentTotal > 100) throw new APIError(`Commission rule ${index + 1}: Partner percentage + Customer percentage cannot exceed 100`, 400);
+						if (percentTotal > 50) splitWarning = `High total split configured: ${percentTotal}% (partner + customer).`;
+						partnerPercent = partnerPctInput;
+						customerPercent = customerPctComputed;
+						partnerSplit = partnerPctInput;
+						customerSplit = customerPctComputed;
+					} else {
+						const partnerAmountInput = toNumber(r.partnerAmount);
+						const customerAmountInput = toNumber(r.customerAmount);
+						const legacyPartnerSplitInput = toNumber(r.partnerSplit);
+						const legacyCustomerSplitInput = toNumber(r.customerSplit);
+						const hasNewFixedInputs = partnerAmountInput != null || customerAmountInput != null;
+						const hasLegacyFixedInputs = legacyPartnerSplitInput != null || legacyCustomerSplitInput != null;
+						if (hasNewFixedInputs) {
+							if (partnerAmountInput == null || partnerAmountInput < 0) throw new APIError(`Commission rule ${index + 1}: Partner fixed amount must be a non-negative number`, 400);
+							if (customerAmountInput == null || customerAmountInput < 0) throw new APIError(`Commission rule ${index + 1}: Customer fixed amount must be a non-negative number`, 400);
+							partnerAmount = partnerAmountInput;
+							customerAmount = customerAmountInput;
+							partnerSplit = partnerAmountInput;
+							customerSplit = customerAmountInput;
+						} else if (hasLegacyFixedInputs) {
+							if (legacyPartnerSplitInput == null || legacyPartnerSplitInput < 0) throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be non-negative numbers`, 400);
+							const resolvedLegacyCustomerSplit = legacyCustomerSplitInput ?? 100 - legacyPartnerSplitInput;
+							if (resolvedLegacyCustomerSplit == null || resolvedLegacyCustomerSplit < 0) throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be non-negative numbers`, 400);
+							partnerSplit = legacyPartnerSplitInput;
+							customerSplit = resolvedLegacyCustomerSplit;
+							partnerAmount = null;
+							customerAmount = null;
+						} else throw new APIError(`Commission rule ${index + 1}: For fixed commissions, both partner and customer values must be provided`, 400);
+					}
+					return {
+						...rule,
+						appliesTo: appliesTo === "categories" ? "segments" : appliesTo,
+						totalCommission: {
+							type,
+							...typeof r.totalCommission.value === "number" ? { value: r.totalCommission.value } : {},
+							...typeof r.totalCommission.maxAmount === "number" ? { maxAmount: r.totalCommission.maxAmount } : {}
+						},
+						partnerPercent,
+						customerPercent,
+						partnerAmount,
+						customerAmount,
+						partnerSplit,
+						customerSplit,
+						splitWarning
+					};
+				});
+				return data;
+			}],
+			afterRead: [({ doc }) => {
+				if (!doc) return doc;
+				const unscale = (value) => {
+					const n = toNumber(value);
+					if (n == null) return null;
+					return Math.round(n / 100 * 100) / 100;
 				};
-			});
-			return data;
-		}] },
+				doc.maxPartnerCommissionPerOrder = unscale(doc.maxPartnerCommissionPerOrder);
+				doc.maxCustomerDiscountPerOrder = unscale(doc.maxCustomerDiscountPerOrder);
+				doc.minOrderAmount = unscale(doc.minOrderAmount);
+				return doc;
+			}]
+		},
 		fields: [
 			{
 				name: "name",
@@ -547,19 +572,19 @@ const createReferralProgramsCollection = (pluginConfig) => {
 				name: "maxPartnerCommissionPerOrder",
 				type: "number",
 				min: 0,
-				admin: { description: "Maximum commission per order for partner. Leave empty for no cap." }
+				admin: { description: "Maximum commission per order for partner (enter normal currency value, e.g. 50 for $50). Leave empty for no cap." }
 			},
 			{
 				name: "maxCustomerDiscountPerOrder",
 				type: "number",
 				min: 0,
-				admin: { description: "Maximum customer discount per order. Leave empty for no cap." }
+				admin: { description: "Maximum customer discount per order (enter normal currency value, e.g. 25 for $25). Leave empty for no cap." }
 			},
 			{
 				name: "minOrderAmount",
 				type: "number",
 				min: 0,
-				admin: { description: "Minimum cart subtotal required for this program. Leave empty for no minimum." }
+				admin: { description: "Minimum cart subtotal required for this program (enter normal currency value, e.g. 100 for $100). Leave empty for no minimum." }
 			},
 			{
 				name: "commissionRules",
@@ -640,7 +665,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						max: 100,
 						admin: {
 							condition: (_, siblingData) => siblingData?.totalCommission?.type === "percentage",
-							description: "Partner share in percent (0-100)"
+							description: "Partner share in percent (0–100)"
 						}
 					},
 					{
@@ -650,7 +675,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						max: 100,
 						admin: {
 							condition: (_, siblingData) => siblingData?.totalCommission?.type === "percentage",
-							description: "Customer share percentage. (0-100). Partner + Customer cannot exceed 100."
+							description: "Customer share percentage (0–100). Partner + Customer cannot exceed 100."
 						}
 					},
 					{
@@ -659,7 +684,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						min: 0,
 						admin: {
 							condition: (_, siblingData) => siblingData?.totalCommission?.type === "fixed",
-							description: "Fixed partner commission amount per item."
+							description: "Fixed partner commission amount per item (normal currency value, e.g. 12.50 for $12.50)."
 						}
 					},
 					{
@@ -668,7 +693,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						min: 0,
 						admin: {
 							condition: (_, siblingData) => siblingData?.totalCommission?.type === "fixed",
-							description: "Fixed customer discount amount per item."
+							description: "Fixed customer discount amount per item (normal currency value, e.g. 5 for $5)."
 						}
 					},
 					{
@@ -677,7 +702,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						min: 0,
 						admin: {
 							hidden: true,
-							description: "Canonical storage field. Percentage mode: percent. Fixed mode: amount."
+							description: "Canonical storage field. Percentage mode: percent value. Fixed mode: per-item amount."
 						}
 					},
 					{
@@ -686,7 +711,7 @@ const createReferralProgramsCollection = (pluginConfig) => {
 						min: 0,
 						admin: {
 							hidden: true,
-							description: "Canonical storage field. Percentage mode: percent. Fixed mode: amount."
+							description: "Canonical storage field. Percentage mode: percent value. Fixed mode: per-item amount."
 						}
 					}
 				]
@@ -873,8 +898,7 @@ function selectBestRuleForItem({ rules, item, itemTotal, quantity, cartTotal, mi
 	const eligibleRules = rules.filter((rule) => {
 		if (!(rule?.totalCommission?.type ? allowedTypes.has(rule.totalCommission.type) : true)) return false;
 		const resolvedMinOrderAmount = typeof minOrderAmount === "number" && Number.isFinite(minOrderAmount) ? minOrderAmount : typeof rule?.minOrderAmount === "number" && Number.isFinite(rule.minOrderAmount) ? rule.minOrderAmount : null;
-		const shouldApplyMinOrder = rule?.totalCommission?.type !== "fixed";
-		if (resolvedMinOrderAmount != null && shouldApplyMinOrder) return cartTotal >= resolvedMinOrderAmount;
+		if (resolvedMinOrderAmount != null) return cartTotal >= resolvedMinOrderAmount;
 		return true;
 	});
 	const productId = relationId$5(item.product);
@@ -924,13 +948,10 @@ function selectBestRuleForItem({ rules, item, itemTotal, quantity, cartTotal, mi
 	return best;
 }
 function getProgramMinimumOrderAmount({ program, allowedTotalCommissionTypes }) {
+	if (typeof program?.minOrderAmount === "number" && Number.isFinite(program.minOrderAmount)) return program.minOrderAmount;
 	const rules = Array.isArray(program?.commissionRules) ? program.commissionRules : [];
 	if (!rules.length) return null;
 	const allowedTypes = allowedCommissionTypesSet(allowedTotalCommissionTypes);
-	if (rules.some((rule) => {
-		if (rule?.totalCommission?.type) return rule.totalCommission.type === "percentage" && allowedTypes.has(rule.totalCommission.type);
-		return true;
-	}) && typeof program?.minOrderAmount === "number" && Number.isFinite(program.minOrderAmount)) return program.minOrderAmount;
 	const minValues = rules.filter((rule) => {
 		if (rule?.totalCommission?.type) return allowedTypes.has(rule.totalCommission.type);
 		return true;
@@ -1174,17 +1195,17 @@ async function handleCouponCode({ payload, cart, cartID, normalizedCode, custome
 	}, { status: 400 });
 	const cartSubtotal = Number(resolvers.getCartSubtotal(cart)) || 0;
 	const cartTotal = Number(resolvers.getCartTotal(cart)) || cartSubtotal || 0;
-	if (coupon.minOrderValue && cartTotal < coupon.minOrderValue) return Response.json({
+	if (coupon.minOrderValue && cartSubtotal < coupon.minOrderValue) return Response.json({
 		success: false,
 		error: `Minimum order value of ${coupon.minOrderValue} ${pluginConfig.defaultCurrency} required`
 	}, { status: 400 });
-	if (coupon.maxOrderValue && cartTotal > coupon.maxOrderValue) return Response.json({
+	if (coupon.maxOrderValue && cartSubtotal > coupon.maxOrderValue) return Response.json({
 		success: false,
 		error: `Maximum order value of ${coupon.maxOrderValue} ${pluginConfig.defaultCurrency} exceeded`
 	}, { status: 400 });
 	const discountAmount = calculateCouponDiscount({
 		coupon,
-		cartTotal
+		cartTotal: cartSubtotal
 	});
 	const nextTotal = roundTo2(Math.max(0, cartTotal - discountAmount));
 	const data = {};
@@ -1246,12 +1267,13 @@ async function handleReferralCode({ payload, cart, cartID, normalizedCode, plugi
 		error: "Referral code already applied to this cart"
 	}, { status: 400 });
 	const cartItems = resolvers.getCartItems(cart);
-	const cartTotal = Number(resolvers.getCartTotal(cart)) || Number(resolvers.getCartSubtotal(cart)) || 0;
+	const cartSubtotal = Number(resolvers.getCartSubtotal(cart)) || 0;
+	const cartTotal = Number(resolvers.getCartTotal(cart)) || cartSubtotal || 0;
 	const minOrderAmount = getProgramMinimumOrderAmount({
 		program,
 		allowedTotalCommissionTypes: pluginConfig.referralConfig.allowedTotalCommissionTypes
 	});
-	if (typeof minOrderAmount === "number" && cartTotal < minOrderAmount) return Response.json({
+	if (typeof minOrderAmount === "number" && cartSubtotal < minOrderAmount) return Response.json({
 		success: false,
 		error: `Minimum order value of ${minOrderAmount} ${pluginConfig.defaultCurrency} required for this referral program`
 	}, { status: 400 });
@@ -1259,7 +1281,7 @@ async function handleReferralCode({ payload, cart, cartID, normalizedCode, plugi
 		cartItems,
 		program,
 		currencyCode: pluginConfig.defaultCurrency,
-		cartTotal,
+		cartTotal: cartSubtotal,
 		allowedTotalCommissionTypes: pluginConfig.referralConfig.allowedTotalCommissionTypes
 	});
 	const roundedPartnerCommission = roundTo2(partnerCommission);
@@ -1688,7 +1710,7 @@ async function validateReferralCode({ payload, normalizedCode, cartID, pluginCon
 		id: cartID,
 		depth: 2
 	}) : null;
-	const cartTotal = cart ? Number(resolvers.getCartTotal(cart)) || Number(resolvers.getCartSubtotal(cart)) || 0 : 0;
+	const cartTotal = cart ? Number(resolvers.getCartSubtotal(cart)) || Number(resolvers.getCartTotal(cart)) || 0 : 0;
 	const minOrderAmount = getProgramMinimumOrderAmount({
 		program,
 		allowedTotalCommissionTypes: pluginConfig.referralConfig.allowedTotalCommissionTypes