@wtfalch/foundry 0.16.15 → 0.16.16
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/org.d.ts +28 -5
- package/dist/org.js +19 -0
- package/dist/plan/deploy-health.d.ts +136 -0
- package/dist/plan/deploy-health.js +153 -0
- package/dist/plan/diff.js +50 -9
- package/dist/plan/entry-files-key.d.ts +3 -1
- package/dist/plan/entry-files-key.js +7 -10
- package/dist/plan/executor.d.ts +52 -5
- package/dist/plan/executor.js +79 -6
- package/dist/plan/hostnames.d.ts +6 -0
- package/dist/plan/hostnames.js +13 -0
- package/dist/plan/index.d.ts +1 -1
- package/dist/plan/index.js +1 -1
- package/dist/plan/plan-apply.d.ts +17 -0
- package/dist/plan/plan-apply.js +48 -3
- package/dist/plan/platform-diff.d.ts +89 -9
- package/dist/plan/platform-diff.js +176 -13
- package/dist/plan/platform-org.d.ts +9 -0
- package/dist/plan/platform-providers.d.ts +38 -5
- package/dist/plan/platform-providers.js +520 -99
- package/package.json +2 -2
|
@@ -4,9 +4,10 @@ import { applyObjects, openInstance, platformMailSettingsObjects } from '@wtfalc
|
|
|
4
4
|
import { VERSIONS, floatingTagBlocked } from '../bootstrap/versions.js';
|
|
5
5
|
import { redactSecrets } from '../calls-sfu-deploy-support.js';
|
|
6
6
|
import { ensureCloudflaredConnector } from './cloudflared-connector.js';
|
|
7
|
+
import { waitForDeploymentFinished, waitForHealthyVersion, waitForNewDeployment, } from './deploy-health.js';
|
|
7
8
|
import { ACCESS_POLICY_NAME, getDatabaseStarted, isNotFoundError, isRunningOrStarting, } from './executor.js';
|
|
8
|
-
import { coolifyDomains } from './hostnames.js';
|
|
9
|
-
import { AUTH_ZITADEL_RUN_OPTIONS, JOBS_SCHEDULER_KEY, PLATFORM_AI_APPLIED_GITREF_SCOPE_KEY, PLATFORM_AI_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_AI_DEPLOY_PENDING_SCOPE_KEY, PLATFORM_AI_INTERNAL_URL_SCOPE_KEY, PLATFORM_AI_KEY, PLATFORM_AI_MANAGEMENT_KEY_CONFLICT_SCOPE_KEY, PLATFORM_AI_MANAGEMENT_KEY_SCOPE_KEY, PLATFORM_AI_MANAGEMENT_KEY_UNDELIVERED_SCOPE_KEY, PLATFORM_AI_MIGRATE_BLOCKED_SCOPE_KEY, PLATFORM_AI_ORGANISATION_SCOPE_KEY,
|
|
9
|
+
import { coolifyDomains, filesShareHostname } from './hostnames.js';
|
|
10
|
+
import { AUTH_ZITADEL_RUN_OPTIONS, JOBS_SCHEDULER_KEY, PLATFORM_AI_APPLIED_GITREF_SCOPE_KEY, PLATFORM_AI_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_AI_DEPLOY_PENDING_SCOPE_KEY, PLATFORM_AI_INTERNAL_URL_SCOPE_KEY, PLATFORM_AI_KEY, PLATFORM_AI_MANAGEMENT_KEY_CONFLICT_SCOPE_KEY, PLATFORM_AI_MANAGEMENT_KEY_SCOPE_KEY, PLATFORM_AI_MANAGEMENT_KEY_UNDELIVERED_SCOPE_KEY, PLATFORM_AI_MIGRATE_BLOCKED_SCOPE_KEY, PLATFORM_AI_ORGANISATION_SCOPE_KEY, PLATFORM_AI_SIGNING_KEY_SET_SCOPE_KEY, PLATFORM_AI_SIGNING_KEY_UNDELIVERED_SCOPE_KEY, PLATFORM_ARCHON_APPLIED_BROKER_SCOPE_KEY, PLATFORM_ARCHON_APPLIED_GIT_REF_SCOPE_KEY, PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_ARCHON_APPLIED_OPERATOR_SCOPE_KEY, PLATFORM_ARCHON_CONNECTOR_APP_SCOPE_KEY, PLATFORM_ARCHON_GATE_CLOSED_SCOPE_KEY, PLATFORM_ARCHON_INTEGRATIONS_KEY_SYNCED_SCOPE_KEY, PLATFORM_ARCHON_KEY, PLATFORM_ARCHON_MASTER_CLOUDFLARE_TOKEN_REF, PLATFORM_ARCHON_MASTER_COOLIFY_TOKEN_REF, PLATFORM_ARCHON_MASTER_COOLIFY_URL_REF, PLATFORM_AUTH_ADMIN_UNDELIVERED_SCOPE_KEY, PLATFORM_AUTH_ADMIN_USER_SCOPE_KEY, PLATFORM_AUTH_BROKER_DEPLOYED_SCOPE_KEY, PLATFORM_AUTH_BROKER_SCOPE_KEY, PLATFORM_AUTH_CONNECTOR_APP_SCOPE_KEY, PLATFORM_AUTH_INSTANCE_SCOPE_KEY, PLATFORM_AUTH_INSTANCE_UNDELIVERED_SCOPE_KEY, PLATFORM_AUTH_KEY, PLATFORM_AUTH_LOGIN_CLIENT_UNDELIVERED_SCOPE_KEY, PLATFORM_AUTH_LOGIN_CLIENT_USER_SCOPE_KEY, PLATFORM_AUTH_OWNER_INVITE_SCOPE_KEY, PLATFORM_AUTH_SMTP_SCOPE_KEY, PLATFORM_AUTH_ZITADEL_APPLIED_IMAGE_TAG_SCOPE_KEY, PLATFORM_AUTH_ZITADEL_RUN_OPTIONS_SCOPE_KEY, PLATFORM_BACKUP_DATABASE_SCOPE_KEYS, PLATFORM_BACKUP_SERVICE_KEYS, PLATFORM_FILES_APPLIED_GIT_REF_SCOPE_KEY, PLATFORM_FILES_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_FILES_INTERNAL_URL_SCOPE_KEY, PLATFORM_FILES_INTROSPECTION_SCOPE_KEY, PLATFORM_FILES_INTROSPECTION_UNDELIVERED_SCOPE_KEY, PLATFORM_FILES_KEY, PLATFORM_FILES_MANAGEMENT_KEY_SCOPE_KEY, PLATFORM_FILES_MANAGEMENT_UNDELIVERED_SCOPE_KEY, PLATFORM_FILES_ZITADEL_PROJECT_SCOPE_KEY, PLATFORM_INTEGRATIONS_APPLIED_GITREF_SCOPE_KEY, PLATFORM_INTEGRATIONS_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY, PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY_SET_SCOPE_KEY, PLATFORM_INTEGRATIONS_KEY_UNDELIVERED_SCOPE_KEY, PLATFORM_INTEGRATIONS_RUNNER_KEYRING_DEPLOYED_SCOPE_KEY, PLATFORM_MAIL_ADMIN_KEY_SCOPE_KEY, PLATFORM_MAIL_ADMIN_UNDELIVERED_SCOPE_KEY, PLATFORM_MAIL_APPLIED_GIT_REF_SCOPE_KEY, PLATFORM_MAIL_APPLIED_HOSTNAME_SCOPE_KEY, PLATFORM_MAIL_CONNECTOR_APP_SCOPE_KEY, PLATFORM_MAIL_INTERNAL_URL_SCOPE_KEY, PLATFORM_MAIL_KEY, PLATFORM_MAIL_ZITADEL_PROJECT_SCOPE_KEY, archonBootstrapOperator, parseBrokerDeployRecord, parseLoginClientRecord, platformMailMxHost, } from './platform-diff.js';
|
|
10
11
|
import { applyCallsSfuPlatformStep } from './platform-sfu.js';
|
|
11
12
|
import { CreateInstanceError, createZitadelInstance, generateSystemApiKeypair, instanceWithoutBearerMessage, systemApiUsersEnv, } from './zitadel-system-api.js';
|
|
12
13
|
/** The key `runPlatformSteps` records the apex zone's id under (`system:kind:key`). */
|
|
@@ -258,7 +259,10 @@ export class FoundryPlatformStepExecutor {
|
|
|
258
259
|
recordedIds[`coolify:app:${PLATFORM_ARCHON_KEY}`]) {
|
|
259
260
|
const accessDrifted = await archonAccessDrifted(this.archon.cloudflare, platform.archon.hostname, this.archon.accessEmails);
|
|
260
261
|
const brokerDrifted = !accessDrifted && (await archonBrokerRegistrationDrifted(this.archon.coolify, recordedIds));
|
|
261
|
-
|
|
262
|
+
const bootstrapOperatorDrifted = !accessDrifted &&
|
|
263
|
+
!brokerDrifted &&
|
|
264
|
+
(await archonBootstrapOperatorDrifted(this.archon.coolify, recordedIds[`coolify:app:${PLATFORM_ARCHON_KEY}`], recordedIds));
|
|
265
|
+
if (accessDrifted || brokerDrifted || bootstrapOperatorDrifted)
|
|
262
266
|
result.archon = true;
|
|
263
267
|
}
|
|
264
268
|
if (platform.auth.enabled && this.auth) {
|
|
@@ -276,7 +280,10 @@ export class FoundryPlatformStepExecutor {
|
|
|
276
280
|
if (platform.files.enabled && this.files && recordedIds[`coolify:app:${PLATFORM_FILES_KEY}`]) {
|
|
277
281
|
// A Coolify read error must not fail the whole plan: treat it as not drifted.
|
|
278
282
|
try {
|
|
279
|
-
if (await filesRunnerEnvDrifted(this.files.coolify, recordedIds
|
|
283
|
+
if (await filesRunnerEnvDrifted(this.files.coolify, recordedIds, {
|
|
284
|
+
publicHosts: this.files.publicHosts,
|
|
285
|
+
shareDomains: filesShareDomains(await this.declaredOrgStore.list()),
|
|
286
|
+
}))
|
|
280
287
|
result.files = true;
|
|
281
288
|
}
|
|
282
289
|
catch {
|
|
@@ -297,6 +304,25 @@ export class FoundryPlatformStepExecutor {
|
|
|
297
304
|
}
|
|
298
305
|
return result;
|
|
299
306
|
}
|
|
307
|
+
/**
|
|
308
|
+
* Gives the files runner a changed share-domain set and nothing else: its
|
|
309
|
+
* Coolify `domains`, `FILES_PUBLIC_HOSTS` and one redeploy of the runner.
|
|
310
|
+
* Returns the scope ids to record, or `null` when nothing changed
|
|
311
|
+
* (or the runner was never applied).
|
|
312
|
+
*/
|
|
313
|
+
async refreshFilesShare(_platform, recordedIds) {
|
|
314
|
+
const runnerAppId = recordedIds[`coolify:app:${PLATFORM_FILES_KEY}`];
|
|
315
|
+
if (!this.files || !runnerAppId)
|
|
316
|
+
return null;
|
|
317
|
+
const wanted = filesShareDomains(await this.declaredOrgStore.list());
|
|
318
|
+
if (!shareDomainsChanged(recordedIds, wanted))
|
|
319
|
+
return null;
|
|
320
|
+
const { coolify } = this.files;
|
|
321
|
+
await coolify.updateApplication(runnerAppId, filesShareDomainsPatch(recordedIds, wanted));
|
|
322
|
+
await coolify.bulkUpsertEnvs(runnerAppId, filesPublicHostsEnvs(recordedIds, this.files.publicHosts, wanted));
|
|
323
|
+
await coolify.deploy(runnerAppId);
|
|
324
|
+
return { [PLATFORM_FILES_SHARE_DOMAINS_SCOPE_KEY]: normalHosts(wanted).join(',') };
|
|
325
|
+
}
|
|
300
326
|
async execute(action, context) {
|
|
301
327
|
if (action.system === 'coolify' && action.kind === 'app' && action.key === PLATFORM_AUTH_KEY) {
|
|
302
328
|
if (!this.auth) {
|
|
@@ -309,7 +335,7 @@ export class FoundryPlatformStepExecutor {
|
|
|
309
335
|
if (!this.files) {
|
|
310
336
|
throw new Error('platform:files needs FoundryPlatformStepExecutor to be constructed with its files dependencies (#171)');
|
|
311
337
|
}
|
|
312
|
-
return provisionPlatformFiles(context, this.files);
|
|
338
|
+
return provisionPlatformFiles(context, this.files, filesShareDomains(await this.declaredOrgStore.list()));
|
|
313
339
|
}
|
|
314
340
|
if (action.system === 'coolify' &&
|
|
315
341
|
action.kind === 'app' &&
|
|
@@ -1061,6 +1087,15 @@ async function provisionPlatformAuth(context, deps, owners = []) {
|
|
|
1061
1087
|
},
|
|
1062
1088
|
{ key: 'OTEL_NODE_RESOURCE_DETECTORS', value: 'none' },
|
|
1063
1089
|
{ key: 'API_CACHE_CONFIG', value: '{"defaultMinutes":2,"longMinutes":5}' },
|
|
1090
|
+
// #405: the login app's own requestId-free fallback (`resolveRedirectUri`
|
|
1091
|
+
// in `wtfalch/auth`'s `login/src/lib/client.ts`) is what a user without an
|
|
1092
|
+
// OIDC request in flight lands on after `/signedin` -- exactly the owner
|
|
1093
|
+
// invite's own path (set a password, then nowhere to go). Only set once
|
|
1094
|
+
// Archon is declared, and only ever to Archon: the platform's one landing
|
|
1095
|
+
// app for anyone who reaches the login app outside an app's own sign-in.
|
|
1096
|
+
...(platform.archon.enabled
|
|
1097
|
+
? [{ key: 'DEFAULT_REDIRECT_URI', value: `https://${platform.archon.hostname}` }]
|
|
1098
|
+
: []),
|
|
1064
1099
|
];
|
|
1065
1100
|
// #210: read back now, not inside the deploy-decision block below -- this
|
|
1066
1101
|
// push has to land before `missingBrokerInputs` is read a few lines down,
|
|
@@ -1446,11 +1481,13 @@ async function provisionPlatformAuth(context, deps, owners = []) {
|
|
|
1446
1481
|
await record(PLATFORM_ZITADEL_ORG_SCOPE_KEY, ownerOrgId);
|
|
1447
1482
|
let invitedUserId;
|
|
1448
1483
|
try {
|
|
1484
|
+
// ZITADEL's default invite link is `/ui/v2/login/verify`, which 404s on the login app;
|
|
1485
|
+
// it serves `/verify` at the root.
|
|
1449
1486
|
({ userId: invitedUserId } = await mailZitadel.inviteOrgOwner(ownerOrgId, {
|
|
1450
1487
|
givenName: owner.givenName,
|
|
1451
1488
|
familyName: owner.familyName,
|
|
1452
1489
|
email: owner.email,
|
|
1453
|
-
}));
|
|
1490
|
+
}, `https://${hostname}/verify?userId={{.UserID}}&code={{.Code}}&organization={{.OrgID}}&invite=true`));
|
|
1454
1491
|
}
|
|
1455
1492
|
catch (error) {
|
|
1456
1493
|
// The cause, with the owner's email and the Lettermint key redacted, so a failure says why.
|
|
@@ -1791,7 +1828,8 @@ async function provisionPlatformMail(context, deps) {
|
|
|
1791
1828
|
const declaredChanged = recorded[PLATFORM_MAIL_DEPLOYED_HOSTNAME_SCOPE_KEY] !== hostname ||
|
|
1792
1829
|
recorded[PLATFORM_MAIL_DEPLOYED_GIT_REF_SCOPE_KEY] !== imageTag;
|
|
1793
1830
|
// A new storage binds into the container only at its next start.
|
|
1794
|
-
|
|
1831
|
+
const mailDeployedNow = app.justCreated || !app.running || envsChanged || declaredChanged || storagesAdded;
|
|
1832
|
+
if (mailDeployedNow) {
|
|
1795
1833
|
// A container still up from before would answer the readiness probe with
|
|
1796
1834
|
// the old deployment's health. Stop it and see it stopped first, so the
|
|
1797
1835
|
// wait below only ever reads the new deployment.
|
|
@@ -1799,7 +1837,16 @@ async function provisionPlatformMail(context, deps) {
|
|
|
1799
1837
|
await deps.coolify.raw('POST', `/applications/${appId}/stop`);
|
|
1800
1838
|
await waitForMailStopped(deps.coolify, appId, runtime, sleep);
|
|
1801
1839
|
}
|
|
1802
|
-
|
|
1840
|
+
// #252: phase 1 only -- Coolify's own deployment record reaching
|
|
1841
|
+
// `'finished'`. Phase 2 (the readiness probe, `ensureMailReady` below)
|
|
1842
|
+
// runs right after the tunnel and DNS wiring that follows, which is what
|
|
1843
|
+
// `hostname` needs before it answers anything at all; running it here
|
|
1844
|
+
// instead would just poll a hostname that cannot resolve yet on a first
|
|
1845
|
+
// apply. Either way it runs before any applied ref is recorded.
|
|
1846
|
+
// The old container was stopped above (or never ran), so nothing stays live.
|
|
1847
|
+
await waitForDeploymentFinished(deps.coolify, appId, runtime, 'platform:mail', app.justCreated || !app.running
|
|
1848
|
+
? `mail stays at ${recorded[PLATFORM_MAIL_APPLIED_GIT_REF_SCOPE_KEY] ?? 'no recorded ref'}`
|
|
1849
|
+
: 'mail is stopped until the next apply');
|
|
1803
1850
|
await record(PLATFORM_MAIL_DEPLOYED_SCOPE_KEY, appId);
|
|
1804
1851
|
// Right after the deploy, so a later failure (tunnel, DNS, readiness,
|
|
1805
1852
|
// settings, mint) does not make the next run stop and redeploy the app.
|
|
@@ -1873,6 +1920,31 @@ async function provisionPlatformMail(context, deps) {
|
|
|
1873
1920
|
proxied: false,
|
|
1874
1921
|
});
|
|
1875
1922
|
}
|
|
1923
|
+
// #252: phase 2, now that the tunnel and DNS above actually route
|
|
1924
|
+
// `hostname`. `'ready'`, not `'version'`: Stalwart's `/healthz/ready`
|
|
1925
|
+
// carries no version field. Run once per apply, whichever of the three
|
|
1926
|
+
// things below needs it first -- a redeploy just above, the OIDC-audience
|
|
1927
|
+
// re-apply right after, or the admin-key mint further down, none of which
|
|
1928
|
+
// can reach an instance that is not up yet either. Combined with phase 1
|
|
1929
|
+
// above having already confirmed Coolify's own deployment record
|
|
1930
|
+
// finished, this is what actually closes the loophole named in #252 (an
|
|
1931
|
+
// old container staying healthy while the deployment itself fails) -- not
|
|
1932
|
+
// this probe alone, which a container that merely kept answering could
|
|
1933
|
+
// still pass.
|
|
1934
|
+
let mailReadyConfirmed = false;
|
|
1935
|
+
const ensureMailReady = async () => {
|
|
1936
|
+
if (mailReadyConfirmed)
|
|
1937
|
+
return;
|
|
1938
|
+
await waitForHealthyVersion(appId, { kind: 'ready', url: `https://${hostname}${STALWART_READY_PATH}` }, runtime, sleep, 'platform:mail', `mail stays at ${recorded[PLATFORM_MAIL_APPLIED_GIT_REF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
1939
|
+
mailReadyConfirmed = true;
|
|
1940
|
+
};
|
|
1941
|
+
// Also probe when the applied ref lags the target: the deployed refs are
|
|
1942
|
+
// recorded before this probe, so a probe that timed out on the last run must
|
|
1943
|
+
// run again, not be skipped because the deploy itself is already recorded.
|
|
1944
|
+
const appliedLagsTarget = recorded[PLATFORM_MAIL_APPLIED_HOSTNAME_SCOPE_KEY] !== hostname ||
|
|
1945
|
+
recorded[PLATFORM_MAIL_APPLIED_GIT_REF_SCOPE_KEY] !== imageTag;
|
|
1946
|
+
if (mailDeployedNow || appliedLagsTarget)
|
|
1947
|
+
await ensureMailReady();
|
|
1876
1948
|
// ---- the mail ZITADEL project, in the platform's sign-in -------------------
|
|
1877
1949
|
// #346: found or created on every run, like the files/Archon steps' own
|
|
1878
1950
|
// projects -- its id is the OIDC audience Stalwart's directory checks an
|
|
@@ -1898,7 +1970,7 @@ async function provisionPlatformMail(context, deps) {
|
|
|
1898
1970
|
// run to retry. A project deleted out of band is noticed only here, on
|
|
1899
1971
|
// the next plan/apply -- the same way the files/Archon steps' own
|
|
1900
1972
|
// projects are.
|
|
1901
|
-
await
|
|
1973
|
+
await ensureMailReady();
|
|
1902
1974
|
const recoveryEnv = (await deps.coolify.listEnvs(appId)).find((e) => e.key === 'STALWART_RECOVERY_ADMIN' && !e.is_preview);
|
|
1903
1975
|
if (!recoveryEnv) {
|
|
1904
1976
|
throw new Error('platform:mail: STALWART_RECOVERY_ADMIN is not set on the app; cannot authenticate to re-apply the OIDC audience');
|
|
@@ -1938,7 +2010,7 @@ async function provisionPlatformMail(context, deps) {
|
|
|
1938
2010
|
if (lost) {
|
|
1939
2011
|
throw new Error(`platform:mail: an admin API key ("${lost}") was minted but never delivered; revoke it in Stalwart and remove the recorded key ${PLATFORM_MAIL_ADMIN_UNDELIVERED_SCOPE_KEY} to mint a new one`);
|
|
1940
2012
|
}
|
|
1941
|
-
await
|
|
2013
|
+
await ensureMailReady();
|
|
1942
2014
|
const recoveryEnv = (await deps.coolify.listEnvs(appId)).find((e) => e.key === 'STALWART_RECOVERY_ADMIN' && !e.is_preview);
|
|
1943
2015
|
if (!recoveryEnv) {
|
|
1944
2016
|
throw new Error('platform:mail: STALWART_RECOVERY_ADMIN is not set on the app; cannot authenticate to mint the admin key');
|
|
@@ -2318,9 +2390,6 @@ export const PLATFORM_ARCHON_CLIENT_ID_SCOPE_KEY = 'zitadel_platform_archon_clie
|
|
|
2318
2390
|
* needed so the two apps agree the moment the broker can run.
|
|
2319
2391
|
*
|
|
2320
2392
|
* Known gaps, left for review:
|
|
2321
|
-
* - `AUTHZ_BOOTSTRAP_OPERATOR`: the first operator's ZITADEL subject id. A
|
|
2322
|
-
* person has to exist in the new instance first; not something foundry
|
|
2323
|
-
* mints.
|
|
2324
2393
|
* - Foundry's own database URL. Archon runs foundry in its panel, but foundry
|
|
2325
2394
|
* does not know its own connection string at plan/apply time: that is host
|
|
2326
2395
|
* config, not something `DeclaredPlatform` or held keys carry.
|
|
@@ -2347,6 +2416,8 @@ async function provisionPlatformArchon(context, deps) {
|
|
|
2347
2416
|
const recorded = context.recordedIds();
|
|
2348
2417
|
const issuer = `https://${platform.auth.hostname}`;
|
|
2349
2418
|
const appliedGitRef = recorded[PLATFORM_ARCHON_APPLIED_GIT_REF_SCOPE_KEY];
|
|
2419
|
+
const runtime = deps.runtime ?? {};
|
|
2420
|
+
const sleep = runtime.sleep ?? defaultSleep;
|
|
2350
2421
|
if (deps.accessEmails.length === 0) {
|
|
2351
2422
|
throw new Error('platform:archon: no Access emails given; refusing to put Archon behind an Access app nobody can pass');
|
|
2352
2423
|
}
|
|
@@ -2537,6 +2608,24 @@ async function provisionPlatformArchon(context, deps) {
|
|
|
2537
2608
|
throw new Error(`platform:archon: app ${appId} lost its AUTH_APP_KEY between two reads`);
|
|
2538
2609
|
}
|
|
2539
2610
|
envs.push({ key: 'AUTH_APP_KEY', value: appKey });
|
|
2611
|
+
// The owner `platform:auth` invited is Archon's first operator.
|
|
2612
|
+
const bootstrapOperator = archonBootstrapOperator(recorded);
|
|
2613
|
+
if (bootstrapOperator)
|
|
2614
|
+
envs.push({ key: 'AUTHZ_BOOTSTRAP_OPERATOR', value: bootstrapOperator });
|
|
2615
|
+
// #406: the invited platform owner's ZITADEL subject id, once
|
|
2616
|
+
// `platform:auth` has recorded one -- the guard at the top of this
|
|
2617
|
+
// function already requires `platform:auth` to have been applied before
|
|
2618
|
+
// this step is reached, and `provisionPlatformAuth` records the owner
|
|
2619
|
+
// invite (or, with no owner declared, the literal string 'none') as part
|
|
2620
|
+
// of that same step, so by the time this runs the value here is whatever
|
|
2621
|
+
// is actually true. `bootstrapOperator` (archon's `src/lib/authz/
|
|
2622
|
+
// bootstrap.ts`) compares this verbatim against a signed-in user's
|
|
2623
|
+
// subject id, so 'none' is skipped rather than written -- it would simply
|
|
2624
|
+
// never match, but it is not a real id and should not look like one.
|
|
2625
|
+
const ownerInviteUserId = recorded[PLATFORM_AUTH_OWNER_INVITE_SCOPE_KEY];
|
|
2626
|
+
if (ownerInviteUserId && ownerInviteUserId !== 'none') {
|
|
2627
|
+
envs.push({ key: 'AUTHZ_BOOTSTRAP_OPERATOR', value: ownerInviteUserId });
|
|
2628
|
+
}
|
|
2540
2629
|
// A value with a line break (the PEM management keys) must be flagged:
|
|
2541
2630
|
// unflagged, Coolify writes it into `.env` unquoted and the container never
|
|
2542
2631
|
// starts.
|
|
@@ -2645,12 +2734,32 @@ async function provisionPlatformArchon(context, deps) {
|
|
|
2645
2734
|
await record(PLATFORM_ARCHON_ACCESS_SCOPE_KEY, accessAppId);
|
|
2646
2735
|
}
|
|
2647
2736
|
// ---- deploy ---------------------------------------------------------------
|
|
2648
|
-
|
|
2737
|
+
// #252: phase 1 of the shared deploy-health helper only -- Coolify's own
|
|
2738
|
+
// deployment record reaching `'finished'`, which is enough on its own to
|
|
2739
|
+
// catch the bug this closes (the old container stays healthy regardless
|
|
2740
|
+
// of whether the deployment record itself fails). Phase 2, the health
|
|
2741
|
+
// check, has to wait until after the tunnel and DNS below are wired: on a
|
|
2742
|
+
// first apply `hostname` answers nothing until then, and splitting the two
|
|
2743
|
+
// phases (`waitForDeploymentFinished` then `waitForHealthyVersion`,
|
|
2744
|
+
// instead of one `waitForNewDeployment` call) is exactly for a step shaped
|
|
2745
|
+
// like this one.
|
|
2746
|
+
// #398: the integrations key id this run wrote into Archon's env. Archon
|
|
2747
|
+
// counts as synced to it only after a deployment finishes and the health
|
|
2748
|
+
// check passes, so a still-unsynced id forces both even when nothing else
|
|
2749
|
+
// changed (a run that died between the env write and the deploy).
|
|
2750
|
+
const integrationsKeyId = inputs.envs.find((e) => e.key === 'INTEGRATIONS_MANAGEMENT_KEY_ID')?.value;
|
|
2751
|
+
// Not forced on a platform recorded before #398, which has no recorded id.
|
|
2752
|
+
const keyUnsynced = Boolean(integrationsKeyId) &&
|
|
2753
|
+
Boolean(recorded[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY]) &&
|
|
2754
|
+
recorded[PLATFORM_ARCHON_INTEGRATIONS_KEY_SYNCED_SCOPE_KEY] !== integrationsKeyId;
|
|
2755
|
+
const archonDeployedNow = keyUnsynced ||
|
|
2756
|
+
app.justCreated ||
|
|
2649
2757
|
!app.running ||
|
|
2650
2758
|
changed ||
|
|
2651
2759
|
appliedGitRef !== gitRef ||
|
|
2652
|
-
recorded[PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY] !== hostname
|
|
2653
|
-
|
|
2760
|
+
recorded[PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY] !== hostname;
|
|
2761
|
+
if (archonDeployedNow) {
|
|
2762
|
+
await waitForDeploymentFinished(deps.coolify, appId, runtime, 'platform:archon', `archon stays at ${appliedGitRef ?? 'no recorded ref'} on ${recorded[PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY] ?? 'no recorded hostname'}`);
|
|
2654
2763
|
}
|
|
2655
2764
|
// ---- tunnel and DNS ---------------------------------------------------------
|
|
2656
2765
|
const existingTunnel = await deps.cloudflare.findTunnelByName(PLATFORM_ARCHON_TUNNEL_NAME);
|
|
@@ -2704,6 +2813,24 @@ async function provisionPlatformArchon(context, deps) {
|
|
|
2704
2813
|
proxied: true,
|
|
2705
2814
|
});
|
|
2706
2815
|
}
|
|
2816
|
+
// #252: phase 2, now that the tunnel and DNS above actually route
|
|
2817
|
+
// `hostname`. `'ready'`, not `'version'`: archon's `/api/health`
|
|
2818
|
+
// (`@wtfalch/reporting`'s `healthHandler`, the same route `executor.ts`'s
|
|
2819
|
+
// `healthUrls` already assumes every hosted app serves) carries no
|
|
2820
|
+
// version field this package knows to check, so a plain 2xx is the mode
|
|
2821
|
+
// available -- combined with phase 1 above having already confirmed
|
|
2822
|
+
// Coolify's own deployment record finished, which is what actually closes
|
|
2823
|
+
// the loophole named in #252 (an old container staying healthy while the
|
|
2824
|
+
// deployment itself fails).
|
|
2825
|
+
if (archonDeployedNow) {
|
|
2826
|
+
await waitForHealthyVersion(appId, { kind: 'ready', url: `https://${hostname}/api/health` }, runtime, sleep, 'platform:archon', `archon stays at ${appliedGitRef ?? 'no recorded ref'} on ${recorded[PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY] ?? 'no recorded hostname'}`);
|
|
2827
|
+
}
|
|
2828
|
+
// #398: the deployment finished and answers health, so Archon now runs with
|
|
2829
|
+
// the key id its env carries. `provisionPlatformIntegrations` drops the
|
|
2830
|
+
// previous public key only on this marker.
|
|
2831
|
+
if (keyUnsynced && integrationsKeyId) {
|
|
2832
|
+
await record(PLATFORM_ARCHON_INTEGRATIONS_KEY_SYNCED_SCOPE_KEY, integrationsKeyId);
|
|
2833
|
+
}
|
|
2707
2834
|
// Last, after every write the applied values depend on, so a run that failed
|
|
2708
2835
|
// halfway plans again.
|
|
2709
2836
|
await record(PLATFORM_ARCHON_APPLIED_HOSTNAME_SCOPE_KEY, hostname);
|
|
@@ -2713,6 +2840,7 @@ async function provisionPlatformArchon(context, deps) {
|
|
|
2713
2840
|
// (whose AUTH_APPS never carried this registration) from one still holding
|
|
2714
2841
|
// it.
|
|
2715
2842
|
await record(PLATFORM_ARCHON_APPLIED_BROKER_SCOPE_KEY, brokerAppId);
|
|
2843
|
+
await record(PLATFORM_ARCHON_APPLIED_OPERATOR_SCOPE_KEY, bootstrapOperator ?? 'none');
|
|
2716
2844
|
return { resourceId: appId };
|
|
2717
2845
|
}
|
|
2718
2846
|
// #211 round 6: mirrors `wtfalch/auth/broker/src/apps.ts`'s own `isValidFrom`
|
|
@@ -3088,6 +3216,32 @@ async function archonBrokerRegistrationDrifted(coolify, recordedIds) {
|
|
|
3088
3216
|
return false;
|
|
3089
3217
|
}
|
|
3090
3218
|
}
|
|
3219
|
+
/**
|
|
3220
|
+
* #406: whether the platform owner invite recorded under
|
|
3221
|
+
* {@link PLATFORM_AUTH_OWNER_INVITE_SCOPE_KEY} is a real user id (not
|
|
3222
|
+
* absent, not the literal `'none'` {@link provisionPlatformAuth} records
|
|
3223
|
+
* when no owner is declared) that Archon's live env does not yet carry as
|
|
3224
|
+
* `AUTHZ_BOOTSTRAP_OPERATOR`. `provisionPlatformAuth`'s own invite can
|
|
3225
|
+
* record after Archon's `coolify:app` id already has -- the owner invite
|
|
3226
|
+
* happens inside `platform:auth` only once its Lettermint token is held,
|
|
3227
|
+
* which Archon's own apply does not wait on -- so without this, an owner
|
|
3228
|
+
* invited after Archon's first deploy would need a redeploy by hand, the
|
|
3229
|
+
* way companyincluded.com's did. A failed read is not drift, the same rule
|
|
3230
|
+
* {@link archonAccessDrifted} and {@link archonBrokerRegistrationDrifted}
|
|
3231
|
+
* follow: the next plan reads again.
|
|
3232
|
+
*/
|
|
3233
|
+
async function archonBootstrapOperatorDrifted(coolify, appId, recordedIds) {
|
|
3234
|
+
const invitedUserId = recordedIds[PLATFORM_AUTH_OWNER_INVITE_SCOPE_KEY];
|
|
3235
|
+
if (!appId || !invitedUserId || invitedUserId === 'none')
|
|
3236
|
+
return false;
|
|
3237
|
+
try {
|
|
3238
|
+
const live = await currentEnvValue(coolify, appId, 'AUTHZ_BOOTSTRAP_OPERATOR');
|
|
3239
|
+
return live !== invitedUserId;
|
|
3240
|
+
}
|
|
3241
|
+
catch {
|
|
3242
|
+
return false;
|
|
3243
|
+
}
|
|
3244
|
+
}
|
|
3091
3245
|
/**
|
|
3092
3246
|
* What Archon reads from each enabled service, gathered before anything is
|
|
3093
3247
|
* built. Either everything is there and the env values come back, or the first
|
|
@@ -3105,6 +3259,23 @@ async function collectArchonServiceInputs(platform, deps, recorded) {
|
|
|
3105
3259
|
if (services.length > 0 && !deps.heldKeys) {
|
|
3106
3260
|
return block(`the host built the platform executor without a held-key reader, and ${services.join(', ')} ${services.length === 1 ? 'is' : 'are'} enabled`);
|
|
3107
3261
|
}
|
|
3262
|
+
const rotationUndelivered = recorded[PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY];
|
|
3263
|
+
if (services.includes('integrations') &&
|
|
3264
|
+
rotationUndelivered &&
|
|
3265
|
+
rotationUndelivered !== recorded[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY]) {
|
|
3266
|
+
// #398: the held key may already be the new pair while the recorded id is
|
|
3267
|
+
// still the old one; writing both would sign with a key id the runner
|
|
3268
|
+
// does not match.
|
|
3269
|
+
return block(`the integrations rotation key ${rotationUndelivered} is minted but not confirmed delivered and pinned`);
|
|
3270
|
+
}
|
|
3271
|
+
const activeKeyId = recorded[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY];
|
|
3272
|
+
if (services.includes('integrations') &&
|
|
3273
|
+
activeKeyId &&
|
|
3274
|
+
recorded[PLATFORM_INTEGRATIONS_RUNNER_KEYRING_DEPLOYED_SCOPE_KEY] !== activeKeyId) {
|
|
3275
|
+
// #398: the runner must run with the new public key before Archon signs
|
|
3276
|
+
// with the new private key.
|
|
3277
|
+
return block(`the integrations runner is not yet deployed with management key ${activeKeyId}`);
|
|
3278
|
+
}
|
|
3108
3279
|
for (const service of services) {
|
|
3109
3280
|
const needs = service === 'jobs'
|
|
3110
3281
|
? {
|
|
@@ -3168,7 +3339,10 @@ async function collectArchonServiceInputs(platform, deps, recorded) {
|
|
|
3168
3339
|
value: INTEGRATIONS_MANAGEMENT_ISSUER,
|
|
3169
3340
|
}, {
|
|
3170
3341
|
key: 'INTEGRATIONS_MANAGEMENT_KEY_ID',
|
|
3171
|
-
|
|
3342
|
+
// #398: the active id, which a rotation moves past `foundry-1` --
|
|
3343
|
+
// falls back to the fixed constant for a platform that applied
|
|
3344
|
+
// integrations before this scope key existed.
|
|
3345
|
+
value: recorded[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY] ?? INTEGRATIONS_MANAGEMENT_KEY_ID,
|
|
3172
3346
|
}, { key: 'INTEGRATIONS_MANAGEMENT_AUDIENCE', value: url });
|
|
3173
3347
|
}
|
|
3174
3348
|
else {
|
|
@@ -3717,9 +3891,15 @@ async function provisionPlatformAi(context, deps) {
|
|
|
3717
3891
|
await coolify.raw('POST', `/applications/${migrate.appId}/stop`);
|
|
3718
3892
|
await waitForStopped(coolify, migrate.appId, runtime, sleep);
|
|
3719
3893
|
}
|
|
3720
|
-
await coolify.deploy(migrate.appId);
|
|
3894
|
+
const migrateDeployed = await coolify.deploy(migrate.appId);
|
|
3721
3895
|
try {
|
|
3722
3896
|
await waitForAiMigration(coolify, migrate.appId, runtime, sleep);
|
|
3897
|
+
// #399: the migrate job can read healthy well before Coolify's own
|
|
3898
|
+
// deployment does -- it is still waiting out the image's HEALTHCHECK
|
|
3899
|
+
// start period -- so stopping it below waits for Coolify's own record
|
|
3900
|
+
// too, or it can find the container already gone and mark a deployment
|
|
3901
|
+
// that actually migrated as `failed`.
|
|
3902
|
+
await waitForMigrateDeployment(coolify, migrate.appId, queuedDeploymentUuid(migrateDeployed) ?? 'untracked', 'platform:ai', 'ai-migrate', runtime.now ?? Date.now, runtime.migrateTimeoutMs ?? 600_000, runtime.migrateIntervalMs ?? 5_000, sleep);
|
|
3723
3903
|
}
|
|
3724
3904
|
catch (error) {
|
|
3725
3905
|
if (error instanceof MigrationNotHealthyError) {
|
|
@@ -3732,49 +3912,44 @@ async function provisionPlatformAi(context, deps) {
|
|
|
3732
3912
|
}
|
|
3733
3913
|
await coolify.raw('POST', `/applications/${migrate.appId}/stop`);
|
|
3734
3914
|
}
|
|
3735
|
-
//
|
|
3736
|
-
//
|
|
3737
|
-
|
|
3915
|
+
// #252: confirmed before anything below -- the applied ref recorded just
|
|
3916
|
+
// after, and the mint further down -- depends on the new version actually
|
|
3917
|
+
// being live. Never read the old container's healthy status as the new
|
|
3918
|
+
// deployment's (`CLAUDE.md`'s platform-step rule 5): `'deployment-only'`,
|
|
3919
|
+
// because the runner's own doc comment above says why there is no url to
|
|
3920
|
+
// check instead ("Nothing public is wired: no Coolify `domains`, tunnel,
|
|
3921
|
+
// DNS record or Access app"). This replaces the old deploy-then-defer-the-
|
|
3922
|
+
// wait-until-the-mint-needs-it shape (#375) with the one every other
|
|
3923
|
+
// platform step uses: the wait happens once, right here, so a failed
|
|
3924
|
+
// deployment is caught before either thing downstream trusts it.
|
|
3738
3925
|
if (deployRunner) {
|
|
3739
|
-
await
|
|
3926
|
+
await waitForNewDeployment(coolify, runner.appId, { kind: 'deployment-only' }, runtime, sleep, 'platform:ai', `the runner stays at ${recorded[PLATFORM_AI_APPLIED_GITREF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
3927
|
+
}
|
|
3928
|
+
if (deployWorker) {
|
|
3929
|
+
await waitForNewDeployment(coolify, worker.appId, { kind: 'deployment-only' }, runtime, sleep, 'platform:ai', `the worker stays at ${recorded[PLATFORM_AI_APPLIED_GITREF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
3740
3930
|
}
|
|
3741
|
-
if (deployWorker)
|
|
3742
|
-
await coolify.deploy(worker.appId);
|
|
3743
3931
|
await record(PLATFORM_AI_DEPLOY_PENDING_SCOPE_KEY, '');
|
|
3744
|
-
// The deploys are
|
|
3745
|
-
// at the mint or delivery must not make the next apply see a
|
|
3746
|
-
// hostname or gitRef and redeploy the live host again. The
|
|
3747
|
-
// plans the step until the resource id is recorded, once
|
|
3932
|
+
// The deploys are confirmed, so record what they deployed now. A later
|
|
3933
|
+
// failure at the mint or delivery must not make the next apply see a
|
|
3934
|
+
// changed hostname or gitRef and redeploy the live host again. The
|
|
3935
|
+
// planner still plans the step until the resource id is recorded, once
|
|
3936
|
+
// the key is delivered.
|
|
3748
3937
|
await record(PLATFORM_AI_APPLIED_HOSTNAME_SCOPE_KEY, hostname);
|
|
3749
3938
|
await record(PLATFORM_AI_APPLIED_GITREF_SCOPE_KEY, gitRef);
|
|
3750
3939
|
const internalUrl = `http://${PLATFORM_AI_RUNNER.internalName}:${PLATFORM_AI_PORT}`;
|
|
3751
3940
|
await record(PLATFORM_AI_INTERNAL_URL_SCOPE_KEY, internalUrl);
|
|
3752
3941
|
// ---- Archon's AI management key, once ------------------------------------
|
|
3942
|
+
// #252: nothing left to wait on here -- the deployment above is already
|
|
3943
|
+
// confirmed finished by the time this runs. The host's own readiness
|
|
3944
|
+
// beyond that (a 503 for a moment after `AI_WORKER_TIMEOUT_MS` warms up)
|
|
3945
|
+
// is unchanged from before this change: a single mint attempt, not
|
|
3946
|
+
// retried here.
|
|
3753
3947
|
const now = context.recordedIds();
|
|
3754
3948
|
if (!now[PLATFORM_AI_MANAGEMENT_KEY_SCOPE_KEY]) {
|
|
3755
3949
|
const lost = now[PLATFORM_AI_MANAGEMENT_KEY_UNDELIVERED_SCOPE_KEY];
|
|
3756
3950
|
if (lost) {
|
|
3757
3951
|
throw new Error(`platform:ai: AI management key ${lost} was minted but never delivered; revoke it and remove the recorded key ${PLATFORM_AI_MANAGEMENT_KEY_UNDELIVERED_SCOPE_KEY} to mint a new one`);
|
|
3758
3952
|
}
|
|
3759
|
-
// The host answers 503 (or nothing) until the deployment that carries its
|
|
3760
|
-
// management settings has finished.
|
|
3761
|
-
const queued = context.recordedIds()[PLATFORM_AI_RUNNER_DEPLOYMENT_SCOPE_KEY];
|
|
3762
|
-
if (queued) {
|
|
3763
|
-
try {
|
|
3764
|
-
await waitForAiDeployment(coolify, runner.appId, queued, runtime, sleep);
|
|
3765
|
-
}
|
|
3766
|
-
catch (error) {
|
|
3767
|
-
// Only a build still running is worth waiting on again. A deployment
|
|
3768
|
-
// that failed, was cancelled or cannot be read is not: mark the host
|
|
3769
|
-
// pending so the next apply queues a new one instead of polling it.
|
|
3770
|
-
if (!(error instanceof AiDeploymentTimeoutError)) {
|
|
3771
|
-
await record(PLATFORM_AI_DEPLOY_PENDING_SCOPE_KEY, '1');
|
|
3772
|
-
await record(PLATFORM_AI_RUNNER_DEPLOYMENT_SCOPE_KEY, '');
|
|
3773
|
-
}
|
|
3774
|
-
throw error;
|
|
3775
|
-
}
|
|
3776
|
-
await record(PLATFORM_AI_RUNNER_DEPLOYMENT_SCOPE_KEY, '');
|
|
3777
|
-
}
|
|
3778
3953
|
// #201: a test injects its own minter; without one, build the real one
|
|
3779
3954
|
// over ai's own POST /v1/platform/keys, signed with the key pinned above.
|
|
3780
3955
|
const minter = deps.managementKeyMinter ??
|
|
@@ -3914,22 +4089,23 @@ function queuedDeploymentUuid(result) {
|
|
|
3914
4089
|
return typeof uuid === 'string' && uuid ? uuid : undefined;
|
|
3915
4090
|
}
|
|
3916
4091
|
/**
|
|
3917
|
-
* Waits until
|
|
3918
|
-
* `failed`/`cancelled-by-user` or once `
|
|
3919
|
-
* deployment id (`untracked`) the only signal left
|
|
3920
|
-
* which an old container can already satisfy, so
|
|
4092
|
+
* Waits until `deploymentUuid`'s Coolify deployment has `finished`; throws on
|
|
4093
|
+
* `failed`/`cancelled-by-user` (via `onEnded`) or once `timeoutMs` has passed
|
|
4094
|
+
* (via `onTimeout`). With no deployment id (`untracked`) the only signal left
|
|
4095
|
+
* is the app's own status, which an old container can already satisfy, so
|
|
4096
|
+
* that case is best effort and returns as soon as the app itself reads
|
|
4097
|
+
* healthy. Shared by every caller that must not act on an app's status
|
|
4098
|
+
* until Coolify's own deployment record agrees it is done (#399: Coolify's
|
|
4099
|
+
* own `HEALTHCHECK` start period can outlive the app already reading
|
|
4100
|
+
* `running:healthy`; acting then finds the container already gone, and
|
|
4101
|
+
* Coolify marks its own deployment `failed` -- "Removing the new version" --
|
|
4102
|
+
* though whatever the app was doing had already finished).
|
|
3921
4103
|
*/
|
|
3922
|
-
|
|
3923
|
-
|
|
3924
|
-
}
|
|
3925
|
-
async function waitForAiDeployment(coolify, appId, deploymentUuid, runtime, sleep) {
|
|
3926
|
-
const now = runtime.now ?? Date.now;
|
|
3927
|
-
const timeout = runtime.migrateTimeoutMs ?? 600_000;
|
|
3928
|
-
const interval = runtime.migrateIntervalMs ?? 5_000;
|
|
3929
|
-
const deadline = now() + timeout;
|
|
4104
|
+
async function waitForCoolifyDeployment(coolify, appId, deploymentUuid, now, timeoutMs, intervalMs, sleep, onEnded, onTimeout) {
|
|
4105
|
+
const deadline = now() + timeoutMs;
|
|
3930
4106
|
let status;
|
|
3931
4107
|
for (;;) {
|
|
3932
|
-
await sleep(
|
|
4108
|
+
await sleep(intervalMs);
|
|
3933
4109
|
if (deploymentUuid === 'untracked') {
|
|
3934
4110
|
status = (await coolify.getApplication(appId)).status;
|
|
3935
4111
|
if (status?.startsWith('running:healthy'))
|
|
@@ -3940,15 +4116,25 @@ async function waitForAiDeployment(coolify, appId, deploymentUuid, runtime, slee
|
|
|
3940
4116
|
status = typeof found?.status === 'string' ? found.status : undefined;
|
|
3941
4117
|
if (status === 'finished')
|
|
3942
4118
|
return;
|
|
3943
|
-
if (status === 'failed' || status === 'cancelled-by-user')
|
|
3944
|
-
throw
|
|
3945
|
-
}
|
|
3946
|
-
}
|
|
3947
|
-
if (now() >= deadline) {
|
|
3948
|
-
throw new AiDeploymentTimeoutError(`platform:ai: the host's deployment for ${appId} did not finish within ${Math.round(timeout / 1000)}s (last status ${status ?? 'unknown'}); the AI management key was not minted. Apply again`);
|
|
4119
|
+
if (status === 'failed' || status === 'cancelled-by-user')
|
|
4120
|
+
throw onEnded(status);
|
|
3949
4121
|
}
|
|
4122
|
+
if (now() >= deadline)
|
|
4123
|
+
throw onTimeout(status ?? 'unknown');
|
|
3950
4124
|
}
|
|
3951
4125
|
}
|
|
4126
|
+
/**
|
|
4127
|
+
* Waits until a migrate job's own queued deployment has `finished`, so stopping a migrate job never races Coolify's own
|
|
4128
|
+
* `HEALTHCHECK` start period (#399: every platform migrate job idles rather
|
|
4129
|
+
* than exits once its migration succeeds, so it reports `running:healthy`
|
|
4130
|
+
* well before Coolify's own deployment does, and stopping it on that signal
|
|
4131
|
+
* alone can make Coolify mark a deployment that actually migrated `failed`).
|
|
4132
|
+
* `label` and `jobName` build an error naming the step and the job, never
|
|
4133
|
+
* just "the deployment".
|
|
4134
|
+
*/
|
|
4135
|
+
async function waitForMigrateDeployment(coolify, appId, deploymentUuid, label, jobName, now, timeoutMs, intervalMs, sleep) {
|
|
4136
|
+
await waitForCoolifyDeployment(coolify, appId, deploymentUuid, now, timeoutMs, intervalMs, sleep, (status) => new Error(`${label}: ${jobName} (${appId})'s deployment ended ${status}; check its build log in Coolify, then apply again`), (status) => new Error(`${label}: ${jobName} (${appId})'s deployment did not finish within ${Math.round(timeoutMs / 1000)}s (last status ${status}); apply again`));
|
|
4137
|
+
}
|
|
3952
4138
|
/**
|
|
3953
4139
|
* Why a mint failed, safe to show: the status ai answered (the minter's own
|
|
3954
4140
|
* fixed message), or a network error's `name` and `cause.code`. Never a
|
|
@@ -4404,7 +4590,9 @@ const PLATFORM_FILES_RUNNER_SCOPE_KEY = 'coolify_platform_files_runner_app';
|
|
|
4404
4590
|
* Coolify network, so the host must run there to use it for management
|
|
4405
4591
|
* calls.
|
|
4406
4592
|
*/
|
|
4407
|
-
async function provisionPlatformFiles(context, deps
|
|
4593
|
+
async function provisionPlatformFiles(context, deps,
|
|
4594
|
+
/** {@link filesShareDomains} of every declared org: each is a runner domain and a public host. */
|
|
4595
|
+
shareDomains) {
|
|
4408
4596
|
const { platform } = context;
|
|
4409
4597
|
const gitRef = platform.files.gitRef;
|
|
4410
4598
|
const recorded = context.recordedIds();
|
|
@@ -4506,7 +4694,11 @@ async function provisionPlatformFiles(context, deps) {
|
|
|
4506
4694
|
dockerfile_target_build: 'runner',
|
|
4507
4695
|
custom_internal_name: FILES_RUNNER_INTERNAL_NAME,
|
|
4508
4696
|
git_branch: gitRef,
|
|
4697
|
+
// Coolify wants full URLs. Written only when the set changed, so a runner
|
|
4698
|
+
// nobody gave a share host keeps no `domains`.
|
|
4699
|
+
...filesShareDomainsPatch(recorded, shareDomains),
|
|
4509
4700
|
});
|
|
4701
|
+
context.recordScopeId(PLATFORM_FILES_SHARE_DOMAINS_SCOPE_KEY, normalHosts(shareDomains).join(','));
|
|
4510
4702
|
// ---- database env ----------------------------------------------------------
|
|
4511
4703
|
// The migrate app sets `files_rt`'s password from DATABASE_URL on every
|
|
4512
4704
|
// boot (files' `scripts/db-runtime-role.sh`), and the runner connects with
|
|
@@ -4557,11 +4749,7 @@ async function provisionPlatformFiles(context, deps) {
|
|
|
4557
4749
|
value: deps.clamd.port,
|
|
4558
4750
|
});
|
|
4559
4751
|
}
|
|
4560
|
-
|
|
4561
|
-
runnerOptionalEnvs.push({
|
|
4562
|
-
key: 'FILES_PUBLIC_HOSTS',
|
|
4563
|
-
value: deps.publicHosts,
|
|
4564
|
-
});
|
|
4752
|
+
runnerOptionalEnvs.push(...filesPublicHostsEnvs(recorded, deps.publicHosts, shareDomains));
|
|
4565
4753
|
if (deps.jobsSigningSecrets)
|
|
4566
4754
|
runnerOptionalEnvs.push({
|
|
4567
4755
|
key: 'JOBS_SIGNING_SECRETS',
|
|
@@ -4642,10 +4830,22 @@ async function provisionPlatformFiles(context, deps) {
|
|
|
4642
4830
|
// deploy. Stopped first, so the wait below cannot pass on the old
|
|
4643
4831
|
// container before the new migration has run.
|
|
4644
4832
|
await stopIfRunning(deps.coolify, migrateApp.appId);
|
|
4645
|
-
await deps.coolify.deploy(migrateApp.appId);
|
|
4833
|
+
const migrateDeployed = await deps.coolify.deploy(migrateApp.appId);
|
|
4646
4834
|
await waitForMigration(deps.coolify, migrateApp.appId, runtime, sleep);
|
|
4835
|
+
// #399: files-migrate idles rather than exits once it has migrated, so it
|
|
4836
|
+
// reads healthy well before Coolify's own deployment does; stopping it on
|
|
4837
|
+
// that signal alone can find the container already gone and make Coolify
|
|
4838
|
+
// mark a deployment that actually migrated as `failed`.
|
|
4839
|
+
await waitForMigrateDeployment(deps.coolify, migrateApp.appId, queuedDeploymentUuid(migrateDeployed) ?? 'untracked', 'platform:files', 'files-migrate', runtime.now ?? Date.now, runtime.migrateTimeoutMs ?? 900_000, runtime.migrateIntervalMs ?? 10_000, sleep);
|
|
4647
4840
|
await deps.coolify.raw('POST', `/applications/${migrateApp.appId}/stop`);
|
|
4648
|
-
|
|
4841
|
+
// #252: `'deployment-only'` -- the runner's own doc comment above says why
|
|
4842
|
+
// ("The runner is created without `domains`... Nothing public is wired"):
|
|
4843
|
+
// there is no url this executor, running outside files' own Docker
|
|
4844
|
+
// network, could ever reach, so `coolify.deployAndWait` reaching Coolify's
|
|
4845
|
+
// own deployment record is the whole check. Still enough to catch the bug
|
|
4846
|
+
// this closes: the applied ref recorded below while the *old* container
|
|
4847
|
+
// (never read here) stayed healthy through a failed deploy.
|
|
4848
|
+
await waitForNewDeployment(deps.coolify, runnerApp.appId, { kind: 'deployment-only' }, runtime, sleep, 'platform:files', `the runner stays at ${recorded[PLATFORM_FILES_APPLIED_GIT_REF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
4649
4849
|
await record(PLATFORM_FILES_INTERNAL_URL_SCOPE_KEY, `http://${FILES_RUNNER_INTERNAL_NAME}:${FILES_PORT}`);
|
|
4650
4850
|
// Last: a run that failed anywhere above is planned again.
|
|
4651
4851
|
context.recordScopeId(PLATFORM_FILES_APPLIED_HOSTNAME_SCOPE_KEY, platform.files.hostname);
|
|
@@ -4722,11 +4922,21 @@ function filesDepsInvalid(deps) {
|
|
|
4722
4922
|
* nothing ever re-checked whether its env could actually pass a health
|
|
4723
4923
|
* check.
|
|
4724
4924
|
*/
|
|
4725
|
-
async function filesRunnerEnvDrifted(coolify, recordedIds) {
|
|
4925
|
+
async function filesRunnerEnvDrifted(coolify, recordedIds, hosts = {}) {
|
|
4726
4926
|
const runnerAppId = recordedIds[`coolify:app:${PLATFORM_FILES_KEY}`];
|
|
4727
4927
|
if (!runnerAppId)
|
|
4728
4928
|
return false;
|
|
4729
|
-
|
|
4929
|
+
// The share set the runner was last given differs from the one now wanted.
|
|
4930
|
+
if (shareDomainsChanged(recordedIds, hosts.shareDomains))
|
|
4931
|
+
return true;
|
|
4932
|
+
const live = (await coolify.listEnvs(runnerAppId)).filter((e) => !e.is_preview);
|
|
4933
|
+
const envs = live.filter((e) => e.value);
|
|
4934
|
+
const present = new Set(envs.map((e) => e.key));
|
|
4935
|
+
// An unset or blank live value equals an empty wanted one.
|
|
4936
|
+
const wantedHosts = filesPublicHostsValue(hosts.publicHosts, hosts.shareDomains);
|
|
4937
|
+
if ((envs.find((e) => e.key === 'FILES_PUBLIC_HOSTS')?.value ?? '') !== wantedHosts) {
|
|
4938
|
+
return true;
|
|
4939
|
+
}
|
|
4730
4940
|
const required = [
|
|
4731
4941
|
'R2_BUCKET',
|
|
4732
4942
|
'R2_ENDPOINT',
|
|
@@ -4890,11 +5100,19 @@ export const INTEGRATIONS_MANAGEMENT_KEY_ID = 'foundry-1';
|
|
|
4890
5100
|
* 3. The migrate app first, once per `gitRef`: stop it if running, deploy it,
|
|
4891
5101
|
* wait until it reports healthy, stop it, and record the ref it migrated.
|
|
4892
5102
|
* Only then are the runner and worker deployed.
|
|
4893
|
-
* 4. The management key, once
|
|
4894
|
-
* before delivery, its private half
|
|
4895
|
-
* {@link PlatformIntegrationsDeps.deliverSecret} and its public
|
|
4896
|
-
* on the runner as `MANAGEMENT_PUBLIC_KEYS`, with
|
|
4897
|
-
* guard is recorded after both.
|
|
5103
|
+
* 4. The management key, once, and rotated on request (#398): an Ed25519
|
|
5104
|
+
* pair minted here, its id recorded before delivery, its private half
|
|
5105
|
+
* handed to {@link PlatformIntegrationsDeps.deliverSecret} and its public
|
|
5106
|
+
* half pinned on the runner as `MANAGEMENT_PUBLIC_KEYS`, with
|
|
5107
|
+
* `MANAGEMENT_ISSUER`. The guard is recorded after both.
|
|
5108
|
+
* A rotation, requested by recording
|
|
5109
|
+
* {@link PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY}, mints a second
|
|
5110
|
+
* pair under a new key id the same way, pinned *beside* the first rather
|
|
5111
|
+
* than replacing it; the first is dropped only once
|
|
5112
|
+
* {@link PLATFORM_ARCHON_INTEGRATIONS_KEY_SYNCED_SCOPE_KEY} shows Archon
|
|
5113
|
+
* holding the new id. Archon reads the active id back from
|
|
5114
|
+
* {@link PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY}, so a rotation reaches it
|
|
5115
|
+
* without this step touching Archon directly.
|
|
4898
5116
|
* 5. The applied `hostname` and `gitRef` are recorded last. A later change
|
|
4899
5117
|
* plans the step again (`planIntegrations`), which patches `git_branch`
|
|
4900
5118
|
* and the runner's `domains`, reruns the migration for a new ref, and
|
|
@@ -5067,21 +5285,28 @@ async function provisionPlatformIntegrations(action, context, deps) {
|
|
|
5067
5285
|
// container's healthy status is never read as the new deployment's.
|
|
5068
5286
|
if (migrateApp.running)
|
|
5069
5287
|
await coolify.raw('POST', `/applications/${migrateApp.appId}/stop`);
|
|
5070
|
-
await coolify.deploy(migrateApp.appId);
|
|
5288
|
+
const migrateDeployed = await coolify.deploy(migrateApp.appId);
|
|
5071
5289
|
await waitForIntegrationsMigration(coolify, migrateApp.appId, runtime, sleep);
|
|
5290
|
+
// #399: integrations-migrate idles rather than exits once it has
|
|
5291
|
+
// migrated (the Dockerfile's own comment, below), so it reads healthy
|
|
5292
|
+
// well before Coolify's own deployment does; stopping it on that signal
|
|
5293
|
+
// alone can find the container already gone and make Coolify mark a
|
|
5294
|
+
// deployment that actually migrated as `failed`.
|
|
5295
|
+
await waitForMigrateDeployment(coolify, migrateApp.appId, queuedDeploymentUuid(migrateDeployed) ?? 'untracked', 'platform:integrations', 'integrations-migrate', runtime.now ?? Date.now, runtime.migrateTimeoutMs ?? 20 * 60_000, runtime.migratePollMs ?? 10_000, sleep);
|
|
5072
5296
|
// It idles after migrating rather than exiting (the Dockerfile's own
|
|
5073
5297
|
// comment), so it is stopped here; a person starts it again for
|
|
5074
5298
|
// maintenance commands.
|
|
5075
5299
|
await coolify.raw('POST', `/applications/${migrateApp.appId}/stop`);
|
|
5076
5300
|
await record(INTEGRATIONS_MIGRATED_SCOPE_KEY, gitRef);
|
|
5077
5301
|
}
|
|
5078
|
-
// ---- the management key, once
|
|
5302
|
+
// ---- the management key, once, and rotated on request (#398) -------------
|
|
5079
5303
|
// The pair's id is recorded and persisted before the private half is
|
|
5080
5304
|
// delivered. The guard is recorded only after delivery and the write of the
|
|
5081
5305
|
// public half. A run that dies in between leaves the id without the guard:
|
|
5082
5306
|
// the planner then reports the key and mints nothing, so a second pair can
|
|
5083
5307
|
// never replace one the host may already hold.
|
|
5084
5308
|
let keyJustSet = false;
|
|
5309
|
+
let rotated = false;
|
|
5085
5310
|
if (!context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_SET_SCOPE_KEY]) {
|
|
5086
5311
|
if (context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_UNDELIVERED_SCOPE_KEY]) {
|
|
5087
5312
|
throw new Error(`platform:integrations: management key ${INTEGRATIONS_MANAGEMENT_KEY_ID} was minted but not confirmed delivered and pinned; not minting another. Check the held key and the runner's MANAGEMENT_PUBLIC_KEYS, then remove the recorded key ${PLATFORM_INTEGRATIONS_KEY_UNDELIVERED_SCOPE_KEY} to mint a new one`);
|
|
@@ -5091,20 +5316,7 @@ async function provisionPlatformIntegrations(action, context, deps) {
|
|
|
5091
5316
|
privateKeyEncoding: { type: 'pkcs8', format: 'pem' },
|
|
5092
5317
|
});
|
|
5093
5318
|
await record(PLATFORM_INTEGRATIONS_KEY_UNDELIVERED_SCOPE_KEY, INTEGRATIONS_MANAGEMENT_KEY_ID);
|
|
5094
|
-
|
|
5095
|
-
for (let attempt = 1;; attempt += 1) {
|
|
5096
|
-
try {
|
|
5097
|
-
await deps.deliverSecret(INTEGRATIONS_MANAGEMENT_KEY_REF, privateKey);
|
|
5098
|
-
break;
|
|
5099
|
-
}
|
|
5100
|
-
catch {
|
|
5101
|
-
// Retried; the error is dropped in case it echoes the key.
|
|
5102
|
-
if (attempt >= attempts) {
|
|
5103
|
-
throw new Error(`platform:integrations: management key ${INTEGRATIONS_MANAGEMENT_KEY_ID} was minted but could not be delivered after ${attempts} attempts`);
|
|
5104
|
-
}
|
|
5105
|
-
await sleep(1000 * attempt);
|
|
5106
|
-
}
|
|
5107
|
-
}
|
|
5319
|
+
await deliverManagementKey(deps, runtime, sleep, privateKey, INTEGRATIONS_MANAGEMENT_KEY_ID);
|
|
5108
5320
|
await coolify.bulkUpsertEnvs(runnerApp.appId, [
|
|
5109
5321
|
{ key: 'MANAGEMENT_ISSUER', value: INTEGRATIONS_MANAGEMENT_ISSUER },
|
|
5110
5322
|
{
|
|
@@ -5112,28 +5324,190 @@ async function provisionPlatformIntegrations(action, context, deps) {
|
|
|
5112
5324
|
value: JSON.stringify({ [INTEGRATIONS_MANAGEMENT_KEY_ID]: publicKey }),
|
|
5113
5325
|
},
|
|
5114
5326
|
]);
|
|
5327
|
+
await record(PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY, INTEGRATIONS_MANAGEMENT_KEY_ID);
|
|
5115
5328
|
await record(PLATFORM_INTEGRATIONS_KEY_SET_SCOPE_KEY, runnerApp.appId);
|
|
5116
5329
|
keyJustSet = true;
|
|
5117
5330
|
}
|
|
5331
|
+
else if (context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY] &&
|
|
5332
|
+
!context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY]) {
|
|
5333
|
+
// A rotation, requested by the recorded scope id
|
|
5334
|
+
// `PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY`.
|
|
5335
|
+
// Mints a new pair under the next key id and pins it *beside* the
|
|
5336
|
+
// current one -- never replacing it outright, so a request signed with
|
|
5337
|
+
// the current key during the overlap window still verifies.
|
|
5338
|
+
// `rotationUndelivered` is never cleared on success (the once-only
|
|
5339
|
+
// mint's own `UNDELIVERED` key never is either) -- a completed rotation
|
|
5340
|
+
// leaves it equal to the now-active id, which is what lets the *next*
|
|
5341
|
+
// rotation request read "no attempt in flight" without this step ever
|
|
5342
|
+
// clearing it. It differs from the active id only while a mint is
|
|
5343
|
+
// unconfirmed: minted and recorded, but not yet delivered and pinned.
|
|
5344
|
+
const previousKeyId = context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY] ??
|
|
5345
|
+
INTEGRATIONS_MANAGEMENT_KEY_ID;
|
|
5346
|
+
const rotationUndelivered = context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY];
|
|
5347
|
+
if (rotationUndelivered && rotationUndelivered !== previousKeyId) {
|
|
5348
|
+
throw new Error(`platform:integrations: rotation key ${rotationUndelivered} was minted but not confirmed delivered and pinned; not minting another. Check the held key and the runner's MANAGEMENT_PUBLIC_KEYS, then remove the recorded key ${PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY} and set ${PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY} again to mint a new one`);
|
|
5349
|
+
}
|
|
5350
|
+
const keyring = await currentManagementPublicKeys(coolify, runnerApp.appId);
|
|
5351
|
+
const nextKeyId = nextManagementKeyId(previousKeyId, keyring);
|
|
5352
|
+
const { publicKey, privateKey } = generateKeyPairSync('ed25519', {
|
|
5353
|
+
publicKeyEncoding: { type: 'spki', format: 'pem' },
|
|
5354
|
+
privateKeyEncoding: { type: 'pkcs8', format: 'pem' },
|
|
5355
|
+
});
|
|
5356
|
+
await record(PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY, nextKeyId);
|
|
5357
|
+
await deliverManagementKey(deps, runtime, sleep, privateKey, nextKeyId);
|
|
5358
|
+
keyring[nextKeyId] = publicKey;
|
|
5359
|
+
await coolify.bulkUpsertEnvs(runnerApp.appId, [
|
|
5360
|
+
{ key: 'MANAGEMENT_PUBLIC_KEYS', value: JSON.stringify(keyring) },
|
|
5361
|
+
]);
|
|
5362
|
+
// The previous id and the new active id go down in one persist: a crash
|
|
5363
|
+
// can never leave the new id active with the previous one unrecorded, or
|
|
5364
|
+
// the previous one recorded while still active.
|
|
5365
|
+
context.recordScopeId(PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY, previousKeyId);
|
|
5366
|
+
context.recordScopeId(PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY, nextKeyId);
|
|
5367
|
+
await context.persist?.();
|
|
5368
|
+
// One request, one rotation: cleared only now the new key is delivered
|
|
5369
|
+
// and pinned. A failure before this leaves the request set and the
|
|
5370
|
+
// undelivered id ahead of the active id, which the planner reports as
|
|
5371
|
+
// blocked and the next run refuses to mint past.
|
|
5372
|
+
await record(PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY, '');
|
|
5373
|
+
rotated = true;
|
|
5374
|
+
keyJustSet = true;
|
|
5375
|
+
}
|
|
5376
|
+
// A request that was not honoured this run (no key minted before it, or an
|
|
5377
|
+
// earlier rotation still waiting to drop its previous key) is cleared, not
|
|
5378
|
+
// kept to fire later; the plan item says so.
|
|
5379
|
+
if (!rotated && context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY]) {
|
|
5380
|
+
await record(PLATFORM_INTEGRATIONS_KEY_ROTATION_REQUESTED_SCOPE_KEY, '');
|
|
5381
|
+
}
|
|
5382
|
+
// ---- drop the previous key once Archon is confirmed on the new one (#398) -
|
|
5383
|
+
// Dropping it any earlier would refuse a request signed by an Archon
|
|
5384
|
+
// container that is still running the previous key while its own redeploy
|
|
5385
|
+
// catches up.
|
|
5386
|
+
const rotationPrevious = context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY];
|
|
5387
|
+
const activeKeyId = context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY];
|
|
5388
|
+
if (rotationPrevious && rotationPrevious === activeKeyId) {
|
|
5389
|
+
// Corrupt record: the previous id is the active one. Never delete it.
|
|
5390
|
+
await record(PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY, '');
|
|
5391
|
+
}
|
|
5392
|
+
else if (rotationPrevious &&
|
|
5393
|
+
// The last delivered mint (the held key) is the active id.
|
|
5394
|
+
context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ROTATION_UNDELIVERED_SCOPE_KEY] ===
|
|
5395
|
+
activeKeyId &&
|
|
5396
|
+
// No Archon to wait for when it is not enabled: nothing else holds the key.
|
|
5397
|
+
(!context.platform.archon.enabled ||
|
|
5398
|
+
context.recordedIds()[PLATFORM_ARCHON_INTEGRATIONS_KEY_SYNCED_SCOPE_KEY] === activeKeyId)) {
|
|
5399
|
+
const keyring = await currentManagementPublicKeys(coolify, runnerApp.appId);
|
|
5400
|
+
// The active key must be pinned before any other is removed. The planner
|
|
5401
|
+
// cannot see the live env, so a missing active key is an error here, not
|
|
5402
|
+
// a silent no-op on every apply.
|
|
5403
|
+
if (!activeKeyId || !keyring[activeKeyId]) {
|
|
5404
|
+
throw new Error(`platform:integrations: the runner's MANAGEMENT_PUBLIC_KEYS does not hold the active key ${activeKeyId ?? ''}; not removing ${rotationPrevious}. Pin the active public key on the runner, then apply again`);
|
|
5405
|
+
}
|
|
5406
|
+
delete keyring[rotationPrevious];
|
|
5407
|
+
await coolify.bulkUpsertEnvs(runnerApp.appId, [
|
|
5408
|
+
{ key: 'MANAGEMENT_PUBLIC_KEYS', value: JSON.stringify(keyring) },
|
|
5409
|
+
]);
|
|
5410
|
+
// One persist: the previous id is gone and the runner is marked as not
|
|
5411
|
+
// yet deployed with this keyring, so a failed deploy below is retried by
|
|
5412
|
+
// the next plan (`runnerKeyStale`) until the live runner stops accepting
|
|
5413
|
+
// the old key.
|
|
5414
|
+
context.recordScopeId(PLATFORM_INTEGRATIONS_KEY_ROTATION_PREVIOUS_SCOPE_KEY, '');
|
|
5415
|
+
context.recordScopeId(PLATFORM_INTEGRATIONS_RUNNER_KEYRING_DEPLOYED_SCOPE_KEY, '');
|
|
5416
|
+
await context.persist?.();
|
|
5417
|
+
keyJustSet = true;
|
|
5418
|
+
}
|
|
5419
|
+
const activeKeyForRunner = context.recordedIds()[PLATFORM_INTEGRATIONS_KEY_ID_SCOPE_KEY];
|
|
5420
|
+
const runnerKeyStale = Boolean(activeKeyForRunner) &&
|
|
5421
|
+
context.recordedIds()[PLATFORM_INTEGRATIONS_RUNNER_KEYRING_DEPLOYED_SCOPE_KEY] !==
|
|
5422
|
+
activeKeyForRunner;
|
|
5118
5423
|
// ---- then the runner and the worker ------------------------------------------------
|
|
5119
5424
|
// Decided from the live state: an env change only reaches a container on its
|
|
5120
5425
|
// next deploy, and a stopped runner is deployed so an earlier failed deploy
|
|
5121
5426
|
// is retried. The worker exits after one pass by design, so "not running"
|
|
5122
5427
|
// says nothing about it and it is deployed only when created or changed.
|
|
5428
|
+
// #252: `'deployment-only'` -- like `coolify:jobs`, the runner is reached
|
|
5429
|
+
// through its Coolify `domains` binding, not a tunnel/DNS record this
|
|
5430
|
+
// executor set up itself, and no Cloudflare wiring is created for
|
|
5431
|
+
// `hostname` (this function's own doc comment, "Known gaps"). With no
|
|
5432
|
+
// reachability confirmed from here, `coolify.deployAndWait` reaching
|
|
5433
|
+
// Coolify's own deployment record is the whole check -- still enough to
|
|
5434
|
+
// catch the bug this closes: the applied ref recorded below while the
|
|
5435
|
+
// *old* container (never read here) stayed healthy through a failed
|
|
5436
|
+
// deploy.
|
|
5123
5437
|
if (runnerApp.justCreated ||
|
|
5124
5438
|
!runnerApp.running ||
|
|
5125
5439
|
runnerEnvsChanged ||
|
|
5126
5440
|
keyJustSet ||
|
|
5441
|
+
runnerKeyStale ||
|
|
5127
5442
|
configChanged) {
|
|
5128
|
-
await coolify
|
|
5443
|
+
await waitForNewDeployment(coolify, runnerApp.appId, { kind: 'deployment-only' }, runtime, sleep, 'platform:integrations', `the runner stays at ${recorded[PLATFORM_INTEGRATIONS_APPLIED_GITREF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
5444
|
+
}
|
|
5445
|
+
// #398: the runner is up with the keyring that holds the active id; only
|
|
5446
|
+
// now may Archon move to it.
|
|
5447
|
+
if (runnerKeyStale && activeKeyForRunner) {
|
|
5448
|
+
await record(PLATFORM_INTEGRATIONS_RUNNER_KEYRING_DEPLOYED_SCOPE_KEY, activeKeyForRunner);
|
|
5129
5449
|
}
|
|
5130
5450
|
if (workerApp.justCreated || workerEnvsChanged || configChanged) {
|
|
5131
|
-
await coolify
|
|
5451
|
+
await waitForNewDeployment(coolify, workerApp.appId, { kind: 'deployment-only' }, runtime, sleep, 'platform:integrations', `the worker stays at ${recorded[PLATFORM_INTEGRATIONS_APPLIED_GITREF_SCOPE_KEY] ?? 'no recorded ref'}`);
|
|
5132
5452
|
}
|
|
5133
5453
|
await record(PLATFORM_INTEGRATIONS_APPLIED_HOSTNAME_SCOPE_KEY, hostname);
|
|
5134
5454
|
await record(PLATFORM_INTEGRATIONS_APPLIED_GITREF_SCOPE_KEY, gitRef);
|
|
5135
5455
|
return { resourceId: runnerApp.appId };
|
|
5136
5456
|
}
|
|
5457
|
+
/**
|
|
5458
|
+
* #398: `deliverSecret` with the once-only mint's own retry discipline,
|
|
5459
|
+
* shared with the rotation path so both mint the same way. The error never
|
|
5460
|
+
* carries the key, only its id.
|
|
5461
|
+
*/
|
|
5462
|
+
async function deliverManagementKey(deps, runtime, sleep, privateKey, keyId) {
|
|
5463
|
+
const attempts = runtime.deliverAttempts ?? 3;
|
|
5464
|
+
for (let attempt = 1;; attempt += 1) {
|
|
5465
|
+
try {
|
|
5466
|
+
await deps.deliverSecret(INTEGRATIONS_MANAGEMENT_KEY_REF, privateKey);
|
|
5467
|
+
return;
|
|
5468
|
+
}
|
|
5469
|
+
catch {
|
|
5470
|
+
// Retried; the error is dropped in case it echoes the key.
|
|
5471
|
+
if (attempt >= attempts) {
|
|
5472
|
+
throw new Error(`platform:integrations: management key ${keyId} was minted but could not be delivered after ${attempts} attempts`);
|
|
5473
|
+
}
|
|
5474
|
+
await sleep(1000 * attempt);
|
|
5475
|
+
}
|
|
5476
|
+
}
|
|
5477
|
+
}
|
|
5478
|
+
/**
|
|
5479
|
+
* #398: the runner's live `MANAGEMENT_PUBLIC_KEYS`, parsed -- `{}` when the
|
|
5480
|
+
* env is absent (no key minted yet). The rotation path reads this rather
|
|
5481
|
+
* than keeping its own copy, so it edits whatever the runner actually holds,
|
|
5482
|
+
* including a key id a person pinned by hand.
|
|
5483
|
+
*/
|
|
5484
|
+
async function currentManagementPublicKeys(coolify, runnerAppId) {
|
|
5485
|
+
const raw = (await coolify.listEnvs(runnerAppId)).find((e) => e.key === 'MANAGEMENT_PUBLIC_KEYS' && !e.is_preview)?.value;
|
|
5486
|
+
if (!raw)
|
|
5487
|
+
return {};
|
|
5488
|
+
try {
|
|
5489
|
+
return JSON.parse(raw);
|
|
5490
|
+
}
|
|
5491
|
+
catch {
|
|
5492
|
+
throw new Error("platform:integrations: the runner's MANAGEMENT_PUBLIC_KEYS is not valid JSON; not touching the keyring");
|
|
5493
|
+
}
|
|
5494
|
+
}
|
|
5495
|
+
/**
|
|
5496
|
+
* #398: the key id a rotation mints next -- `foundry-1` to `foundry-2`, and
|
|
5497
|
+
* so on, by incrementing the trailing number. A current id with no trailing
|
|
5498
|
+
* number (hand-pinned, never by this step) gets `-2` appended rather than
|
|
5499
|
+
* refusing: the host's keyring only requires `^[A-Za-z0-9_-]{1,100}$`, and
|
|
5500
|
+
* this never collides with a number the current id does not already carry.
|
|
5501
|
+
*/
|
|
5502
|
+
function nextManagementKeyId(currentKeyId, keyring) {
|
|
5503
|
+
const match = /^(.*-)(\d+)$/.exec(currentKeyId);
|
|
5504
|
+
const prefix = match ? match[1] : `${currentKeyId}-`;
|
|
5505
|
+
let n = match ? Number(match[2]) + 1 : 2;
|
|
5506
|
+
// Never overwrite an id already pinned on the runner.
|
|
5507
|
+
while (keyring[`${prefix}${n}`])
|
|
5508
|
+
n += 1;
|
|
5509
|
+
return `${prefix}${n}`;
|
|
5510
|
+
}
|
|
5137
5511
|
/**
|
|
5138
5512
|
* The runtime `DATABASE_URL` already on the migrate app, or a new one:
|
|
5139
5513
|
* {@link INTEGRATIONS_RUNTIME_ROLE} with a password minted once from a
|
|
@@ -5773,3 +6147,50 @@ const ARCHON_SERVICE_INPUTS = {
|
|
|
5773
6147
|
refs: [INTEGRATIONS_MANAGEMENT_KEY_REF],
|
|
5774
6148
|
},
|
|
5775
6149
|
};
|
|
6150
|
+
/** Scope id (no `:`): the share domains the runner's Coolify `domains` was last set to, comma-joined. */
|
|
6151
|
+
export const PLATFORM_FILES_SHARE_DOMAINS_SCOPE_KEY = 'platform_files_share_domains';
|
|
6152
|
+
/** Lowercased, trimmed, deduplicated and sorted, so the same set always gives the same value. */
|
|
6153
|
+
function normalHosts(hosts) {
|
|
6154
|
+
return [...new Set((hosts ?? []).map((h) => h.trim().toLowerCase()).filter(Boolean))].sort();
|
|
6155
|
+
}
|
|
6156
|
+
/** The runner's Coolify `domains`, written only when the share set changed (a runner nobody gave a share host keeps none). */
|
|
6157
|
+
function filesShareDomainsPatch(recorded, shareDomains) {
|
|
6158
|
+
return shareDomainsChanged(recorded, shareDomains)
|
|
6159
|
+
? { domains: coolifyDomains(normalHosts(shareDomains)) }
|
|
6160
|
+
: {};
|
|
6161
|
+
}
|
|
6162
|
+
/**
|
|
6163
|
+
* The runner's `FILES_PUBLIC_HOSTS` env. Always written when an earlier apply
|
|
6164
|
+
* recorded a share set: files reads an empty value as no public host
|
|
6165
|
+
* (`filesPublicHosts()`), so an emptied set blanks the old value (the port has
|
|
6166
|
+
* no env delete). A runner never given a host keeps no such env.
|
|
6167
|
+
*/
|
|
6168
|
+
function filesPublicHostsEnvs(recorded, publicHosts, shareDomains) {
|
|
6169
|
+
const value = filesPublicHostsValue(publicHosts, shareDomains);
|
|
6170
|
+
return value || recorded[PLATFORM_FILES_SHARE_DOMAINS_SCOPE_KEY]
|
|
6171
|
+
? [{ key: 'FILES_PUBLIC_HOSTS', value }]
|
|
6172
|
+
: [];
|
|
6173
|
+
}
|
|
6174
|
+
function shareDomainsChanged(recorded, shareDomains) {
|
|
6175
|
+
return ((recorded[PLATFORM_FILES_SHARE_DOMAINS_SCOPE_KEY] ?? '') !== normalHosts(shareDomains).join(','));
|
|
6176
|
+
}
|
|
6177
|
+
/**
|
|
6178
|
+
* The runner's `FILES_PUBLIC_HOSTS`: the host-supplied `publicHosts` first, in
|
|
6179
|
+
* their given order, then the share domains sorted, with no host twice.
|
|
6180
|
+
* Empty when there is neither.
|
|
6181
|
+
*/
|
|
6182
|
+
export function filesPublicHostsValue(publicHosts, shareDomains) {
|
|
6183
|
+
const given = (publicHosts ?? '')
|
|
6184
|
+
.split(',')
|
|
6185
|
+
.map((h) => h.trim())
|
|
6186
|
+
.filter(Boolean);
|
|
6187
|
+
return [...new Set([...given, ...normalHosts(shareDomains)])].join(',');
|
|
6188
|
+
}
|
|
6189
|
+
/**
|
|
6190
|
+
* The share domain of every org that has a domain and an entry declaring
|
|
6191
|
+
* `uses.files.shareHost`: `share.<domain>`. The platform files step derives it
|
|
6192
|
+
* from the declared orgs, for its apply and its drift check alike.
|
|
6193
|
+
*/
|
|
6194
|
+
export function filesShareDomains(orgs) {
|
|
6195
|
+
return normalHosts(orgs.map((org) => filesShareHostname(org) ?? ''));
|
|
6196
|
+
}
|