@wrongstack/tools 0.272.1 → 0.273.0

package/dist/builtin.js

@@ -1,13 +1,13 @@
 import { spawn, execFileSync } from 'node:child_process';
 import * as Core from '@wrongstack/core';
-import { buildChildEnv, detectNewlineStyle, normalizeToLf, toStyle, atomicWrite, unifiedDiff, isPrivateIPv4, isPrivateIPv6, assessCommitSafety, compileGlob, expectDefined, recordPackageAction, detectPackageEcosystem, mutatePlan, clearPlan, getPlanTemplate, addPlanItem, deriveTodosFromPlanItem, removePlanItem, setPlanItemStatus, mutateTasks, formatTaskList, formatPlan, toErrorMessage, computeTaskItemProgress, loadPlan, savePlan, loadTasks, saveTasks, wstackGlobalRoot, resolveWstackPaths, truncate } from '@wrongstack/core';
+import { buildChildEnv, detectNewlineStyle, normalizeToLf, toStyle, atomicWrite, unifiedDiff, isPrivateIPv4, isPrivateIPv6, assessCommitSafety, compileGlob, expectDefined, recordPackageAction, detectPackageEcosystem, mutatePlan, clearPlan, getPlanTemplate, addPlanItem, deriveTodosFromPlanItem, removePlanItem, setPlanItemStatus, mutateTasks, formatTaskList, formatPlan, toErrorMessage as toErrorMessage$1, computeTaskItemProgress, loadPlan, savePlan, loadTasks, saveTasks, wstackGlobalRoot, resolveWstackPaths, truncate } from '@wrongstack/core';
 import * as fs from 'node:fs';
 import { statSync, mkdirSync, createWriteStream } from 'node:fs';
 import * as fs2 from 'node:fs/promises';
 import * as path3 from 'node:path';
 import { resolve, sep, dirname, join } from 'node:path';
 import * as os2 from 'node:os';
-import { toErrorMessage as toErrorMessage$1 } from '@wrongstack/core/utils';
+import { toErrorMessage as toErrorMessage$2 } from '@wrongstack/core/utils';
 import { createRequire } from 'node:module';
 import { fileURLToPath } from 'node:url';
 import { Worker } from 'node:worker_threads';
@@ -1084,6 +1084,21 @@ function parseAuditOutput(json, exitCode) {
   }
 }
 var REGISTRY_FILE = ".wrongstack/process-registry.json";
+function toErrorMessage(err) {
+  return err instanceof Error ? err.message : String(err);
+}
+function emitStructuredLog(level, event, message, error) {
+  const payload = {
+    level,
+    event,
+    message,
+    timestamp: (/* @__PURE__ */ new Date()).toISOString()
+  };
+  if (error !== void 0) {
+    payload.error = toErrorMessage(error);
+  }
+  console.log(JSON.stringify(payload));
+}
 var HEARTBEAT_INTERVAL_MS = 5e3;
 var STALE_THRESHOLD_MS = 3e4;
 var LOCKFILE = ".wrongstack/.process-registry.lock";
@@ -1093,6 +1108,9 @@ function generateInstanceId() {
   const random = Math.random().toString(36).slice(2, 8);
   return `${hostname2}:${pid}:${random}`;
 }
+function isNodeError(err) {
+  return typeof err === "object" && err !== null && "code" in err;
+}
 async function acquireLock(lockfilePath, timeoutMs = 5e3) {
   const start = Date.now();
   const pidStr = String(process.pid);
@@ -1107,7 +1125,7 @@ async function acquireLock(lockfilePath, timeoutMs = 5e3) {
         }
       };
     } catch (err) {
-      if (err.code === "EEXIST") {
+      if (isNodeError(err) && err.code === "EEXIST") {
         try {
           const content = await fs2.readFile(lockfilePath, "utf-8");
           const parts = content.split(":");
@@ -1144,7 +1162,7 @@ async function readRegistryFile(filePath) {
     }
     return parsed;
   } catch (err) {
-    if (err.code === "ENOENT") {
+    if (isNodeError(err) && err.code === "ENOENT") {
       return {
         version: 1,
         instances: /* @__PURE__ */ new Map(),
@@ -1180,7 +1198,7 @@ var PersistentProcessRegistry = class {
     this.lockPath = path3.join(homeDir, LOCKFILE);
     this.baseRegistry = baseRegistry ?? getProcessRegistry();
     this.ensureDirectory().catch((err) => {
-      console.error("PersistentProcessRegistry: failed to create .wrongstack dir", err);
+      emitStructuredLog("warn", "process_registry.dir_create_failed", "PersistentProcessRegistry: failed to create .wrongstack directory", err);
     });
   }
   async ensureDirectory() {
@@ -1188,7 +1206,7 @@ var PersistentProcessRegistry = class {
     try {
       await fs2.mkdir(dir, { recursive: true });
     } catch (err) {
-      if (err.code !== "EEXIST") throw err;
+      if (!isNodeError(err) || err.code !== "EEXIST") throw err;
     }
   }
   /**
@@ -1268,6 +1286,7 @@ var PersistentProcessRegistry = class {
     try {
       const data = await readRegistryFile(this.registryPath);
       data.instances.set(String(entry.pid), entry);
+      const child = null;
       this.baseRegistry.register({
         pid: entry.pid,
         name: entry.name,
@@ -1275,8 +1294,7 @@ var PersistentProcessRegistry = class {
         startedAt: entry.startedAt,
         sessionId: entry.sessionId,
         protected: entry.protected,
-        child: null
-        // Main process has no child handle
+        child
       });
       await writeRegistryFile(this.registryPath, data);
     } finally {
@@ -1324,7 +1342,7 @@ var PersistentProcessRegistry = class {
       data.lastCleanup = now;
       await writeRegistryFile(this.registryPath, data);
     } catch (err) {
-      console.error("PersistentProcessRegistry: sync failed", err);
+      emitStructuredLog("warn", "process_registry.sync_failed", "PersistentProcessRegistry: sync failed", err);
     } finally {
       await release();
     }
@@ -1345,7 +1363,11 @@ var PersistentProcessRegistry = class {
             if (process.platform !== "win32") {
               process.kill(entry.pid, 0);
             } else {
-              console.log(`PersistentProcessRegistry: checking stale pid ${entry.pid} (${age}ms old)`);
+              emitStructuredLog(
+                "debug",
+                "process_registry.stale_pid_check",
+                `PersistentProcessRegistry: checking stale pid ${entry.pid} (${age}ms old)`
+              );
             }
           } catch {
             stalePids.push(_pidStr);
@@ -1359,7 +1381,7 @@ var PersistentProcessRegistry = class {
         await writeRegistryFile(this.registryPath, data);
       }
     } catch (err) {
-      console.error("PersistentProcessRegistry: cleanup failed", err);
+      emitStructuredLog("warn", "process_registry.cleanup_failed", "PersistentProcessRegistry: cleanup failed", err);
     } finally {
       await release();
     }
@@ -1582,7 +1604,7 @@ async function isKillProtected(kill) {
     const entries = await getProtectedEntries();
     const killNameLower = kill.name.toLowerCase();
     for (const entry of entries) {
-      if (entry.name && entry.name.toLowerCase().includes(killNameLower)) {
+      if (entry.name?.toLowerCase().includes(killNameLower)) {
         return true;
       }
     }
@@ -2346,7 +2368,7 @@ function loadDatabaseSync() {
     DatabaseSyncCtor = req("node:sqlite").DatabaseSync;
   } catch (err) {
     throw new Error(
-      `The codebase index needs Node's built-in SQLite (node:sqlite), available since Node 22.5. This runtime doesn't provide it: ${toErrorMessage$1(err)}`
+      `The codebase index needs Node's built-in SQLite (node:sqlite), available since Node 22.5. This runtime doesn't provide it: ${toErrorMessage$2(err)}`
     );
   }
   return DatabaseSyncCtor;
@@ -3683,11 +3705,15 @@ async function tryNativeParse(file, content) {
     const crateDir = path3.join(toolsDir, "syn-parser");
     const tmpFile = path3.join(crateDir, "src", "input.rs");
     await fs2.writeFile(tmpFile, content, "utf8");
-    const proc = spawn("cargo", ["run", "--manifest-path", path3.join(toolsDir, "Cargo.toml")], {
-      cwd: process.cwd(),
-      stdio: ["pipe", "pipe", "pipe"],
-      windowsHide: true
-    });
+    const proc = spawn(
+      "cargo",
+      ["run", "--manifest-path", path3.join(toolsDir, "Cargo.toml")],
+      {
+        cwd: process.cwd(),
+        stdio: ["pipe", "pipe", "pipe"],
+        windowsHide: true
+      }
+    );
     let stdout = "";
     proc.stdout?.on("data", (chunk) => {
       stdout += chunk.toString();
@@ -7842,7 +7868,7 @@ var readTool = {
     } catch (err) {
       const code = err.code;
       if (code === "ENOENT") throw new Error(`read: file not found "${input.path}"`);
-      throw new Error(`read: failed to stat "${input.path}": ${toErrorMessage(err)}`);
+      throw new Error(`read: failed to stat "${input.path}": ${toErrorMessage$1(err)}`);
     }
     if (!stat11.isFile()) throw new Error(`read: "${input.path}" is not a regular file`);
     if (stat11.size > MAX_BYTES2) {
@@ -8017,7 +8043,7 @@ var replaceTool = {
         if (err.code === "ENOENT") return null;
         throw err;
       });
-      if (!lstat2 || !lstat2.isFile()) continue;
+      if (!lstat2?.isFile()) continue;
       if (lstat2.isSymbolicLink()) continue;
       let realPath;
       try {
@@ -8028,7 +8054,7 @@ var replaceTool = {
       const rel = path3.relative(realRoot, realPath);
       if (rel.startsWith("..") || path3.isAbsolute(rel)) continue;
       const stat11 = await fs2.stat(realPath).catch(() => null);
-      if (!stat11 || !stat11.isFile()) continue;
+      if (!stat11?.isFile()) continue;
       let content;
       try {
         const buf = await fs2.readFile(realPath);
@@ -8438,7 +8464,7 @@ async function duckduckgoSearch(query2, num, signal) {
       truncated: results.length >= num
     };
   } catch (err) {
-    console.log(JSON.stringify({ level: "debug", event: "search_failed", query: query2, error: toErrorMessage$1(err) }));
+    console.log(JSON.stringify({ level: "debug", event: "search_failed", query: query2, error: toErrorMessage$2(err) }));
     return {
       query: query2,
       results: [{ title: "Search unavailable", url: "", snippet: "Could not reach DuckDuckGo" }],
@@ -8602,7 +8628,7 @@ var setWorkingDirTool = {
     } catch (err) {
       return {
         current: ctx.workingDir,
-        error: toErrorMessage$1(err)
+        error: toErrorMessage$2(err)
       };
     }
     try {
@@ -8752,7 +8778,11 @@ var taskTool = {
             const newIds = new Set(input.tasks.map((t) => t.id));
             if (newIds.size !== input.tasks.length) {
               const seen = /* @__PURE__ */ new Set();
-              const dupes = [...new Set(input.tasks.map((t) => t.id).filter((id) => seen.has(id) ? true : (seen.add(id), false)))];
+              const dupes = [...new Set(input.tasks.map((t) => t.id).filter((id) => {
+                if (seen.has(id)) return true;
+                seen.add(id);
+                return false;
+              }))];
               early = {
                 ok: false,
                 message: `action=replace has duplicate task IDs: ${dupes.join(", ")}. Each task id must be unique.`,
@@ -8787,7 +8817,7 @@ var taskTool = {
           }
           case "add": {
             const t = input.task;
-            if (!t || !t.title) {
+            if (!t?.title) {
               early = { ok: false, message: "action=add requires `task` with at least `title`.", count: 0, completed: 0, inProgress: 0 };
               return f;
             }