@wrongstack/tools 0.260.0 → 0.265.1

package/dist/codebase-index/worker.js

@@ -2,6 +2,7 @@ import { parentPort } from 'node:worker_threads';
 import { expectDefined, resolveWstackPaths, compileGlob, truncate } from '@wrongstack/core';
 import * as fs3 from 'node:fs/promises';
 import * as path4 from 'node:path';
+import { toErrorMessage } from '@wrongstack/core/utils';
 import { createRequire } from 'node:module';
 import * as fs from 'node:fs';
 import { writeFileSync, mkdirSync } from 'node:fs';
@@ -235,7 +236,7 @@ function loadDatabaseSync() {
     DatabaseSyncCtor = req("node:sqlite").DatabaseSync;
   } catch (err) {
     throw new Error(
-      `The codebase index needs Node's built-in SQLite (node:sqlite), available since Node 22.5. This runtime doesn't provide it: ${err instanceof Error ? err.message : String(err)}`
+      `The codebase index needs Node's built-in SQLite (node:sqlite), available since Node 22.5. This runtime doesn't provide it: ${toErrorMessage(err)}`
     );
   }
   return DatabaseSyncCtor;
@@ -681,39 +682,57 @@ var IndexStore = class {
       }
     });
   }
+  /**
+   * Bulk-insert refs for many source symbols in a single transaction.
+   *
+   * Unlike {@link insertRefs} this does NOT delete per source id — the caller
+   * (the indexer) has already cleared stale refs for the file via
+   * {@link deleteRefsForFile}, so the per-source DELETE would be redundant work
+   * repeated once per symbol. One transaction for the whole file instead of one
+   * per symbol turns an O(symbols) transaction count into O(1).
+   *
+   * Each ref's own {@link Ref.fromId} is used; pass an empty array to no-op.
+   */
+  insertRefsBatch(refs) {
+    if (refs.length === 0) return;
+    this.runWithRetry(() => {
+      const stmt = this.db.prepare(
+        `INSERT INTO refs(from_id, to_name, to_id, call_type, line)
+         VALUES (?, ?, ?, ?, ?)`
+      );
+      for (const ref of refs) {
+        stmt.run(ref.fromId, ref.toName, ref.toId ?? null, ref.callType, ref.line);
+      }
+    });
+  }
   /**
    * Delete all refs whose source symbols are in a given file.
    * Used when re-indexing a file to clear stale refs.
    */
   deleteRefsForFile(file) {
     this.runWithRetry(() => {
-      const ids = this.db.prepare(
-        "SELECT id FROM symbols WHERE file = ?"
-      ).all(file);
-      if (!ids.length) return;
-      const placeholders = ids.map(() => "?").join(",");
-      this.db.prepare(`DELETE FROM refs WHERE from_id IN (${placeholders})`).run(...ids.map((r) => r.id));
+      this.db.prepare(
+        "DELETE FROM refs WHERE from_id IN (SELECT id FROM symbols WHERE file = ?)"
+      ).run(file);
     });
   }
   /**
    * Resolve `to_name` → `to_id` for all refs that have a name but no id.
    * Call this after all symbols have been inserted to fill in cross-references.
+   *
+   * Single statement: the `to_name IN (SELECT name FROM symbols)` guard restricts
+   * the UPDATE to refs that will actually resolve, so `.changes` counts only refs
+   * that found a target — matching the previous per-row loop's return value.
    */
   resolveRefs() {
     return this.runWithRetry(() => {
-      const unresolved = this.db.prepare(
-        "SELECT id, to_name FROM refs WHERE to_id IS NULL AND to_name IS NOT NULL"
-      ).all();
-      let resolved = 0;
-      for (const row of unresolved) {
-        const target = this.db.prepare("SELECT id FROM symbols WHERE name = ? LIMIT 1").all(row.to_name);
-        const first = target[0];
-        if (first) {
-          this.db.prepare("UPDATE refs SET to_id = ? WHERE id = ?").run(first.id, row.id);
-          resolved++;
-        }
-      }
-      return resolved;
+      const result = this.db.prepare(
+        `UPDATE refs SET to_id = (
+           SELECT id FROM symbols WHERE name = refs.to_name LIMIT 1
+         ) WHERE to_id IS NULL AND to_name IS NOT NULL
+           AND to_name IN (SELECT name FROM symbols)`
+      ).run();
+      return result.changes ?? 0;
     });
   }
   /**
@@ -820,7 +839,7 @@ function getSignature(node, sourceFile) {
 }
 function getJsDoc(node, sourceFile) {
   const fullText = sourceFile.getFullText();
-  const nodePos = node.getFullWidth();
+  const nodePos = node.getFullStart();
   const comments = ts.getLeadingCommentRanges(fullText, nodePos);
   if (!comments) return "";
   for (const range of comments) {
@@ -2188,13 +2207,26 @@ async function runIndexerWithStore(store, opts) {
     symbolsIndexed += count;
     langStats[lang] = (langStats[lang] ?? 0) + count;
     if (parsed.refs && parsed.refs.length > 0) {
-      for (let i = 0; i < symbolsWithIds.length; i++) {
-        const sym = expectDefined(symbolsWithIds[i]);
-        const symRefs = parsed.refs.filter((r) => r.line === sym.line);
-        if (symRefs.length > 0) {
-          const refsWithFromId = symRefs.map((r) => ({ ...r, fromId: sym.id }));
-          store.insertRefs(sym.id, refsWithFromId);
+      const refsByLine = /* @__PURE__ */ new Map();
+      for (const r of parsed.refs) {
+        let arr = refsByLine.get(r.line);
+        if (!arr) {
+          arr = [];
+          refsByLine.set(r.line, arr);
         }
+        arr.push(r);
+      }
+      const batch = [];
+      for (const sym of symbolsWithIds) {
+        const symRefs = refsByLine.get(sym.line);
+        if (symRefs) {
+          for (const r of symRefs) {
+            batch.push({ ...r, fromId: sym.id });
+          }
+        }
+      }
+      if (batch.length > 0) {
+        store.insertRefsBatch(batch);
       }
     }
     store.upsertFile({