@wrongstack/plugins 0.291.1 → 0.292.0

package/dist/shell-check.js

@@ -1,6 +1,6 @@
 // src/shell-check/index.ts
-import { execFileSync, execSync } from "node:child_process";
-import { existsSync, readdirSync } from "node:fs";
+import { execFile } from "node:child_process";
+import { readdir } from "node:fs/promises";
 import { isAbsolute, join, relative, resolve } from "node:path";
 var API_VERSION = "^0.1.10";
 function withinProject(p) {
@@ -21,15 +21,23 @@ var state = {
   /** Most recent run summary, surfaced by health(). */
   lastRun: null
 };
-function runShellCheck(files, severity, cwd) {
-  if (!existsSync("shellcheck")) {
-    try {
-      execSync("shellcheck --version", { encoding: "utf-8", stdio: "ignore", windowsHide: true });
-    } catch {
-      throw new Error(
-        "shellcheck is not installed. Install via: apt install shellcheck / brew install shellcheck"
+async function runShellCheck(files, severity, cwd) {
+  try {
+    await new Promise((resolvePromise, rejectPromise) => {
+      execFile(
+        "shellcheck",
+        ["--version"],
+        { encoding: "utf-8", windowsHide: true },
+        (err) => {
+          if (err) rejectPromise(err);
+          else resolvePromise();
+        }
       );
-    }
+    });
+  } catch {
+    throw new Error(
+      "shellcheck is not installed. Install via: apt install shellcheck / brew install shellcheck"
+    );
   }
   const levelMap = {
     error: "error",
@@ -41,20 +49,34 @@ function runShellCheck(files, severity, cwd) {
   const args = ["-f", "json", "-S", severityFlag, ...files];
   let raw;
   try {
-    raw = execFileSync("shellcheck", args, {
-      encoding: "utf-8",
-      cwd,
-      stdio: ["pipe", "pipe", "pipe"],
-      timeout: 6e4,
-      windowsHide: true
+    raw = await new Promise((resolvePromise, rejectPromise) => {
+      execFile(
+        "shellcheck",
+        args,
+        {
+          encoding: "utf-8",
+          cwd,
+          windowsHide: true,
+          timeout: 6e4,
+          maxBuffer: 16 * 1024 * 1024
+        },
+        (err, stdout, stderr) => {
+          if (err) {
+            const e = err;
+            const diagnostic = stdout || e.stdout?.toString() || stderr || e.stderr?.toString() || "";
+            if (diagnostic.trim()) {
+              resolvePromise(diagnostic);
+              return;
+            }
+            rejectPromise(err);
+            return;
+          }
+          resolvePromise(stdout);
+        }
+      );
     });
-  } catch (err) {
-    const e = err;
-    if (e.stderr && !e.stderr.includes("shellcheck")) {
-      raw = e.stderr;
-    } else {
-      return [];
-    }
+  } catch {
+    return [];
   }
   if (!raw.trim()) return [];
   try {
@@ -71,21 +93,23 @@ function runShellCheck(files, severity, cwd) {
     return [];
   }
 }
-function findShellFiles(dir, pattern) {
+async function findShellFiles(dir, pattern) {
   const results = [];
+  let entries;
   try {
-    const entries = readdirSync(dir, { withFileTypes: true });
-    for (const entry of entries) {
-      const full = join(dir, entry.name);
-      if (entry.isDirectory() && entry.name !== "node_modules" && entry.name !== ".git") {
-        results.push(...findShellFiles(full, pattern));
-      } else if (entry.isFile() && (entry.name.endsWith(".sh") || entry.name === "Dockerfile")) {
-        if (!pattern || entry.name.includes(pattern)) {
-          results.push(full);
-        }
+    entries = await readdir(dir, { withFileTypes: true });
+  } catch {
+    return results;
+  }
+  for (const entry of entries) {
+    const full = join(dir, entry.name);
+    if (entry.isDirectory() && entry.name !== "node_modules" && entry.name !== ".git") {
+      results.push(...await findShellFiles(full, pattern));
+    } else if (entry.isFile() && (entry.name.endsWith(".sh") || entry.name === "Dockerfile")) {
+      if (!pattern || entry.name.includes(pattern)) {
+        results.push(full);
       }
     }
-  } catch {
   }
   return results;
 }
@@ -186,7 +210,7 @@ var plugin = {
         if (files && files.length > 0) {
           checkFiles = files;
         } else {
-          checkFiles = findShellFiles(directory, pattern);
+          checkFiles = await findShellFiles(directory, pattern);
           scannedDirectories = true;
         }
         if (checkFiles.length === 0) {
@@ -207,7 +231,7 @@ var plugin = {
         }
         let issues;
         try {
-          issues = runShellCheck(checkFiles, severity);
+          issues = await runShellCheck(checkFiles, severity);
         } catch (err) {
           const msg = err instanceof Error ? err.message : String(err);
           return { ok: false, error: msg, issues: [], filesScanned: 0 };