@wrongstack/acp 1.0.26 → 1.0.28

package/dist/agent/server-agent-turn.d.ts

@@ -162,8 +162,10 @@ declare function isRecord(v: unknown): v is Record<string, unknown>;
  * When the prompt is all text we return a plain string (the common,
  * cheapest path). When it carries images we build a multimodal
  * `ContentBlock[]` the provider can pass to a vision-capable model.
- * Audio and resource blocks have no core representation yet, so they're
- * recorded as bracketed text placeholders alongside the other content.
+ * Images go through core's shared ingest (allowlist, base64, size and count
+ * caps, the bytes decide the media type): the client's label used to reach
+ * the provider unchecked. Every other block renders as in the text path, so
+ * an embedded resource keeps its `[embedded resource: <uri>]` header.
  */
 declare function promptToAgentInput(blocks: readonly ContentBlock[]): AgentInput;
 /**

package/dist/agent/stdio-transport.d.ts

@@ -55,6 +55,13 @@ export interface ACPClientTransport {
      * message stream via onMessage, so claim semantics are not needed.
      */
     onMessageClaim?(handler: (msg: ACPMessage) => boolean): () => void;
+    /**
+     * Called once when the connection ends for any reason (the agent exited,
+     * the socket closed, a frame limit tripped, stop()). Optional for custom
+     * transports; without it a client learns of a dead agent only when each
+     * in-flight request times out.
+     */
+    onClose?(handler: (reason: string) => void): () => void;
     stop(): void;
 }
 export declare class StdioTransport implements AgentServerTransport {
@@ -134,6 +141,7 @@ export declare class ClientTransport implements ACPClientTransport {
     private buffer;
     private readonly handlers;
     private readonly claimHandlers;
+    private readonly closeHandlers;
     private closed;
     private resolveRead;
     private messageQueue;
@@ -158,7 +166,10 @@ export declare class ClientTransport implements ACPClientTransport {
      * the gating logic.
      */
     onMessageClaim(handler: (msg: ACPMessage) => boolean): () => void;
-    stop(): void;
+    onClose(handler: (reason: string) => void): () => void;
+    /** Tell close listeners once; the handlers are dropped with the connection. */
+    private notifyClosed;
+    stop(reason?: string): void;
     private onChildData;
     private onChildError;
     private onChildClose;

package/dist/agent.js

@@ -534,6 +534,7 @@ async function handleSetModeOp(ctx, id, params) {
       modeId
     }
   });
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, {});
   return false;
 }
@@ -559,7 +560,7 @@ async function handleSetConfigOptionOp(ctx, id, params) {
       configOptions: options
     }
   });
-  await ctx.persist(session);
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, { configOptions: options });
   return false;
 }
@@ -976,6 +977,7 @@ var ACPProtocolHandler = class {
 };
 
 // src/agent/server-agent-turn.ts
+import { parseIncomingImages } from "@wrongstack/core/utils";
 function makeACPServerAgentTurn(opts) {
   const agents = /* @__PURE__ */ new Map();
   const timeouts = /* @__PURE__ */ new Map();
@@ -987,6 +989,7 @@ function makeACPServerAgentTurn(opts) {
   const maxHistoryBytes = finitePositiveLimit(opts.maxHistoryBytes, 8 * 1024 * 1024);
   const deliveryNoticeDebounceMs = finiteNonNegativeLimit(opts.deliveryNoticeDebounceMs, 1500);
   const notifiers = /* @__PURE__ */ new Map();
+  const liveTurns = /* @__PURE__ */ new Map();
   const stillPending = (sessionId) => {
     if (!opts.pendingDeliveries) return true;
     try {
@@ -1056,6 +1059,9 @@ function makeACPServerAgentTurn(opts) {
     return state;
   };
   const turn = async (input, emit, api) => {
+    const token = Symbol(input.sessionId);
+    liveTurns.set(input.sessionId, token);
+    const alive = () => liveTurns.get(input.sessionId) === token;
     let agent = agents.get(input.sessionId);
     if (!agent) {
       agent = await opts.agentFor(
@@ -1064,6 +1070,12 @@ function makeACPServerAgentTurn(opts) {
         api,
         input.mcpServers
       );
+      if (!alive()) {
+        const stale = agent;
+        void Promise.resolve().then(() => stale.teardown?.()).catch(() => {
+        });
+        return { stopReason: "cancelled" };
+      }
       agents.set(input.sessionId, agent);
       if (pendingSeed.has(input.sessionId)) {
         pendingSeed.delete(input.sessionId);
@@ -1129,10 +1141,11 @@ function makeACPServerAgentTurn(opts) {
           content: { type: "text", text }
         });
       }
+      const record = alive();
       const userText = promptToText(input.prompt);
       const hist = history.get(input.sessionId) ?? [];
       let retainedHistoryBytes = historyBytes.get(input.sessionId) ?? 0;
-      if (userText) {
+      if (record && userText) {
         const update = {
           sessionUpdate: "user_message_chunk",
           content: { type: "text", text: userText }
@@ -1140,7 +1153,7 @@ function makeACPServerAgentTurn(opts) {
         hist.push(update);
         retainedHistoryBytes += replayEntryBytes(update);
       }
-      if (text) {
+      if (record && text) {
         const update = {
           sessionUpdate: "agent_message_chunk",
           content: { type: "text", text }
@@ -1188,6 +1201,7 @@ function makeACPServerAgentTurn(opts) {
       if (usage) result_out.usage = usage;
       return result_out;
     } finally {
+      if (alive()) liveTurns.delete(input.sessionId);
       clearTimeout(timer);
       timeouts.delete(input.sessionId);
       input.signal.removeEventListener("abort", onParentAbort);
@@ -1214,6 +1228,7 @@ function makeACPServerAgentTurn(opts) {
     pendingSeed.add(sessionId);
   };
   const dispose = (sessionId) => {
+    liveTurns.delete(sessionId);
     const timer = timeouts.get(sessionId);
     if (timer) clearTimeout(timer);
     timeouts.delete(sessionId);
@@ -1322,26 +1337,24 @@ function isRecord(v) {
   return typeof v === "object" && v !== null && !Array.isArray(v);
 }
 function promptToAgentInput(blocks) {
-  const hasImage = blocks.some((b) => b.type === "image");
-  if (!hasImage) {
+  const images = blocks.filter((b) => b.type === "image");
+  if (images.length === 0) {
     return promptToText(blocks);
   }
+  let parsed;
+  try {
+    parsed = parseIncomingImages(images.map((b) => ({ data: b.data, mediaType: b.mimeType })));
+  } catch (err) {
+    throw Object.assign(new Error(err.message), { code: -32602 });
+  }
   const out = [];
+  let next = 0;
   for (const b of blocks) {
-    if (b.type === "text") {
-      out.push({ type: "text", text: b.text });
-    } else if (b.type === "image") {
-      out.push({
-        type: "image",
-        source: { type: "base64", media_type: b.mimeType, data: b.data }
-      });
-    } else if (b.type === "audio") {
-      out.push({ type: "text", text: `[audio: ${b.mimeType}]` });
-    } else if (b.type === "resource") {
-      const text = "text" in b.resource && typeof b.resource.text === "string" ? b.resource.text : `[embedded resource: ${b.resource.uri}]`;
-      out.push({ type: "text", text });
-    } else if (b.type === "resource_link") {
-      out.push({ type: "text", text: `[resource link: ${b.uri}]` });
+    if (b.type === "image") out.push(parsed[next++]);
+    else if (b.type === "text") out.push({ type: "text", text: b.text });
+    else {
+      const text = promptToText([b]);
+      if (text) out.push({ type: "text", text });
     }
   }
   return out;
@@ -1691,6 +1704,16 @@ import { treeKill } from "@wrongstack/core/utils/tree-kill";
 var DEFAULT_MAX_FRAME_CHARS = 20 * 1024 * 1024;
 var DEFAULT_MAX_QUEUED_MESSAGES = 1e3;
 var DEFAULT_MAX_QUEUED_CHARS = 32 * 1024 * 1024;
+function takeLines(pending, chunk) {
+  const lines = [];
+  let start = 0;
+  for (let nl = chunk.indexOf("\n"); nl !== -1; nl = chunk.indexOf("\n", start)) {
+    lines.push(pending + chunk.slice(start, nl));
+    pending = "";
+    start = nl + 1;
+  }
+  return { lines, pending: pending + chunk.slice(start) };
+}
 function positiveLimit(value, fallback) {
   return value !== void 0 && Number.isFinite(value) && value > 0 ? Math.floor(value) : fallback;
 }
@@ -1778,9 +1801,8 @@ var StdioTransport = class {
     this.claimHandlers.clear();
   }
   onData(chunk) {
-    this.buffer += chunk;
-    const lines = this.buffer.split("\n");
-    this.buffer = lines.pop() ?? "";
+    const { lines, pending } = takeLines(this.buffer, chunk);
+    this.buffer = pending;
     if (this.buffer.length > this.maxFrameChars) {
       this.stderr.write(
         `[wstack-acp frame error] pending frame exceeds ${this.maxFrameChars} characters
@@ -2087,16 +2109,17 @@ var WrongStackACPServer = class {
         return;
       }
       const MAX_HTTP_BODY = 10 * 1024 * 1024;
-      let body = "";
+      const chunks = [];
       let bodyBytes = 0;
       let tooLarge = false;
       for await (const chunk of req) {
         bodyBytes += chunk.length;
         if (bodyBytes > MAX_HTTP_BODY) {
           tooLarge = true;
-          break;
+          chunks.length = 0;
+          if (bodyBytes > 2 * MAX_HTTP_BODY) break;
         }
-        body += chunk;
+        if (!tooLarge) chunks.push(chunk);
       }
       if (tooLarge) {
         res.writeHead(413, { "Content-Type": "application/json" });
@@ -2105,7 +2128,7 @@ var WrongStackACPServer = class {
       }
       let msg;
       try {
-        msg = JSON.parse(body);
+        msg = JSON.parse(Buffer.concat(chunks).toString("utf8"));
       } catch {
         res.writeHead(400);
         res.end(JSON.stringify({ error: { code: -32700, message: "Parse error" } }));

package/dist/client/acp-request-state.d.ts

@@ -6,4 +6,11 @@ export interface PendingRequest {
     timeoutHandle: ReturnType<typeof setTimeout>;
 }
 export type State = 'init' | 'ready' | 'authenticated' | 'sessioning' | 'prompting' | 'done' | 'closed';
+/**
+ * Fail and forget every in-flight request. Without a `reason` the session was
+ * closed locally; with one, the agent connection ended (the process exited,
+ * the socket closed), so no reply can arrive and waiting out each request's
+ * timeout would only stall the caller.
+ */
+export declare function rejectPendingRequests(pending: Map<string | number, PendingRequest>, reason?: string): void;
 //# sourceMappingURL=acp-request-state.d.ts.map

package/dist/client/websocket-transport.d.ts

@@ -31,6 +31,7 @@ export interface WebSocketClientTransportOptions {
 export declare class WebSocketClientTransport implements ACPClientTransport {
     private ws;
     private readonly handlers;
+    private readonly closeHandlers;
     private closed;
     private readonly opts;
     private readonly maxBufferedBytes;
@@ -41,7 +42,10 @@ export declare class WebSocketClientTransport implements ACPClientTransport {
     start(): Promise<void>;
     send(msg: ACPMessage): Promise<void>;
     onMessage(handler: (msg: ACPMessage) => void): () => void;
-    stop(): void;
+    onClose(handler: (reason: string) => void): () => void;
+    /** Tell close listeners once; the handlers are dropped with the connection. */
+    private notifyClosed;
+    stop(reason?: string): void;
     private onData;
     private dispatch;
 }

package/dist/client.js

@@ -11,6 +11,16 @@ import {
 var DEFAULT_MAX_FRAME_CHARS = 20 * 1024 * 1024;
 var DEFAULT_MAX_QUEUED_MESSAGES = 1e3;
 var DEFAULT_MAX_QUEUED_CHARS = 32 * 1024 * 1024;
+function takeLines(pending, chunk) {
+  const lines = [];
+  let start = 0;
+  for (let nl = chunk.indexOf("\n"); nl !== -1; nl = chunk.indexOf("\n", start)) {
+    lines.push(pending + chunk.slice(start, nl));
+    pending = "";
+    start = nl + 1;
+  }
+  return { lines, pending: pending + chunk.slice(start) };
+}
 function positiveLimit(value, fallback) {
   return value !== void 0 && Number.isFinite(value) && value > 0 ? Math.floor(value) : fallback;
 }
@@ -19,6 +29,7 @@ var ClientTransport = class {
   buffer = "";
   handlers = /* @__PURE__ */ new Set();
   claimHandlers = /* @__PURE__ */ new Set();
+  closeHandlers = /* @__PURE__ */ new Set();
   closed = false;
   resolveRead = null;
   messageQueue = [];
@@ -126,6 +137,7 @@ var ClientTransport = class {
   }
   send(msg) {
     if (!this.child) return Promise.reject(new Error("ClientTransport not started"));
+    if (this.closed) return Promise.reject(new Error("ClientTransport is closed"));
     return new Promise((resolve3, reject) => {
       const line = JSON.stringify(msg) + "\n";
       this.child?.stdin.write(line, "utf8", (err) => {
@@ -163,7 +175,22 @@ var ClientTransport = class {
     this.claimHandlers.add(handler);
     return () => this.claimHandlers.delete(handler);
   }
-  stop() {
+  onClose(handler) {
+    this.closeHandlers.add(handler);
+    return () => this.closeHandlers.delete(handler);
+  }
+  /** Tell close listeners once; the handlers are dropped with the connection. */
+  notifyClosed(reason) {
+    const handlers = [...this.closeHandlers];
+    this.closeHandlers.clear();
+    for (const handler of handlers) {
+      try {
+        handler(reason);
+      } catch {
+      }
+    }
+  }
+  stop(reason = "transport stopped") {
     this.closed = true;
     this.resolveRead?.(null);
     this.resolveRead = null;
@@ -172,19 +199,19 @@ var ClientTransport = class {
     this.queuedChars = 0;
     this.handlers.clear();
     this.claimHandlers.clear();
+    this.notifyClosed(reason);
     const child = this.child;
     if (!child) return;
     treeKill(child);
     this.child = null;
   }
   onChildData(chunk) {
-    this.buffer += chunk;
-    const lines = this.buffer.split("\n");
-    this.buffer = lines.pop() ?? "";
+    const { lines, pending } = takeLines(this.buffer, chunk);
+    this.buffer = pending;
     if (this.buffer.length > this.maxFrameChars) {
       writeErr(`[acp-child pending frame exceeds ${this.maxFrameChars} characters]
 `);
-      this.stop();
+      this.stop(`agent frame exceeds ${this.maxFrameChars} characters`);
       return;
     }
     for (const raw of lines) {
@@ -192,7 +219,7 @@ var ClientTransport = class {
       if (raw.length > this.maxFrameChars) {
         writeErr(`[acp-child frame exceeds ${this.maxFrameChars} characters]
 `);
-        this.stop();
+        this.stop(`agent frame exceeds ${this.maxFrameChars} characters`);
         return;
       }
       try {
@@ -218,6 +245,7 @@ var ClientTransport = class {
       writeErr(`[acp-child exited with code ${code}]
 `);
     }
+    this.notifyClosed(`agent process exited with code ${code}`);
   }
   dispatch(msg, chars = JSON.stringify(msg).length) {
     if (this.resolveRead) {
@@ -364,6 +392,16 @@ function isAuthRequiredError(err) {
   return false;
 }
 
+// src/client/acp-request-state.ts
+function rejectPendingRequests(pending, reason) {
+  for (const p of pending.values()) {
+    clearTimeout(p.timeoutHandle);
+    const message = reason === void 0 ? "session was closed" : `agent connection closed (${reason}) during ${p.method}`;
+    p.reject(new ACPSessionError("closed", message));
+  }
+  pending.clear();
+}
+
 // src/client/acp-session-ops.ts
 function filterMcpServers(agentCapabilities, servers) {
   if (!servers || servers.length === 0) return [];
@@ -1263,11 +1301,30 @@ function makePermissionPolicy(decide) {
 // src/client/terminal-server.ts
 import { spawn } from "node:child_process";
 import { randomBytes as randomBytes2 } from "node:crypto";
-import { realpathSync as realpathSync2 } from "node:fs";
+import { accessSync, realpathSync as realpathSync2 } from "node:fs";
 import * as path2 from "node:path";
 import { buildChildEnv } from "@wrongstack/core/utils";
 import { treeKill as treeKill2 } from "@wrongstack/core/utils/tree-kill";
 var EMPTY_BUFFER = Buffer.alloc(0);
+function win32BatchTarget(command) {
+  if (/\.(?:cmd|bat)$/i.test(command)) return command;
+  if (/[\\/]/.test(command) || path2.extname(command)) return void 0;
+  const exts = (process.env["PATHEXT"] ?? ".COM;.EXE;.BAT;.CMD").toLowerCase().split(";");
+  for (const dir of (process.env["PATH"] ?? "").split(path2.delimiter)) {
+    if (!dir) continue;
+    for (const ext of exts) {
+      if (!ext) continue;
+      const full = path2.join(dir, `${command}${ext}`);
+      try {
+        accessSync(full);
+      } catch {
+        continue;
+      }
+      return ext === ".cmd" || ext === ".bat" ? full : void 0;
+    }
+  }
+  return void 0;
+}
 var DEBUG_DISPOSE = typeof process !== "undefined" && !!process.env?.WRONGSTACK_DEBUG && process.env.WRONGSTACK_DEBUG !== "0" && process.env.WRONGSTACK_DEBUG !== "false";
 var TerminalServer = class {
   terminals = /* @__PURE__ */ new Map();
@@ -1318,11 +1375,14 @@ var TerminalServer = class {
       Math.max(1, this.clampFiniteInt(params.outputByteLimit, this.outputByteLimit)),
       this.maxOutputByteLimit
     );
-    const proc = spawn(params.command, params.args ?? [], {
+    const batch = process.platform === "win32" ? win32BatchTarget(params.command) : void 0;
+    const shim = batch ? buildWin32CmdShimInvocation(batch, params.args ?? []) : void 0;
+    const proc = spawn(shim?.command ?? params.command, shim?.args ?? params.args ?? [], {
       cwd,
       env: this.buildEnv(params.env),
       stdio: ["ignore", "pipe", "pipe"],
-      windowsHide: true
+      windowsHide: true,
+      ...shim ? { windowsVerbatimArguments: shim.windowsVerbatimArguments } : {}
       // shell: false on purpose. The terminal server is invoked with
       // the agent's explicit argv; turning on shell-mode would make
       // the command a single shell-parsed string, which breaks
@@ -1619,7 +1679,7 @@ function isAllowed(decision) {
 }
 function toTrustBoundaryRequest(request, options) {
   const rawSessionId = request.toolCall.rawInput?.sessionId;
-  const sessionId = typeof rawSessionId === "string" && rawSessionId.length > 0 ? rawSessionId : options.actor?.sessionId;
+  const sessionId = options.actor?.sessionId ?? (typeof rawSessionId === "string" && rawSessionId.length > 0 ? rawSessionId : void 0);
   return {
     version: 1,
     requestId: String(request.toolCall.toolCallId),
@@ -1655,6 +1715,7 @@ function makeTrustBoundaryPermissionPolicy(options) {
 var WebSocketClientTransport = class {
   ws = null;
   handlers = /* @__PURE__ */ new Set();
+  closeHandlers = /* @__PURE__ */ new Set();
   closed = false;
   opts;
   maxBufferedBytes;
@@ -1681,6 +1742,7 @@ var WebSocketClientTransport = class {
     const timeoutMs = this.opts.handshakeTimeoutMs ?? 3e4;
     return new Promise((resolve3, reject) => {
       const ws = new WS(this.opts.url, this.opts.protocols);
+      ws.binaryType = "arraybuffer";
       this.ws = ws;
       const timer = setTimeout(() => {
         const pending = this.pendingStart;
@@ -1706,7 +1768,7 @@ var WebSocketClientTransport = class {
       ws.addEventListener("error", (ev) => {
         const pending = this.pendingStart;
         if (pending === null) {
-          this.stop();
+          this.stop("WebSocket error");
           return;
         }
         this.pendingStart = null;
@@ -1727,6 +1789,7 @@ var WebSocketClientTransport = class {
           clearTimeout(pending.timer);
           pending.reject(new Error("WebSocket closed before the connection opened"));
         }
+        this.notifyClosed("WebSocket closed");
       });
       ws.addEventListener("message", (ev) => {
         this.onData(ev.data);
@@ -1754,9 +1817,25 @@ var WebSocketClientTransport = class {
     this.handlers.add(handler);
     return () => this.handlers.delete(handler);
   }
-  stop() {
+  onClose(handler) {
+    this.closeHandlers.add(handler);
+    return () => this.closeHandlers.delete(handler);
+  }
+  /** Tell close listeners once; the handlers are dropped with the connection. */
+  notifyClosed(reason) {
+    const handlers = [...this.closeHandlers];
+    this.closeHandlers.clear();
+    for (const handler of handlers) {
+      try {
+        handler(reason);
+      } catch {
+      }
+    }
+  }
+  stop(reason = "transport stopped") {
     this.closed = true;
     this.handlers.clear();
+    this.notifyClosed(reason);
     if (this.pendingStart !== null) {
       const pending = this.pendingStart;
       this.pendingStart = null;
@@ -1777,7 +1856,7 @@ var WebSocketClientTransport = class {
   onData(data) {
     const text = typeof data === "string" ? data : data instanceof ArrayBuffer ? Buffer.from(data).toString("utf8") : Buffer.isBuffer(data) ? data.toString("utf8") : String(data);
     if (text.length > this.maxMessageChars) {
-      this.stop();
+      this.stop(`agent message exceeds ${this.maxMessageChars} characters`);
       return;
     }
     if (!text.trim()) return;
@@ -1946,6 +2025,10 @@ var ACPSession = class _ACPSession {
     }
     const session = new _ACPSession(opts, transport);
     session.transportOff = transport.onMessage((msg) => session.handleMessage(msg));
+    transport.onClose?.((reason) => {
+      if (!session.closed) rejectPendingRequests(session.pending, reason);
+      void session.close();
+    });
     try {
       await session.initialize();
     } catch (err) {
@@ -2072,6 +2155,9 @@ var ACPSession = class _ACPSession {
     if (this.state !== "ready" && this.state !== "authenticated" && this.state !== "done") {
       throw new ACPSessionError("protocol_error", `prompt called in state=${this.state}`);
     }
+    if (this.promptCallbackAbort) {
+      throw new ACPSessionError("protocol_error", "prompt called while another prompt is running");
+    }
     if (signal.aborted) {
       return emptyRunResult("cancelled");
     }
@@ -2143,6 +2229,7 @@ var ACPSession = class _ACPSession {
       this.sessionId = sessionId;
     }
     if (signal.aborted) {
+      this.promptCallbackAbort = null;
       return emptyRunResult("cancelled");
     }
     this.resetScratch();
@@ -2250,11 +2337,7 @@ var ACPSession = class _ACPSession {
       } catch {
       }
     }
-    for (const [, p] of this.pending) {
-      clearTimeout(p.timeoutHandle);
-      p.reject(new ACPSessionError("closed", "session was closed"));
-    }
-    this.pending.clear();
+    rejectPendingRequests(this.pending);
     this.transportOff?.();
     this.transportOff = null;
     try {
@@ -2470,6 +2553,7 @@ async function makeACPSubagentRunnerWithStop(options) {
   const timeoutMs = options.timeoutMs ?? 5 * 6e4;
   const persistent = options.persistent === true;
   let shared = null;
+  let turns = Promise.resolve();
   const startSession = async () => {
     return ACPSession.start({
       command: options.command,
@@ -2485,10 +2569,17 @@ async function makeACPSubagentRunnerWithStop(options) {
   };
   const runner = async (task, ctx) => {
     let session;
-    const reuse = persistent && shared !== null;
     try {
-      session = reuse ? shared : await startSession();
-      if (persistent) shared = session;
+      if (persistent) {
+        shared ??= startSession();
+        const starting = shared;
+        session = await starting.catch((err) => {
+          if (shared === starting) shared = null;
+          throw err;
+        });
+      } else {
+        session = await startSession();
+      }
     } catch (err) {
       throw acpErrorToSubagentError(err, options.role ?? "acp-subagent");
     }
@@ -2505,7 +2596,10 @@ async function makeACPSubagentRunnerWithStop(options) {
     };
     let result;
     try {
-      result = await session.prompt([textContent(task.description)], ctx.signal, onProgress);
+      const turn = () => session.prompt([textContent(task.description)], ctx.signal, onProgress);
+      const run = persistent ? turns.then(turn, turn) : turn();
+      if (persistent) turns = run;
+      result = await run;
     } catch (err) {
       throw acpErrorToSubagentError(err, options.role ?? "acp-subagent");
     } finally {
@@ -2526,10 +2620,10 @@ async function makeACPSubagentRunnerWithStop(options) {
   };
   const stop = async () => {
     if (shared) {
-      const s = shared;
+      const starting = shared;
       shared = null;
       try {
-        await s.close();
+        await (await starting).close();
       } catch {
       }
     }

package/dist/index.js

@@ -537,6 +537,7 @@ async function handleSetModeOp(ctx, id, params) {
       modeId
     }
   });
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, {});
   return false;
 }
@@ -562,7 +563,7 @@ async function handleSetConfigOptionOp(ctx, id, params) {
       configOptions: options
     }
   });
-  await ctx.persist(session);
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, { configOptions: options });
   return false;
 }
@@ -991,6 +992,16 @@ import {
 var DEFAULT_MAX_FRAME_CHARS = 20 * 1024 * 1024;
 var DEFAULT_MAX_QUEUED_MESSAGES = 1e3;
 var DEFAULT_MAX_QUEUED_CHARS = 32 * 1024 * 1024;
+function takeLines(pending, chunk) {
+  const lines = [];
+  let start = 0;
+  for (let nl = chunk.indexOf("\n"); nl !== -1; nl = chunk.indexOf("\n", start)) {
+    lines.push(pending + chunk.slice(start, nl));
+    pending = "";
+    start = nl + 1;
+  }
+  return { lines, pending: pending + chunk.slice(start) };
+}
 function positiveLimit(value, fallback) {
   return value !== void 0 && Number.isFinite(value) && value > 0 ? Math.floor(value) : fallback;
 }
@@ -1078,9 +1089,8 @@ var StdioTransport = class {
     this.claimHandlers.clear();
   }
   onData(chunk) {
-    this.buffer += chunk;
-    const lines = this.buffer.split("\n");
-    this.buffer = lines.pop() ?? "";
+    const { lines, pending } = takeLines(this.buffer, chunk);
+    this.buffer = pending;
     if (this.buffer.length > this.maxFrameChars) {
       this.stderr.write(
         `[wstack-acp frame error] pending frame exceeds ${this.maxFrameChars} characters
@@ -1161,6 +1171,7 @@ var ClientTransport = class {
   buffer = "";
   handlers = /* @__PURE__ */ new Set();
   claimHandlers = /* @__PURE__ */ new Set();
+  closeHandlers = /* @__PURE__ */ new Set();
   closed = false;
   resolveRead = null;
   messageQueue = [];
@@ -1268,6 +1279,7 @@ var ClientTransport = class {
   }
   send(msg) {
     if (!this.child) return Promise.reject(new Error("ClientTransport not started"));
+    if (this.closed) return Promise.reject(new Error("ClientTransport is closed"));
     return new Promise((resolve5, reject) => {
       const line = JSON.stringify(msg) + "\n";
       this.child?.stdin.write(line, "utf8", (err) => {
@@ -1305,7 +1317,22 @@ var ClientTransport = class {
     this.claimHandlers.add(handler);
     return () => this.claimHandlers.delete(handler);
   }
-  stop() {
+  onClose(handler) {
+    this.closeHandlers.add(handler);
+    return () => this.closeHandlers.delete(handler);
+  }
+  /** Tell close listeners once; the handlers are dropped with the connection. */
+  notifyClosed(reason) {
+    const handlers = [...this.closeHandlers];
+    this.closeHandlers.clear();
+    for (const handler of handlers) {
+      try {
+        handler(reason);
+      } catch {
+      }
+    }
+  }
+  stop(reason = "transport stopped") {
     this.closed = true;
     this.resolveRead?.(null);
     this.resolveRead = null;
@@ -1314,19 +1341,19 @@ var ClientTransport = class {
     this.queuedChars = 0;
     this.handlers.clear();
     this.claimHandlers.clear();
+    this.notifyClosed(reason);
     const child = this.child;
     if (!child) return;
     treeKill(child);
     this.child = null;
   }
   onChildData(chunk) {
-    this.buffer += chunk;
-    const lines = this.buffer.split("\n");
-    this.buffer = lines.pop() ?? "";
+    const { lines, pending } = takeLines(this.buffer, chunk);
+    this.buffer = pending;
     if (this.buffer.length > this.maxFrameChars) {
       writeErr(`[acp-child pending frame exceeds ${this.maxFrameChars} characters]
 `);
-      this.stop();
+      this.stop(`agent frame exceeds ${this.maxFrameChars} characters`);
       return;
     }
     for (const raw of lines) {
@@ -1334,7 +1361,7 @@ var ClientTransport = class {
       if (raw.length > this.maxFrameChars) {
         writeErr(`[acp-child frame exceeds ${this.maxFrameChars} characters]
 `);
-        this.stop();
+        this.stop(`agent frame exceeds ${this.maxFrameChars} characters`);
         return;
       }
       try {
@@ -1360,6 +1387,7 @@ var ClientTransport = class {
       writeErr(`[acp-child exited with code ${code}]
 `);
     }
+    this.notifyClosed(`agent process exited with code ${code}`);
   }
   dispatch(msg, chars = JSON.stringify(msg).length) {
     if (this.resolveRead) {
@@ -1635,16 +1663,17 @@ var WrongStackACPServer = class {
         return;
       }
       const MAX_HTTP_BODY = 10 * 1024 * 1024;
-      let body = "";
+      const chunks = [];
       let bodyBytes = 0;
       let tooLarge = false;
       for await (const chunk of req) {
         bodyBytes += chunk.length;
         if (bodyBytes > MAX_HTTP_BODY) {
           tooLarge = true;
-          break;
+          chunks.length = 0;
+          if (bodyBytes > 2 * MAX_HTTP_BODY) break;
         }
-        body += chunk;
+        if (!tooLarge) chunks.push(chunk);
       }
       if (tooLarge) {
         res.writeHead(413, { "Content-Type": "application/json" });
@@ -1653,7 +1682,7 @@ var WrongStackACPServer = class {
       }
       let msg;
       try {
-        msg = JSON.parse(body);
+        msg = JSON.parse(Buffer.concat(chunks).toString("utf8"));
       } catch {
         res.writeHead(400);
         res.end(JSON.stringify({ error: { code: -32700, message: "Parse error" } }));
@@ -1887,6 +1916,16 @@ function isAuthRequiredError(err) {
   return false;
 }
 
+// src/client/acp-request-state.ts
+function rejectPendingRequests(pending, reason) {
+  for (const p of pending.values()) {
+    clearTimeout(p.timeoutHandle);
+    const message = reason === void 0 ? "session was closed" : `agent connection closed (${reason}) during ${p.method}`;
+    p.reject(new ACPSessionError("closed", message));
+  }
+  pending.clear();
+}
+
 // src/client/acp-session-ops.ts
 function filterMcpServers(agentCapabilities, servers) {
   if (!servers || servers.length === 0) return [];
@@ -2786,11 +2825,30 @@ function makePermissionPolicy(decide) {
 // src/client/terminal-server.ts
 import { spawn } from "node:child_process";
 import { randomBytes as randomBytes2 } from "node:crypto";
-import { realpathSync as realpathSync2 } from "node:fs";
+import { accessSync, realpathSync as realpathSync2 } from "node:fs";
 import * as path3 from "node:path";
 import { buildChildEnv } from "@wrongstack/core/utils";
 import { treeKill as treeKill2 } from "@wrongstack/core/utils/tree-kill";
 var EMPTY_BUFFER = Buffer.alloc(0);
+function win32BatchTarget(command) {
+  if (/\.(?:cmd|bat)$/i.test(command)) return command;
+  if (/[\\/]/.test(command) || path3.extname(command)) return void 0;
+  const exts = (process.env["PATHEXT"] ?? ".COM;.EXE;.BAT;.CMD").toLowerCase().split(";");
+  for (const dir of (process.env["PATH"] ?? "").split(path3.delimiter)) {
+    if (!dir) continue;
+    for (const ext of exts) {
+      if (!ext) continue;
+      const full = path3.join(dir, `${command}${ext}`);
+      try {
+        accessSync(full);
+      } catch {
+        continue;
+      }
+      return ext === ".cmd" || ext === ".bat" ? full : void 0;
+    }
+  }
+  return void 0;
+}
 var DEBUG_DISPOSE = typeof process !== "undefined" && !!process.env?.WRONGSTACK_DEBUG && process.env.WRONGSTACK_DEBUG !== "0" && process.env.WRONGSTACK_DEBUG !== "false";
 var TerminalServer = class {
   terminals = /* @__PURE__ */ new Map();
@@ -2841,11 +2899,14 @@ var TerminalServer = class {
       Math.max(1, this.clampFiniteInt(params.outputByteLimit, this.outputByteLimit)),
       this.maxOutputByteLimit
     );
-    const proc = spawn(params.command, params.args ?? [], {
+    const batch = process.platform === "win32" ? win32BatchTarget(params.command) : void 0;
+    const shim = batch ? buildWin32CmdShimInvocation(batch, params.args ?? []) : void 0;
+    const proc = spawn(shim?.command ?? params.command, shim?.args ?? params.args ?? [], {
       cwd,
       env: this.buildEnv(params.env),
       stdio: ["ignore", "pipe", "pipe"],
-      windowsHide: true
+      windowsHide: true,
+      ...shim ? { windowsVerbatimArguments: shim.windowsVerbatimArguments } : {}
       // shell: false on purpose. The terminal server is invoked with
       // the agent's explicit argv; turning on shell-mode would make
       // the command a single shell-parsed string, which breaks
@@ -3142,7 +3203,7 @@ function isAllowed(decision) {
 }
 function toTrustBoundaryRequest(request, options) {
   const rawSessionId = request.toolCall.rawInput?.sessionId;
-  const sessionId = typeof rawSessionId === "string" && rawSessionId.length > 0 ? rawSessionId : options.actor?.sessionId;
+  const sessionId = options.actor?.sessionId ?? (typeof rawSessionId === "string" && rawSessionId.length > 0 ? rawSessionId : void 0);
   return {
     version: 1,
     requestId: String(request.toolCall.toolCallId),
@@ -3178,6 +3239,7 @@ function makeTrustBoundaryPermissionPolicy(options) {
 var WebSocketClientTransport = class {
   ws = null;
   handlers = /* @__PURE__ */ new Set();
+  closeHandlers = /* @__PURE__ */ new Set();
   closed = false;
   opts;
   maxBufferedBytes;
@@ -3204,6 +3266,7 @@ var WebSocketClientTransport = class {
     const timeoutMs = this.opts.handshakeTimeoutMs ?? 3e4;
     return new Promise((resolve5, reject) => {
       const ws = new WS(this.opts.url, this.opts.protocols);
+      ws.binaryType = "arraybuffer";
       this.ws = ws;
       const timer = setTimeout(() => {
         const pending = this.pendingStart;
@@ -3229,7 +3292,7 @@ var WebSocketClientTransport = class {
       ws.addEventListener("error", (ev) => {
         const pending = this.pendingStart;
         if (pending === null) {
-          this.stop();
+          this.stop("WebSocket error");
           return;
         }
         this.pendingStart = null;
@@ -3250,6 +3313,7 @@ var WebSocketClientTransport = class {
           clearTimeout(pending.timer);
           pending.reject(new Error("WebSocket closed before the connection opened"));
         }
+        this.notifyClosed("WebSocket closed");
       });
       ws.addEventListener("message", (ev) => {
         this.onData(ev.data);
@@ -3277,9 +3341,25 @@ var WebSocketClientTransport = class {
     this.handlers.add(handler);
     return () => this.handlers.delete(handler);
   }
-  stop() {
+  onClose(handler) {
+    this.closeHandlers.add(handler);
+    return () => this.closeHandlers.delete(handler);
+  }
+  /** Tell close listeners once; the handlers are dropped with the connection. */
+  notifyClosed(reason) {
+    const handlers = [...this.closeHandlers];
+    this.closeHandlers.clear();
+    for (const handler of handlers) {
+      try {
+        handler(reason);
+      } catch {
+      }
+    }
+  }
+  stop(reason = "transport stopped") {
     this.closed = true;
     this.handlers.clear();
+    this.notifyClosed(reason);
     if (this.pendingStart !== null) {
       const pending = this.pendingStart;
       this.pendingStart = null;
@@ -3300,7 +3380,7 @@ var WebSocketClientTransport = class {
   onData(data) {
     const text = typeof data === "string" ? data : data instanceof ArrayBuffer ? Buffer.from(data).toString("utf8") : Buffer.isBuffer(data) ? data.toString("utf8") : String(data);
     if (text.length > this.maxMessageChars) {
-      this.stop();
+      this.stop(`agent message exceeds ${this.maxMessageChars} characters`);
       return;
     }
     if (!text.trim()) return;
@@ -3469,6 +3549,10 @@ var ACPSession = class _ACPSession {
     }
     const session = new _ACPSession(opts, transport);
     session.transportOff = transport.onMessage((msg) => session.handleMessage(msg));
+    transport.onClose?.((reason) => {
+      if (!session.closed) rejectPendingRequests(session.pending, reason);
+      void session.close();
+    });
     try {
       await session.initialize();
     } catch (err) {
@@ -3595,6 +3679,9 @@ var ACPSession = class _ACPSession {
     if (this.state !== "ready" && this.state !== "authenticated" && this.state !== "done") {
       throw new ACPSessionError("protocol_error", `prompt called in state=${this.state}`);
     }
+    if (this.promptCallbackAbort) {
+      throw new ACPSessionError("protocol_error", "prompt called while another prompt is running");
+    }
     if (signal.aborted) {
       return emptyRunResult("cancelled");
     }
@@ -3666,6 +3753,7 @@ var ACPSession = class _ACPSession {
       this.sessionId = sessionId;
     }
     if (signal.aborted) {
+      this.promptCallbackAbort = null;
       return emptyRunResult("cancelled");
     }
     this.resetScratch();
@@ -3773,11 +3861,7 @@ var ACPSession = class _ACPSession {
       } catch {
       }
     }
-    for (const [, p] of this.pending) {
-      clearTimeout(p.timeoutHandle);
-      p.reject(new ACPSessionError("closed", "session was closed"));
-    }
-    this.pending.clear();
+    rejectPendingRequests(this.pending);
     this.transportOff?.();
     this.transportOff = null;
     try {
@@ -4535,6 +4619,7 @@ async function makeACPSubagentRunnerWithStop(options) {
   const timeoutMs = options.timeoutMs ?? 5 * 6e4;
   const persistent = options.persistent === true;
   let shared = null;
+  let turns = Promise.resolve();
   const startSession = async () => {
     return ACPSession.start({
       command: options.command,
@@ -4550,10 +4635,17 @@ async function makeACPSubagentRunnerWithStop(options) {
   };
   const runner = async (task, ctx) => {
     let session;
-    const reuse = persistent && shared !== null;
     try {
-      session = reuse ? shared : await startSession();
-      if (persistent) shared = session;
+      if (persistent) {
+        shared ??= startSession();
+        const starting = shared;
+        session = await starting.catch((err) => {
+          if (shared === starting) shared = null;
+          throw err;
+        });
+      } else {
+        session = await startSession();
+      }
     } catch (err) {
       throw acpErrorToSubagentError(err, options.role ?? "acp-subagent");
     }
@@ -4570,7 +4662,10 @@ async function makeACPSubagentRunnerWithStop(options) {
     };
     let result;
     try {
-      result = await session.prompt([textContent(task.description)], ctx.signal, onProgress);
+      const turn = () => session.prompt([textContent(task.description)], ctx.signal, onProgress);
+      const run = persistent ? turns.then(turn, turn) : turn();
+      if (persistent) turns = run;
+      result = await run;
     } catch (err) {
       throw acpErrorToSubagentError(err, options.role ?? "acp-subagent");
     } finally {
@@ -4591,10 +4686,10 @@ async function makeACPSubagentRunnerWithStop(options) {
   };
   const stop = async () => {
     if (shared) {
-      const s = shared;
+      const starting = shared;
       shared = null;
       try {
-        await s.close();
+        await (await starting).close();
       } catch {
       }
     }

package/dist/wrongstack-acp-agent.js

@@ -541,6 +541,7 @@ async function handleSetModeOp(ctx, id, params) {
       modeId
     }
   });
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, {});
   return false;
 }
@@ -566,7 +567,7 @@ async function handleSetConfigOptionOp(ctx, id, params) {
       configOptions: options
     }
   });
-  await ctx.persist(session);
+  if (ctx.sessions.get(session.id) === session) await ctx.persist(session);
   await ctx.sendResult(id, { configOptions: options });
   return false;
 }
@@ -988,6 +989,16 @@ import { treeKill } from "@wrongstack/core/utils/tree-kill";
 var DEFAULT_MAX_FRAME_CHARS = 20 * 1024 * 1024;
 var DEFAULT_MAX_QUEUED_MESSAGES = 1e3;
 var DEFAULT_MAX_QUEUED_CHARS = 32 * 1024 * 1024;
+function takeLines(pending, chunk) {
+  const lines = [];
+  let start = 0;
+  for (let nl = chunk.indexOf("\n"); nl !== -1; nl = chunk.indexOf("\n", start)) {
+    lines.push(pending + chunk.slice(start, nl));
+    pending = "";
+    start = nl + 1;
+  }
+  return { lines, pending: pending + chunk.slice(start) };
+}
 function positiveLimit(value, fallback) {
   return value !== void 0 && Number.isFinite(value) && value > 0 ? Math.floor(value) : fallback;
 }
@@ -1075,9 +1086,8 @@ var StdioTransport = class {
     this.claimHandlers.clear();
   }
   onData(chunk) {
-    this.buffer += chunk;
-    const lines = this.buffer.split("\n");
-    this.buffer = lines.pop() ?? "";
+    const { lines, pending } = takeLines(this.buffer, chunk);
+    this.buffer = pending;
     if (this.buffer.length > this.maxFrameChars) {
       this.stderr.write(
         `[wstack-acp frame error] pending frame exceeds ${this.maxFrameChars} characters
@@ -1267,16 +1277,17 @@ var WrongStackACPServer = class {
         return;
       }
       const MAX_HTTP_BODY = 10 * 1024 * 1024;
-      let body = "";
+      const chunks = [];
       let bodyBytes = 0;
       let tooLarge = false;
       for await (const chunk of req) {
         bodyBytes += chunk.length;
         if (bodyBytes > MAX_HTTP_BODY) {
           tooLarge = true;
-          break;
+          chunks.length = 0;
+          if (bodyBytes > 2 * MAX_HTTP_BODY) break;
         }
-        body += chunk;
+        if (!tooLarge) chunks.push(chunk);
       }
       if (tooLarge) {
         res.writeHead(413, { "Content-Type": "application/json" });
@@ -1285,7 +1296,7 @@ var WrongStackACPServer = class {
       }
       let msg;
       try {
-        msg = JSON.parse(body);
+        msg = JSON.parse(Buffer.concat(chunks).toString("utf8"));
       } catch {
         res.writeHead(400);
         res.end(JSON.stringify({ error: { code: -32700, message: "Parse error" } }));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wrongstack/acp",
-  "version": "1.0.26",
+  "version": "1.0.28",
   "license": "MIT",
   "description": "ACP (Agent Client Protocol) integration for WrongStack — client + agent support",
   "keywords": [
@@ -52,8 +52,8 @@
   ],
   "dependencies": {
     "@agentclientprotocol/sdk": "^1.4.0",
-    "@wrongstack/core": "1.0.26",
-    "@wrongstack/primitives": "1.0.26"
+    "@wrongstack/core": "1.0.28",
+    "@wrongstack/primitives": "1.0.28"
   },
   "devDependencies": {
     "@types/node": "^26.5.1",