@workos/oagen 0.19.0 → 0.19.2

package/dist/cli/index.mjs

@@ -6930,16 +6930,17 @@ function apiSurfaceToSnapshot(surface) {
 /** Convert a legacy ApiParam to a CompatParameter. */
 function apiParamToCompatParam(param, position, language) {
 	const policy = getDefaultPolicy(language);
+	const passing = param.passingStyle ?? inferPassingStyle(language);
 	return {
 		publicName: param.name,
 		position,
 		required: !param.optional,
 		nullable: false,
 		hasDefault: param.optional,
-		passing: param.passingStyle ?? inferPassingStyle(language),
+		passing,
 		type: { name: param.type },
 		sensitivity: {
-			order: policy.constructorOrderMatters,
+			order: passing === "positional",
 			publicName: policy.methodParameterNamesArePublicApi,
 			requiredness: true,
 			type: true
@@ -7273,10 +7274,9 @@ function classifyParameterChanges(baseline, candidate, policy, specRef) {
 			policy,
 			specRef
 		}));
-		if (baseParam.position !== candParam.position) if (isConstructor ? policy.constructorOrderMatters : baseParam.sensitivity.order) {
-			const category = isConstructor ? "constructor_position_changed_order_sensitive" : "parameter_position_changed_order_sensitive";
-			changes.push(makeChange({
-				category,
+		if (baseParam.position !== candParam.position) {
+			if (isConstructor) if (policy.constructorOrderMatters) changes.push(makeChange({
+				category: "constructor_position_changed_order_sensitive",
 				symbol: baseline.fqName,
 				old: {
 					parameter: baseParam.publicName,
@@ -7290,21 +7290,52 @@ function classifyParameterChanges(baseline, candidate, policy, specRef) {
 				policy,
 				specRef
 			}));
-		} else changes.push(makeChange({
-			category: "constructor_reordered_named_friendly",
-			symbol: baseline.fqName,
-			old: {
-				parameter: baseParam.publicName,
-				position: String(baseParam.position)
-			},
-			new: {
-				parameter: candParam.publicName,
-				position: String(candParam.position)
-			},
-			message: `Parameter "${baseParam.publicName}" reordered on "${baseline.displayName}" (named-friendly language)`,
-			policy,
-			specRef
-		}));
+			else changes.push(makeChange({
+				category: "constructor_reordered_named_friendly",
+				symbol: baseline.fqName,
+				old: {
+					parameter: baseParam.publicName,
+					position: String(baseParam.position)
+				},
+				new: {
+					parameter: candParam.publicName,
+					position: String(candParam.position)
+				},
+				message: `Parameter "${baseParam.publicName}" reordered on "${baseline.displayName}" (named-friendly language)`,
+				policy,
+				specRef
+			}));
+			else if (baseParam.passing === "positional") changes.push(makeChange({
+				category: "parameter_position_changed_order_sensitive",
+				symbol: baseline.fqName,
+				old: {
+					parameter: baseParam.publicName,
+					position: String(baseParam.position)
+				},
+				new: {
+					parameter: candParam.publicName,
+					position: String(candParam.position)
+				},
+				message: `Parameter "${baseParam.publicName}" moved from position ${baseParam.position} to ${candParam.position} on "${baseline.displayName}"`,
+				policy,
+				specRef
+			}));
+			else if (baseParam.passing === "named") changes.push(makeChange({
+				category: "constructor_reordered_named_friendly",
+				symbol: baseline.fqName,
+				old: {
+					parameter: baseParam.publicName,
+					position: String(baseParam.position)
+				},
+				new: {
+					parameter: candParam.publicName,
+					position: String(candParam.position)
+				},
+				message: `Parameter "${baseParam.publicName}" reordered on "${baseline.displayName}" (named-friendly language)`,
+				policy,
+				specRef
+			}));
+		}
 	}
 	for (const candParam of candParams) if (!baseByName.has(candParam.publicName)) {
 		if (changes.some((c) => c.category === "parameter_renamed" && c.new.parameter === candParam.publicName)) continue;