@workday/canvas-kit-docs 5.3.2 → 5.3.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -10,6 +10,7 @@ any questions about the update.
10
10
  - [Canvas Kit Preview](#canvas-kit-preview)
11
11
  - [Type Deprecations and Hierarchy Updates](#type-deprecations-and-hierarchy-updates)
12
12
  - [Canvas Kit CSS Maintenance Mode](#canvas-kit-css-maintenance-mode)
13
+ - [Prop Interfaces](#prop-interfaces)
13
14
  - [Component Changes](#component-changes)
14
15
  - [Component Promotions](#component-promotions)
15
16
  - [Core](#core)
@@ -423,6 +424,59 @@ provide more focused support and to dedicate our efforts to making bigger and be
423
424
  our most used components: Canvas Kit React. If you have questions or concerns, please
424
425
  [let us know](https://github.com/Workday/canvas-kit/issues/new?labels=&template=question.md).
425
426
 
427
+ ### Prop Interfaces
428
+
429
+ Many components were updated to be polymorphic using the `createComponent` utility function. Most
430
+ components in Canvas Kit extend from an HTML interface and spread extra props onto the HTML element.
431
+ Since these components are now polymorphic, the exported props no longer extend from an HTML
432
+ interface since the HTML interface is now determined by an optional `as` prop. It is common to wrap
433
+ Canvas Kit components with your own component and extend from the Canvas Kit component's prop
434
+ interface. To support this use-case in addition to polymorphic prop interfaces, `ExtractProp` was
435
+ introduced. `ExtractProp` understands these polymorphic components and will return the base props in
436
+ addition to the HTML interface. There is an optional second argument that can override the default
437
+ HTML interface if your wrapper component uses the `as`.
438
+
439
+ ```tsx
440
+ // v4
441
+ import {TextInput, TextInputProps} from '@workday/canvas-kit-react-text-input';
442
+
443
+ const FancyTextInput: React.FC<TextInputProps> = props => <TextInput {...props} />;
444
+
445
+ // v5
446
+ import {TextInput} from '@workday/canvas-kit-react/text-input';
447
+ import {ExtractProps} from '@workday/canvas-kit-react/common';
448
+
449
+ const FancyTextInput: React.FC<ExtractProps<typeof TextInput>> = props => {};
450
+
451
+ // v5 via createComponent
452
+ import {TextInput} from '@workday/canvas-kit-react/text-input';
453
+ import {createComponent} from '@workday/canvas-kit-react/common';
454
+
455
+ const FancyTextInput = createComponent(TextInput)({
456
+ displayName: 'FancyTextInput',
457
+ Component((props) => <TextInput {...props} />)
458
+ })
459
+ ```
460
+
461
+ Components that made this change:
462
+
463
+ - Button
464
+ - IconButton
465
+ - Card
466
+ - Hyperlink
467
+ - Select
468
+ - TextArea
469
+ - TextInput
470
+ - Checkbox
471
+ - Radio
472
+ - ColorInput
473
+ - ColorPreview
474
+ - Modal
475
+ - Popup
476
+ - Skeleton
477
+ - Tabs
478
+ - Toast
479
+
426
480
  ## Component Changes
427
481
 
428
482
  ### Component Promotions
@@ -799,20 +853,25 @@ Button prop interface and accesses properties like `onClick`, you'll need to pro
799
853
  attribute yourself in order to avoid TypeScript issues (this doesn't affect runtime). This is not
800
854
  code-moddable since intent cannot be pre-determined.
801
855
 
856
+ #### Props
857
+
858
+ The exported props no longer extend from the `HTMLButtonElement` interface. Use
859
+ [ExtractProps](#prop-interfaces) instead.
860
+
802
861
  ```tsx
803
862
  interface MyButtonProps extends ButtonProps {}
804
863
 
805
864
  // onClick no longer exists in `ButtonProps`, so TypeScript will complain about onClick not
806
865
  // existing in `MyButtonProps` (`onClick` does exist as a prop on `<Button>`, however)
807
866
  const MyButton = ({children, onClick}: MyButtonProps) => (
808
- <Button onClick={onClick}>{children}</Button>
867
+ <SecondaryButton onClick={onClick}>{children}</SecondaryButton>
809
868
  );
810
869
 
811
870
  // After
812
- interface MyButtonProps extends ButtonProps, React.ButtonHTMLAttributes<HTMLButtonElement> {}
871
+ interface MyButtonProps extends ExtractProps<typeof SecondaryButton> {}
813
872
 
814
873
  // After (alternate fix)
815
- interface MyButtonProps extends ButtonProps {
874
+ interface MyButtonProps extends ExtractProps<> {
816
875
  onClick?: React.MouseEventHandler<HTMLButtonElement>;
817
876
  }
818
877
  ```
@@ -881,6 +940,21 @@ const props = {
881
940
  import {Card} from './Card' // where `Card` is a re-exported Canvas Kit `Card`
882
941
  ```
883
942
 
943
+ #### Props
944
+
945
+ The exported props no longer extend from the `HTMLDivElement` interface. Use
946
+ [ExtractProps](#prop-interfaces) instead.
947
+
948
+ ```tsx
949
+ // NOT handled by the codemod
950
+
951
+ // v4
952
+ interface MyCard extends CardProps {}
953
+
954
+ // v5
955
+ interface MyCard extends ExtractProps<typeof Card>
956
+ ```
957
+
884
958
  ---
885
959
 
886
960
  ### Inputs
@@ -924,14 +998,14 @@ element that `inputRef` was applied to previously. Select and Select (Preview) d
924
998
  `inputRef` in v4, but now support `ref` in v5. See each component's documentation for information on
925
999
  which element `ref` is forwarded to for that particular component.
926
1000
 
1001
+ #### Props
1002
+
927
1003
  Input component prop interfaces no longer extend directly from their underlying element interface
928
1004
  (e.g. `TextInputProps` no longer extends from `React.InputHTMLAttributes<HTMLInputElement>`).
929
1005
  `createComponent` returns a component that determines the element interface via the `as` prop. This
930
1006
  is why input component props no longer contain an element interface directly. If you extend from an
931
1007
  input component prop interface, or have code that uses an input component prop interface and
932
- accesses properties like `onClick`, you'll need to provide the input attribute yourself in order to
933
- avoid TypeScript issues (this doesn't affect runtime). This is not code-moddable since intent cannot
934
- be pre-determined.
1008
+ accesses properties like `onClick`, you'll need to use [ExtractProps](#prop-interfaces) instead.
935
1009
 
936
1010
  ```tsx
937
1011
  interface MyTextInputProps extends TextInputProps {}
@@ -941,7 +1015,7 @@ interface MyTextInputProps extends TextInputProps {}
941
1015
  const MyTextInput = ({onClick}: MyTextInputProps) => <TextInput onClick={onClick} />;
942
1016
 
943
1017
  // Fix
944
- interface MyTextInputProps extends TextInputProps, React.InputHTMLAttributes<HTMLInputElement> {}
1018
+ interface MyTextInputProps extends ExtractProps<typeof TextInput> {}
945
1019
 
946
1020
  // Alternate fix
947
1021
  interface MyTextInputProps extends TextInputProps {
@@ -1,6 +1,7 @@
1
1
  import {LoadingAnimation} from '@workday/canvas-kit-react/loading-animation';
2
2
 
3
3
  import Basic from './examples/Basic';
4
+ import RTL from './examples/RTL';
4
5
 
5
6
 
6
7
  # Canvas Kit Loading Animation
@@ -22,6 +23,10 @@ yarn add @workday/canvas-kit-react
22
23
 
23
24
  <ExampleCodeBlock code={Basic} />
24
25
 
26
+ ### Right-to-Left (RTL)
27
+
28
+ <ExampleCodeBlock code={RTL} />
29
+
25
30
  ## Props
26
31
 
27
32
  Loading Animation does not have any documented props. Undocumented props are spread to its outermost
@@ -0,0 +1,16 @@
1
+ import React from 'react';
2
+ import {LoadingAnimation} from '@workday/canvas-kit-react/loading-animation';
3
+ import {CanvasProvider, ContentDirection} from '@workday/canvas-kit-react/common';
4
+
5
+ export default () => {
6
+ const theme = {
7
+ canvas: {
8
+ direction: ContentDirection.RTL,
9
+ },
10
+ };
11
+ return (
12
+ <CanvasProvider theme={theme}>
13
+ <LoadingAnimation />
14
+ </CanvasProvider>
15
+ );
16
+ };
@@ -3,6 +3,7 @@ import {Specifications} from '@workday/canvas-kit-docs';
3
3
 
4
4
  import Default from './examples/Default';
5
5
  import CustomContent from './examples/CustomContent';
6
+ import DelayedTooltip from './examples/DelayedTooltip';
6
7
  import DescribeType from './examples/DescribeType';
7
8
  import Muted from './examples/Muted';
8
9
  import Placements from './examples/Placements';
@@ -87,6 +88,13 @@ a dialog instead.
87
88
 
88
89
  <ExampleCodeBlock code={CustomContent} />
89
90
 
91
+ ### Delayed Tooltip
92
+
93
+ The default delay for showing and hiding a tooltip are 300ms and 100ms, respectively. You can
94
+ control the length of the delay by providing custom `showDelay` and `hideDelay` in ms.
95
+
96
+ <ExampleCodeBlock code={DelayedTooltip} />
97
+
90
98
  ### Placements
91
99
 
92
100
  The tooltip allows for a `placement` configuration. The tooltip uses
@@ -0,0 +1,16 @@
1
+ import React from 'react';
2
+
3
+ import {SecondaryButton} from '@workday/canvas-kit-react/button';
4
+ import {Tooltip} from '@workday/canvas-kit-react/tooltip';
5
+
6
+ export default () => {
7
+ return (
8
+ <React.Fragment>
9
+ <Tooltip type="describe" title="Tooltip Text" showDelay={2000} hideDelay={1000}>
10
+ <SecondaryButton>
11
+ Tooltip appears after 2 seconds and disappears after 1 second
12
+ </SecondaryButton>
13
+ </Tooltip>
14
+ </React.Fragment>
15
+ );
16
+ };
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@workday/canvas-kit-docs",
3
- "version": "5.3.2",
3
+ "version": "5.3.6",
4
4
  "description": "Documentation components of Canvas Kit components",
5
5
  "author": "Workday, Inc. (https://www.workday.com)",
6
6
  "license": "Apache-2.0",
@@ -35,7 +35,8 @@
35
35
  "build:specs": "node ./utils/build-specifications.js",
36
36
  "build:downlevel-dts": "yarn run downlevel-dts dist ts3.5/dist",
37
37
  "build": "npm-run-all --parallel build:cjs build:es6 build:mdx --sequential build:specs build:downlevel-dts",
38
- "depcheck": "node ../../utils/check-dependencies-exist.js"
38
+ "depcheck": "node ../../utils/check-dependencies-exist.js",
39
+ "typecheck:src": "tsc -p . --noEmit --incremental false"
39
40
  },
40
41
  "publishConfig": {
41
42
  "access": "public"
@@ -49,7 +50,7 @@
49
50
  ],
50
51
  "dependencies": {
51
52
  "@storybook/csf": "0.0.1",
52
- "@workday/canvas-kit-react": "^5.3.2"
53
+ "@workday/canvas-kit-react": "^5.3.6"
53
54
  },
54
55
  "devDependencies": {
55
56
  "fs-extra": "^10.0.0",
@@ -57,5 +58,5 @@
57
58
  "mkdirp": "^1.0.3",
58
59
  "typescript": "^3.8.3"
59
60
  },
60
- "gitHead": "b6506c1b24e744ab5e132a16d6f4187be6dc6e2a"
61
+ "gitHead": "067d8895ad8f2e70f7e8f658dc728addc74ddf87"
61
62
  }