@workbench-kit/shell-react 0.0.2-prototype.0.2.6 → 0.0.2-prototype.0.2.8

package/src/{use-extension-management.ts → extensions/use-extension-management.ts}

@@ -1,193 +1,241 @@
-import { useCallback, useEffect, useMemo, useState } from 'react';
-import {
-  DEFAULT_INSTALLED_EXTENSIONS_STORAGE_KEY,
-  applyExtensionInstallPlanToRecords,
-  loadInstalledExtensions,
-  parseExtensionCatalog,
-  saveInstalledExtensions,
-  toggleInstalledExtensionEnabled,
-  type ExtensionCatalogEntry,
-  type InstalledExtensionRecord,
-} from '@workbench-kit/workbench-core';
-import type {
-  ExtensionCatalogBrowseEntry,
-  ExtensionManagementEntry,
-  ExtensionManagementPendingAction,
-} from '@workbench-kit/react/workbench/management';
-
-import {
-  createCatalogEntryInstallPlan,
-  createExtensionCatalogBrowseEntries,
-  createExtensionInstallPlanningContext,
-  createExtensionManagementEntries,
-} from './extension-management-model.js';
-import { useWorkbench, type WorkbenchStorageAdapter } from './provider.js';
-
-export interface UseExtensionManagementModelOptions {
-  catalogUrl?: string | undefined;
-  installedExtensionsStorage?: WorkbenchStorageAdapter | undefined;
-  installedExtensionsStorageKey?: string | undefined;
-}
-
-export function useExtensionManagementModel({
-  catalogUrl = '/extension-catalog.json',
-  installedExtensionsStorage,
-  installedExtensionsStorageKey,
-}: UseExtensionManagementModelOptions = {}) {
-  const workbench = useWorkbench();
-  const { extensionRegistry } = workbench;
-  const resolvedInstalledExtensionsStorage =
-    installedExtensionsStorage ?? workbench.installedExtensionsStorage;
-  const resolvedInstalledExtensionsStorageKey =
-    installedExtensionsStorageKey ??
-    workbench.installedExtensionsStorageKey ??
-    DEFAULT_INSTALLED_EXTENSIONS_STORAGE_KEY;
-  const [catalogEntries, setCatalogEntries] = useState<readonly ExtensionCatalogEntry[]>([]);
-  const [catalogLoading, setCatalogLoading] = useState(Boolean(catalogUrl));
-  const [catalogError, setCatalogError] = useState<string | undefined>();
-  const [pendingAction, setPendingAction] = useState<
-    ExtensionManagementPendingAction | undefined
-  >();
-  const [installedRecords, setInstalledRecords] = useState<readonly InstalledExtensionRecord[]>(
-    () =>
-      loadInstalledExtensions(
-        resolvedInstalledExtensionsStorageKey,
-        resolvedInstalledExtensionsStorage,
-      ),
-  );
-
-  useEffect(() => {
-    setInstalledRecords(
-      loadInstalledExtensions(
-        resolvedInstalledExtensionsStorageKey,
-        resolvedInstalledExtensionsStorage,
-      ),
-    );
-  }, [resolvedInstalledExtensionsStorage, resolvedInstalledExtensionsStorageKey]);
-
-  useEffect(() => {
-    if (!catalogUrl) {
-      setCatalogEntries([]);
-      setCatalogLoading(false);
-      setCatalogError(undefined);
-      return;
-    }
-
-    let cancelled = false;
-    setCatalogLoading(true);
-    setCatalogError(undefined);
-
-    void fetch(catalogUrl)
-      .then(async (response) => {
-        if (!response.ok) {
-          throw new Error(`Catalog request failed with status ${response.status}.`);
-        }
-
-        const catalog = parseExtensionCatalog(await response.json());
-        if (!cancelled) {
-          setCatalogEntries(catalog.entries);
-        }
-      })
-      .catch((error: unknown) => {
-        if (!cancelled) {
-          setCatalogEntries([]);
-          setCatalogError(
-            error instanceof Error ? error.message : 'Failed to load extension catalog.',
-          );
-        }
-      })
-      .finally(() => {
-        if (!cancelled) {
-          setCatalogLoading(false);
-        }
-      });
-
-    return () => {
-      cancelled = true;
-    };
-  }, [catalogUrl]);
-
-  const installedEntries = useMemo<readonly ExtensionManagementEntry[]>(() => {
-    return createExtensionManagementEntries({ extensionRegistry, installedRecords });
-  }, [extensionRegistry, installedRecords]);
-
-  const browseEntries = useMemo<readonly ExtensionCatalogBrowseEntry[]>(() => {
-    return createExtensionCatalogBrowseEntries({
-      catalogEntries,
-      extensionRegistry,
-      installedRecords,
-    });
-  }, [catalogEntries, extensionRegistry, installedRecords]);
-
-  const installCatalogEntry = useCallback(
-    (entry: ExtensionCatalogBrowseEntry) => {
-      const installContext = createExtensionInstallPlanningContext({
-        catalogEntries,
-        extensionRegistry,
-        installedRecords,
-      });
-      const plan = createCatalogEntryInstallPlan(entry, installContext);
-      if (!plan || plan.blocked) {
-        return;
-      }
-
-      const next = applyExtensionInstallPlanToRecords({
-        currentRecords: installedRecords,
-        installSources: installContext.installSources,
-        plan,
-      });
-      saveInstalledExtensions(
-        next,
-        resolvedInstalledExtensionsStorageKey,
-        resolvedInstalledExtensionsStorage,
-      );
-      setInstalledRecords(next);
-      setPendingAction({ entryId: entry.id, kind: 'install' });
-      if (typeof window !== 'undefined') {
-        window.requestAnimationFrame(() => {
-          window.location.reload();
-        });
-      }
-    },
-    [
-      catalogEntries,
-      extensionRegistry,
-      installedRecords,
-      resolvedInstalledExtensionsStorage,
-      resolvedInstalledExtensionsStorageKey,
-    ],
-  );
-
-  const toggleInstalledEntry = useCallback(
-    (entry: ExtensionManagementEntry, enabled: boolean) => {
-      if (entry.source === 'bundled' && entry.id.startsWith('workbench-kit.builtin.')) {
-        return;
-      }
-
-      const next = toggleInstalledExtensionEnabled(
-        entry.id,
-        enabled,
-        resolvedInstalledExtensionsStorageKey,
-        resolvedInstalledExtensionsStorage,
-      );
-      setInstalledRecords(next);
-      setPendingAction({ entryId: entry.id, kind: 'toggle' });
-      if (typeof window !== 'undefined') {
-        window.requestAnimationFrame(() => {
-          window.location.reload();
-        });
-      }
-    },
-    [resolvedInstalledExtensionsStorage, resolvedInstalledExtensionsStorageKey],
-  );
-
-  return {
-    browseEntries,
-    catalogError,
-    catalogLoading,
-    installCatalogEntry,
-    installedEntries,
-    pendingAction,
-    toggleInstalledEntry,
-  };
-}
+import { useCallback, useEffect, useMemo, useState } from 'react';
+import {
+  DEFAULT_EXTENSION_CATALOG_TRUST_POLICY,
+  DEFAULT_EXTENSION_INSTALL_TRUST_STORAGE_KEY,
+  DEFAULT_INSTALLED_EXTENSIONS_STORAGE_KEY,
+  ExtensionInstallApprovalRequiredError,
+  applyExtensionInstallPlanToRecords,
+  assertExtensionCatalogUrlAllowed,
+  loadExtensionInstallTrustRecords,
+  loadInstalledExtensions,
+  parseExtensionCatalog,
+  recordExtensionInstallTrust,
+  saveExtensionInstallTrustRecords,
+  saveInstalledExtensions,
+  toggleInstalledExtensionEnabled,
+  type ExtensionCatalogEntry,
+  type ExtensionCatalogTrustPolicy,
+  type ExtensionInstallTrustRecord,
+  type InstalledExtensionRecord,
+} from '@workbench-kit/workbench-core';
+import type {
+  ExtensionCatalogBrowseEntry,
+  ExtensionInstallOptions,
+  ExtensionManagementEntry,
+  ExtensionManagementPendingAction,
+} from '@workbench-kit/react/workbench/management';
+
+import {
+  createCatalogEntryInstallPlan,
+  createExtensionCatalogBrowseEntries,
+  createExtensionInstallPlanningContext,
+  createExtensionManagementEntries,
+} from './management-model.js';
+import { useWorkbench, type WorkbenchStorageAdapter } from '../shell/provider.js';
+
+export interface UseExtensionManagementModelOptions {
+  catalogTrustPolicy?: ExtensionCatalogTrustPolicy | undefined;
+  catalogUrl?: string | undefined;
+  installedExtensionsStorage?: WorkbenchStorageAdapter | undefined;
+  installedExtensionsStorageKey?: string | undefined;
+  installTrustStorage?: WorkbenchStorageAdapter | undefined;
+  installTrustStorageKey?: string | undefined;
+}
+
+export function useExtensionManagementModel({
+  catalogTrustPolicy = DEFAULT_EXTENSION_CATALOG_TRUST_POLICY,
+  catalogUrl = '/extension-catalog.json',
+  installedExtensionsStorage,
+  installedExtensionsStorageKey,
+  installTrustStorage,
+  installTrustStorageKey = DEFAULT_EXTENSION_INSTALL_TRUST_STORAGE_KEY,
+}: UseExtensionManagementModelOptions = {}) {
+  const workbench = useWorkbench();
+  const { extensionRegistry } = workbench;
+  const resolvedInstalledExtensionsStorage =
+    installedExtensionsStorage ?? workbench.installedExtensionsStorage;
+  const resolvedInstalledExtensionsStorageKey =
+    installedExtensionsStorageKey ??
+    workbench.installedExtensionsStorageKey ??
+    DEFAULT_INSTALLED_EXTENSIONS_STORAGE_KEY;
+  const resolvedInstallTrustStorage = installTrustStorage ?? resolvedInstalledExtensionsStorage;
+  const [catalogEntries, setCatalogEntries] = useState<readonly ExtensionCatalogEntry[]>([]);
+  const [catalogLoading, setCatalogLoading] = useState(Boolean(catalogUrl));
+  const [catalogError, setCatalogError] = useState<string | undefined>();
+  const [pendingAction, setPendingAction] = useState<
+    ExtensionManagementPendingAction | undefined
+  >();
+  const [installedRecords, setInstalledRecords] = useState<readonly InstalledExtensionRecord[]>(
+    () =>
+      loadInstalledExtensions(
+        resolvedInstalledExtensionsStorageKey,
+        resolvedInstalledExtensionsStorage,
+      ),
+  );
+  const [installTrustRecords, setInstallTrustRecords] = useState<
+    readonly ExtensionInstallTrustRecord[]
+  >(() => loadExtensionInstallTrustRecords(installTrustStorageKey, resolvedInstallTrustStorage));
+
+  useEffect(() => {
+    setInstalledRecords(
+      loadInstalledExtensions(
+        resolvedInstalledExtensionsStorageKey,
+        resolvedInstalledExtensionsStorage,
+      ),
+    );
+  }, [resolvedInstalledExtensionsStorage, resolvedInstalledExtensionsStorageKey]);
+
+  useEffect(() => {
+    setInstallTrustRecords(
+      loadExtensionInstallTrustRecords(installTrustStorageKey, resolvedInstallTrustStorage),
+    );
+  }, [installTrustStorageKey, resolvedInstallTrustStorage]);
+
+  useEffect(() => {
+    if (!catalogUrl) {
+      setCatalogEntries([]);
+      setCatalogLoading(false);
+      setCatalogError(undefined);
+      return;
+    }
+
+    let cancelled = false;
+    setCatalogLoading(true);
+    setCatalogError(undefined);
+
+    void Promise.resolve()
+      .then(() => {
+        assertExtensionCatalogUrlAllowed(catalogUrl, catalogTrustPolicy);
+        return fetch(catalogUrl);
+      })
+      .then(async (response) => {
+        if (!response.ok) {
+          throw new Error(`Catalog request failed with status ${response.status}.`);
+        }
+
+        const catalog = parseExtensionCatalog(await response.json());
+        if (!cancelled) {
+          setCatalogEntries(catalog.entries);
+        }
+      })
+      .catch((error: unknown) => {
+        if (!cancelled) {
+          setCatalogEntries([]);
+          setCatalogError(
+            error instanceof Error ? error.message : 'Failed to load extension catalog.',
+          );
+        }
+      })
+      .finally(() => {
+        if (!cancelled) {
+          setCatalogLoading(false);
+        }
+      });
+
+    return () => {
+      cancelled = true;
+    };
+  }, [catalogTrustPolicy, catalogUrl]);
+
+  const installedEntries = useMemo<readonly ExtensionManagementEntry[]>(() => {
+    return createExtensionManagementEntries({ extensionRegistry, installedRecords });
+  }, [extensionRegistry, installedRecords]);
+
+  const browseEntries = useMemo<readonly ExtensionCatalogBrowseEntry[]>(() => {
+    return createExtensionCatalogBrowseEntries({
+      catalogEntries,
+      extensionRegistry,
+      installedRecords,
+    });
+  }, [catalogEntries, extensionRegistry, installedRecords]);
+
+  const installCatalogEntry = useCallback(
+    (entry: ExtensionCatalogBrowseEntry, options?: ExtensionInstallOptions) => {
+      const installContext = createExtensionInstallPlanningContext({
+        catalogEntries,
+        extensionRegistry,
+        installedRecords,
+      });
+      const plan = createCatalogEntryInstallPlan(entry, installContext);
+      if (!plan || plan.blocked) {
+        return;
+      }
+
+      // Align with core hard gate: unapproved privileged installs must not persist.
+      if (plan.requiresApproval && options?.approved !== true) {
+        throw new ExtensionInstallApprovalRequiredError();
+      }
+
+      const next = applyExtensionInstallPlanToRecords({
+        approved: options?.approved === true,
+        currentRecords: installedRecords,
+        installSources: installContext.installSources,
+        plan,
+      });
+      saveInstalledExtensions(
+        next,
+        resolvedInstalledExtensionsStorageKey,
+        resolvedInstalledExtensionsStorage,
+      );
+      setInstalledRecords(next);
+      setPendingAction({ entryId: entry.id, kind: 'install' });
+      if (typeof window !== 'undefined') {
+        window.requestAnimationFrame(() => {
+          window.location.reload();
+        });
+      }
+    },
+    [
+      catalogEntries,
+      extensionRegistry,
+      installedRecords,
+      resolvedInstalledExtensionsStorage,
+      resolvedInstalledExtensionsStorageKey,
+    ],
+  );
+
+  const toggleInstalledEntry = useCallback(
+    (entry: ExtensionManagementEntry, enabled: boolean) => {
+      if (entry.source === 'bundled' && entry.id.startsWith('workbench-kit.builtin.')) {
+        return;
+      }
+
+      const next = toggleInstalledExtensionEnabled(
+        entry.id,
+        enabled,
+        resolvedInstalledExtensionsStorageKey,
+        resolvedInstalledExtensionsStorage,
+      );
+      setInstalledRecords(next);
+      setPendingAction({ entryId: entry.id, kind: 'toggle' });
+      if (typeof window !== 'undefined') {
+        window.requestAnimationFrame(() => {
+          window.location.reload();
+        });
+      }
+    },
+    [resolvedInstalledExtensionsStorage, resolvedInstalledExtensionsStorageKey],
+  );
+
+  const rememberInstallTrust = useCallback(
+    (entry: ExtensionCatalogBrowseEntry) => {
+      const permissions = entry.installPlan?.permissions ?? [];
+      const next = recordExtensionInstallTrust(entry.id, permissions, installTrustRecords);
+      saveExtensionInstallTrustRecords(next, installTrustStorageKey, resolvedInstallTrustStorage);
+      setInstallTrustRecords(next);
+    },
+    [installTrustRecords, installTrustStorageKey, resolvedInstallTrustStorage],
+  );
+
+  return {
+    browseEntries,
+    catalogError,
+    catalogLoading,
+    installCatalogEntry,
+    installedEntries,
+    installTrustRecords,
+    pendingAction,
+    rememberInstallTrust,
+    toggleInstalledEntry,
+  };
+}

package/src/{extensions-view-data.ts → extensions/view-data.ts}

@@ -1,19 +1,19 @@
-export const BUILTIN_EXTENSIONS_VIEW_RENDER_KIND = 'workbench-kit.builtin.extensions.view' as const;
-export const BUILTIN_EXTENSIONS_VIEW_CONTAINER_ID = 'extensions' as const;
-export const BUILTIN_EXTENSIONS_FOCUS_COMMAND_ID =
-  'workbench-kit.builtin.extensions.focus' as const;
-
-export interface BuiltinExtensionsViewRenderData {
-  readonly kind: typeof BUILTIN_EXTENSIONS_VIEW_RENDER_KIND;
-}
-
-export function isBuiltinExtensionsViewRenderData(
-  value: unknown,
-): value is BuiltinExtensionsViewRenderData {
-  return (
-    typeof value === 'object' &&
-    value !== null &&
-    'kind' in value &&
-    (value as BuiltinExtensionsViewRenderData).kind === BUILTIN_EXTENSIONS_VIEW_RENDER_KIND
-  );
-}
+export const BUILTIN_EXTENSIONS_VIEW_RENDER_KIND = 'workbench-kit.builtin.extensions.view' as const;
+export const BUILTIN_EXTENSIONS_VIEW_CONTAINER_ID = 'extensions' as const;
+export const BUILTIN_EXTENSIONS_FOCUS_COMMAND_ID =
+  'workbench-kit.builtin.extensions.focus' as const;
+
+export interface BuiltinExtensionsViewRenderData {
+  readonly kind: typeof BUILTIN_EXTENSIONS_VIEW_RENDER_KIND;
+}
+
+export function isBuiltinExtensionsViewRenderData(
+  value: unknown,
+): value is BuiltinExtensionsViewRenderData {
+  return (
+    typeof value === 'object' &&
+    value !== null &&
+    'kind' in value &&
+    (value as BuiltinExtensionsViewRenderData).kind === BUILTIN_EXTENSIONS_VIEW_RENDER_KIND
+  );
+}

package/src/{extensions-view.tsx → extensions/view.tsx}

@@ -1,38 +1,63 @@
-import { ExtensionManagementSidebar } from '@workbench-kit/react/workbench/management';
-
-import {
-  BUILTIN_EXTENSIONS_VIEW_RENDER_KIND,
-  isBuiltinExtensionsViewRenderData,
-  type BuiltinExtensionsViewRenderData,
-} from './extensions-view-data.js';
-import { useExtensionManagementModel } from './use-extension-management.js';
-import { useWorkbench } from './provider.js';
-
-export type { BuiltinExtensionsViewRenderData };
-export { BUILTIN_EXTENSIONS_VIEW_RENDER_KIND, isBuiltinExtensionsViewRenderData };
-
-export function BuiltinExtensionsView({ catalogUrl }: { catalogUrl?: string | undefined }) {
-  const { missingExtensionIds } = useWorkbench();
-  const {
-    browseEntries,
-    catalogError,
-    catalogLoading,
-    installCatalogEntry,
-    installedEntries,
-    pendingAction,
-    toggleInstalledEntry,
-  } = useExtensionManagementModel({ catalogUrl });
-
-  return (
-    <ExtensionManagementSidebar
-      browseEntries={browseEntries}
-      catalogError={catalogError}
-      catalogLoading={catalogLoading}
-      installedEntries={installedEntries}
-      missingExtensionIds={missingExtensionIds}
-      pendingAction={pendingAction}
-      onInstall={installCatalogEntry}
-      onToggleEnabled={toggleInstalledEntry}
-    />
-  );
-}
+import { useCallback } from 'react';
+import { ExtensionManagementSidebar } from '@workbench-kit/react/workbench/management';
+import {
+  isExtensionInstallTrusted,
+  type ExtensionCatalogTrustPolicy,
+} from '@workbench-kit/workbench-core';
+
+import {
+  BUILTIN_EXTENSIONS_VIEW_RENDER_KIND,
+  isBuiltinExtensionsViewRenderData,
+  type BuiltinExtensionsViewRenderData,
+} from './view-data.js';
+import { useExtensionManagementModel } from './use-extension-management.js';
+import { useWorkbench } from '../shell/provider.js';
+
+export type { BuiltinExtensionsViewRenderData };
+export { BUILTIN_EXTENSIONS_VIEW_RENDER_KIND, isBuiltinExtensionsViewRenderData };
+
+export function BuiltinExtensionsView({
+  catalogTrustPolicy,
+  catalogUrl,
+}: {
+  catalogTrustPolicy?: ExtensionCatalogTrustPolicy | undefined;
+  catalogUrl?: string | undefined;
+}) {
+  const { missingExtensionIds } = useWorkbench();
+  const {
+    browseEntries,
+    catalogError,
+    catalogLoading,
+    installCatalogEntry,
+    installedEntries,
+    installTrustRecords,
+    pendingAction,
+    rememberInstallTrust,
+    toggleInstalledEntry,
+  } = useExtensionManagementModel({ catalogTrustPolicy, catalogUrl });
+
+  const isInstallTrusted = useCallback(
+    (entry: (typeof browseEntries)[number]) =>
+      isExtensionInstallTrusted(
+        entry.id,
+        entry.installPlan?.permissions ?? [],
+        installTrustRecords,
+      ),
+    [installTrustRecords],
+  );
+
+  return (
+    <ExtensionManagementSidebar
+      browseEntries={browseEntries}
+      catalogError={catalogError}
+      catalogLoading={catalogLoading}
+      installedEntries={installedEntries}
+      isInstallTrusted={isInstallTrusted}
+      missingExtensionIds={missingExtensionIds}
+      pendingAction={pendingAction}
+      onInstall={installCatalogEntry}
+      onRememberInstallTrust={rememberInstallTrust}
+      onToggleEnabled={toggleInstalledEntry}
+    />
+  );
+}

package/src/{field-remap-demo.tsx → field-remap/demo.tsx}

@@ -1,18 +1,18 @@
-import type { JSX } from 'react';
-
-import { FieldRemapPanel } from './field-remap-panel.js';
-import { getFieldRemapSample, type FieldRemapSampleId } from './field-remap-samples.js';
-
-export interface SampleFieldRemapDemoProps {
-  readonly sampleId?: FieldRemapSampleId | string | undefined;
-}
-
-/**
- * Sample host wrapper around {@link FieldRemapPanel}.
- */
-export function SampleFieldRemapDemo({
-  sampleId = 'nested-ab',
-}: SampleFieldRemapDemoProps = {}): JSX.Element {
-  const sample = getFieldRemapSample(sampleId);
-  return <FieldRemapPanel key={sample.id} sample={sample} />;
-}
+import type { JSX } from 'react';
+
+import { FieldRemapPanel } from './panel.js';
+import { getFieldRemapSample, type FieldRemapSampleId } from './samples.js';
+
+export interface SampleFieldRemapDemoProps {
+  readonly sampleId?: FieldRemapSampleId | string | undefined;
+}
+
+/**
+ * Sample host wrapper around {@link FieldRemapPanel}.
+ */
+export function SampleFieldRemapDemo({
+  sampleId = 'nested-ab',
+}: SampleFieldRemapDemoProps = {}): JSX.Element {
+  const sample = getFieldRemapSample(sampleId);
+  return <FieldRemapPanel key={sample.id} sample={sample} />;
+}