@workbench-kit/shell-react 0.0.2-prototype.0.2.26 → 0.0.2-prototype.0.2.28

package/src/workbench/command-host.tsx

@@ -16,15 +16,18 @@ import {
   type WorkbenchCommandRunContext,
   type WorkbenchShellCommandContext,
 } from '@workbench-kit/react/workbench';
+import {
+  matchesWorkbenchCommandPaletteShortcut,
+  matchesWorkbenchQuickAccessShortcut,
+} from '@workbench-kit/react/workbench/command-ui';
 import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 
+import { useContextKeyRevision } from '../commands/use-context-key-revision.js';
 import { useWorkbench } from '../shell/provider.js';
 import { registerWorkbenchShellCommandHandlers } from './shell-command-registration.js';
 import {
   buildWorkbenchPaletteCommands,
   collectExtensionCommandFeaturesById,
-  matchesWorkbenchCommandPaletteShortcut,
-  matchesWorkbenchQuickAccessShortcut,
   resolveShellCommandActivities,
 } from './command-palette.js';
 import { resolveExtensionKeybindingCommand } from './keybinding-bridge.js';
@@ -98,6 +101,7 @@ export function WorkbenchCommandHost({
   quickOpenTitle = 'Quick Open',
 }: WorkbenchCommandHostProps) {
   const {
+    contextKeyService,
     executeCommand,
     extensionRegistry,
     keybindingOverrides,
@@ -110,6 +114,11 @@ export function WorkbenchCommandHost({
   const [quickOpenQuery, setQuickOpenQuery] = useState('');
   const [layout, setLayout] = useState(() => layoutService.getState());
   const shellContextRef = useRef<WorkbenchShellCommandContext | undefined>(undefined);
+  const contextKeyRevision = useContextKeyRevision(contextKeyService);
+  const contextKeySnapshot = useMemo(
+    () => contextKeyService.createSnapshot(),
+    [contextKeyRevision, contextKeyService],
+  );
 
   const workspaceService = isWorkspaceResourceService(workspaceHostPort?.service)
     ? workspaceHostPort.service
@@ -126,19 +135,41 @@ export function WorkbenchCommandHost({
     };
   }, [layoutService]);
 
-  const shellActivities = useMemo(
+  const managedShellActivities = useMemo(
     () => resolveShellCommandActivities(extensionRegistry),
     [extensionRegistry],
   );
+  const visibleShellActivities = useMemo(
+    () => resolveShellCommandActivities(extensionRegistry, contextKeySnapshot),
+    [contextKeySnapshot, extensionRegistry],
+  );
+  const visibleShellActivityIdSet = new Set(visibleShellActivities.map((activity) => activity.id));
+  const visibleShellActivitySignature = managedShellActivities
+    .map((activity) => (visibleShellActivityIdSet.has(activity.id) ? '1' : '0'))
+    .join('');
 
   const shellCommandDefinitions = useMemo(
     () =>
       createWorkbenchShellCommands({
-        activities: shellActivities,
+        activities: managedShellActivities.filter(
+          (_activity, index) => visibleShellActivitySignature[index] === '1',
+        ),
         includeSettings: true,
         includeSidebarToggle: true,
       }),
-    [shellActivities],
+    [managedShellActivities, visibleShellActivitySignature],
+  );
+
+  const managedShellCommandIds = useMemo(
+    () =>
+      new Set(
+        createWorkbenchShellCommands({
+          activities: managedShellActivities,
+          includeSettings: true,
+          includeSidebarToggle: true,
+        }).map((command) => command.id),
+      ),
+    [managedShellActivities],
   );
 
   const shellCommandRegistry = useMemo(
@@ -194,11 +225,19 @@ export function WorkbenchCommandHost({
       buildWorkbenchPaletteCommands({
         additionalCommands,
         extensionCommandFeaturesById: collectExtensionCommandFeaturesById(extensionRegistry),
-        extensionCommands: extensionRegistry.commands.getCommands(),
+        extensionCommands: extensionRegistry.commands
+          .getCommands()
+          .filter((command) => !managedShellCommandIds.has(command.id)),
         shellCommands: shellCommandDefinitions,
         shellContext,
       }),
-    [additionalCommands, extensionRegistry, shellContext, shellCommandDefinitions],
+    [
+      additionalCommands,
+      extensionRegistry,
+      managedShellCommandIds,
+      shellContext,
+      shellCommandDefinitions,
+    ],
   );
 
   const resolvedQuickOpenProviders = useMemo(() => {

package/src/workbench/command-palette.ts

@@ -4,10 +4,11 @@ import type {
   WorkbenchShellCommandActivity,
   WorkbenchShellCommandContext,
 } from '@workbench-kit/react/workbench';
-import type { ExtensionCommandFeatureSpec, ExtensionRegistry } from '@workbench-kit/workbench-core';
-
-export const WORKBENCH_COMMAND_PALETTE_SHORTCUT = 'Ctrl+Shift+P';
-export const WORKBENCH_QUICK_ACCESS_SHORTCUT = 'Ctrl+P';
+import {
+  filterActivitiesByWhenClause,
+  type ExtensionCommandFeatureSpec,
+  type ExtensionRegistry,
+} from '@workbench-kit/workbench-core';
 
 type ExtensionCommand = ReturnType<ExtensionRegistry['commands']['getCommands']>[number];
 
@@ -44,10 +45,16 @@ export function resolveExtensionCommandIcon(icon: ExtensionCommand['icon']): str
 
 export function resolveShellCommandActivities(
   extensionRegistry: ExtensionRegistry,
+  contextKeys?: object | undefined,
 ): WorkbenchShellCommandActivity[] {
   const activities = extensionRegistry.activities.getActivities();
   if (activities.length > 0) {
-    return activities
+    const visibleActivities =
+      contextKeys === undefined
+        ? activities
+        : filterActivitiesByWhenClause(activities, contextKeys);
+
+    return visibleActivities
       .map((activity) => ({
         icon: formatWorkbenchCommandIcon(activity.icon),
         id: activity.viewContainerId,
@@ -166,43 +173,3 @@ export function buildWorkbenchPaletteCommands({
     ...additionalCommands,
   ]);
 }
-
-export function matchesWorkbenchCommandPaletteShortcut(
-  event: Pick<KeyboardEvent, 'altKey' | 'ctrlKey' | 'key' | 'metaKey' | 'shiftKey'>,
-) {
-  const key = event.key.toLowerCase();
-
-  if (key !== 'p') {
-    return false;
-  }
-
-  if (!(event.ctrlKey || event.metaKey) || !event.shiftKey || event.altKey) {
-    return false;
-  }
-
-  return true;
-}
-
-export function matchesWorkbenchQuickAccessShortcut(
-  event: Pick<KeyboardEvent, 'altKey' | 'ctrlKey' | 'key' | 'metaKey' | 'shiftKey'>,
-) {
-  const key = event.key.toLowerCase();
-
-  if (key !== 'p') {
-    return false;
-  }
-
-  if (!(event.ctrlKey || event.metaKey) || event.shiftKey || event.altKey) {
-    return false;
-  }
-
-  return true;
-}
-
-export function getWorkbenchCommandPaletteShortcutLabel() {
-  return WORKBENCH_COMMAND_PALETTE_SHORTCUT;
-}
-
-export function getWorkbenchQuickAccessShortcutLabel() {
-  return WORKBENCH_QUICK_ACCESS_SHORTCUT;
-}

package/src/workbench/workspace-view-state.ts

@@ -1,10 +1,12 @@
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useMemo, useState } from 'react';
 import type {
   VirtualWorkspaceState,
   WorkspaceChangeEvent,
   WorkspaceResourceService,
 } from '@workbench-kit/workspace';
 
+const EMPTY_WORKSPACE_FILES: VirtualWorkspaceState['files'] = [];
+
 export function isWorkspaceResourceService(value: unknown): value is WorkspaceResourceService {
   return (
     typeof value === 'object' &&
@@ -33,3 +35,18 @@ export function useWorkspaceResourceState(
 
   return state;
 }
+
+export function useWorkspaceTextDocuments(workspaceService: WorkspaceResourceService | undefined) {
+  const workspaceState = useWorkspaceResourceState(workspaceService);
+  const files =
+    workspaceState?.files ?? workspaceService?.getState().files ?? EMPTY_WORKSPACE_FILES;
+  const documentsByPath = useMemo(
+    () => new Map(files.map((file) => [file.path.replace(/\\/g, '/'), file.content])),
+    [files],
+  );
+  const loadDocument = useCallback(
+    (documentPath: string) => documentsByPath.get(documentPath.replace(/\\/g, '/')) ?? null,
+    [documentsByPath],
+  );
+  return { files, loadDocument };
+}