@wordpress/eslint-plugin 9.3.0 → 10.0.1-next.f435e9e01b.0

package/CHANGELOG.md

@@ -2,6 +2,27 @@
 
 ## Unreleased
 
+## 10.0.0 (2022-01-27)
+
+### Breaking Changes
+
+-   The peer dependency constraint for ESLint has been updated from `^6 || ^7` to `^8`.
+-   The bundled `@typescript-eslint/eslint-plugin` dependency has been updated from requiring `^4.31.0` to requiring `^5.3.0` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The bundled `@typescript-eslint/parser` dependency has been updated from requiring `^4.31.0` to requiring `^5.3.0` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The bundled `eslint-config-prettier` dependency has been updated from requiring `^7.1.0` to requiring `^8.3.0` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The bundled `eslint-plugin-jest` dependency has been updated from requiring `^24.1.3` to requiring `^25.2.3` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The bundled `eslint-plugin-jsdoc` dependency has been updated from requiring `^36.0.8` to requiring `^37.0.3` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The bundled `globals` dependency has been updated from requiring `^12.0.0` to requiring `^13.12.0` ([#36283](https://github.com/WordPress/gutenberg/pull/36283)).
+-   The `gutenberg-phase` rule has been deprecated and replaced by the `is-gutenberg-plugin` rule. ([#38202](https://github.com/WordPress/gutenberg/pull/38202))
+
+### Enhancement
+
+-   Omit verification for WordPress dependencies in the import statements since they get externalized when used with WordPress ([#37639](https://github.com/WordPress/gutenberg/pull/37639)).
+
+### Bug Fix
+
+-   Fix Babel config resolution when a custom ESLint config present ([#37406](https://github.com/WordPress/gutenberg/pull/37406)). Warning: it won't recognize the `babel.config.json` file present in the project until the upstream bug in `cosmiconfig` is fixed.
+
 ## 9.3.0 (2021-11-15)
 
 ### Enhancements

package/LICENSE.md

@@ -1,6 +1,6 @@
 ## Gutenberg
 
-    Copyright 2016-2021 by the contributors
+    Copyright 2016-2022 by the contributors
 
 **License for Contributions (on and after April 15, 2021)**
 

package/README.md

@@ -56,23 +56,25 @@ The granular rulesets will not define any environment globals. As such, if they
 
 ### Rules
 
-| Rule                                                                                                                 | Description                                                                                    | Recommended |
-| -------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------- | ----------- |
-| [data-no-store-string-literals](/packages/eslint-plugin/docs/rules/data-no-store-string-literals.md)                 | Discourage passing string literals to reference data stores                                    |             |
-| [dependency-group](/packages/eslint-plugin/docs/rules/dependency-group.md)                                           | Enforce dependencies docblocks formatting                                                      | ✓           |
-| [gutenberg-phase](docs/rules/gutenberg-phase.md)                                                                     | Governs the use of the `process.env.GUTENBERG_PHASE` constant                                  | ✓           |
-| [no-base-control-with-label-without-id](/packages/eslint-plugin/docs/rules/no-base-control-with-label-without-id.md) | Disallow the usage of BaseControl component with a label prop set but omitting the id property | ✓           |
-| [no-unguarded-get-range-at](/packages/eslint-plugin/docs/rules/no-unguarded-get-range-at.md)                         | Disallow the usage of unguarded `getRangeAt` calls                                             | ✓           |
-| [no-unsafe-wp-apis](/packages/eslint-plugin/docs/rules/no-unsafe-wp-apis.md)                                         | Disallow the usage of unsafe APIs from `@wordpress/*` packages                                 | ✓           |
-| [no-unused-vars-before-return](/packages/eslint-plugin/docs/rules/no-unused-vars-before-return.md)                   | Disallow assigning variable values if unused before a return                                   | ✓           |
-| [react-no-unsafe-timeout](/packages/eslint-plugin/docs/rules/react-no-unsafe-timeout.md)                             | Disallow unsafe `setTimeout` in component                                                      |             |
-| [valid-sprintf](/packages/eslint-plugin/docs/rules/valid-sprintf.md)                                                 | Enforce valid sprintf usage                                                                    | ✓           |
-| [i18n-ellipsis](/packages/eslint-plugin/docs/rules/i18n-ellipsis.md)                                                 | Disallow using three dots in translatable strings                                              | ✓           |
-| [i18n-no-collapsible-whitespace](/packages/eslint-plugin/docs/rules/i18n-no-collapsible-whitespace.md)               | Disallow collapsible whitespace in translatable strings                                        | ✓           |
-| [i18n-no-placeholders-only](/packages/eslint-plugin/docs/rules/i18n-no-placeholders-only.md)                         | Prevent using only placeholders in translatable strings                                        | ✓           |
-| [i18n-no-variables](/packages/eslint-plugin/docs/rules/i18n-no-variables.md)                                         | Enforce string literals as translation function arguments                                      | ✓           |
-| [i18n-text-domain](/packages/eslint-plugin/docs/rules/i18n-text-domain.md)                                           | Enforce passing valid text domains                                                             | ✓           |
-| [i18n-translator-comments](/packages/eslint-plugin/docs/rules/i18n-translator-comments.md)                           | Enforce adding translator comments                                                             | ✓           |
+| Rule                                                                                                                                                                 | Description                                                                                    | Recommended |
+| -------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------- | ----------- |
+| [data-no-store-string-literals](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/data-no-store-string-literals.md)                 | Discourage passing string literals to reference data stores                                    |             |
+| [dependency-group](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/dependency-group.md)                                           | Enforce dependencies docblocks formatting                                                      | ✓           |
+| [is-gutenberg-plugin](docs/rules/is-gutenberg-plugin.md)                                                                                                             | Governs the use of the `process.env.IS_GUTENBERG_PLUGIN` constant                              | ✓           |
+| [no-base-control-with-label-without-id](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-base-control-with-label-without-id.md) | Disallow the usage of BaseControl component with a label prop set but omitting the id property | ✓           |
+| [no-unguarded-get-range-at](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unguarded-get-range-at.md)                         | Disallow the usage of unguarded `getRangeAt` calls                                             | ✓           |
+| [no-unsafe-wp-apis](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unsafe-wp-apis.md)                                         | Disallow the usage of unsafe APIs from `@wordpress/*` packages                                 | ✓           |
+| [no-unused-vars-before-return](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unused-vars-before-return.md)                   | Disallow assigning variable values if unused before a return                                   | ✓           |
+| [react-no-unsafe-timeout](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/react-no-unsafe-timeout.md)                             | Disallow unsafe `setTimeout` in component                                                      |             |
+| [valid-sprintf](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/valid-sprintf.md)                                                 | Enforce valid sprintf usage                                                                    | ✓           |
+| [i18n-ellipsis](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-ellipsis.md)                                                 | Disallow using three dots in translatable strings                                              | ✓           |
+| [i18n-no-collapsible-whitespace](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-no-collapsible-whitespace.md)               | Disallow collapsible whitespace in translatable strings                                        | ✓           |
+| [i18n-no-placeholders-only](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-no-placeholders-only.md)                         | Prevent using only placeholders in translatable strings                                        | ✓           |
+| [i18n-no-variables](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-no-variables.md)                                         | Enforce string literals as translation function arguments                                      | ✓           |
+| [i18n-text-domain](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-text-domain.md)                                           | Enforce passing valid text domains                                                             | ✓           |
+| [i18n-translator-comments](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-translator-comments.md)                           | Enforce adding translator comments                                                             | ✓           |
+| [i18n-no-flanking-whitespace](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-no-flanking-whitespace.md)                     | Disallow leading or trailing whitespace in translatable strings                                |             |
+| [i18n-hyphenated-range](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/i18n-hyphenated-range.md)                                 | Disallow hyphenated numerical ranges in translatable strings                                   |             |
 
 ### Legacy
 
@@ -84,4 +86,10 @@ If you are using WordPress' `.jshintrc` JSHint configuration and you would like
 }
 ```
 
-<br/><br/><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p>
+## Contributing to this package
+
+This is an individual package that's part of the Gutenberg project. The project is organized as a monorepo. It's made up of multiple self-contained software packages, each with a specific purpose. The packages in this monorepo are published to [npm](https://www.npmjs.com/) and used by [WordPress](https://make.wordpress.org/core/) as well as other software projects.
+
+To find out more about contributing to this package or Gutenberg as a whole, please read the project's main [contributor guide](https://github.com/WordPress/gutenberg/tree/HEAD/CONTRIBUTING.md).
+
+<br /><br /><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p>

package/configs/custom.js

@@ -13,6 +13,8 @@ module.exports = {
 			files: [ '*.native.js' ],
 			rules: {
 				'@wordpress/no-base-control-with-label-without-id': 'off',
+				'@wordpress/i18n-no-flanking-whitespace': 'error',
+				'@wordpress/i18n-hyphenated-range': 'error',
 			},
 		},
 		{
@@ -27,9 +29,4 @@ module.exports = {
 			},
 		},
 	],
-	settings: {
-		react: {
-			version: '16.6',
-		},
-	},
 };

package/configs/esnext.js

@@ -1,11 +1,17 @@
-module.exports = {
+/**
+ * External dependencies
+ */
+const { cosmiconfigSync } = require( 'cosmiconfig' );
+
+const config = {
+	parser: '@babel/eslint-parser',
+	parserOptions: {
+		sourceType: 'module',
+	},
 	env: {
 		es6: true,
 	},
 	extends: [ require.resolve( './es5.js' ) ],
-	parserOptions: {
-		sourceType: 'module',
-	},
 	rules: {
 		// Disable ES5-specific (extended from ES5)
 		'vars-on-top': 'off',
@@ -45,3 +51,18 @@ module.exports = {
 		'template-curly-spacing': [ 'error', 'always' ],
 	},
 };
+
+// It won't recognize the `babel.config.json` file used in the project until the upstream bug in `cosmiconfig` is fixed:
+// https://github.com/davidtheclark/cosmiconfig/issues/246.
+const result = cosmiconfigSync( 'babel' ).search();
+if ( ! result || ! result.filepath ) {
+	config.parserOptions = {
+		...config.parserOptions,
+		requireConfigFile: false,
+		babelOptions: {
+			presets: [ require.resolve( '@wordpress/babel-preset-default' ) ],
+		},
+	};
+}
+
+module.exports = config;

package/configs/react.js

@@ -6,7 +6,9 @@ module.exports = {
 		},
 	},
 	settings: {
-		'import/extensions': [ '.js', '.jsx' ],
+		react: {
+			version: 'detect',
+		},
 	},
 	plugins: [ '@wordpress', 'react', 'react-hooks' ],
 	rules: {

package/configs/recommended-with-formatting.js

@@ -3,8 +3,10 @@
  */
 const { isPackageInstalled } = require( '../utils' );
 
+// Exclude bundled WordPress packages from the list.
+const wpPackagesRegExp = '^@wordpress/(?!(icons|interface))';
+
 const config = {
-	parser: '@babel/eslint-parser',
 	extends: [
 		require.resolve( './jsx-a11y.js' ),
 		require.resolve( './custom.js' ),
@@ -21,6 +23,10 @@ const config = {
 		document: true,
 		wp: 'readonly',
 	},
+	settings: {
+		'import/internal-regex': wpPackagesRegExp,
+		'import/extensions': [ '.js', '.jsx' ],
+	},
 	rules: {
 		'import/no-extraneous-dependencies': [
 			'error',
@@ -28,7 +34,12 @@ const config = {
 				peerDependencies: true,
 			},
 		],
-		'import/no-unresolved': 'error',
+		'import/no-unresolved': [
+			'error',
+			{
+				ignore: [ wpPackagesRegExp ],
+			},
+		],
 		'import/default': 'warn',
 		'import/named': 'warn',
 	},

package/configs/recommended.js

@@ -21,7 +21,6 @@ const config = {
 	extends: [
 		require.resolve( './recommended-with-formatting.js' ),
 		'plugin:prettier/recommended',
-		'prettier/react',
 	],
 	rules: {
 		'prettier/prettier': [ 'error', prettierConfig ],
@@ -35,7 +34,6 @@ if ( isPackageInstalled( 'typescript' ) ) {
 				extensions: [ '.js', '.jsx', '.ts', '.tsx' ],
 			},
 		},
-		'import/core-modules': [ 'react' ],
 	};
 	config.extends.push( 'plugin:@typescript-eslint/eslint-recommended' );
 	config.ignorePatterns = [ '**/*.d.ts' ];

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/eslint-plugin",
-	"version": "9.3.0",
+	"version": "10.0.1-next.f435e9e01b.0",
 	"description": "ESLint plugin for WordPress development.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -32,25 +32,27 @@
 	"main": "index.js",
 	"dependencies": {
 		"@babel/eslint-parser": "^7.16.0",
-		"@typescript-eslint/eslint-plugin": "^4.31.0",
-		"@typescript-eslint/parser": "^4.31.0",
-		"@wordpress/prettier-config": "^1.1.1",
+		"@typescript-eslint/eslint-plugin": "^5.3.0",
+		"@typescript-eslint/parser": "^5.3.0",
+		"@wordpress/babel-preset-default": "^6.5.1-next.f435e9e01b.0",
+		"@wordpress/prettier-config": "^1.1.2-next.f435e9e01b.0",
 		"cosmiconfig": "^7.0.0",
-		"eslint-config-prettier": "^7.1.0",
+		"eslint-config-prettier": "^8.3.0",
 		"eslint-plugin-import": "^2.25.2",
-		"eslint-plugin-jest": "^24.1.3",
-		"eslint-plugin-jsdoc": "^36.0.8",
-		"eslint-plugin-jsx-a11y": "^6.4.1",
+		"eslint-plugin-jest": "^25.2.3",
+		"eslint-plugin-jsdoc": "^37.0.3",
+		"eslint-plugin-jsx-a11y": "^6.5.1",
 		"eslint-plugin-prettier": "^3.3.0",
-		"eslint-plugin-react": "^7.22.0",
-		"eslint-plugin-react-hooks": "^4.2.0",
-		"globals": "^12.0.0",
+		"eslint-plugin-react": "^7.27.0",
+		"eslint-plugin-react-hooks": "^4.3.0",
+		"globals": "^13.12.0",
 		"prettier": "npm:wp-prettier@2.2.1-beta-1",
 		"requireindex": "^1.2.0"
 	},
 	"peerDependencies": {
-		"eslint": "^6 || ^7",
-		"typescript": "^4"
+		"@babel/core": ">=7",
+		"eslint": ">=8",
+		"typescript": ">=4"
 	},
 	"peerDependenciesMeta": {
 		"typescript": {
@@ -60,5 +62,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "9a1dd3474d937468e4cf9caf9886ad61ef0a8f50"
+	"gitHead": "14b2846015dfb1b440ce93accdd03842ebe5f1cd"
 }

package/rules/__tests__/i18n-hyphenated-range.js

@@ -0,0 +1,63 @@
+/**
+ * External dependencies
+ */
+import { RuleTester } from 'eslint';
+
+/**
+ * Internal dependencies
+ */
+import rule from '../i18n-hyphenated-range';
+
+const ruleTester = new RuleTester( {
+	parserOptions: {
+		ecmaVersion: 6,
+	},
+} );
+
+ruleTester.run( 'i18n-hyphenated-range', rule, {
+	valid: [
+		{
+			code: `__( 'Hyphenated-words are ok' )`,
+		},
+		{
+			code: `__( 'Hyphen - when used in this case - is ok' )`,
+		},
+		{
+			code: `__('en dash – and em dash — are ok')`,
+		},
+		{
+			code: `__( 'en dash – ranges work 1–99 or 2 – 98' )`,
+		},
+		{
+			code: `__( 'Negative numbers like -99 or -33 are ok' )`,
+		},
+		{
+			code: `__( 'Numbers with trailing hyphens are odd but ok like 99-' )`,
+		},
+		{
+			code: `__( '1 0 -1' )`,
+		},
+	],
+	invalid: [
+		{
+			code: `__( 'guess a number 1 - 10' )`,
+			output: `__( 'guess a number 1 – 10' )`,
+			errors: [ { messageId: 'foundHyphen' } ],
+		},
+		{
+			code: `__( 'No spaces: 00-99' )`,
+			output: `__( 'No spaces: 00–99' )`,
+			errors: [ { messageId: 'foundHyphen' } ],
+		},
+		{
+			code: `__( 'From 0   -   2 many spaces in the range' )`,
+			output: `__( 'From 0   –   2 many spaces in the range' )`,
+			errors: [ { messageId: 'foundHyphen' } ],
+		},
+		{
+			code: `__( '1-2' + ' fixing multiple strings' )`,
+			output: `__( '1–2' + ' fixing multiple strings' )`,
+			errors: [ { messageId: 'foundHyphen' } ],
+		},
+	],
+} );

package/rules/__tests__/i18n-no-flanking-whitespace.js

@@ -0,0 +1,77 @@
+/**
+ * External dependencies
+ */
+import { RuleTester } from 'eslint';
+
+/**
+ * Internal dependencies
+ */
+import rule from '../i18n-no-flanking-whitespace';
+
+const ruleTester = new RuleTester( {
+	parserOptions: {
+		ecmaVersion: 6,
+	},
+} );
+
+ruleTester.run( 'i18n-no-flanking-whitespace', rule, {
+	valid: [
+		{
+			code: `__( 'Hello World…' )`,
+		},
+		{
+			code:
+				'__( `A long string ` +\n `spread over ` +\n  `multiple lines.` );',
+		},
+		{
+			code: `__( 'Not concerned about   \t whitespace rules')`,
+		},
+	],
+	invalid: [
+		{
+			code: '__( "Double quoted string with a trailing newline\\n" );',
+			output: `__( 'Double quoted string with a trailing newline' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: `__( ' Leading whitespace.' );`,
+			output: `__( 'Leading whitespace.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: `__( 'Trailing whitespace. ' );`,
+			output: `__( 'Trailing whitespace.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: `__( ' Flanking whitespace. ' );`,
+			output: `__( 'Flanking whitespace.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: '__( "\tLeading tab." );',
+			output: `__( 'Leading tab.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: '__( "\u0009Leading unicode tab." );',
+			output: `__( 'Leading unicode tab.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: `__( "Trailing tab.\t" );`,
+			output: `__( 'Trailing tab.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+		{
+			code: `__( "\tFlanking tab.\t" );`,
+			output: `__( 'Flanking tab.' );`,
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+
+		{
+			code: '__( ` Template literals ` )',
+			errors: [ { messageId: 'noFlankingWhitespace' } ],
+		},
+	],
+} );

package/rules/__tests__/is-gutenberg-plugin.js

@@ -0,0 +1,65 @@
+/**
+ * External dependencies
+ */
+import { RuleTester } from 'eslint';
+
+/**
+ * Internal dependencies
+ */
+import rule from '../is-gutenberg-plugin';
+
+const ruleTester = new RuleTester( {
+	parserOptions: {
+		ecmaVersion: 6,
+	},
+} );
+
+const ERROR_MESSAGE =
+	'The `process.env.IS_GUTENBERG_PLUGIN` constant should only be used as the condition in an if statement or ternary expression.';
+
+ruleTester.run( 'is-gutenberg-plugin', rule, {
+	valid: [
+		{ code: `if ( process.env.IS_GUTENBERG_PLUGIN ) {}` },
+		{ code: `if ( ! process.env.IS_GUTENBERG_PLUGIN ) {}` },
+		{
+			// Ensure whitespace is ok.
+			code: `if (
+				process.env.
+				IS_GUTENBERG_PLUGIN
+			) {}`,
+		},
+		{ code: `const test = process.env.IS_GUTENBERG_PLUGIN ? foo : bar` },
+		{ code: `const test = ! process.env.IS_GUTENBERG_PLUGIN ? bar : foo` },
+		{
+			// Ensure whitespace is ok.
+			code: `const test = ! process.env.
+				IS_GUTENBERG_PLUGIN ? bar : foo`,
+		},
+	],
+	invalid: [
+		{
+			code: `if ( IS_GUTENBERG_PLUGIN ) {}`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+		{
+			code: `if ( window[ 'IS_GUTENBERG_PLUGIN' ] ) {}`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+		{
+			code: `if ( true ) { process.env.IS_GUTENBERG_PLUGIN === 2 }`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+		{
+			code: `if ( process.env.IS_GUTENBERG_PLUGIN === 2 ) {}`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+		{
+			code: `if ( true || process.env.IS_GUTENBERG_PLUGIN === 2 ) {}`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+		{
+			code: `const isFeatureActive = process.env.IS_GUTENBERG_PLUGIN;`,
+			errors: [ { message: ERROR_MESSAGE } ],
+		},
+	],
+} );

package/rules/data-no-store-string-literals.js

@@ -198,6 +198,7 @@ function getFixes( fixer, context, callNode ) {
 module.exports = {
 	meta: {
 		type: 'problem',
+		hasSuggestions: true,
 		schema: [],
 		messages: {
 			doNotUseStringLiteral: `Do not use string literals ( '{{ argument }}' ) for accessing @wordpress/data stores. Pass the store definition instead`,

package/rules/gutenberg-phase.js

@@ -144,6 +144,8 @@ module.exports = {
 	meta: {
 		type: 'problem',
 		schema: [],
+		deprecated: true,
+		replacedBy: '@wordpress/is-gutenberg-plugin',
 	},
 	create( context ) {
 		return {

package/rules/i18n-hyphenated-range.js

@@ -0,0 +1,101 @@
+/**
+ * Internal dependencies
+ */
+const {
+	TRANSLATION_FUNCTIONS,
+	getTextContentFromNode,
+	getTranslateFunctionName,
+	getTranslateFunctionArgs,
+} = require( '../utils' );
+
+const EN_DASH = '–';
+const HYPHEN_IN_RANGE = /(\d\s+-\s+\d)|(\d-\d)/g;
+
+function replaceHyphenWithEnDash( string ) {
+	if ( string.match( HYPHEN_IN_RANGE ) ) {
+		return string.replace( '-', EN_DASH );
+	}
+	return string;
+}
+
+function makeFixerFunction( arg ) {
+	return ( fixer ) => {
+		switch ( arg.type ) {
+			case 'TemplateLiteral':
+				return arg.quasis.reduce( ( fixes, quasi ) => {
+					if (
+						'TemplateElement' === quasi.type &&
+						quasi.value.raw.match( HYPHEN_IN_RANGE )
+					) {
+						fixes.push(
+							fixer.replaceTextRange(
+								[ quasi.start, quasi.end ],
+								replaceHyphenWithEnDash( quasi.value.raw )
+							)
+						);
+					}
+					return fixes;
+				}, [] );
+
+			case 'Literal':
+				return [
+					fixer.replaceText(
+						arg,
+						replaceHyphenWithEnDash( arg.raw )
+					),
+				];
+
+			case 'BinaryExpression':
+				return [
+					...makeFixerFunction( arg.left )( fixer ),
+					...makeFixerFunction( arg.right )( fixer ),
+				];
+		}
+	};
+}
+
+module.exports = {
+	meta: {
+		type: 'problem',
+		schema: [],
+		messages: {
+			foundHyphen:
+				'Use dashes (en or em) in place of hyphens for numeric ranges.',
+		},
+		fixable: 'code',
+	},
+	create( context ) {
+		return {
+			CallExpression( node ) {
+				const { callee, arguments: args } = node;
+
+				const functionName = getTranslateFunctionName( callee );
+
+				if ( ! TRANSLATION_FUNCTIONS.has( functionName ) ) {
+					return;
+				}
+
+				const candidates = getTranslateFunctionArgs(
+					functionName,
+					args
+				);
+
+				for ( const arg of candidates ) {
+					const argumentString = getTextContentFromNode( arg );
+					if (
+						! argumentString ||
+						! argumentString.match( HYPHEN_IN_RANGE )
+					) {
+						continue;
+					}
+
+					context.report( {
+						node,
+						messageId: 'foundHyphen',
+						fix: makeFixerFunction( arg ),
+					} );
+				}
+			},
+		};
+	},
+};

package/rules/i18n-no-flanking-whitespace.js

@@ -0,0 +1,91 @@
+/**
+ * Internal dependencies
+ */
+const {
+	TRANSLATION_FUNCTIONS,
+	getTextContentFromNode,
+	getTranslateFunctionName,
+	getTranslateFunctionArgs,
+} = require( '../utils' );
+
+const PROBLEMS_BY_CHAR_CODE = {
+	9: '\\t',
+	10: '\\n',
+	13: '\\r',
+	32: 'whitespace',
+};
+
+function makeFixerFunction( arg ) {
+	return ( fixer ) => {
+		switch ( arg.type ) {
+			case 'Literal':
+				return [ fixer.replaceText( arg, `'${ arg.value.trim() }'` ) ];
+
+			case 'BinaryExpression':
+				return [
+					...makeFixerFunction( arg.left )( fixer ),
+					...makeFixerFunction( arg.right )( fixer ),
+				];
+		}
+	};
+}
+
+module.exports = {
+	meta: {
+		type: 'problem',
+		schema: [],
+		messages: {
+			noFlankingWhitespace:
+				'Translations should not contain flanking whitespace{{problem}}',
+		},
+		fixable: 'code',
+	},
+	create( context ) {
+		return {
+			CallExpression( node ) {
+				const { callee, arguments: args } = node;
+
+				const functionName = getTranslateFunctionName( callee );
+
+				if ( ! TRANSLATION_FUNCTIONS.has( functionName ) ) {
+					return;
+				}
+
+				const candidates = getTranslateFunctionArgs(
+					functionName,
+					args
+				);
+
+				for ( const arg of candidates ) {
+					const argumentString = getTextContentFromNode( arg );
+					if ( ! argumentString ) {
+						continue;
+					}
+
+					const trimmableWhitespace = argumentString.match(
+						/^\s|\s$/
+					);
+
+					if ( ! trimmableWhitespace ) {
+						continue;
+					}
+
+					const problem =
+						PROBLEMS_BY_CHAR_CODE[
+							trimmableWhitespace[ 0 ].charCodeAt( 0 )
+						];
+					const problemString = problem ? ` (${ problem })` : '';
+
+					context.report( {
+						node,
+						messageId: 'noFlankingWhitespace',
+						data: {
+							problem: problemString,
+						},
+						fix: makeFixerFunction( arg ),
+					} );
+				}
+			},
+		};
+	},
+};

package/rules/is-gutenberg-plugin.js

@@ -0,0 +1,94 @@
+/**
+ * Traverse up through the chain of parent AST nodes returning the first parent
+ * the predicate returns a truthy value for.
+ *
+ * @param {Object}   sourceNode The AST node to search from.
+ * @param {Function} predicate  A predicate invoked for each parent.
+ *
+ * @return {?Object } The first encountered parent node where the predicate
+ *                    returns a truthy value.
+ */
+function findParent( sourceNode, predicate ) {
+	if ( ! sourceNode.parent ) {
+		return;
+	}
+
+	if ( predicate( sourceNode.parent ) ) {
+		return sourceNode.parent;
+	}
+
+	return findParent( sourceNode.parent, predicate );
+}
+
+/**
+ * Tests whether the IS_GUTENBERG_PLUGIN variable is used as the condition for an
+ * if statement or ternary, triggering a violation if not.
+ *
+ * @example
+ * ```js
+ * // good
+ * if ( process.env.IS_GUTENBERG_PLUGIN ) {
+ *
+ * // bad
+ * const isFeatureActive = process.env.IS_GUTENBERG_PLUGIN;
+ * ```
+ *
+ * @param {Object} node    The IS_GUTENBERG_PLUGIN identifier node.
+ * @param {Object} context The eslint context object.
+ */
+function isUsedInConditional( node, context ) {
+	const conditionalParent = findParent( node, ( candidate ) =>
+		[ 'IfStatement', 'ConditionalExpression' ].includes( candidate.type )
+	);
+
+	if ( ! conditionalParent ) {
+		return false;
+	}
+
+	// Allow for whitespace as prettier sometimes breaks this on separate lines.
+	const textRegex = /^\s*!?\s*process\s*\.\s*env\s*\.\s*IS_GUTENBERG_PLUGIN$/;
+	const testSource = context.getSource( conditionalParent.test );
+
+	if ( ! textRegex.test( testSource ) ) {
+		return false;
+	}
+
+	return true;
+}
+
+const ERROR_MESSAGE =
+	'The `process.env.IS_GUTENBERG_PLUGIN` constant should only be used as the condition in an if statement or ternary expression.';
+
+module.exports = {
+	meta: {
+		type: 'problem',
+		schema: [],
+	},
+	create( context ) {
+		return {
+			Identifier( node ) {
+				// Bypass any identifiers with a node name different to `IS_GUTENBERG_PLUGIN`.
+				if ( node.name !== 'IS_GUTENBERG_PLUGIN' ) {
+					return;
+				}
+
+				if ( ! isUsedInConditional( node, context ) ) {
+					context.report( node, ERROR_MESSAGE );
+				}
+			},
+			// Check for literals, e.g. when 'IS_GUTENBERG_PLUGIN' is used as a string via something like 'window[ 'IS_GUTENBERG_PLUGIN' ]'.
+			Literal( node ) {
+				// Bypass any identifiers with a node value different to `IS_GUTENBERG_PLUGIN`.
+				if ( node.value !== 'IS_GUTENBERG_PLUGIN' ) {
+					return;
+				}
+
+				if ( node.parent && node.parent.type === 'MemberExpression' ) {
+					if ( ! isUsedInConditional( node, context ) ) {
+						context.report( node, ERROR_MESSAGE );
+					}
+				}
+			},
+		};
+	},
+};

package/rules/__tests__/gutenberg-phase.js

@@ -1,63 +0,0 @@
-/**
- * External dependencies
- */
-import { RuleTester } from 'eslint';
-
-/**
- * Internal dependencies
- */
-import rule from '../gutenberg-phase';
-
-const ruleTester = new RuleTester( {
-	parserOptions: {
-		ecmaVersion: 6,
-	},
-} );
-
-const ACCESS_ERROR =
-	'The `GUTENBERG_PHASE` constant should be accessed using `process.env.GUTENBERG_PHASE`.';
-const EQUALITY_ERROR =
-	'The `GUTENBERG_PHASE` constant should only be used in a strict equality comparison with a primitive number.';
-const IF_ERROR =
-	'The `GUTENBERG_PHASE` constant should only be used as part of the condition in an if statement or ternary expression.';
-
-ruleTester.run( 'gutenberg-phase', rule, {
-	valid: [
-		{ code: `if ( process.env.GUTENBERG_PHASE === 2 ) {}` },
-		{ code: `if ( process.env.GUTENBERG_PHASE !== 2 ) {}` },
-		{ code: `if ( 2 === process.env.GUTENBERG_PHASE ) {}` },
-		{ code: `if ( 2 !== process.env.GUTENBERG_PHASE ) {}` },
-		{ code: `const test = process.env.GUTENBERG_PHASE === 2 ? foo : bar` },
-		{ code: `const test = process.env.GUTENBERG_PHASE !== 2 ? foo : bar` },
-	],
-	invalid: [
-		{
-			code: `if ( GUTENBERG_PHASE === 1 ) {}`,
-			errors: [ { message: ACCESS_ERROR } ],
-		},
-		{
-			code: `if ( window[ 'GUTENBERG_PHASE' ] === 1 ) {}`,
-			errors: [ { message: ACCESS_ERROR } ],
-		},
-		{
-			code: `if ( process.env.GUTENBERG_PHASE > 1 ) {}`,
-			errors: [ { message: EQUALITY_ERROR } ],
-		},
-		{
-			code: `if ( process.env.GUTENBERG_PHASE === '2' ) {}`,
-			errors: [ { message: EQUALITY_ERROR } ],
-		},
-		{
-			code: `if ( true ) { process.env.GUTENBERG_PHASE === 2 }`,
-			errors: [ { message: IF_ERROR } ],
-		},
-		{
-			code: `if ( true || process.env.GUTENBERG_PHASE === 2 ) {}`,
-			errors: [ { message: IF_ERROR } ],
-		},
-		{
-			code: `const isFeatureActive = process.env.GUTENBERG_PHASE === 2;`,
-			errors: [ { message: IF_ERROR } ],
-		},
-	],
-} );