@wordpress/eslint-plugin 25.1.0 → 25.2.1-next.v.202605131006.0

package/README.md

@@ -127,8 +127,9 @@ The granular rulesets will not define any environment globals. As such, if they
 | [no-dom-globals-in-react-fc](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-dom-globals-in-react-fc.md)                       | Disallow use of DOM globals in the render cycle of a React function component.                  |             |
 | [components-no-missing-40px-size-prop](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/components-no-missing-40px-size-prop.md)   | Disallow missing `__next40pxDefaultSize` prop on `@wordpress/components` components.            | ✓           |
 | [components-no-unsafe-button-disabled](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/components-no-unsafe-button-disabled.md)   | Disallow using `disabled` on Button without `accessibleWhenDisabled`.                           | ✓           |
-| [no-unsafe-render-order](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unsafe-render-order.md)                                 | Prevent unsafe `render` composition orders that silently remove semantics.                       | ✓           |
+| [no-unsafe-render-order](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unsafe-render-order.md)                               | Prevent unsafe `render` composition orders that silently remove semantics.                      | ✓           |
 | [no-i18n-in-save](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-i18n-in-save.md)                                             | Disallow translation functions in block save methods.                                           |             |
+| [no-non-module-stylesheet-imports](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-non-module-stylesheet-imports.md)           | Disallow importing non-module stylesheets from JavaScript files.                                |             |
 | [no-unmerged-classname](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unmerged-classname.md)                                 | Disallow unmerged `className` in components that spread rest props.                             |             |
 | [no-unguarded-get-range-at](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unguarded-get-range-at.md)                         | Disallow the usage of unguarded `getRangeAt` calls.                                             | ✓           |
 | [no-unsafe-wp-apis](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin/docs/rules/no-unsafe-wp-apis.md)                                         | Disallow the usage of unsafe APIs from `@wordpress/*` packages                                  | ✓           |
@@ -146,6 +147,7 @@ If you are upgrading from a previous version that used `.eslintrc.*` files:
 
 1. Replace your `.eslintrc.*` file with an `eslint.config.mjs` file.
 2. Change `extends` arrays to import + spread:
+
     ```js
     // Old (.eslintrc.js)
     module.exports = {
@@ -156,14 +158,17 @@ If you are upgrading from a previous version that used `.eslintrc.*` files:
     import wordpress from '@wordpress/eslint-plugin';
     export default [ ...wordpress.configs.recommended ];
     ```
+
 3. Convert `overrides` to separate config objects with `files` patterns.
 4. Replace `env` with `languageOptions.globals` using the [`globals`](https://www.npmjs.com/package/globals) package.
 5. Delete your `.eslintignore` file and move patterns into an `ignores` config object.
 6. Update rule prefixes in inline comments: `eslint-comments/*` has been renamed to `@eslint-community/eslint-comments/*`. For example:
+
     ```diff
     - /* eslint-disable eslint-comments/no-unlimited-disable */
     + /* eslint-disable @eslint-community/eslint-comments/no-unlimited-disable */
     ```
+
 7. Remove any `/* eslint-env */` comments — they are no longer supported in ESLint v10. Use `languageOptions.globals` in your config instead.
 
 For a comprehensive walkthrough with examples and troubleshooting, see the [Gutenberg ESLint v10 migration guide](https://github.com/WordPress/gutenberg/blob/HEAD/docs/how-to-guides/eslint-v10-migration.md). See also the [ESLint migration guide](https://eslint.org/docs/latest/use/configure/migration-guide) for general flat config details.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/eslint-plugin",
-	"version": "25.1.0",
+	"version": "25.2.1-next.v.202605131006.0+2a3d07cab",
 	"description": "ESLint plugin for WordPress development.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -44,9 +44,9 @@
 		"@babel/eslint-parser": "^7.28.6",
 		"@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
 		"@eslint/compat": "^2.0.0",
-		"@wordpress/babel-preset-default": "^8.45.0",
-		"@wordpress/prettier-config": "^4.45.0",
-		"@wordpress/theme": "^0.12.0",
+		"@wordpress/babel-preset-default": "^8.45.1-next.v.202605131006.0+2a3d07cab",
+		"@wordpress/prettier-config": "^4.45.1-next.v.202605131006.0+2a3d07cab",
+		"@wordpress/theme": "^0.13.1-next.v.202605131006.0+2a3d07cab",
 		"cosmiconfig": "^7.0.0",
 		"eslint-config-prettier": "^10.0.0",
 		"eslint-import-resolver-typescript": "^4.4.4",
@@ -57,7 +57,7 @@
 		"eslint-plugin-playwright": "^2.1.0",
 		"eslint-plugin-prettier": "^5.0.0",
 		"eslint-plugin-react": "^7.37.0",
-		"eslint-plugin-react-hooks": "^5.0.0",
+		"eslint-plugin-react-hooks": "7.1.1",
 		"globals": "^16.0.0",
 		"requireindex": "^1.2.0",
 		"typescript-eslint": "^8.0.0"
@@ -83,5 +83,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "8c229eaed0e88c9827e2da3d73a78f9ddd77714b"
+	"gitHead": "8804fa29bc78a1d98e5a4d40c3e180ddd907016c"
 }

package/rules/__tests__/no-non-module-stylesheet-imports.js

@@ -0,0 +1,39 @@
+import { RuleTester } from 'eslint';
+import rule from '../no-non-module-stylesheet-imports';
+
+const ruleTester = new RuleTester( {
+	languageOptions: {
+		sourceType: 'module',
+		ecmaVersion: 6,
+	},
+} );
+
+ruleTester.run( 'no-non-module-stylesheet-imports', rule, {
+	valid: [
+		{ code: "import './component';" },
+		{ code: "import styles from './style.module.css';" },
+		{ code: "import styles from './style.module.scss';" },
+		{ code: "import styles from './style.module.sass';" },
+		{ code: "import theme from './style.module.css?inline';" },
+		{ code: "import './style.module.css';" },
+		{ code: "import './style.module.scss?inline';" },
+	],
+	invalid: [
+		{
+			code: "import './style.css';",
+			errors: [ { messageId: 'noNonModuleStylesheet' } ],
+		},
+		{
+			code: "import './style.scss';",
+			errors: [ { messageId: 'noNonModuleStylesheet' } ],
+		},
+		{
+			code: "import './style.sass';",
+			errors: [ { messageId: 'noNonModuleStylesheet' } ],
+		},
+		{
+			code: "import styles from './style.scss';",
+			errors: [ { messageId: 'noNonModuleStylesheet' } ],
+		},
+	],
+} );

package/rules/no-non-module-stylesheet-imports.js

@@ -0,0 +1,50 @@
+const STYLESHEET_EXTENSIONS = /\.(?:css|scss|sass)$/i;
+const MODULE_STYLESHEET_EXTENSIONS = /\.module\.(?:css|scss|sass)$/i;
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+	meta: {
+		type: 'problem',
+		docs: {
+			description:
+				'Disallow importing non-module stylesheets from JavaScript files.',
+			url: 'https://github.com/WordPress/gutenberg/blob/HEAD/packages/eslint-plugin/docs/rules/no-non-module-stylesheet-imports.md',
+		},
+		schema: [],
+		messages: {
+			noNonModuleStylesheet:
+				'Import non-module stylesheets through the package stylesheet entry point instead of JavaScript. If you want to import from JavaScript, use a CSS module.',
+		},
+	},
+	create( context ) {
+		return {
+			ImportDeclaration( node ) {
+				if ( typeof node.source.value !== 'string' ) {
+					return;
+				}
+
+				const importPath = stripQueryAndHash( node.source.value );
+				if ( ! STYLESHEET_EXTENSIONS.test( importPath ) ) {
+					return;
+				}
+
+				if ( MODULE_STYLESHEET_EXTENSIONS.test( importPath ) ) {
+					return;
+				}
+
+				context.report( {
+					node,
+					messageId: 'noNonModuleStylesheet',
+				} );
+			},
+		};
+	},
+};
+
+/**
+ * @param {string} importPath Import source path.
+ * @return {string} Import source path without query or hash suffixes.
+ */
+function stripQueryAndHash( importPath ) {
+	return importPath.replace( /[?#].*$/, '' );
+}