@wordpress/eslint-plugin 12.9.0 → 13.0.0

package/CHANGELOG.md

@@ -2,11 +2,18 @@
 
 ## Unreleased
 
+## 13.0.0 (2022-08-24)
+
+### Breaking Change
+
+-   Increase the minimum Node.js version to 14 and minimum npm version to 6.14.4 ([#43141](https://github.com/WordPress/gutenberg/pull/43141)).
+-   Remove all rules targeting test files from the `recommended` and `recommended-with-formatting` presets when Jest package is installed ([#43272](https://github.com/WordPress/gutenberg/pull/43272)).
+
 ## 12.8.0 (2022-07-27)
 
 ### Code Quality
 
--   Remove deprecated rules `no-negated-in-lhs` replaced with `no-unsafe-negation`, and `jsx-a11y/label-has-for` replaced with `jsx-a11/label-has-associated-control` ([#42654](https://github.com/WordPress/gutenberg/pull/42654)). 
+-   Remove deprecated rules `no-negated-in-lhs` replaced with `no-unsafe-negation`, and `jsx-a11y/label-has-for` replaced with `jsx-a11/label-has-associated-control` ([#42654](https://github.com/WordPress/gutenberg/pull/42654)).
 
 ## 12.6.0 (2022-06-29)
 

package/README.md

@@ -10,7 +10,7 @@ Install the module
 npm install @wordpress/eslint-plugin --save-dev
 ```
 
-**Note**: This package requires `node` 12.0.0 or later, and `npm` 6.9.0 or later. It is not compatible with older versions.
+**Note**: This package requires `node` 14.0.0 or later, and `npm` 6.14.4 or later. It is not compatible with older versions.
 
 ## Usage
 
@@ -44,15 +44,15 @@ There is also `recommended-with-formatting` ruleset for projects that want to en
 
 Alternatively, you can opt-in to only the more granular rulesets offered by the plugin. These include:
 
--   `custom`
--   `es5`
--   `esnext`
--   `jsdoc`
--   `jsx-a11y`
--   `react`
--   `i18n`
--   `test-e2e`
--   `test-unit`
+-   `custom` – custom rules for WordPress development.
+-   `es5` – rules for legacy ES5 environments.
+-   `esnext` – rules for ES2015+ environments.
+-   `i18n` – rules for internationalization.
+-   `jsdoc` – rules for JSDoc comments.
+-   `jsx-a11y` – rules for accessibility in JSX.
+-   `react` – rules for React components.
+-   `test-e2e` – rules for end-to-end tests written in Puppeteer.
+-   `test-unit`– rules for unit tests written in Jest.
 
 For example, if your project does not use React, you could consider extending including only the ESNext rules in your project using the following `extends` definition:
 

package/configs/recommended-with-formatting.js

@@ -1,10 +1,5 @@
-/**
- * Internal dependencies
- */
-const { isPackageInstalled } = require( '../utils' );
-
 // Exclude bundled WordPress packages from the list.
-const wpPackagesRegExp = '^@wordpress/(?!(icons|interface))';
+const wpPackagesRegExp = '^@wordpress/(?!(icons|interface|style-engine))';
 
 const config = {
 	extends: [
@@ -45,23 +40,4 @@ const config = {
 	},
 };
 
-// Don't apply Jest config if Playwright is installed.
-if (
-	isPackageInstalled( 'jest' ) &&
-	! isPackageInstalled( '@playwright/test' )
-) {
-	config.overrides = [
-		{
-			// Unit test files and their helpers only.
-			files: [ '**/@(test|__tests__)/**/*.js', '**/?(*.)test.js' ],
-			extends: [ require.resolve( './test-unit.js' ) ],
-		},
-		{
-			// End-to-end test files and their helpers only.
-			files: [ '**/specs/**/*.js', '**/?(*.)spec.js' ],
-			extends: [ require.resolve( './test-e2e.js' ) ],
-		},
-	];
-}
-
 module.exports = config;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/eslint-plugin",
-	"version": "12.9.0",
+	"version": "13.0.0",
 	"description": "ESLint plugin for WordPress development.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -20,8 +20,8 @@
 		"url": "https://github.com/WordPress/gutenberg/issues"
 	},
 	"engines": {
-		"node": ">=12",
-		"npm": ">=6.9"
+		"node": ">=14",
+		"npm": ">=6.14.4"
 	},
 	"files": [
 		"configs",
@@ -34,8 +34,8 @@
 		"@babel/eslint-parser": "^7.16.0",
 		"@typescript-eslint/eslint-plugin": "^5.3.0",
 		"@typescript-eslint/parser": "^5.3.0",
-		"@wordpress/babel-preset-default": "^6.17.0",
-		"@wordpress/prettier-config": "^1.4.0",
+		"@wordpress/babel-preset-default": "^7.0.0",
+		"@wordpress/prettier-config": "^2.0.0",
 		"cosmiconfig": "^7.0.0",
 		"eslint-config-prettier": "^8.3.0",
 		"eslint-plugin-import": "^2.25.2",
@@ -65,5 +65,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "08358f53b627a15148c3a3e433cdf58cf8714aa4"
+	"gitHead": "171b87c7465b93e685e081c5f57f153507363c95"
 }

package/rules/__tests__/dependency-group.js

@@ -22,7 +22,7 @@ ruleTester.run( 'dependency-group', rule, {
 /**
  * External dependencies
  */
-import { get } from 'lodash';
+import { camelCase } from 'change-case';
 import classnames from 'classnames';
 
 /**
@@ -40,7 +40,7 @@ import edit from './edit';`,
 /**
  * External dependencies
  */
-const { get } = require( 'lodash' );
+const { camelCase } = require( 'change-case' );
 const classnames = require( 'classnames' );
 
 /**
@@ -57,7 +57,7 @@ const edit = require( './edit' );`,
 	invalid: [
 		{
 			code: `
-import { get } from 'lodash';
+import { camelCase } from 'change-case';
 import classnames from 'classnames';
 /*
  * wordpress dependencies.
@@ -82,7 +82,7 @@ import edit from './edit';`,
 /**
  * External dependencies
  */
-import { get } from 'lodash';
+import { camelCase } from 'change-case';
 import classnames from 'classnames';
 /**
  * WordPress dependencies
@@ -95,7 +95,7 @@ import edit from './edit';`,
 		},
 		{
 			code: `
-const { get } = require( 'lodash' );
+const { camelCase } = require( 'change-case' );
 const classnames = require( 'classnames' );
 /*
  * wordpress dependencies.
@@ -120,7 +120,7 @@ const edit = require( './edit' );`,
 /**
  * External dependencies
  */
-const { get } = require( 'lodash' );
+const { camelCase } = require( 'change-case' );
 const classnames = require( 'classnames' );
 /**
  * WordPress dependencies

package/rules/__tests__/no-unsafe-wp-apis.js

@@ -21,15 +21,15 @@ const options = [
 
 ruleTester.run( 'no-unsafe-wp-apis', rule, {
 	valid: [
-		{ code: "import _ from 'lodash';", options },
-		{ code: "import { map } from 'lodash';", options },
-		{ code: "import { __experimentalFoo } from 'lodash';", options },
-		{ code: "import { __unstableFoo } from 'lodash';", options },
-		{ code: "import _, { __unstableFoo } from 'lodash';", options },
-		{ code: "import * as _ from 'lodash';", options },
+		{ code: "import _ from 'change-case';", options },
+		{ code: "import { camelCase } from 'change-case';", options },
+		{ code: "import { __experimentalFoo } from 'change-case';", options },
+		{ code: "import { __unstableFoo } from 'change-case';", options },
+		{ code: "import _, { __unstableFoo } from 'change-case';", options },
+		{ code: "import * as _ from 'change-case';", options },
 
 		{ code: "import _ from './x';", options },
-		{ code: "import { map } from './x';", options },
+		{ code: "import { camelCase } from './x';", options },
 		{ code: "import { __experimentalFoo } from './x';", options },
 		{ code: "import { __unstableFoo } from './x';", options },
 		{ code: "import _, { __unstableFoo } from './x';", options },