@wordpress/eslint-plugin 12.4.0 → 12.7.0

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 12.6.0 (2022-06-29)
+
+-   Enable `no-unused-vars`'s setting `ignoreRestSiblings` to allow unused variables when destructuring with rest properties ([#41897](https://github.com/WordPress/gutenberg/pull/41897)).
+
 ## 12.2.0 (2022-05-04)
 
 ### Bug Fix

package/configs/es5.js

@@ -52,7 +52,7 @@ module.exports = {
 		'no-unreachable': 'error',
 		'no-unsafe-negation': 'error',
 		'no-unused-expressions': 'error',
-		'no-unused-vars': 'error',
+		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
 		'no-useless-return': 'error',
 		'no-whitespace-before-property': 'error',
 		'no-with': 'error',

package/configs/jshint.js

@@ -9,7 +9,7 @@ module.exports = {
 		'no-trailing-spaces': 'error',
 		'no-undef': 'error',
 		'no-unused-expressions': 'error',
-		'no-unused-vars': 'error',
+		'no-unused-vars': [ 'error', { ignoreRestSiblings: true } ],
 		'one-var': [ 'error', 'always' ],
 		quotes: [ 'error', 'single' ],
 		'wrap-iife': [ 'error', 'any' ],

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/eslint-plugin",
-	"version": "12.4.0",
+	"version": "12.7.0",
 	"description": "ESLint plugin for WordPress development.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -34,8 +34,8 @@
 		"@babel/eslint-parser": "^7.16.0",
 		"@typescript-eslint/eslint-plugin": "^5.3.0",
 		"@typescript-eslint/parser": "^5.3.0",
-		"@wordpress/babel-preset-default": "^6.12.0",
-		"@wordpress/prettier-config": "^1.3.0",
+		"@wordpress/babel-preset-default": "^6.15.0",
+		"@wordpress/prettier-config": "^1.4.0",
 		"cosmiconfig": "^7.0.0",
 		"eslint-config-prettier": "^8.3.0",
 		"eslint-plugin-import": "^2.25.2",
@@ -65,5 +65,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "a3e0b62091e8a8bdf5e2518e42d60d7098af48cc"
+	"gitHead": "9d9d33bbdf317a4381b8ca1713e43bb50df653b3"
 }

package/rules/__tests__/data-no-store-string-literals.js

@@ -44,8 +44,7 @@ const createSuggestionTestCase = ( code, output ) => ( {
 		{
 			suggestions: [
 				{
-					desc:
-						'Replace literal with store definition. Import store if neccessary.',
+					desc: 'Replace literal with store definition. Import store if neccessary.',
 					output,
 				},
 			],

package/rules/__tests__/i18n-no-collapsible-whitespace.js

@@ -20,8 +20,7 @@ ruleTester.run( 'i18n-no-collapsible-whitespace', rule, {
 			code: `__( 'Hello World…' )`,
 		},
 		{
-			code:
-				'__( `A long string ` +\n `spread over ` +\n  `multiple lines.` );',
+			code: '__( `A long string ` +\n `spread over ` +\n  `multiple lines.` );',
 		},
 	],
 	invalid: [
@@ -54,8 +53,7 @@ ruleTester.run( 'i18n-no-collapsible-whitespace', rule, {
 			errors: [ { messageId: 'noCollapsibleWhitespace' } ],
 		},
 		{
-			code:
-				"__( 'A string with consecutive spaces.  These two are after a full stop.' );",
+			code: "__( 'A string with consecutive spaces.  These two are after a full stop.' );",
 			errors: [ { messageId: 'noCollapsibleWhitespace' } ],
 		},
 	],

package/rules/__tests__/i18n-no-flanking-whitespace.js

@@ -20,8 +20,7 @@ ruleTester.run( 'i18n-no-flanking-whitespace', rule, {
 			code: `__( 'Hello World…' )`,
 		},
 		{
-			code:
-				'__( `A long string ` +\n `spread over ` +\n  `multiple lines.` );',
+			code: '__( `A long string ` +\n `spread over ` +\n  `multiple lines.` );',
 		},
 		{
 			code: `__( 'Not concerned about   \t whitespace rules')`,

package/rules/__tests__/no-unsafe-wp-apis.js

@@ -46,8 +46,7 @@ ruleTester.run( 'no-unsafe-wp-apis', rule, {
 			options,
 		},
 		{
-			code:
-				"import { feature, __experimentalSafe } from '@wordpress/package';",
+			code: "import { feature, __experimentalSafe } from '@wordpress/package';",
 			options,
 		},
 		{
@@ -81,8 +80,7 @@ See https://developer.wordpress.org/block-editor/contributors/develop/coding-gui
 			],
 		},
 		{
-			code:
-				"import { feature, __experimentalSafe } from '@wordpress/unsafe';",
+			code: "import { feature, __experimentalSafe } from '@wordpress/unsafe';",
 			options,
 			errors: [
 				{
@@ -93,8 +91,7 @@ See https://developer.wordpress.org/block-editor/contributors/develop/coding-gui
 			],
 		},
 		{
-			code:
-				"import s, { __experimentalUnsafe } from '@wordpress/package';",
+			code: "import s, { __experimentalUnsafe } from '@wordpress/package';",
 			options,
 			errors: [
 				{

package/rules/data-no-store-string-literals.js

@@ -122,8 +122,7 @@ function collectAllNodesFromObjectPropertyFunctionCalls( context, node ) {
 function getSuggest( context, callNode ) {
 	return [
 		{
-			desc:
-				'Replace literal with store definition. Import store if neccessary.',
+			desc: 'Replace literal with store definition. Import store if neccessary.',
 			fix: ( fixer ) => getFixes( fixer, context, callNode ),
 		},
 	];
@@ -211,18 +210,17 @@ module.exports = {
 					return;
 				}
 
-				const callbackFunctionNodes = collectAllNodesFromCallbackFunctions(
-					context,
-					node
-				);
+				const callbackFunctionNodes =
+					collectAllNodesFromCallbackFunctions( context, node );
 				const directNodes = collectAllNodesFromDirectFunctionCalls(
 					context,
 					node
 				);
-				const objectPropertyCallNodes = collectAllNodesFromObjectPropertyFunctionCalls(
-					context,
-					node
-				);
+				const objectPropertyCallNodes =
+					collectAllNodesFromObjectPropertyFunctionCalls(
+						context,
+						node
+					);
 
 				const allNodes = [
 					...callbackFunctionNodes,

package/rules/dependency-group.js

@@ -7,8 +7,7 @@ module.exports = {
 		type: 'layout',
 		docs: {
 			description: 'Enforce dependencies docblocks formatting',
-			url:
-				'https://github.com/WordPress/gutenberg/blob/HEAD/packages/eslint-plugin/docs/rules/dependency-group.md',
+			url: 'https://github.com/WordPress/gutenberg/blob/HEAD/packages/eslint-plugin/docs/rules/dependency-group.md',
 		},
 		schema: [],
 		fixable: 'code',
@@ -184,8 +183,9 @@ module.exports = {
 					let source;
 					switch ( child.type ) {
 						case 'ImportDeclaration':
-							source = /** @type {string} */ ( child.source
-								.value );
+							source = /** @type {string} */ (
+								child.source.value
+							);
 							candidates.push( [ child, source ] );
 							break;
 
@@ -195,10 +195,12 @@ module.exports = {
 								if (
 									! init ||
 									init.type !== 'CallExpression' ||
-									/** @type {import('estree').CallExpression} */ ( init )
-										.callee.type !== 'Identifier' ||
-									/** @type {import('estree').Identifier} */ ( init.callee )
-										.name !== 'require'
+									/** @type {import('estree').CallExpression} */ (
+										init
+									).callee.type !== 'Identifier' ||
+									/** @type {import('estree').Identifier} */ (
+										init.callee
+									).name !== 'require'
 								) {
 									return;
 								}

package/rules/i18n-no-collapsible-whitespace.js

@@ -46,9 +46,8 @@ module.exports = {
 						continue;
 					}
 
-					const collapsibleWhitespace = argumentString.match(
-						/(\n|\t|\r| {2})/
-					);
+					const collapsibleWhitespace =
+						argumentString.match( /(\n|\t|\r| {2})/ );
 
 					if ( ! collapsibleWhitespace ) {
 						continue;

package/rules/i18n-no-flanking-whitespace.js

@@ -62,9 +62,8 @@ module.exports = {
 						continue;
 					}
 
-					const trimmableWhitespace = argumentString.match(
-						/^\s|\s$/
-					);
+					const trimmableWhitespace =
+						argumentString.match( /^\s|\s$/ );
 
 					if ( ! trimmableWhitespace ) {
 						continue;

package/rules/no-unused-vars-before-return.js

@@ -129,9 +129,8 @@ module.exports = /** @type {import('eslint').Rule} */ ( {
 
 					// Merge with any JSX identifiers in scope, if any.
 					if ( FUNCTION_SCOPE_JSX_IDENTIFIERS.has( functionScope ) ) {
-						const jsxIdentifiers = FUNCTION_SCOPE_JSX_IDENTIFIERS.get(
-							functionScope
-						);
+						const jsxIdentifiers =
+							FUNCTION_SCOPE_JSX_IDENTIFIERS.get( functionScope );
 
 						identifiers.push( ...jsxIdentifiers );
 					}

package/utils/constants.js

@@ -36,13 +36,14 @@ const TRANSLATION_FUNCTIONS = new Set( [ '__', '_x', '_n', '_nx' ] );
  *
  * @type {RegExp}
  */
-const REGEXP_SPRINTF_PLACEHOLDER = /%(((\d+)\$)|(\(([$_a-zA-Z][$_a-zA-Z0-9]*)\)))?[ +0#-]*\d*(\.(\d+|\*))?(ll|[lhqL])?([cduxXefgsp%])/g;
-//                                    ▲         ▲                    ▲       ▲  ▲            ▲           ▲ type
-//                                    │         │                    │       │  │            └ Length (unsupported)
-//                                    │         │                    │       │  └ Precision / max width
-//                                    │         │                    │       └ Min width (unsupported)
-//                                    │         │                    └ Flags (unsupported)
-//                                    └ Index   └ Name (for named arguments)
+const REGEXP_SPRINTF_PLACEHOLDER =
+	/%(((\d+)\$)|(\(([$_a-zA-Z][$_a-zA-Z0-9]*)\)))?[ +0#-]*\d*(\.(\d+|\*))?(ll|[lhqL])?([cduxXefgsp%])/g;
+//               ▲         ▲                    ▲       ▲  ▲            ▲           ▲ type
+//               │         │                    │       │  │            └ Length (unsupported)
+//               │         │                    │       │  └ Precision / max width
+//               │         │                    │       └ Min width (unsupported)
+//               │         │                    └ Flags (unsupported)
+//               └ Index   └ Name (for named arguments)
 
 /**
  * "Unordered" means there's no position specifier: '%s', not '%2$s'.
@@ -51,7 +52,8 @@ const REGEXP_SPRINTF_PLACEHOLDER = /%(((\d+)\$)|(\(([$_a-zA-Z][$_a-zA-Z0-9]*)\))
  *
  * @type {RegExp}
  */
-const REGEXP_SPRINTF_PLACEHOLDER_UNORDERED = /(?:(?<!%)%[+-]?(?:(?:0|'.)?-?[0-9]*(?:\.(?:[ 0]|'.)?[0-9]+)?|(?:[ ])?-?[0-9]+(?:\.(?:[ 0]|'.)?[0-9]+)?)[bcdeEfFgGosuxX])/;
+const REGEXP_SPRINTF_PLACEHOLDER_UNORDERED =
+	/(?:(?<!%)%[+-]?(?:(?:0|'.)?-?[0-9]*(?:\.(?:[ 0]|'.)?[0-9]+)?|(?:[ ])?-?[0-9]+(?:\.(?:[ 0]|'.)?[0-9]+)?)[bcdeEfFgGosuxX])/;
 
 module.exports = {
 	TRANSLATION_FUNCTIONS,