@wordpress/editor 14.48.1 → 14.49.0

package/src/components/post-view-link/test/index.js

@@ -0,0 +1,71 @@
+/**
+ * External dependencies
+ */
+import { render, screen } from '@testing-library/react';
+
+/**
+ * WordPress dependencies
+ */
+import { useSelect } from '@wordpress/data';
+
+/**
+ * Internal dependencies
+ */
+import PostViewLink from '../';
+
+jest.mock( '@wordpress/data/src/components/use-select', () => jest.fn() );
+
+const DEFAULTS = {
+	postType: { labels: { view_item: 'View Post' } },
+	permalink: 'https://example.com/sample/',
+	isPublished: true,
+	showIconLabels: false,
+};
+
+function setupUseSelectMock( overrides = {} ) {
+	// Use object spread (not destructure defaults) so an explicit `undefined`
+	// override actually overrides the default value.
+	const data = { ...DEFAULTS, ...overrides };
+	useSelect.mockImplementation( ( cb ) =>
+		cb( () => ( {
+			getCurrentPostType: () => 'post',
+			getPostType: () => data.postType,
+			getPermalink: () => data.permalink,
+			isCurrentPostPublished: () => data.isPublished,
+			get: () => data.showIconLabels,
+		} ) )
+	);
+}
+
+describe( 'PostViewLink', () => {
+	it( 'renders the post type-specific view label when available', () => {
+		setupUseSelectMock();
+		render( <PostViewLink /> );
+		expect( screen.getByLabelText( 'View Post' ) ).toBeInTheDocument();
+	} );
+
+	it( 'falls back to "View post" without crashing when the post type has no labels', () => {
+		// See https://github.com/WordPress/gutenberg/issues/62918.
+		setupUseSelectMock( { postType: {} } );
+		render( <PostViewLink /> );
+		expect( screen.getByLabelText( 'View post' ) ).toBeInTheDocument();
+	} );
+
+	it( 'renders nothing if the post is not published', () => {
+		setupUseSelectMock( { isPublished: false } );
+		const { container } = render( <PostViewLink /> );
+		expect( container ).toBeEmptyDOMElement();
+	} );
+
+	it( 'renders nothing if no permalink is available', () => {
+		setupUseSelectMock( { permalink: undefined } );
+		const { container } = render( <PostViewLink /> );
+		expect( container ).toBeEmptyDOMElement();
+	} );
+
+	it( 'renders nothing while the post type has not loaded', () => {
+		setupUseSelectMock( { postType: undefined } );
+		const { container } = render( <PostViewLink /> );
+		expect( container ).toBeEmptyDOMElement();
+	} );
+} );

package/src/components/post-visibility/index.js

@@ -82,7 +82,6 @@ export default function PostVisibility( { onClose } ) {
 						placeholder={ __( 'Use a secure password' ) }
 						type="text"
 						id={ `editor-post-visibility__password-input-${ instanceId }` }
-						__next40pxDefaultSize
 						maxLength={ 255 }
 					/>
 				) }

package/src/components/provider/disable-non-page-content-blocks.js

@@ -52,22 +52,31 @@ export default function DisableNonPageContentBlocks() {
 	// Child blocks of templates and templateParts are also loaded separately,
 	// so these are kept in separate effects.
 	useEffect( () => {
-		const { setBlockEditingMode, unsetBlockEditingMode } =
-			registry.dispatch( blockEditorStore );
+		const {
+			setBlockEditingMode,
+			unsetBlockEditingMode,
+			__unstableMarkNextChangeAsNotPersistent,
+		} = registry.dispatch( blockEditorStore );
 
+		__unstableMarkNextChangeAsNotPersistent();
 		setBlockEditingMode( '', 'disabled' );
 
 		return () => {
+			__unstableMarkNextChangeAsNotPersistent();
 			unsetBlockEditingMode( '' );
 		};
 	}, [ registry ] );
 
 	useEffect( () => {
-		const { setBlockEditingMode, unsetBlockEditingMode } =
-			registry.dispatch( blockEditorStore );
+		const {
+			setBlockEditingMode,
+			unsetBlockEditingMode,
+			__unstableMarkNextChangeAsNotPersistent,
+		} = registry.dispatch( blockEditorStore );
 
 		registry.batch( () => {
 			for ( const clientId of templateParts ) {
+				__unstableMarkNextChangeAsNotPersistent();
 				setBlockEditingMode( clientId, 'contentOnly' );
 			}
 		} );
@@ -75,6 +84,7 @@ export default function DisableNonPageContentBlocks() {
 		return () => {
 			registry.batch( () => {
 				for ( const clientId of templateParts ) {
+					__unstableMarkNextChangeAsNotPersistent();
 					unsetBlockEditingMode( clientId );
 				}
 			} );
@@ -82,17 +92,22 @@ export default function DisableNonPageContentBlocks() {
 	}, [ templateParts, registry ] );
 
 	useEffect( () => {
-		const { setBlockEditingMode, unsetBlockEditingMode } =
-			registry.dispatch( blockEditorStore );
+		const {
+			setBlockEditingMode,
+			unsetBlockEditingMode,
+			__unstableMarkNextChangeAsNotPersistent,
+		} = registry.dispatch( blockEditorStore );
 
 		const contentOnlySet = new Set( contentOnlyIds );
 
 		registry.batch( () => {
 			for ( const clientId of contentOnlyIds ) {
+				__unstableMarkNextChangeAsNotPersistent();
 				setBlockEditingMode( clientId, 'contentOnly' );
 			}
 			for ( const clientId of templatePartChildren ) {
 				if ( ! contentOnlySet.has( clientId ) ) {
+					__unstableMarkNextChangeAsNotPersistent();
 					setBlockEditingMode( clientId, 'disabled' );
 				}
 			}
@@ -101,10 +116,12 @@ export default function DisableNonPageContentBlocks() {
 		return () => {
 			registry.batch( () => {
 				for ( const clientId of contentOnlyIds ) {
+					__unstableMarkNextChangeAsNotPersistent();
 					unsetBlockEditingMode( clientId );
 				}
 				for ( const clientId of templatePartChildren ) {
 					if ( ! contentOnlySet.has( clientId ) ) {
+						__unstableMarkNextChangeAsNotPersistent();
 						unsetBlockEditingMode( clientId );
 					}
 				}

package/src/components/provider/index.js

@@ -380,7 +380,8 @@ export const ExperimentalEditorProvider = withRegistryProvider(
 		}, [ post.type, post.id, setEditedPost, removeNotice ] );
 
 		// Synchronize the editor settings as they change.
-		useEffect( () => {
+		// Do it as a layout effect so that rendered UI with outdated settings is not painted.
+		useLayoutEffect( () => {
 			updateEditorSettings( settings );
 		}, [ settings, updateEditorSettings ] );
 

package/src/components/provider/navigation-block-editing-mode.js

@@ -2,7 +2,7 @@
  * WordPress dependencies
  */
 import { useEffect } from '@wordpress/element';
-import { useDispatch, useSelect } from '@wordpress/data';
+import { useRegistry, useSelect } from '@wordpress/data';
 import { store as blockEditorStore } from '@wordpress/block-editor';
 
 /**
@@ -14,24 +14,30 @@ import { store as blockEditorStore } from '@wordpress/block-editor';
  */
 
 export default function NavigationBlockEditingMode() {
+	const registry = useRegistry();
 	// In the navigation block editor,
 	// the navigation block is the only root block.
 	const blockClientId = useSelect(
 		( select ) => select( blockEditorStore ).getBlockOrder()?.[ 0 ],
 		[]
 	);
-	const { setBlockEditingMode, unsetBlockEditingMode } =
-		useDispatch( blockEditorStore );
 
 	useEffect( () => {
 		if ( ! blockClientId ) {
 			return;
 		}
+		const {
+			setBlockEditingMode,
+			unsetBlockEditingMode,
+			__unstableMarkNextChangeAsNotPersistent,
+		} = registry.dispatch( blockEditorStore );
 
+		__unstableMarkNextChangeAsNotPersistent();
 		setBlockEditingMode( blockClientId, 'contentOnly' );
 
 		return () => {
+			__unstableMarkNextChangeAsNotPersistent();
 			unsetBlockEditingMode( blockClientId );
 		};
-	}, [ blockClientId, unsetBlockEditingMode, setBlockEditingMode ] );
+	}, [ registry, blockClientId ] );
 }

package/src/components/provider/use-block-editor-settings.js

@@ -68,6 +68,7 @@ const BLOCK_EDITOR_SETTINGS = [
 	'clearBlockSelection',
 	'codeEditingEnabled',
 	'colors',
+	'disableContentOnlyForTemplateParts',
 	'disableContentOnlyForUnsyncedPatterns',
 	'disableCustomColors',
 	'disableCustomFontSizes',
@@ -414,7 +415,8 @@ function useBlockEditorSettings( settings, postType, postId, renderingMode ) {
 			// When in template-locked mode (e.g., "Show Template" in the post editor),
 			// don't treat template parts as contentOnly sections.
 			disableContentOnlyForTemplateParts:
-				renderingMode === 'template-locked',
+				renderingMode === 'template-locked' ||
+				settings.disableContentOnlyForTemplateParts,
 			...( deviceType ? { [ deviceTypeKey ]: deviceType } : {} ),
 			[ onViewportStateChangeKey ]: updateDeviceTypeForViewportState,
 			[ isNavigationOverlayContextKey ]: isNavigationOverlayContext,

package/src/components/resizable-editor/resize-handle.js

@@ -4,7 +4,6 @@
 import { __ } from '@wordpress/i18n';
 import { LEFT, RIGHT } from '@wordpress/keycodes';
 import { __unstableMotion as motion } from '@wordpress/components';
-// eslint-disable-next-line @wordpress/use-recommended-components -- `Tooltip` is not yet on the recommended `@wordpress/ui` allow-list; landing as a migration step ahead of the wider rollout.
 import { Tooltip, VisuallyHidden } from '@wordpress/ui';
 
 const DELTA_DISTANCE = 20; // The distance to resize per keydown in pixels.

package/src/components/revision-diff-panel/index.js

@@ -15,8 +15,14 @@ import PostPanelRow from '../post-panel-row';
  * @param {string}  props.title       Panel title.
  * @param {Object}  props.entries     Map of key → diffWords parts arrays.
  * @param {boolean} props.initialOpen Whether the panel starts open.
+ * @param {string}  [props.className] Optional class for the content wrapper.
  */
-export default function RevisionDiffPanel( { title, entries, initialOpen } ) {
+export default function RevisionDiffPanel( {
+	title,
+	entries,
+	initialOpen,
+	className,
+} ) {
 	if ( ! entries ) {
 		return null;
 	}
@@ -53,7 +59,7 @@ export default function RevisionDiffPanel( { title, entries, initialOpen } ) {
 
 	return (
 		<PanelBody title={ title } initialOpen={ initialOpen }>
-			{ fields }
+			<div className={ className }>{ fields }</div>
 		</PanelBody>
 	);
 }

package/src/components/revision-fields-diff/index.js

@@ -38,6 +38,16 @@ function stringifyValue( value ) {
 	return String( value );
 }
 
+/**
+ * Determines whether a meta value should be treated as empty.
+ *
+ * @param {string} str The stringified value.
+ * @return {boolean} Whether the value is effectively empty.
+ */
+function isEmptyMeta( str ) {
+	return ! str || str === '[]' || str === '{}';
+}
+
 /**
  * Panel that shows meta field diffs between the current revision and
  * the previous revision in the document sidebar during revision mode.
@@ -72,7 +82,7 @@ export default function RevisionFieldsDiffPanel() {
 			const revStr = stringifyValue( revisionMeta[ key ] );
 			const prevStr = stringifyValue( previousMeta[ key ] );
 
-			if ( ! revStr && ! prevStr ) {
+			if ( isEmptyMeta( revStr ) && isEmptyMeta( prevStr ) ) {
 				continue;
 			}
 
@@ -91,6 +101,7 @@ export default function RevisionFieldsDiffPanel() {
 			title={ __( 'Meta' ) }
 			entries={ entries }
 			initialOpen={ false }
+			className="editor-revision-meta-diff__content"
 		/>
 	);
 }