@wordpress/edit-post 5.0.1-next.5df0cd52b7.0 → 5.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/edit-post",
-	"version": "5.0.1-next.5df0cd52b7.0",
+	"version": "5.0.4",
 	"description": "Edit Post module for WordPress.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -27,31 +27,31 @@
 	"react-native": "src/index",
 	"dependencies": {
 		"@babel/runtime": "^7.13.10",
-		"@wordpress/a11y": "^3.2.2-next.5df0cd52b7.0",
-		"@wordpress/api-fetch": "^5.2.2-next.5df0cd52b7.0",
-		"@wordpress/block-editor": "^7.0.1-next.5df0cd52b7.0",
-		"@wordpress/block-library": "^6.0.1-next.5df0cd52b7.0",
-		"@wordpress/blocks": "^11.0.1-next.5df0cd52b7.0",
-		"@wordpress/components": "^16.0.1-next.5df0cd52b7.0",
-		"@wordpress/compose": "^5.0.1-next.5df0cd52b7.0",
-		"@wordpress/core-data": "^4.0.1-next.5df0cd52b7.0",
-		"@wordpress/data": "^6.0.1-next.5df0cd52b7.0",
-		"@wordpress/data-controls": "^2.2.2-next.5df0cd52b7.0",
-		"@wordpress/editor": "^11.0.1-next.5df0cd52b7.0",
-		"@wordpress/element": "^4.0.1-next.5df0cd52b7.0",
-		"@wordpress/hooks": "^3.2.1-next.5df0cd52b7.0",
-		"@wordpress/i18n": "^4.2.2-next.5df0cd52b7.0",
-		"@wordpress/icons": "^5.0.1-next.5df0cd52b7.0",
-		"@wordpress/interface": "^4.0.1-next.5df0cd52b7.0",
-		"@wordpress/keyboard-shortcuts": "^3.0.1-next.5df0cd52b7.0",
-		"@wordpress/keycodes": "^3.2.2-next.5df0cd52b7.0",
-		"@wordpress/media-utils": "^3.0.1-next.5df0cd52b7.0",
-		"@wordpress/notices": "^3.2.2-next.5df0cd52b7.0",
-		"@wordpress/plugins": "^4.0.1-next.5df0cd52b7.0",
-		"@wordpress/primitives": "^3.0.1-next.5df0cd52b7.0",
-		"@wordpress/url": "^3.2.2-next.5df0cd52b7.0",
-		"@wordpress/viewport": "^4.0.1-next.5df0cd52b7.0",
-		"@wordpress/warning": "^2.2.2-next.5df0cd52b7.0",
+		"@wordpress/a11y": "^3.2.3",
+		"@wordpress/api-fetch": "^5.2.4",
+		"@wordpress/block-editor": "^7.0.4",
+		"@wordpress/block-library": "^6.0.2",
+		"@wordpress/blocks": "^11.1.2",
+		"@wordpress/components": "^19.0.0",
+		"@wordpress/compose": "^5.0.4",
+		"@wordpress/core-data": "^4.0.4",
+		"@wordpress/data": "^6.1.2",
+		"@wordpress/data-controls": "^2.2.5",
+		"@wordpress/editor": "^12.0.1",
+		"@wordpress/element": "^4.0.3",
+		"@wordpress/hooks": "^3.2.1",
+		"@wordpress/i18n": "^4.2.3",
+		"@wordpress/icons": "^6.0.1",
+		"@wordpress/interface": "^4.1.2",
+		"@wordpress/keyboard-shortcuts": "^3.0.4",
+		"@wordpress/keycodes": "^3.2.3",
+		"@wordpress/media-utils": "^3.0.3",
+		"@wordpress/notices": "^3.2.5",
+		"@wordpress/plugins": "^4.0.4",
+		"@wordpress/primitives": "^3.0.3",
+		"@wordpress/url": "^3.2.3",
+		"@wordpress/viewport": "^4.0.4",
+		"@wordpress/warning": "^2.2.2",
 		"classnames": "^2.3.1",
 		"lodash": "^4.17.21",
 		"memize": "^1.1.0",
@@ -61,5 +61,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "558d577d12bec15f05e694eb49a094836d885cca"
+	"gitHead": "157f4ae53ab98e574af01f72213ae5a9613159ff"
 }

package/src/components/header/fullscreen-mode-close/index.js

@@ -7,12 +7,17 @@ import { get } from 'lodash';
  * WordPress dependencies
  */
 import { useSelect } from '@wordpress/data';
-import { Button, Icon } from '@wordpress/components';
+import {
+	Button,
+	Icon,
+	__unstableMotion as motion,
+} from '@wordpress/components';
 import { __ } from '@wordpress/i18n';
 import { addQueryArgs } from '@wordpress/url';
 import { wordpress } from '@wordpress/icons';
 import { store as editorStore } from '@wordpress/editor';
 import { store as coreStore } from '@wordpress/core-data';
+import { useReducedMotion } from '@wordpress/compose';
 
 /**
  * Internal dependencies
@@ -44,15 +49,26 @@ function FullscreenModeClose( { showTooltip, icon, href } ) {
 		[]
 	);
 
+	const disableMotion = useReducedMotion();
+
 	if ( ! isActive || ! postType ) {
 		return null;
 	}
 
 	let buttonIcon = <Icon size="36px" icon={ wordpress } />;
 
+	const effect = {
+		expand: {
+			scale: 1.7,
+			borderRadius: 0,
+			transition: { type: 'tween', duration: '0.2' },
+		},
+	};
+
 	if ( siteIconUrl ) {
 		buttonIcon = (
-			<img
+			<motion.img
+				variants={ ! disableMotion && effect }
 				alt={ __( 'Site Icon' ) }
 				className="edit-post-fullscreen-mode-close_site-icon"
 				src={ siteIconUrl }
@@ -70,19 +86,25 @@ function FullscreenModeClose( { showTooltip, icon, href } ) {
 	}
 
 	return (
-		<Button
-			className="edit-post-fullscreen-mode-close has-icon"
-			href={
-				href ??
-				addQueryArgs( 'edit.php', {
-					post_type: postType.slug,
-				} )
-			}
-			label={ get( postType, [ 'labels', 'view_items' ], __( 'Back' ) ) }
-			showTooltip={ showTooltip }
-		>
-			{ buttonIcon }
-		</Button>
+		<motion.div whileHover="expand">
+			<Button
+				className="edit-post-fullscreen-mode-close has-icon"
+				href={
+					href ??
+					addQueryArgs( 'edit.php', {
+						post_type: postType.slug,
+					} )
+				}
+				label={ get(
+					postType,
+					[ 'labels', 'view_items' ],
+					__( 'Back' )
+				) }
+				showTooltip={ showTooltip }
+			>
+				{ buttonIcon }
+			</Button>
+		</motion.div>
 	);
 }
 

package/src/components/header/fullscreen-mode-close/style.scss

@@ -11,7 +11,7 @@
 		align-items: center;
 		align-self: stretch;
 		border: none;
-		background: #23282e; // WP-admin gray.
+		background: $gray-900;
 		color: $white;
 		border-radius: 0;
 		height: $header-height + $border-width;
@@ -38,7 +38,7 @@
 			bottom: 9px;
 			left: 9px;
 			border-radius: $radius-block-ui + $border-width + $border-width;
-			box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) #23282e;
+			box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) $gray-900;
 		}
 
 		// Hover color.

package/src/components/header/header-toolbar/index.native.js

@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import { ScrollView, View } from 'react-native';
+import { Platform, ScrollView, View } from 'react-native';
 
 /**
  * WordPress dependencies
@@ -43,7 +43,13 @@ function HeaderToolbar( {
 } ) {
 	const scrollViewRef = useRef( null );
 	const scrollToStart = () => {
-		scrollViewRef.current.scrollTo( { x: 0 } );
+		// scrollview doesn't seem to automatically adjust to RTL on Android so, scroll to end when Android
+		const isAndroid = Platform.OS === 'android';
+		if ( isAndroid && isRTL ) {
+			scrollViewRef.current.scrollToEnd();
+		} else {
+			scrollViewRef.current.scrollTo( { x: 0 } );
+		}
 	};
 	const renderHistoryButtons = () => {
 		const buttons = [

package/src/components/header/more-menu/index.js

@@ -2,9 +2,12 @@
  * WordPress dependencies
  */
 import { __ } from '@wordpress/i18n';
-import { DropdownMenu, MenuGroup } from '@wordpress/components';
-import { moreVertical } from '@wordpress/icons';
-import { ActionItem, PinnedItems } from '@wordpress/interface';
+import { MenuGroup } from '@wordpress/components';
+import {
+	ActionItem,
+	MoreMenuDropdown,
+	PinnedItems,
+} from '@wordpress/interface';
 import { useViewportMatch } from '@wordpress/compose';
 
 /**
@@ -17,26 +20,18 @@ import WritingMenu from '../writing-menu';
 
 const POPOVER_PROPS = {
 	className: 'edit-post-more-menu__content',
-	position: 'bottom left',
-};
-const TOGGLE_PROPS = {
-	tooltipPosition: 'bottom',
 };
 
 const MoreMenu = ( { showIconLabels } ) => {
 	const isLargeViewport = useViewportMatch( 'large' );
 
 	return (
-		<DropdownMenu
+		<MoreMenuDropdown
 			className="edit-post-more-menu"
-			icon={ moreVertical }
-			/* translators: button label text should, if possible, be under 16 characters. */
-			label={ __( 'Options' ) }
 			popoverProps={ POPOVER_PROPS }
 			toggleProps={ {
 				showTooltip: ! showIconLabels,
 				...( showIconLabels && { variant: 'tertiary' } ),
-				...TOGGLE_PROPS,
 			} }
 		>
 			{ ( { onClose } ) => (
@@ -61,7 +56,7 @@ const MoreMenu = ( { showIconLabels } ) => {
 					</MenuGroup>
 				</>
 			) }
-		</DropdownMenu>
+		</MoreMenuDropdown>
 	);
 };
 

package/src/components/header/template-title/index.js

@@ -28,7 +28,9 @@ function TemplateTitle() {
 		return {
 			template: _isEditing ? getEditedPostTemplate() : null,
 			isEditing: _isEditing,
-			title: getEditedPostAttribute( 'title' ),
+			title: getEditedPostAttribute( 'title' )
+				? getEditedPostAttribute( 'title' )
+				: __( 'Untitled' ),
 		};
 	}, [] );
 

package/src/components/header/writing-menu/index.js

@@ -5,11 +5,7 @@ import { MenuGroup } from '@wordpress/components';
 import { __, _x } from '@wordpress/i18n';
 import { useViewportMatch } from '@wordpress/compose';
 import { displayShortcut } from '@wordpress/keycodes';
-
-/**
- * Internal dependencies
- */
-import FeatureToggle from '../feature-toggle';
+import { MoreMenuFeatureToggle } from '@wordpress/interface';
 
 function WritingMenu() {
 	const isLargeViewport = useViewportMatch( 'medium' );
@@ -19,7 +15,8 @@ function WritingMenu() {
 
 	return (
 		<MenuGroup label={ _x( 'View', 'noun' ) }>
-			<FeatureToggle
+			<MoreMenuFeatureToggle
+				scope="core/edit-post"
 				feature="fixedToolbar"
 				label={ __( 'Top toolbar' ) }
 				info={ __(
@@ -28,14 +25,16 @@ function WritingMenu() {
 				messageActivated={ __( 'Top toolbar activated' ) }
 				messageDeactivated={ __( 'Top toolbar deactivated' ) }
 			/>
-			<FeatureToggle
+			<MoreMenuFeatureToggle
+				scope="core/edit-post"
 				feature="focusMode"
 				label={ __( 'Spotlight mode' ) }
 				info={ __( 'Focus on one block at a time' ) }
 				messageActivated={ __( 'Spotlight mode activated' ) }
 				messageDeactivated={ __( 'Spotlight mode deactivated' ) }
 			/>
-			<FeatureToggle
+			<MoreMenuFeatureToggle
+				scope="core/edit-post"
 				feature="fullscreenMode"
 				label={ __( 'Fullscreen mode' ) }
 				info={ __( 'Work without distraction' ) }

package/src/components/keyboard-shortcut-help-modal/dynamic-shortcut.js

@@ -10,19 +10,22 @@ import { store as keyboardShortcutsStore } from '@wordpress/keyboard-shortcuts';
 import Shortcut from './shortcut';
 
 function DynamicShortcut( { name } ) {
-	const { keyCombination, description, aliases } = useSelect( ( select ) => {
-		const {
-			getShortcutKeyCombination,
-			getShortcutDescription,
-			getShortcutAliases,
-		} = select( keyboardShortcutsStore );
+	const { keyCombination, description, aliases } = useSelect(
+		( select ) => {
+			const {
+				getShortcutKeyCombination,
+				getShortcutDescription,
+				getShortcutAliases,
+			} = select( keyboardShortcutsStore );
 
-		return {
-			keyCombination: getShortcutKeyCombination( name ),
-			aliases: getShortcutAliases( name ),
-			description: getShortcutDescription( name ),
-		};
-	} );
+			return {
+				keyCombination: getShortcutKeyCombination( name ),
+				aliases: getShortcutAliases( name ),
+				description: getShortcutDescription( name ),
+			};
+		},
+		[ name ]
+	);
 
 	if ( ! keyCombination ) {
 		return null;

package/src/components/keyboard-shortcut-help-modal/index.js

@@ -91,9 +91,7 @@ const ShortcutCategorySection = ( {
 };
 
 export function KeyboardShortcutHelpModal( { isModalActive, toggleModal } ) {
-	useShortcut( 'core/edit-post/keyboard-shortcuts', toggleModal, {
-		bindGlobal: true,
-	} );
+	useShortcut( 'core/edit-post/keyboard-shortcuts', toggleModal );
 
 	if ( ! isModalActive ) {
 		return null;

package/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap

@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`KeyboardShortcutHelpModal should match snapshot when the modal is active 1`] = `
-<WithInstanceId(Modal)
+<Modal
   className="edit-post-keyboard-shortcut-help-modal"
   closeLabel="Close"
   onRequestClose={[Function]}
@@ -80,7 +80,7 @@ exports[`KeyboardShortcutHelpModal should match snapshot when the modal is activ
     }
     title="Text formatting"
   />
-</WithInstanceId(Modal)>
+</Modal>
 `;
 
 exports[`KeyboardShortcutHelpModal should match snapshot when the modal is not active 1`] = `""`;

package/src/components/keyboard-shortcuts/index.js

@@ -131,44 +131,31 @@ function KeyboardShortcuts() {
 			);
 		},
 		{
-			bindGlobal: true,
 			isDisabled: isModeToggleDisabled,
 		}
 	);
 
-	useShortcut(
-		'core/edit-post/toggle-fullscreen',
-		() => {
-			toggleFeature( 'fullscreenMode' );
-		},
-		{
-			bindGlobal: true,
+	useShortcut( 'core/edit-post/toggle-fullscreen', () => {
+		toggleFeature( 'fullscreenMode' );
+	} );
+
+	useShortcut( 'core/edit-post/toggle-sidebar', ( event ) => {
+		// This shortcut has no known clashes, but use preventDefault to prevent any
+		// obscure shortcuts from triggering.
+		event.preventDefault();
+
+		if ( isEditorSidebarOpened() ) {
+			closeGeneralSidebar();
+		} else {
+			const sidebarToOpen = getBlockSelectionStart()
+				? 'edit-post/block'
+				: 'edit-post/document';
+			openGeneralSidebar( sidebarToOpen );
 		}
-	);
+	} );
 
-	useShortcut(
-		'core/edit-post/toggle-sidebar',
-		( event ) => {
-			// This shortcut has no known clashes, but use preventDefault to prevent any
-			// obscure shortcuts from triggering.
-			event.preventDefault();
-
-			if ( isEditorSidebarOpened() ) {
-				closeGeneralSidebar();
-			} else {
-				const sidebarToOpen = getBlockSelectionStart()
-					? 'edit-post/block'
-					: 'edit-post/document';
-				openGeneralSidebar( sidebarToOpen );
-			}
-		},
-		{ bindGlobal: true }
-	);
-
-	useShortcut(
-		'core/edit-post/toggle-list-view',
-		() => setIsListViewOpened( ! isListViewOpened() ),
-		{ bindGlobal: true }
+	useShortcut( 'core/edit-post/toggle-list-view', () =>
+		setIsListViewOpened( ! isListViewOpened() )
 	);
 
 	return null;

package/src/components/layout/index.js

@@ -15,7 +15,7 @@ import {
 	EditorSnackbars,
 	store as editorStore,
 } from '@wordpress/editor';
-import { AsyncModeProvider, useSelect, useDispatch } from '@wordpress/data';
+import { useSelect, useDispatch } from '@wordpress/data';
 import { BlockBreadcrumb } from '@wordpress/block-editor';
 import { Button, ScrollLock, Popover } from '@wordpress/components';
 import { useViewportMatch } from '@wordpress/compose';
@@ -112,12 +112,10 @@ function Layout( { styles } ) {
 			hasActiveMetaboxes: select( editPostStore ).hasMetaBoxes(),
 			previousShortcut: select(
 				keyboardShortcutsStore
-			).getAllShortcutRawKeyCombinations(
-				'core/edit-post/previous-region'
-			),
+			).getAllShortcutKeyCombinations( 'core/edit-post/previous-region' ),
 			nextShortcut: select(
 				keyboardShortcutsStore
-			).getAllShortcutRawKeyCombinations( 'core/edit-post/next-region' ),
+			).getAllShortcutKeyCombinations( 'core/edit-post/next-region' ),
 			showIconLabels: select( editPostStore ).isFeatureActive(
 				'showIconLabels'
 			),
@@ -175,11 +173,7 @@ function Layout( { styles } ) {
 			return <InserterSidebar />;
 		}
 		if ( mode === 'visual' && isListViewOpened ) {
-			return (
-				<AsyncModeProvider value="true">
-					<ListViewSidebar />
-				</AsyncModeProvider>
-			);
+			return <ListViewSidebar />;
 		}
 		return null;
 	};

package/src/components/layout/index.native.js

@@ -91,7 +91,13 @@ class Layout extends Component {
 	}
 
 	renderHTML() {
-		return <HTMLTextInput parentHeight={ this.state.rootViewHeight } />;
+		const { globalStyles } = this.props;
+		return (
+			<HTMLTextInput
+				parentHeight={ this.state.rootViewHeight }
+				style={ globalStyles }
+			/>
+		);
 	}
 
 	renderVisual() {

package/src/components/meta-boxes/index.js

@@ -6,7 +6,9 @@ import { map } from 'lodash';
 /**
  * WordPress dependencies
  */
-import { withSelect } from '@wordpress/data';
+import { useSelect, useRegistry } from '@wordpress/data';
+import { useEffect } from '@wordpress/element';
+import { store as editorStore } from '@wordpress/editor';
 
 /**
  * Internal dependencies
@@ -15,7 +17,44 @@ import MetaBoxesArea from './meta-boxes-area';
 import MetaBoxVisibility from './meta-box-visibility';
 import { store as editPostStore } from '../../store';
 
-function MetaBoxes( { location, isVisible, metaBoxes } ) {
+export default function MetaBoxes( { location } ) {
+	const registry = useRegistry();
+	const {
+		metaBoxes,
+		isVisible,
+		areMetaBoxesInitialized,
+		isEditorReady,
+	} = useSelect(
+		( select ) => {
+			const { __unstableIsEditorReady } = select( editorStore );
+			const {
+				isMetaBoxLocationVisible,
+				getMetaBoxesPerLocation,
+				areMetaBoxesInitialized: _areMetaBoxesInitialized,
+			} = select( editPostStore );
+			return {
+				metaBoxes: getMetaBoxesPerLocation( location ),
+				isVisible: isMetaBoxLocationVisible( location ),
+				areMetaBoxesInitialized: _areMetaBoxesInitialized(),
+				isEditorReady: __unstableIsEditorReady(),
+			};
+		},
+		[ location ]
+	);
+
+	// When editor is ready, initialize postboxes (wp core script) and metabox
+	// saving. This initializes all meta box locations, not just this specific
+	// one.
+	useEffect( () => {
+		if ( isEditorReady && ! areMetaBoxesInitialized ) {
+			registry.dispatch( editPostStore ).initializeMetaBoxes();
+		}
+	}, [ isEditorReady, areMetaBoxesInitialized ] );
+
+	if ( ! areMetaBoxesInitialized ) {
+		return null;
+	}
+
 	return (
 		<>
 			{ map( metaBoxes, ( { id } ) => (
@@ -25,14 +64,3 @@ function MetaBoxes( { location, isVisible, metaBoxes } ) {
 		</>
 	);
 }
-
-export default withSelect( ( select, { location } ) => {
-	const { isMetaBoxLocationVisible, getMetaBoxesPerLocation } = select(
-		editPostStore
-	);
-
-	return {
-		metaBoxes: getMetaBoxesPerLocation( location ),
-		isVisible: isMetaBoxLocationVisible( location ),
-	};
-} )( MetaBoxes );