@wordpress/e2e-tests 4.6.0 → 4.9.0

package/README.md

@@ -18,30 +18,30 @@ The following commands are available on the Gutenberg repo:
 
 ```json
 {
-	"test-e2e": "wp-scripts test-e2e --config packages/e2e-tests/jest.config.js",
-	"test-e2e:debug": "wp-scripts --inspect-brk test-e2e --config packages/e2e-tests/jest.config.js --puppeteer-devtools",
-	"test-e2e:watch": "npm run test-e2e -- --watch"
+	"test:e2e": "wp-scripts test-e2e --config packages/e2e-tests/jest.config.js",
+	"test:e2e:debug": "wp-scripts --inspect-brk test-e2e --config packages/e2e-tests/jest.config.js --puppeteer-devtools",
+	"test:e2e:watch": "npm run test:e2e -- --watch"
 }
 ```
 
 ### Run all available tests
 
 ```bash
-npm run test-e2e
+npm run test:e2e
 ```
 
 ### Run all available tests and listen for changes.
 
 ```bash
-npm run test-e2e:watch
+npm run test:e2e:watch
 ```
 
 ### Run a specific test file
 
 ```bash
-npm run test-e2e -- packages/e2e-test/<path_to_test_file>
+npm run test:e2e -- packages/e2e-test/<path_to_test_file>
 # Or, in order to watch for changes:
-npm run test-e2e:watch -- packages/e2e-test/<path_to_test_file>
+npm run test:e2e:watch -- packages/e2e-test/<path_to_test_file>
 ```
 
 ### Debugging
@@ -49,7 +49,7 @@ npm run test-e2e:watch -- packages/e2e-test/<path_to_test_file>
 Makes e2e tests available to debug in a Chrome Browser.
 
 ```bash
-npm run test-e2e:debug
+npm run test:e2e:debug
 ```
 
 After running the command, tests will be available for debugging in Chrome by going to chrome://inspect/#devices and clicking `inspect` under the path to `/test-e2e.js`.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@wordpress/e2e-tests",
-	"version": "4.6.0",
+	"version": "4.9.0",
 	"description": "End-To-End (E2E) tests for WordPress.",
 	"author": "The WordPress Contributors",
 	"license": "GPL-2.0-or-later",
@@ -23,11 +23,11 @@
 		"node": ">=12"
 	},
 	"dependencies": {
-		"@wordpress/e2e-test-utils": "^7.8.0",
-		"@wordpress/jest-console": "^5.3.0",
-		"@wordpress/jest-puppeteer-axe": "^4.0.2",
-		"@wordpress/scripts": "^23.4.0",
-		"@wordpress/url": "^3.13.0",
+		"@wordpress/e2e-test-utils": "^7.11.0",
+		"@wordpress/jest-console": "^5.4.0",
+		"@wordpress/jest-puppeteer-axe": "^4.1.0",
+		"@wordpress/scripts": "^23.7.0",
+		"@wordpress/url": "^3.16.0",
 		"chalk": "^4.0.0",
 		"expect-puppeteer": "^4.4.0",
 		"filenamify": "^4.2.0",
@@ -46,5 +46,5 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"gitHead": "a80eeb62ec7cb1418b9915c277e084a29d6665e3"
+	"gitHead": "08358f53b627a15148c3a3e433cdf58cf8714aa4"
 }

package/plugins/cpt-locking.php

@@ -19,7 +19,13 @@ function gutenberg_test_cpt_locking() {
 				'placeholder' => 'Add a description',
 			),
 		),
-		array( 'core/quote' ),
+		array(
+			'core/quote',
+			array(),
+			array(
+				array( 'core/paragraph' ),
+			),
+		),
 		array( 'core/columns' ),
 	);
 	register_post_type(
@@ -65,7 +71,13 @@ function gutenberg_test_cpt_locking() {
 						'templateLock' => false,
 					),
 					array(
-						array( 'core/quote' ),
+						array(
+							'core/quote',
+							array(),
+							array(
+								array( 'core/paragraph' ),
+							),
+						),
 						array(
 							'core/paragraph',
 							array(
@@ -91,7 +103,13 @@ function gutenberg_test_cpt_locking() {
 						'templateLock' => 'all',
 					),
 					array(
-						array( 'core/quote' ),
+						array(
+							'core/quote',
+							array(),
+							array(
+								array( 'core/paragraph' ),
+							),
+						),
 						array(
 							'core/paragraph',
 							array(
@@ -115,7 +133,13 @@ function gutenberg_test_cpt_locking() {
 					'core/group',
 					array(),
 					array(
-						array( 'core/quote' ),
+						array(
+							'core/quote',
+							array(),
+							array(
+								array( 'core/paragraph' ),
+							),
+						),
 						array(
 							'core/paragraph',
 							array(

package/specs/editor/blocks/__snapshots__/quote.test.js.snap

@@ -34,180 +34,86 @@ exports[`Quote can be converted to paragraphs and renders one paragraph block pe
 
 exports[`Quote can be converted to paragraphs and renders only one paragraph for the cite, if the quote is void 1`] = `
 "<!-- wp:paragraph -->
+<p></p>
+<!-- /wp:paragraph -->
+
+<!-- wp:paragraph -->
 <p>cite</p>
 <!-- /wp:paragraph -->"
 `;
 
 exports[`Quote can be created by converting a heading 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>test</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:heading -->
+<h2>test</h2>
+<!-- /wp:heading --></blockquote>
 <!-- /wp:quote -->"
 `;
 
 exports[`Quote can be created by converting a paragraph 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>test</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>test</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
 
 exports[`Quote can be created by converting multiple paragraphs 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>one</p><p>two</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>one</p>
+<!-- /wp:paragraph -->
+
+<!-- wp:paragraph -->
+<p>two</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
 
 exports[`Quote can be created by typing "/quote" 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>I’m a quote</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>I’m a quote</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
 
 exports[`Quote can be created by typing > in front of text of a paragraph block 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>test</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>test</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
 
 exports[`Quote can be created by using > at the start of a paragraph block 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>A quote</p><p>Another paragraph</p></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote can be merged into from a paragraph 1`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>test</p></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote can be split at the end and merged back 1`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p></blockquote>
-<!-- /wp:quote -->
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>A quote</p>
+<!-- /wp:paragraph -->
 
 <!-- wp:paragraph -->
-<p></p>
-<!-- /wp:paragraph -->"
-`;
-
-exports[`Quote can be split at the end and merged back 2`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p><p></p></blockquote>
+<p>Another paragraph</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
 
-exports[`Quote can be split at the end and merged back 3`] = `
+exports[`Quote can be split at the end 1`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote can be split in the middle and merged back 1`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p><cite>c</cite></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>1</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->
 
 <!-- wp:paragraph -->
 <p></p>
-<!-- /wp:paragraph -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>2</p><cite>c</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote can be split in the middle and merged back 2`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p><p></p><cite>c</cite></blockquote>
-<!-- /wp:quote -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>2</p><cite>c</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote can be split in the middle and merged back 3`] = `
-"<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p><cite>c</cite></blockquote>
-<!-- /wp:quote -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>2</p><cite>c</cite></blockquote>
-<!-- /wp:quote -->"
+<!-- /wp:paragraph -->"
 `;
 
-exports[`Quote can be split in the middle and merged back 4`] = `
+exports[`Quote can be split at the end 2`] = `
 "<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>1</p><p>2</p><cite>c</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote is transformed to a heading and a quote if the quote contains a citation 1`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p></p><cite>cite</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote is transformed to a heading and a quote if the quote contains multiple paragraphs 1`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>two</p><p>three</p></blockquote>
+<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+<p>1</p>
+<!-- /wp:paragraph --></blockquote>
 <!-- /wp:quote -->"
 `;
-
-exports[`Quote is transformed to a heading if the quote just contains one paragraph 1`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->"
-`;
-
-exports[`Quote is transformed to an empty heading if the quote is empty 1`] = `
-"<!-- wp:heading -->
-<h2></h2>
-<!-- /wp:heading -->"
-`;
-
-exports[`Quote the resuling quote after transforming to a heading can be transformed again 1`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p>two</p><cite>cite</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote the resuling quote after transforming to a heading can be transformed again 2`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->
-
-<!-- wp:heading -->
-<h2>two</h2>
-<!-- /wp:heading -->
-
-<!-- wp:quote -->
-<blockquote class=\\"wp-block-quote\\"><p></p><cite>cite</cite></blockquote>
-<!-- /wp:quote -->"
-`;
-
-exports[`Quote the resuling quote after transforming to a heading can be transformed again 3`] = `
-"<!-- wp:heading -->
-<h2>one</h2>
-<!-- /wp:heading -->
-
-<!-- wp:heading -->
-<h2>two</h2>
-<!-- /wp:heading -->
-
-<!-- wp:heading -->
-<h2>cite</h2>
-<!-- /wp:heading -->"
-`;

package/specs/editor/blocks/gallery.test.js

@@ -103,7 +103,7 @@ describe( 'Gallery', () => {
 		// This xpath selects the anchor node for the block which has a child span which contains the text
 		// label of the block and then selects the expander span for that node.
 		const galleryExpander = await page.waitForXPath(
-			`//a[span[text()='Gallery']]/span[contains(@class, 'block-editor-list-view__expander')]`
+			`//a[.//span[text()='Gallery']]/span[contains(@class, 'block-editor-list-view__expander')]`
 		);
 
 		await galleryExpander.click();

package/specs/editor/blocks/navigation.test.js

@@ -1047,7 +1047,7 @@ Expected mock function not to be called but it was called with: ["POST", "http:/
 			await openListView();
 
 			const navExpander = await page.waitForXPath(
-				`//a[span[text()='Navigation']]/span[contains(@class, 'block-editor-list-view__expander')]`
+				`//a[.//span[text()='Navigation']]/span[contains(@class, 'block-editor-list-view__expander')]`
 			);
 
 			await navExpander.click();
@@ -1317,45 +1317,10 @@ Expected mock function not to be called but it was called with: ["POST", "http:/
 			await switchUserToAdmin();
 		} );
 
-		it( 'shows a warning if user does not have permission to edit or update navigation menus', async () => {
-			await createNewPost();
-			await insertBlock( 'Navigation' );
-
-			const startEmptyButton = await page.waitForXPath(
-				START_EMPTY_XPATH
-			);
-
-			// This creates an empty Navigation post type entity.
-			await startEmptyButton.click();
-
-			// Publishing the Post ensures the Navigation entity is saved.
-			// The Post itself is irrelevant.
-			await publishPost();
-
-			// Switch to a Contributor role user - they should not have
-			// permission to update Navigation menus.
-			await loginUser( contributorUsername, contributorPassword );
-
-			await createNewPost();
-
-			// At this point the block will automatically pick the first Navigation Menu
-			// which will be the one created by the Admin User.
-			await insertBlock( 'Navigation' );
-
-			// Make sure the snackbar error shows up.
-			await page.waitForXPath(
-				`//*[contains(@class, 'components-snackbar__content')][ text()="You do not have permission to edit this Menu. Any changes made will not be saved." ]`
-			);
-
-			// Expect a console 403 for requests to:
-			// * /wp/v2/settings?_locale=user
-			// * /wp/v2/templates?context=edit&post_type=post&per_page=100&_locale=user
-			expect( console ).toHaveErrored();
-		} );
-
-		it( 'shows a warning if user does not have permission to create navigation menus', async () => {
+		it.skip( 'shows a warning if user does not have permission to create navigation menus', async () => {
 			const noticeText =
 				'You do not have permission to create Navigation Menus.';
+
 			// Switch to a Contributor role user - they should not have
 			// permission to update Navigations.
 			await loginUser( contributorUsername, contributorPassword );

package/specs/editor/blocks/quote.test.js

@@ -77,7 +77,9 @@ describe( 'Quote', () => {
 			await page.keyboard.type( 'one' );
 			await page.keyboard.press( 'Enter' );
 			await page.keyboard.type( 'two' );
-			await transformBlockTo( 'Paragraph' );
+			// Navigate to the citation to select the block.
+			await page.keyboard.press( 'ArrowRight' );
+			await transformBlockTo( 'Unwrap' );
 
 			expect( await getEditedPostContent() ).toMatchSnapshot();
 		} );
@@ -89,7 +91,7 @@ describe( 'Quote', () => {
 			await page.keyboard.type( 'two' );
 			await page.keyboard.press( 'ArrowRight' );
 			await page.keyboard.type( 'cite' );
-			await transformBlockTo( 'Paragraph' );
+			await transformBlockTo( 'Unwrap' );
 
 			expect( await getEditedPostContent() ).toMatchSnapshot();
 		} );
@@ -98,14 +100,15 @@ describe( 'Quote', () => {
 			await insertBlock( 'Quote' );
 			await page.keyboard.press( 'ArrowRight' );
 			await page.keyboard.type( 'cite' );
-			await transformBlockTo( 'Paragraph' );
+			await transformBlockTo( 'Unwrap' );
 
 			expect( await getEditedPostContent() ).toMatchSnapshot();
 		} );
 
 		it( 'and renders a void paragraph if both the cite and quote are void', async () => {
 			await insertBlock( 'Quote' );
-			await transformBlockTo( 'Paragraph' );
+			await page.keyboard.press( 'ArrowRight' ); // Select the quote
+			await transformBlockTo( 'Unwrap' );
 
 			expect( await getEditedPostContent() ).toMatchSnapshot();
 		} );
@@ -119,56 +122,6 @@ describe( 'Quote', () => {
 		expect( await getEditedPostContent() ).toMatchSnapshot();
 	} );
 
-	it( 'is transformed to an empty heading if the quote is empty', async () => {
-		await insertBlock( 'Quote' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
-	it( 'is transformed to a heading if the quote just contains one paragraph', async () => {
-		await insertBlock( 'Quote' );
-		await page.keyboard.type( 'one' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
-	it( 'is transformed to a heading and a quote if the quote contains multiple paragraphs', async () => {
-		await insertBlock( 'Quote' );
-		await page.keyboard.type( 'one' );
-		await page.keyboard.press( 'Enter' );
-		await page.keyboard.type( 'two' );
-		await page.keyboard.press( 'Enter' );
-		await page.keyboard.type( 'three' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
-	it( 'is transformed to a heading and a quote if the quote contains a citation', async () => {
-		await insertBlock( 'Quote' );
-		await page.keyboard.type( 'one' );
-		await page.keyboard.press( 'ArrowRight' );
-		await page.keyboard.type( 'cite' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
-	it( 'the resuling quote after transforming to a heading can be transformed again', async () => {
-		await insertBlock( 'Quote' );
-		await page.keyboard.type( 'one' );
-		await page.keyboard.press( 'Enter' );
-		await page.keyboard.type( 'two' );
-		await page.keyboard.press( 'ArrowRight' );
-		await page.keyboard.type( 'cite' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-		await page.click( '[data-type="core/quote"]' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-		await page.click( '[data-type="core/quote"]' );
-		await transformBlockTo( 'Heading' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
 	it( 'can be converted to a pullquote', async () => {
 		await insertBlock( 'Quote' );
 		await page.keyboard.type( 'one' );
@@ -180,16 +133,7 @@ describe( 'Quote', () => {
 		expect( await getEditedPostContent() ).toMatchSnapshot();
 	} );
 
-	it( 'can be merged into from a paragraph', async () => {
-		await insertBlock( 'Quote' );
-		await insertBlock( 'Paragraph' );
-		await page.keyboard.type( 'test' );
-		await pressKeyTimes( 'ArrowLeft', 'test'.length );
-		await page.keyboard.press( 'Backspace' );
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-	} );
-
-	it( 'can be split at the end and merged back', async () => {
+	it( 'can be split at the end', async () => {
 		await insertBlock( 'Quote' );
 		await page.keyboard.type( '1' );
 		await page.keyboard.press( 'Enter' );
@@ -200,46 +144,53 @@ describe( 'Quote', () => {
 
 		await page.keyboard.press( 'Backspace' );
 
-		// Expect empty paragraph inside quote block.
-		expect( await getEditedPostContent() ).toMatchSnapshot();
-
-		await page.keyboard.press( 'Backspace' );
-
-		// Expect quote without empty paragraphs.
+		// Expect the paragraph to be deleted.
 		expect( await getEditedPostContent() ).toMatchSnapshot();
 	} );
 
-	it( 'can be split in the middle and merged back', async () => {
+	it( 'can be unwrapped on Backspace', async () => {
 		await insertBlock( 'Quote' );
-		await page.keyboard.type( '1' );
-		await page.keyboard.press( 'Enter' );
-		await page.keyboard.type( '2' );
-		await page.keyboard.press( 'ArrowRight' );
-		await page.keyboard.type( 'c' );
-		await page.keyboard.press( 'ArrowUp' );
-		await page.keyboard.press( 'ArrowUp' );
-		await page.keyboard.press( 'Enter' );
-		await page.keyboard.press( 'Enter' );
 
-		// Expect two quote blocks and empty paragraph in the middle.
-		expect( await getEditedPostContent() ).toMatchSnapshot();
+		expect( await getEditedPostContent() ).toMatchInlineSnapshot( `
+		"<!-- wp:quote -->
+		<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+		<p></p>
+		<!-- /wp:paragraph --></blockquote>
+		<!-- /wp:quote -->"
+	` );
 
 		await page.keyboard.press( 'Backspace' );
 
-		// Expect two quote blocks and empty paragraph in the first quote.
-		expect( await getEditedPostContent() ).toMatchSnapshot();
+		expect( await getEditedPostContent() ).toMatchInlineSnapshot( `""` );
+	} );
 
-		await page.keyboard.press( 'Backspace' );
+	it( 'can be unwrapped with content on Backspace', async () => {
+		await insertBlock( 'Quote' );
+		await page.keyboard.type( '1' );
+		await page.keyboard.press( 'ArrowRight' );
+		await page.keyboard.type( '2' );
 
-		// Expect two quote blocks.
-		expect( await getEditedPostContent() ).toMatchSnapshot();
+		expect( await getEditedPostContent() ).toMatchInlineSnapshot( `
+		"<!-- wp:quote -->
+		<blockquote class=\\"wp-block-quote\\"><!-- wp:paragraph -->
+		<p>1</p>
+		<!-- /wp:paragraph --><cite>2</cite></blockquote>
+		<!-- /wp:quote -->"
+	` );
 
 		await page.keyboard.press( 'ArrowLeft' );
-		await page.keyboard.press( 'ArrowDown' );
-		await page.keyboard.press( 'ArrowDown' );
-		await page.keyboard.press( 'ArrowDown' );
+		await page.keyboard.press( 'ArrowUp' );
+		await page.keyboard.press( 'ArrowUp' );
 		await page.keyboard.press( 'Backspace' );
 
-		expect( await getEditedPostContent() ).toMatchSnapshot();
+		expect( await getEditedPostContent() ).toMatchInlineSnapshot( `
+		"<!-- wp:paragraph -->
+		<p>1</p>
+		<!-- /wp:paragraph -->
+
+		<!-- wp:paragraph -->
+		<p>2</p>
+		<!-- /wp:paragraph -->"
+	` );
 	} );
 } );