@wordpress/components 29.7.0 → 29.9.0

package/src/unit-control/test/utils.ts

@@ -42,6 +42,42 @@ describe( 'UnitControl utils', () => {
 			] );
 		} );
 
+		it( 'should not mutate default units argument definiton', () => {
+			const unitsA = useCustomUnits( {
+				availableUnits: [ 'px', 'em', 'rem' ],
+				defaultValues: { px: 8, em: 0.5, rem: 0.5 },
+			} );
+
+			const unitsB = useCustomUnits( {
+				availableUnits: [ 'px', 'em', 'rem' ],
+				defaultValues: { px: 16, em: 1, rem: 1 },
+			} );
+
+			expect( unitsA ).not.toEqual( unitsB );
+		} );
+
+		it( 'should not mutate custon units argument definitons', () => {
+			const units = [
+				{ value: 'px', label: 'pixel' },
+				{ value: 'em', label: 'em' },
+				{ value: 'rem', label: 'rem' },
+			];
+
+			const unitsA = useCustomUnits( {
+				availableUnits: [ 'px', 'em', 'rem' ],
+				defaultValues: { px: 8, em: 0.5, rem: 0.5 },
+				units,
+			} );
+
+			const unitsB = useCustomUnits( {
+				availableUnits: [ 'px', 'em', 'rem' ],
+				defaultValues: { px: 16, em: 1, rem: 1 },
+				units,
+			} );
+
+			expect( unitsA ).not.toEqual( unitsB );
+		} );
+
 		it( 'should add default values to available units even if the default values are strings', () => {
 			// Although the public APIs of the component expect a `number` as the type of the
 			// default values, it's still good to test for strings (as it can happen in un-typed

package/src/unit-control/utils.ts

@@ -428,19 +428,16 @@ export const useCustomUnits = ( {
 		units
 	);
 
-	if ( defaultValues ) {
-		customUnitsToReturn.forEach( ( unit, i ) => {
-			if ( defaultValues[ unit.value ] ) {
-				const [ parsedDefaultValue ] = parseQuantityAndUnitFromRawValue(
-					defaultValues[ unit.value ]
-				);
-
-				customUnitsToReturn[ i ].default = parsedDefaultValue;
-			}
-		} );
+	if ( ! defaultValues ) {
+		return customUnitsToReturn;
 	}
 
-	return customUnitsToReturn;
+	return customUnitsToReturn.map( ( unit ) => {
+		const [ defaultValue ] = defaultValues[ unit.value ]
+			? parseQuantityAndUnitFromRawValue( defaultValues[ unit.value ] )
+			: [];
+		return { ...unit, default: defaultValue };
+	} );
 };
 
 /**